From 224ec196c12189ea265af7728c4a50baf6b05d22 Mon Sep 17 00:00:00 2001
From: Theresa Kurz <theresa.kurz@iws.uni-stuttgart.de>
Date: Mon, 17 Dec 2018 09:04:23 +0100
Subject: [PATCH] [cleanup] comment local residual in exercise-mainfile,
improve description in mainfile
---
exercises/exercise-mainfile/1pproblem.hh | 6 +++---
exercises/exercise-mainfile/README.md | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/exercises/exercise-mainfile/1pproblem.hh b/exercises/exercise-mainfile/1pproblem.hh
index 7f1d69c5..14273f4e 100644
--- a/exercises/exercise-mainfile/1pproblem.hh
+++ b/exercises/exercise-mainfile/1pproblem.hh
@@ -38,7 +38,7 @@
// TODO: dumux-course-task
// uncomment the incompressiblelocalresidual which is a specialization of the standard immisible localresidual for one phase incompressible cases and provides an analytic jacobian.
-#include <dumux/porousmediumflow/1p/incompressiblelocalresidual.hh>
+// #include <dumux/porousmediumflow/1p/incompressiblelocalresidual.hh>
#include <dumux/porousmediumflow/problem.hh>
#include <dumux/porousmediumflow/1p/model.hh>
@@ -84,8 +84,8 @@ public:
// TODO: dumux-course-task
// set the OneP Incompressible local residual for the OnePIncompressible type tag. This provides an analytic jacobian to be used for the analytic solution. Change that by setting:
-template<class TypeTag>
-struct LocalResidual<TypeTag, TTag::OnePIncompressible> { using type = OnePIncompressibleLocalResidual<TypeTag>; };
+// template<class TypeTag>
+// struct LocalResidual<TypeTag, TTag::OnePIncompressible> { using type = OnePIncompressibleLocalResidual<TypeTag>; };
// the fluid system for compressible tests
diff --git a/exercises/exercise-mainfile/README.md b/exercises/exercise-mainfile/README.md
index 5be7515f..04d5aa5f 100644
--- a/exercises/exercise-mainfile/README.md
+++ b/exercises/exercise-mainfile/README.md
@@ -185,6 +185,6 @@ For the incompressible one phase problem it is possible to also have an analytic
```c++
// TODO: dumux-course-task
```
-For the analytic solution of your immiscible problem you need analytic solutions for the derivatives of the jacobian. For that we have a special local residual, the `OnePIncompressibleLocalResidual` which provides that. You just need to include that in your `1pproblem.hh` and use that instead of the `immisciblelocalresidual.hh` which is used as a standard for all immiscible models.
+For the analytic solution of your immiscible problem you need analytic solutions for the derivatives of the jacobian. For that we have a special local residual, the `OnePIncompressibleLocalResidual` which provides that. You just need to include `incompressiblelocalresidual.hh` in your `1pproblem.hh` and use that instead of the `immisciblelocalresidual.hh` which is used as a standard for all immiscible models.
Additionally you need to set the differentiation method in the main file `exercise_1p_a.cc` to analytic.
--
GitLab