diff --git a/exercises/exercise-mainfile/README.md b/exercises/exercise-mainfile/README.md index b1dec1ab314a8acbfbe160d21338e1eda031e6a1..a4028bedb8c088fff61561287972c81138fb2955 100644 --- a/exercises/exercise-mainfile/README.md +++ b/exercises/exercise-mainfile/README.md @@ -76,7 +76,7 @@ using GridVariables = typename GET_PROP_TYPE(TypeTag, GridVariables); auto gridVariables = std::make_shared<GridVariables>(problem, fvGridGeometry); gridVariables->init(x); -// intialize the vtk output module +// initialize the vtk output module using VtkOutputFields = typename GET_PROP_TYPE(TypeTag, VtkOutputFields); VtkOutputModule<TypeTag> vtkWriter(*problem, *fvGridGeometry, *gridVariables, x, problem->name()); VtkOutputFields::init(vtkWriter); //!< Add model specific output fields @@ -183,6 +183,6 @@ For the incompressible one phase problem it is possible to also have an analytic ```c++ // TODO: dumux-course-task ``` -For the analytic solution of your immiscible problem you need analytic solutions for the derivatives of the jacobian. For that we have a special local residual, the `OneincompressibleLocalResidual` which provides that. You just need to include that in your `1pproblem.hh` and use that instead of the `immisciblelocalresidual.hh` which is used as a standard for all immiscible models. +For the analytic solution of your immiscible problem you need analytic solutions for the derivatives of the jacobian. For that we have a special local residual, the `OnePIncompressibleLocalResidual` which provides that. You just need to include that in your `1pproblem.hh` and use that instead of the `immisciblelocalresidual.hh` which is used as a standard for all immiscible models. Additionally you need to set the differentiation method in the main file `exercise_1p_a.cc` to analytic. diff --git a/exercises/exercise-mainfile/exercise_1p_a.cc b/exercises/exercise-mainfile/exercise_1p_a.cc index 13e72dc7da25e86da997b72eded010d84774618d..5ce59ce96e9c4b6cf1669e94759f85f850c03675 100644 --- a/exercises/exercise-mainfile/exercise_1p_a.cc +++ b/exercises/exercise-mainfile/exercise_1p_a.cc @@ -98,7 +98,7 @@ int main(int argc, char** argv) try auto gridVariables = std::make_shared<GridVariables>(problem, fvGridGeometry); gridVariables->init(x); - // intialize the vtk output module + // initialize the vtk output module using VtkOutputFields = typename GET_PROP_TYPE(TypeTag, VtkOutputFields); VtkOutputModule<TypeTag> vtkWriter(*problem, *fvGridGeometry, *gridVariables, x, problem->name()); VtkOutputFields::init(vtkWriter); //!< Add model specific output fields diff --git a/exercises/exercise-mainfile/exercise_1p_b.cc b/exercises/exercise-mainfile/exercise_1p_b.cc index 3bf7d527a4dc1449ab3cac255d2a22485b38c8d4..4fdde99b6f09fd59bab2278797a14f050ad6ab15 100644 --- a/exercises/exercise-mainfile/exercise_1p_b.cc +++ b/exercises/exercise-mainfile/exercise_1p_b.cc @@ -75,7 +75,7 @@ int main(int argc, char** argv) try gridManager.init(); //////////////////////////////////////////////////////////// - // run instationary non-linear problem on this grid + // run stationary non-linear problem on this grid //////////////////////////////////////////////////////////// // we compute on the leaf grid view @@ -99,7 +99,7 @@ int main(int argc, char** argv) try auto gridVariables = std::make_shared<GridVariables>(problem, fvGridGeometry); gridVariables->init(x); - // intialize the vtk output module + // initialize the vtk output module using VtkOutputFields = typename GET_PROP_TYPE(TypeTag, VtkOutputFields); VtkOutputModule<TypeTag> vtkWriter(*problem, *fvGridGeometry, *gridVariables, x, problem->name()); VtkOutputFields::init(vtkWriter); //!< Add model specific output fields diff --git a/exercises/exercise-mainfile/exercise_1p_c.cc b/exercises/exercise-mainfile/exercise_1p_c.cc index e6a91e6255445d7a47032f517e4f68810c9ebb04..aaa2209c7874c439e0ff296e2b53426fa1de78ed 100644 --- a/exercises/exercise-mainfile/exercise_1p_c.cc +++ b/exercises/exercise-mainfile/exercise_1p_c.cc @@ -101,7 +101,7 @@ int main(int argc, char** argv) try auto gridVariables = std::make_shared<GridVariables>(problem, fvGridGeometry); gridVariables->init(x, xOld); - // intialize the vtk output module + // initialize the vtk output module using VtkOutputFields = typename GET_PROP_TYPE(TypeTag, VtkOutputFields); VtkOutputModule<TypeTag> vtkWriter(*problem, *fvGridGeometry, *gridVariables, x, problem->name()); VtkOutputFields::init(vtkWriter); //!< Add model specific output fields