diff --git a/exercises/exercise-basic/README.md b/exercises/exercise-basic/README.md index ac7eaa57a002015b260fa0a36f287e43edfa24dd..750a957e06f6eaa5ff1eaee874a22bd8177107c7 100644 --- a/exercises/exercise-basic/README.md +++ b/exercises/exercise-basic/README.md @@ -95,4 +95,4 @@ make exercise_basic_2pni # builds new executable <img src="https://git.iws.uni-stuttgart.de/dumux-repositories/dumux-course/raw/master/exercises/extradoc/exercise1_nonisothermal.png" width="800"> -The non-isothermal model requires additional parameters like the thermal conductivity of the solid component. They are already implemented and set in `exercise_basic.input`, you just need to _uncomment_ them. +The non-isothermal model requires additional parameters like the thermal conductivity of the solid component. They are already implemented and set in `params.input`, you just need to _uncomment_ them. diff --git a/exercises/exercise-dunemodule/README.md b/exercises/exercise-dunemodule/README.md index fb2f400ffddb8c47bba9418aa6448d93014c43da..e396be75f52aef55968f14630c6c1e0ea5898028 100644 --- a/exercises/exercise-dunemodule/README.md +++ b/exercises/exercise-dunemodule/README.md @@ -31,19 +31,19 @@ The following command will configure your new module ./dune-common/bin/dunecontrol --opts=<opts file> --only=dumux-example all ``` -You need to run this command in the folder with content dumux, dumux-course, dune-common, dune-geometry, dune-grid, dune-istl, etc. `<opts file>` needs to be replaced (please replace the angle brackets also) by an options file, e.g. by `./dumux/cmake.opts`. Have a look at the comments in this file to see how you can adapt it to your needs. +You need to run this command in the folder with content dumux, dumux-course, dune-common, dune-geometry, dune-grid, dune-istl, etc. `<opts file>` needs to be replaced (please replace the angle brackets also) by an options file, e.g., by `./dumux/cmake.opts`. Have a look at the comments in this file to see how you can adapt it to your needs. <hr><br><br> ### Task 3: Create a new test case within your new DuMuX module <hr> -* Create a new folder (in your module folder), e.g. `appl` +* Create a new folder (in your module folder), e.g., `appl` ```bash mkdir appl ``` -* Copy some test case from the dumux module, e.g. test_1p from test/porousmediumflow/1p/implicit/compressible/stationary +* Copy some test case from the dumux module, e.g., test_1p from test/porousmediumflow/1p/implicit/compressible/stationary in your new folder (e.g., `appl`) * Copy the problem, spatialparams, cc source file, input file * Adjust the CMakeLists.txt file within the dumux-example (or your module name)-folder to include your new subdirectory @@ -74,7 +74,7 @@ cmake build-cmake cd build-cmake make build_tests cd appl -./test_1p_compressible_tpfa test_1p.input +./test_1p_compressible_stationary_tpfa params.input ``` <hr><br><br> diff --git a/exercises/exercise-fluidsystem/exercise-fluidsystem.cc b/exercises/exercise-fluidsystem/exercise-fluidsystem.cc index 7241485ca3eba14e9a28f9991f389b87f546c185..197c32590f582a37a4f2fa4633f6328227aac8ef 100644 --- a/exercises/exercise-fluidsystem/exercise-fluidsystem.cc +++ b/exercises/exercise-fluidsystem/exercise-fluidsystem.cc @@ -63,7 +63,7 @@ int main(int argc, char** argv) try // define the type tag for this problem // TYPETAG is set in CMakeLists.txt as compile time definition // alternatively you could write `using TypeTag = Properties::TTag::ExerciseFluidsystemBoxTwoP;` - // then, for the 2p2c problem you have to change this line to `using TypeTag = Properties::TTag::ExerciseFluidsystemBoxTwoP;` + // then, for the 2p2c problem you have to change this line to `using TypeTag = Properties::TTag::ExerciseFluidsystemBoxTwoPTwoC;` // and recompile the executable using TypeTag = Properties::TTag::TYPETAG; diff --git a/exercises/exercise-mainfile/exercise_1p_a.cc b/exercises/exercise-mainfile/exercise_1p_a.cc index 0c624197883ce5eddd7e85bd2316a9f476f1f66c..1c260a38d5907094debe842cfb60a9e8dd3650cc 100644 --- a/exercises/exercise-mainfile/exercise_1p_a.cc +++ b/exercises/exercise-mainfile/exercise_1p_a.cc @@ -105,7 +105,7 @@ int main(int argc, char** argv) try using IOFields = GetPropType<TypeTag, Properties::IOFields>; IOFields::initOutputModule(vtkWriter); //!< Add model specific output fields vtkWriter.write(0.0); - + Dune::Timer timer; // TODO: dumux-course-task diff --git a/exercises/exercise-properties/mylocalresidual.hh b/exercises/exercise-properties/mylocalresidual.hh index f47698e5e115969f72df11cd2458b1e2b178afe6..f69e6b6a0d61fbd7412ffd944266908af58f6b9f 100644 --- a/exercises/exercise-properties/mylocalresidual.hh +++ b/exercises/exercise-properties/mylocalresidual.hh @@ -53,7 +53,7 @@ class MyLocalResidual : public GetPropType<TypeTag, Properties::BaseLocalResidua using EnergyLocalResidual = GetPropType<TypeTag, Properties::EnergyLocalResidual>; using ModelTraits = GetPropType<TypeTag, Properties::ModelTraits>; - static constexpr int numPhases = ModelTraits::numPhases(); + static constexpr int numPhases = ModelTraits::numFluidPhases(); static constexpr int conti0EqIdx = ModelTraits::Indices::conti0EqIdx; //!< first index for the mass balance public: diff --git a/exercises/solution/exercise-mainfile/exercise_1p_a_solution.cc b/exercises/solution/exercise-mainfile/exercise_1p_a_solution.cc index 55137bfd5b3cbf57f2bd7aac43c2412ce285b271..93a65e39c243c1f08d8dd0b9916c38d94d048562 100644 --- a/exercises/solution/exercise-mainfile/exercise_1p_a_solution.cc +++ b/exercises/solution/exercise-mainfile/exercise_1p_a_solution.cc @@ -51,7 +51,7 @@ int main(int argc, char** argv) try using namespace Dumux; // define the type tag for this problem - using TypeTag = Properties::TTag::TYPETAG; + using TypeTag = Properties::TTag::OnePIncompressible; //////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////// diff --git a/scripts/test_dumux.sh b/scripts/test_dumux.sh index cf77c3ed025399fde4677b151471f89ab2e7c2dc..67e5b57b3df4e799af4b6b1846bf71c5a6a27416 100755 --- a/scripts/test_dumux.sh +++ b/scripts/test_dumux.sh @@ -1,9 +1,9 @@ # Compile and runs a simple # one-phase ground water flow example # and visualizes the result using paraview. -cd dumux/build-cmake/test/porousmediumflow/1p/implicit +cd dumux/build-cmake/test/porousmediumflow/1p/implicit/incompressible echo "Compiling a one-phase test using a cell-centered TPFA discretization (might take a while)..." -make -B test_1pcctpfa +make -B test_1p_incompressible_tpfa_anadiff echo "Running simulation..." -./test_1pcctpfa test_1pfv.input -Grid.Cells "100 100" +./test_1p_incompressible_tpfa_anadiff params.input -Grid.Cells "100 100" paraview *pvd