From 02c12be06816f7401c97d2a47fa9984145e7dd5e Mon Sep 17 00:00:00 2001
From: Kilian Weishaupt <kilian.weishaupt@iws.uni-stuttgart.de>
Date: Thu, 2 Nov 2017 10:53:31 +0100
Subject: [PATCH] [freeflow] Add default method for Neumann returning 0
---
dumux/freeflow/staggered/localresidual.hh | 2 +-
dumux/freeflow/staggered/problem.hh | 30 ++++++++++++++++++-----
2 files changed, 25 insertions(+), 7 deletions(-)
diff --git a/dumux/freeflow/staggered/localresidual.hh b/dumux/freeflow/staggered/localresidual.hh
index 61caa336cb..e87b589258 100644
--- a/dumux/freeflow/staggered/localresidual.hh
+++ b/dumux/freeflow/staggered/localresidual.hh
@@ -276,7 +276,7 @@ protected:
if(bcTypes.isNeumann(eqIdx))
{
const auto extrusionFactor = 1.0; //TODO: get correct extrusion factor
- boundaryFlux[eqIdx] = problem.neumannAtPos(scvf.center())[cellCenterIdx][eqIdx]
+ boundaryFlux[eqIdx] = problem.neumann(element, scvf)[cellCenterIdx][eqIdx]
* extrusionFactor * scvf.area();
}
}
diff --git a/dumux/freeflow/staggered/problem.hh b/dumux/freeflow/staggered/problem.hh
index 081bebb8ad..f954237503 100644
--- a/dumux/freeflow/staggered/problem.hh
+++ b/dumux/freeflow/staggered/problem.hh
@@ -43,21 +43,18 @@ class NavierStokesProblem : public StaggeredFVProblem<TypeTag>
using Implementation = typename GET_PROP_TYPE(TypeTag, Problem);
using GridView = typename GET_PROP_TYPE(TypeTag, GridView);
- using TimeManager = typename GET_PROP_TYPE(TypeTag, TimeManager);
using Grid = typename GridView::Grid;
using Scalar = typename GET_PROP_TYPE(TypeTag, Scalar);
using Indices = typename GET_PROP_TYPE(TypeTag, Indices);
using Element = typename GridView::template Codim<0>::Entity;
- using Intersection = typename GridView::Intersection;
-
- using FVElementGeometry = typename GET_PROP_TYPE(TypeTag, FVElementGeometry);
using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry);
using FacePrimaryVariables = typename GET_PROP_TYPE(TypeTag, FacePrimaryVariables);
using PrimaryVariables = typename GET_PROP_TYPE(TypeTag, PrimaryVariables);
using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace);
using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume);
+ using BoundaryValues = typename GET_PROP_TYPE(TypeTag, BoundaryValues);
enum {
dim = Grid::dimension,
@@ -69,7 +66,7 @@ class NavierStokesProblem : public StaggeredFVProblem<TypeTag>
velocityYIdx = Indices::velocityYIdx
};
- typedef Dune::FieldVector<Scalar, dimWorld> GlobalPosition;
+ using GlobalPosition = Dune::FieldVector<Scalar, dimWorld>;
using DofTypeIndices = typename GET_PROP(TypeTag, DofTypeIndices);
typename DofTypeIndices::CellCenterIdx cellCenterIdx;
@@ -95,11 +92,32 @@ public:
*
* \param scvf The sub control volume face
*/
- auto dirichlet(const Element &element, const SubControlVolumeFace &scvf) const
+ BoundaryValues dirichlet(const Element &element, const SubControlVolumeFace &scvf) const
{
return asImp_().dirichletAtPos(scvf.center());
}
+ /*!
+ * \brief Returns neumann values at a given scv face.
+ This method can be overloaded in the actual problem, e.g. for coupling strategies
+ *
+ * \param scvf The sub control volume face
+ */
+ BoundaryValues neumann(const Element &element, const SubControlVolumeFace &scvf) const
+ {
+ return asImp_().neumannAtPos(scvf.center());
+ }
+
+ /*!
+ * \brief Returns neumann values at a position.
+ *
+ * \param scvf The sub control volume face
+ */
+ BoundaryValues neumannAtPos(const GlobalPosition& globalPos) const
+ {
+ return BoundaryValues(0.0);
+ }
+
/*!
* \brief Returns the temperature \f$\mathrm{[K]}\f$ at a given global position.
*
--
GitLab