Commit 1ef4d5cf authored by Timo Koch's avatar Timo Koch
Browse files

[bugfix][cc][scv] Replace optional by unique_ptr

Using optional lead to issues probably because the assignment operator were not
correcty implemented. However there is not need for optional here since the
member is in fact not optional but always there when the object is validly constructed.
We can simply use a unique_ptr to work around the fact that not all geometry
imeplementation are default-constructible and/or copy-assignable.
parent 2fdc1289
......@@ -24,7 +24,7 @@
#include <optional>
#include <memory>
#include <dune/common/fvector.hh>
......@@ -92,13 +92,14 @@ public:
CCSubControlVolume(GeometryParamType geometry,
GridIndexType elementIndex)
: ParentType()
, geometry_(std::move(geometry))
, center_(geometry_.value().center())
, geometry_(std::make_unique<Geometry>(std::move(geometry)))
, center_(geometry_->center())
, elementIndex_(elementIndex)
//! The copy constrcutor
CCSubControlVolume(const CCSubControlVolume& other) = default;
CCSubControlVolume(const CCSubControlVolume& other)
{ deepCopy_(other); }
//! The move constrcutor
CCSubControlVolume(CCSubControlVolume&& other) = default;
......@@ -106,26 +107,12 @@ public:
//! The copy assignment operator
CCSubControlVolume& operator=(const CCSubControlVolume& other)
// We want to use the default copy/move assignment.
// But since geometry is not copy assignable :( we
// have to construct it again
center_ = other.center_;
elementIndex_ = other.elementIndex_;
return *this;
//! The move assignment operator
CCSubControlVolume& operator=(CCSubControlVolume&& other) noexcept
// We want to use the default copy/move assignment.
// But since geometry is not copy assignable :( we
// have to construct it again
center_ = std::move(other.center_);
elementIndex_ = std::move(other.elementIndex_);
return *this;
CCSubControlVolume& operator=(CCSubControlVolume&& other) = default;
//! The center of the sub control volume
const GlobalPosition& center() const
......@@ -143,8 +130,7 @@ public:
// e.g. for integration
const Geometry& geometry() const
return geometry_.value();
return *geometry_;
//! The index of the dof this scv is embedded in (the global index of this scv)
......@@ -186,8 +172,18 @@ public:
// Work around the fact that geometry is not default constructible
std::optional<Geometry> geometry_;
void deepCopy_(const CCSubControlVolume& other)
if (other.geometry_)
geometry_ = std::make_unique<Geometry>(other.geometry());
center_ = other.center_;
elementIndex_ = other.elementIndex_;
// Work around the fact that geometry is not default-constructible and not copy-assignable
std::unique_ptr<Geometry> geometry_;
GlobalPosition center_;
GridIndexType elementIndex_;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment