From 35a86158663efa1e5d524485340520c396e6737c Mon Sep 17 00:00:00 2001
From: Timo Koch <timo.koch@iws.uni-stuttgart.de>
Date: Wed, 20 Nov 2019 10:48:59 +0100
Subject: [PATCH] [pmflow][velocity][doc] Improve comments and add not
implemented error message
---
dumux/porousmediumflow/velocity.hh | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/dumux/porousmediumflow/velocity.hh b/dumux/porousmediumflow/velocity.hh
index 8ef2c6dadf..771a9207a1 100644
--- a/dumux/porousmediumflow/velocity.hh
+++ b/dumux/porousmediumflow/velocity.hh
@@ -305,16 +305,22 @@ public:
using NumEqVector = std::decay_t<decltype(neumannFlux)>;
if (Dune::FloatCmp::eq<NumEqVector, Dune::FloatCmp::CmpStyle::absolute>(neumannFlux, NumEqVector(0.0), 1e-30))
scvfFluxes[scvfIndexInInside[localScvfIdx]] = 0;
- // cubes
+
+ // otherwise, we try some reconstruction (TODO: Can this be improved?)
+ // for cubes
else if (dim == 1 || geomType.isCube())
{
const auto fIdx = scvfIndexInInside[localScvfIdx];
const auto fIdxOpposite = fIdx%2 ? fIdx-1 : fIdx+1;
scvfFluxes[fIdx] = -scvfFluxes[fIdxOpposite];
}
- // simplices
+
+ // for simplices
else if (geomType.isSimplex())
scvfFluxes[scvfIndexInInside[localScvfIdx]] = 0;
+
+ else
+ DUNE_THROW(Dune::NotImplemented, "Velocity computation at Neumann boundaries for cell-centered and prism/pyramid");
}
}
}
@@ -344,7 +350,7 @@ public:
}
// 3D prism and pyramids
else
- DUNE_THROW(Dune::NotImplemented, "velocity output for cell-centered and prism/pyramid");
+ DUNE_THROW(Dune::NotImplemented, "Velocity computation for cell-centered and prism/pyramid");
Velocity scvVelocity(0);
jacobianT2.mtv(refVelocity, scvVelocity);
--
GitLab