From 513d0abffc00ec76bc2695f78ca71b124c177c98 Mon Sep 17 00:00:00 2001
From: DennisGlaeser <dennis.glaeser@iws.uni-stuttgart.de>
Date: Tue, 23 Feb 2016 11:59:20 +0100
Subject: [PATCH] [2pdfm] fix bug in localresidual

in the local residual the derivative dSw_m/dSw_F was multiplied to the storage term even though in an implicit scheme this is not necessary
---
 .../2pdfm/implicit/localresidual.hh                |  7 -------
 .../2pdfm/implicit/volumevariables.hh              | 14 --------------
 2 files changed, 21 deletions(-)

diff --git a/dumux/porousmediumflow/2pdfm/implicit/localresidual.hh b/dumux/porousmediumflow/2pdfm/implicit/localresidual.hh
index 37ba13300b..80d018919e 100644
--- a/dumux/porousmediumflow/2pdfm/implicit/localresidual.hh
+++ b/dumux/porousmediumflow/2pdfm/implicit/localresidual.hh
@@ -168,12 +168,6 @@ public:
         storageMatrix[nPhaseIdx]    = 0.0;
         //        const GlobalPosition &globalPos = geometry.corner(scvIdx);
 
-        Scalar dsm_dsf = volVars.dsm_dsf();
-        if (!this->problem_().useInterfaceCondition())
-        {
-            dsm_dsf = 1.0;
-        }
-
         if (isFracture)
         {
             for (int phaseIdx = 0; phaseIdx<2; phaseIdx++)
@@ -185,7 +179,6 @@ public:
                 storageMatrix[phaseIdx] = volVars.density(phaseIdx)
                                         * volVars.porosity()
                                         * wm
-                                        * dsm_dsf
                                         * volVars.saturationMatrix(phaseIdx);
             }
         }
diff --git a/dumux/porousmediumflow/2pdfm/implicit/volumevariables.hh b/dumux/porousmediumflow/2pdfm/implicit/volumevariables.hh
index d12c7a7a6c..4cc216aea5 100644
--- a/dumux/porousmediumflow/2pdfm/implicit/volumevariables.hh
+++ b/dumux/porousmediumflow/2pdfm/implicit/volumevariables.hh
@@ -189,13 +189,6 @@ public:
             mobilityFracture_[nPhaseIdx] =
                     MaterialLaw::krn(materialParamsFracture, fluidStateFracture_.saturation(wPhaseIdx))
                         / fluidStateFracture_.viscosity(nPhaseIdx);
-
-            // derivative resulted from BrooksCorey pc_Sw formulation
-            dsm_dsf_ = (1 - problem.spatialParams().swrm_) / (1 - problem.spatialParams().swrf_)
-                    * pow((problem.spatialParams().pdm_/ problem.spatialParams().pdf_),problem.spatialParams().lambdaM_)
-                    * (problem.spatialParams().lambdaM_ / problem.spatialParams().lambdaF_)
-                    * pow((satWFracture_ - problem.spatialParams().swrf_ ) / (1 - problem.spatialParams().swrf_),
-                            (problem.spatialParams().lambdaM_ / problem.spatialParams().lambdaF_) - 1);
         }// end if (node)
         ///////////////////////////////////////////////////////////////////////////////
         else
@@ -343,12 +336,6 @@ public:
     Scalar permeabilityFracture() const
     { return permeabilityFracture_; }
 
-    /*!
-     * \brief Returns the derivative dsm/dsf
-     */
-    Scalar dsm_dsf() const
-    { return dsm_dsf_;}
-
 protected:
     FluidState fluidState_;
     FluidState fluidStateFracture_;
@@ -370,7 +357,6 @@ protected:
     Scalar pcFracture_;
     Scalar pcMatrix_;
     Scalar pEntryMatrix_;
-    Scalar dsm_dsf_;
 
     bool isNodeOnFracture_;
 
-- 
GitLab