From 7474de9b73ad4ac82fc55f3babdba5b6ff9a411a Mon Sep 17 00:00:00 2001
From: Katharina Heck <katharina.heck@iws.uni-stuttgart.de>
Date: Mon, 6 Aug 2018 15:43:03 +0200
Subject: [PATCH] [cleanup] unnecessary code in spatial params and
volumevariables if chemical equilbrium is assumed
---
dumux/porousmediumflow/nonequilibrium/volumevariables.hh | 9 ---------
.../mpnc/implicit/thermalnonequilibrium/spatialparams.hh | 9 ---------
2 files changed, 18 deletions(-)
diff --git a/dumux/porousmediumflow/nonequilibrium/volumevariables.hh b/dumux/porousmediumflow/nonequilibrium/volumevariables.hh
index 4ca1cc3b8d..f09724184c 100644
--- a/dumux/porousmediumflow/nonequilibrium/volumevariables.hh
+++ b/dumux/porousmediumflow/nonequilibrium/volumevariables.hh
@@ -125,7 +125,6 @@ public:
const Element& element,
const Scv& scv)
{
- factorMassTransfer_ = problem.spatialParams().factorMassTransfer(element, scv, elemSol);
factorEnergyTransfer_ = problem.spatialParams().factorEnergyTransfer(element, scv, elemSol);
characteristicLength_ = problem.spatialParams().characteristicLength(element, scv, elemSol);
@@ -237,8 +236,6 @@ public:
const Scalar characteristicLength() const { return characteristicLength_; }
//! access function pre factor energy transfer
const Scalar factorEnergyTransfer() const { return factorEnergyTransfer_; }
- //! access function pre factor mass transfer
- const Scalar factorMassTransfer() const { return factorMassTransfer_; }
private:
//! dimensionless numbers
@@ -248,7 +245,6 @@ private:
Scalar characteristicLength_;
Scalar factorEnergyTransfer_;
- Scalar factorMassTransfer_;
Scalar solidSurface_ ;
Scalar interfacialArea_[ModelTraits::numPhases()+numEnergyEqSolid][ModelTraits::numPhases()+numEnergyEqSolid];
};
@@ -324,7 +320,6 @@ public:
const Element& element,
const Scv& scv)
{
- factorMassTransfer_ = problem.spatialParams().factorMassTransfer(element, scv, elemSol);
factorEnergyTransfer_ = problem.spatialParams().factorEnergyTransfer(element, scv, elemSol);
characteristicLength_ = problem.spatialParams().characteristicLength(element, scv, elemSol);
@@ -362,8 +357,6 @@ public:
const Scalar characteristicLength() const { return characteristicLength_; }
//! access function pre factor energy transfer
const Scalar factorEnergyTransfer() const { return factorEnergyTransfer_; }
- //! access function pre factor mass transfer
- const Scalar factorMassTransfer() const { return factorMassTransfer_; }
private:
//! dimensionless numbers
@@ -373,9 +366,7 @@ private:
Scalar characteristicLength_;
Scalar factorEnergyTransfer_;
- Scalar factorMassTransfer_;
Scalar solidSurface_ ;
- Scalar interfacialArea_[ModelTraits::numPhases()+numEnergyEqSolid][ModelTraits::numPhases()+numEnergyEqSolid];
};
////////////////////////////////////////////////////////////////////////////////////////////////////
diff --git a/test/porousmediumflow/mpnc/implicit/thermalnonequilibrium/spatialparams.hh b/test/porousmediumflow/mpnc/implicit/thermalnonequilibrium/spatialparams.hh
index 7b96235b0f..cbfc800eeb 100644
--- a/test/porousmediumflow/mpnc/implicit/thermalnonequilibrium/spatialparams.hh
+++ b/test/porousmediumflow/mpnc/implicit/thermalnonequilibrium/spatialparams.hh
@@ -86,7 +86,6 @@ public:
intrinsicPermeability_ = (pow(characteristicLength_,2.0) * pow(porosity_, 3.0)) / (150.0 * pow((1.0-porosity_),2.0)); // 1.69e-10 ; //
factorEnergyTransfer_ = getParam<Scalar>("SpatialParams.PorousMedium.factorEnergyTransfer");
- factorMassTransfer_ =getParam<Scalar>("SpatialParams.PorousMedium.factorMassTransfer");
lengthPM_ = getParam<Scalar>("Grid.lengthPM");
// residual saturations
@@ -177,13 +176,6 @@ public:
const Scalar factorEnergyTransferAtPos(const GlobalPosition & globalPos) const
{ return factorEnergyTransfer_; }
-
- /*!\brief Return the pre factor the the mass transfer
- * \param globalPos The position in global coordinates.*/
- const Scalar factorMassTransferAtPos(const GlobalPosition & globalPos) const
- { return factorMassTransfer_; }
-
-
//! Return if the tested position (input) is a specific region (right end of porous medium) in the domain
bool inOutFlow(const GlobalPosition & globalPos) const { return globalPos[0] > (lengthPM_ - eps_) ; }
//! Return the length of the porous medium domain
@@ -198,7 +190,6 @@ private:
Scalar intrinsicPermeability_ ;
Scalar porosity_ ;
Scalar factorEnergyTransfer_ ;
- Scalar factorMassTransfer_ ;
Scalar characteristicLength_ ;
MaterialLawParams materialParams_ ;
--
GitLab