From 99c6d1d5d8e1fff4ac38d265da6c2148b0069a20 Mon Sep 17 00:00:00 2001 From: Timo Koch <timo.koch@iws.uni-stuttgart.de> Date: Wed, 23 Aug 2017 18:22:33 +0200 Subject: [PATCH] [next] Rename GlobalFvGeometry -> FVGridGeometry --- dumux/common/pointsource.hh | 2 +- dumux/discretization/box/fvelementgeometry.hh | 56 +++++++-------- ...{globalfvgeometry.hh => fvgridgeometry.hh} | 16 ++--- .../box/globalfluxvariablescache.hh | 2 +- .../box/globalvolumevariables.hh | 2 +- .../cellcentered/globalvolumevariables.hh | 6 +- .../cellcentered/mpfa/darcyslaw.hh | 2 +- .../mpfa/elementfluxvariablescache.hh | 4 +- .../mpfa/elementvolumevariables.hh | 14 ++-- .../cellcentered/mpfa/fickslaw.hh | 2 +- .../mpfa/fluxvariablescachefiller.hh | 10 +-- .../cellcentered/mpfa/fourierslaw.hh | 2 +- .../cellcentered/mpfa/fvelementgeometry.hh | 64 ++++++++--------- ...{globalfvgeometry.hh => fvgridgeometry.hh} | 18 ++--- .../mpfa/globalfluxvariablescache.hh | 6 +- .../mpfa/globalinteractionvolumeseedsbase.hh | 2 +- .../mpfa/globalvolumevariables.hh | 6 +- .../cellcentered/mpfa/helper.hh | 2 +- ...{globalfvgeometry.hh => fvgridgeometry.hh} | 12 ++-- .../hybridfps/globalinteractionvolumeseeds.hh | 6 +- .../cellcentered/mpfa/interiorboundarydata.hh | 2 +- .../lmethod/globalinteractionvolumeseeds.hh | 18 ++--- .../cellcentered/mpfa/lmethod/helper.hh | 12 ++-- .../mpfa/lmethod/interactionvolume.hh | 10 +-- .../omethod/globalinteractionvolumeseeds.hh | 8 +-- .../cellcentered/mpfa/omethod/helper.hh | 26 +++---- .../mpfa/omethod/interactionvolume.hh | 2 +- .../cellcentered/tpfa/CMakeLists.txt | 2 +- .../tpfa/elementfluxvariablescache.hh | 4 +- .../tpfa/elementvolumevariables.hh | 4 +- .../cellcentered/tpfa/fickslaw.hh | 2 +- .../cellcentered/tpfa/fourierslaw.hh | 4 +- .../cellcentered/tpfa/fvelementgeometry.hh | 70 +++++++++---------- ...{globalfvgeometry.hh => fvgridgeometry.hh} | 22 +++--- .../tpfa/globalfluxvariablescache.hh | 6 +- dumux/discretization/fluxstencil.hh | 8 +-- .../staggered/elementfluxvariablescache.hh | 2 +- .../staggered/elementvolumevariables.hh | 2 +- .../staggered/fvelementgeometry.hh | 60 ++++++++-------- ...{globalfvgeometry.hh => fvgridgeometry.hh} | 16 ++--- .../staggered/globalfluxvariablescache.hh | 6 +- .../staggered/globalvolumevariables.hh | 6 +- dumux/discretization/upwindscheme.hh | 4 +- dumux/freeflow/staggered/model.hh | 2 +- dumux/freeflow/staggerednc/model.hh | 2 +- dumux/implicit/box/localjacobian.hh | 2 +- dumux/implicit/box/propertydefaults.hh | 6 +- dumux/implicit/cellcentered/assemblymap.hh | 2 +- dumux/implicit/cellcentered/localjacobian.hh | 6 +- .../cellcentered/mpfa/generalassemblymap.hh | 2 +- .../cellcentered/mpfa/propertydefaults.hh | 6 +- .../cellcentered/tpfa/propertydefaults.hh | 6 +- dumux/implicit/localresidual.hh | 4 +- dumux/implicit/model.hh | 14 ++-- dumux/implicit/properties.hh | 4 +- dumux/implicit/propertydefaults.hh | 2 +- dumux/implicit/staggered/assembler.hh | 2 +- dumux/implicit/staggered/assemblymap.hh | 4 +- dumux/implicit/staggered/localjacobian.hh | 6 +- dumux/implicit/staggered/localresidual.hh | 2 +- dumux/implicit/staggered/model.hh | 12 ++-- dumux/implicit/staggered/propertydefaults.hh | 6 +- dumux/io/staggeredvtkoutputmodule.hh | 2 +- dumux/io/vtkoutputmodulebase.hh | 2 +- .../cellcentered/bboxtreecouplingmanager.hh | 8 +-- .../bboxtreecouplingmanagersimple.hh | 8 +-- .../facet/mpfa/couplingmanager.hh | 10 +-- .../facet/mpfa/couplingmapper.hh | 10 +-- .../facet/mpfa/interiorboundarydata.hh | 10 +-- .../mixeddimension/integrationpointsource.hh | 2 +- .../mixeddimension/subproblemlocaljacobian.hh | 4 +- dumux/porousmediumflow/2p2c/implicit/model.hh | 2 +- dumux/porousmediumflow/2pnc/implicit/model.hh | 2 +- .../2pncmin/implicit/model.hh | 2 +- dumux/porousmediumflow/3p3c/implicit/model.hh | 2 +- .../compositional/primaryvariableswitch.hh | 4 +- .../richards/implicit/newtoncontroller.hh | 2 +- test/discretization/box/test_boxfvgeometry.cc | 4 +- .../cellcentered/tpfa/test_tpfafvgeometry.cc | 4 +- .../staggered/test_staggered.cc | 8 +-- test/freeflow/staggered/channeltestproblem.hh | 2 +- .../staggered/closedsystemtestproblem.hh | 2 +- test/freeflow/staggered/doneatestproblem.hh | 6 +- .../staggered/kovasznaytestproblem.hh | 6 +- .../staggerednc/channeltestproblem.hh | 4 +- .../staggerednc/densityflowproblem.hh | 4 +- .../1p2c_richards2c/richardstestproblem.hh | 4 +- .../1p2c_richards2c/rootsystemtestproblem.hh | 4 +- .../1p2c_richards2c/rositestproblem.hh | 8 +-- .../embedded/1p_1p/bloodflowproblem.hh | 4 +- .../embedded/1p_1p/tissueproblem.hh | 6 +- .../1p_richards/richardstestproblem.hh | 4 +- .../1p_richards/rootsystemtestproblem.hh | 4 +- .../1p/implicit/1pniconductionproblem.hh | 4 +- .../1p/implicit/1pniconvectionproblem.hh | 4 +- .../1p/implicit/fractureproblem.hh | 2 +- .../1p2c/implicit/1p2cniconductionproblem.hh | 4 +- .../1p2c/implicit/1p2cniconvectionproblem.hh | 4 +- .../2p/implicit/cc2pcornerpointproblem.hh | 2 +- .../2p/implicit/fractureproblem.hh | 2 +- .../2p/implicit/lensproblem.hh | 2 +- .../2pnc/implicit/fuelcellproblem.hh | 2 +- .../3p/implicit/3pniconductionproblem.hh | 4 +- .../3p/implicit/3pniconvectionproblem.hh | 4 +- .../implicit/richardswelltracerproblem.hh | 2 +- 105 files changed, 400 insertions(+), 400 deletions(-) rename dumux/discretization/box/{globalfvgeometry.hh => fvgridgeometry.hh} (96%) rename dumux/discretization/cellcentered/mpfa/{globalfvgeometry.hh => fvgridgeometry.hh} (98%) rename dumux/discretization/cellcentered/mpfa/hybridfps/{globalfvgeometry.hh => fvgridgeometry.hh} (97%) rename dumux/discretization/cellcentered/tpfa/{globalfvgeometry.hh => fvgridgeometry.hh} (96%) rename dumux/discretization/staggered/{globalfvgeometry.hh => fvgridgeometry.hh} (96%) diff --git a/dumux/common/pointsource.hh b/dumux/common/pointsource.hh index 0f66f4c45d..ed3e716c7f 100644 --- a/dumux/common/pointsource.hh +++ b/dumux/common/pointsource.hh @@ -380,7 +380,7 @@ public: // check in which subcontrolvolume(s) we are // TODO mapper/problem in bboxtree would allow to make this much better const auto element = boundingBoxTree.entity(eIdx); - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bindElement(element); const auto globalPos = source.position(); diff --git a/dumux/discretization/box/fvelementgeometry.hh b/dumux/discretization/box/fvelementgeometry.hh index 44e666d1d9..0c52731976 100644 --- a/dumux/discretization/box/fvelementgeometry.hh +++ b/dumux/discretization/box/fvelementgeometry.hh @@ -36,8 +36,8 @@ namespace Dumux { //! forward declaration of the global finite volume geometry -template<class TypeTag, bool EnableGlobalFVGeometryCache> -class BoxGlobalFVGeometry; +template<class TypeTag, bool EnableFVGridGeometryCache> +class BoxFVGridGeometry; /*! * \ingroup ImplicitModel @@ -45,7 +45,7 @@ class BoxGlobalFVGeometry; * This builds up the sub control volumes and sub control volume faces * for each element. */ -template<class TypeTag, bool EnableGlobalFVGeometryCache> +template<class TypeTag, bool EnableFVGridGeometryCache> class BoxFVElementGeometry {}; @@ -60,7 +60,7 @@ class BoxFVElementGeometry<TypeTag, true> using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume); using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace); using Element = typename GridView::template Codim<0>::Entity; - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using Scalar = typename GET_PROP_TYPE(TypeTag, Scalar); using CoordScalar = typename GridView::ctype; @@ -77,19 +77,19 @@ class BoxFVElementGeometry<TypeTag, true> public: //! Constructor - BoxFVElementGeometry(const GlobalFVGeometry& globalFvGeometry) - : globalFvGeometryPtr_(&globalFvGeometry) {} + BoxFVElementGeometry(const FVGridGeometry& fvGridGeometry) + : fvGridGeometryPtr_(&fvGridGeometry) {} //! Get a sub control volume with a local scv index const SubControlVolume& scv(IndexType scvIdx) const { - return globalFvGeometry().scvs(eIdx_)[scvIdx]; + return fvGridGeometry().scvs(eIdx_)[scvIdx]; } //! Get a sub control volume face with a local scvf index const SubControlVolumeFace& scvf(IndexType scvfIdx) const { - return globalFvGeometry().scvfs(eIdx_)[scvfIdx]; + return fvGridGeometry().scvfs(eIdx_)[scvfIdx]; } //! iterator range for sub control volumes. Iterates over @@ -100,7 +100,7 @@ public: friend inline Dune::IteratorRange<typename std::vector<SubControlVolume>::const_iterator> scvs(const BoxFVElementGeometry& fvGeometry) { - const auto& g = fvGeometry.globalFvGeometry(); + const auto& g = fvGeometry.fvGridGeometry(); using Iter = typename std::vector<SubControlVolume>::const_iterator; return Dune::IteratorRange<Iter>(g.scvs(fvGeometry.eIdx_).begin(), g.scvs(fvGeometry.eIdx_).end()); } @@ -113,7 +113,7 @@ public: friend inline Dune::IteratorRange<typename std::vector<SubControlVolumeFace>::const_iterator> scvfs(const BoxFVElementGeometry& fvGeometry) { - const auto& g = fvGeometry.globalFvGeometry(); + const auto& g = fvGeometry.fvGridGeometry(); using Iter = typename std::vector<SubControlVolumeFace>::const_iterator; return Dune::IteratorRange<Iter>(g.scvfs(fvGeometry.eIdx_).begin(), g.scvfs(fvGeometry.eIdx_).end()); } @@ -121,19 +121,19 @@ public: //! Get a local finite element basis const FeLocalBasis& feLocalBasis() const { - return globalFvGeometry().feCache().get(elementPtr_->geometry().type()).localBasis(); + return fvGridGeometry().feCache().get(elementPtr_->geometry().type()).localBasis(); } //! The total number of sub control volumes std::size_t numScv() const { - return globalFvGeometry().scvs(eIdx_).size(); + return fvGridGeometry().scvs(eIdx_).size(); } //! The total number of sub control volume faces std::size_t numScvf() const { - return globalFvGeometry().scvfs(eIdx_).size(); + return fvGridGeometry().scvfs(eIdx_).size(); } //! this function is for compatibility reasons with cc methods @@ -150,16 +150,16 @@ public: void bindElement(const Element& element) { elementPtr_ = &element; - eIdx_ = globalFvGeometry().problem_().elementMapper().index(element); + eIdx_ = fvGridGeometry().problem_().elementMapper().index(element); } //! The global finite volume geometry we are a restriction of - const GlobalFVGeometry& globalFvGeometry() const - { return *globalFvGeometryPtr_; } + const FVGridGeometry& fvGridGeometry() const + { return *fvGridGeometryPtr_; } private: const Element* elementPtr_; - const GlobalFVGeometry* globalFvGeometryPtr_; + const FVGridGeometry* fvGridGeometryPtr_; IndexType eIdx_; }; @@ -174,7 +174,7 @@ class BoxFVElementGeometry<TypeTag, false> using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume); using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace); using FVElementGeometry = typename GET_PROP_TYPE(TypeTag, FVElementGeometry); - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); static const int dim = GridView::dimension; static const int dimWorld = GridView::dimensionworld; @@ -192,8 +192,8 @@ class BoxFVElementGeometry<TypeTag, false> public: //! Constructor - BoxFVElementGeometry(const GlobalFVGeometry& globalFvGeometry) - : globalFvGeometryPtr_(&globalFvGeometry) {} + BoxFVElementGeometry(const FVGridGeometry& fvGridGeometry) + : fvGridGeometryPtr_(&fvGridGeometry) {} //! Get a sub control volume with a local scv index const SubControlVolume& scv(IndexType scvIdx) const @@ -234,7 +234,7 @@ public: //! Get a local finite element basis const FeLocalBasis& feLocalBasis() const { - return globalFvGeometry().feCache().get(elementPtr_->geometry().type()).localBasis(); + return fvGridGeometry().feCache().get(elementPtr_->geometry().type()).localBasis(); } //! The total number of sub control volumes @@ -263,19 +263,19 @@ public: void bindElement(const Element& element) { elementPtr_ = &element; - eIdx_ = globalFvGeometry().problem_().elementMapper().index(element); + eIdx_ = fvGridGeometry().problem_().elementMapper().index(element); makeElementGeometries(element); } //! The global finite volume geometry we are a restriction of - const GlobalFVGeometry& globalFvGeometry() const - { return *globalFvGeometryPtr_; } + const FVGridGeometry& fvGridGeometry() const + { return *fvGridGeometryPtr_; } private: void makeElementGeometries(const Element& element) { - auto eIdx = globalFvGeometry().problem_().elementMapper().index(element); + auto eIdx = fvGridGeometry().problem_().elementMapper().index(element); // get the element geometry auto elementGeometry = element.geometry(); @@ -289,7 +289,7 @@ private: for (unsigned int scvLocalIdx = 0; scvLocalIdx < elementGeometry.corners(); ++scvLocalIdx) { // get asssociated dof index - auto dofIdxGlobal = globalFvGeometry().problem_().vertexMapper().subIndex(element, scvLocalIdx, dim); + auto dofIdxGlobal = fvGridGeometry().problem_().vertexMapper().subIndex(element, scvLocalIdx, dim); // add scv to the local container scvs_[scvLocalIdx] = SubControlVolume(geometryHelper, @@ -318,7 +318,7 @@ private: } // construct the sub control volume faces on the domain boundary - for (const auto& intersection : intersections(globalFvGeometry().gridView(), element)) + for (const auto& intersection : intersections(fvGridGeometry().gridView(), element)) { if (intersection.boundary()) { @@ -350,7 +350,7 @@ private: IndexType eIdx_; //! The global geometry this is a restriction of - const GlobalFVGeometry* globalFvGeometryPtr_; + const FVGridGeometry* fvGridGeometryPtr_; //! vectors to store the geometries locally after binding an element std::vector<SubControlVolume> scvs_; diff --git a/dumux/discretization/box/globalfvgeometry.hh b/dumux/discretization/box/fvgridgeometry.hh similarity index 96% rename from dumux/discretization/box/globalfvgeometry.hh rename to dumux/discretization/box/fvgridgeometry.hh index aa760c0e79..3d1f8bb9d6 100644 --- a/dumux/discretization/box/globalfvgeometry.hh +++ b/dumux/discretization/box/fvgridgeometry.hh @@ -42,13 +42,13 @@ namespace Dumux * This builds up the sub control volumes and sub control volume faces * for each element. */ -template<class TypeTag, bool EnableGlobalFVGeometryCache> -class BoxGlobalFVGeometry +template<class TypeTag, bool EnableFVGridGeometryCache> +class BoxFVGridGeometry {}; // specialization in case the FVElementGeometries are stored template<class TypeTag> -class BoxGlobalFVGeometry<TypeTag, true> +class BoxFVGridGeometry<TypeTag, true> { using Problem = typename GET_PROP_TYPE(TypeTag, Problem); using GridView = typename GET_PROP_TYPE(TypeTag, GridView); @@ -75,7 +75,7 @@ class BoxGlobalFVGeometry<TypeTag, true> public: //! Constructor - BoxGlobalFVGeometry(const GridView gridView) + BoxFVGridGeometry(const GridView gridView) : gridView_(gridView) {} //! The total number of sub control volumes @@ -193,7 +193,7 @@ public: * The local object is only functional after calling its bind/bindElement method * This is a free function that will be found by means of ADL */ - friend FVElementGeometry localView(const BoxGlobalFVGeometry& global) + friend FVElementGeometry localView(const BoxFVGridGeometry& global) { return FVElementGeometry(global); } @@ -228,7 +228,7 @@ private: // specialization in case the FVElementGeometries are not stored template<class TypeTag> -class BoxGlobalFVGeometry<TypeTag, false> +class BoxFVGridGeometry<TypeTag, false> { using Problem = typename GET_PROP_TYPE(TypeTag, Problem); using GridView = typename GET_PROP_TYPE(TypeTag, GridView); @@ -255,7 +255,7 @@ class BoxGlobalFVGeometry<TypeTag, false> public: //! Constructor - BoxGlobalFVGeometry(const GridView gridView) + BoxFVGridGeometry(const GridView gridView) : gridView_(gridView) {} @@ -309,7 +309,7 @@ public: * The local object is only functional after calling its bind/bindElement method * This is a free function that will be found by means of ADL */ - friend FVElementGeometry localView(const BoxGlobalFVGeometry& global) + friend FVElementGeometry localView(const BoxFVGridGeometry& global) { return FVElementGeometry(global); } diff --git a/dumux/discretization/box/globalfluxvariablescache.hh b/dumux/discretization/box/globalfluxvariablescache.hh index 0c6d134d46..de58e8141b 100644 --- a/dumux/discretization/box/globalfluxvariablescache.hh +++ b/dumux/discretization/box/globalfluxvariablescache.hh @@ -65,7 +65,7 @@ public: { auto eIdx = problem.elementMapper().index(element); // bind the geometries and volume variables to the element (all the elements in stencil) - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bind(element); auto elemVolVars = localView(problem.model().curGlobalVolVars()); diff --git a/dumux/discretization/box/globalvolumevariables.hh b/dumux/discretization/box/globalvolumevariables.hh index ac5ae9b68f..3b50d93842 100644 --- a/dumux/discretization/box/globalvolumevariables.hh +++ b/dumux/discretization/box/globalvolumevariables.hh @@ -70,7 +70,7 @@ public: { auto eIdx = problem_().elementMapper().index(element); - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bindElement(element); // get the element solution diff --git a/dumux/discretization/cellcentered/globalvolumevariables.hh b/dumux/discretization/cellcentered/globalvolumevariables.hh index b70f940cf0..9b358da95c 100644 --- a/dumux/discretization/cellcentered/globalvolumevariables.hh +++ b/dumux/discretization/cellcentered/globalvolumevariables.hh @@ -66,13 +66,13 @@ public: { problemPtr_ = &problem; - auto numScv = problem.model().globalFvGeometry().numScv(); - auto numBoundaryScvf = problem.model().globalFvGeometry().numBoundaryScvf(); + auto numScv = problem.model().fvGridGeometry().numScv(); + auto numBoundaryScvf = problem.model().fvGridGeometry().numBoundaryScvf(); volumeVariables_.resize(numScv + numBoundaryScvf); for (const auto& element : elements(problem.gridView())) { - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) diff --git a/dumux/discretization/cellcentered/mpfa/darcyslaw.hh b/dumux/discretization/cellcentered/mpfa/darcyslaw.hh index de9b1d5902..32a452d93f 100644 --- a/dumux/discretization/cellcentered/mpfa/darcyslaw.hh +++ b/dumux/discretization/cellcentered/mpfa/darcyslaw.hh @@ -138,7 +138,7 @@ class DarcysLawImplementation<TypeTag, DiscretizationMethods::CCMpfa> const FluxVariablesCacheFiller& fluxVarsCacheFiller) { // get interaction volume from the flux vars cache filler & upate the cache - if (problem.model().globalFvGeometry().isInBoundaryInteractionVolume(scvf)) + if (problem.model().fvGridGeometry().isInBoundaryInteractionVolume(scvf)) scvfFluxVarsCache.updateAdvection(fluxVarsCacheFiller.boundaryInteractionVolume(), scvf); else scvfFluxVarsCache.updateAdvection(fluxVarsCacheFiller.interactionVolume(), scvf); diff --git a/dumux/discretization/cellcentered/mpfa/elementfluxvariablescache.hh b/dumux/discretization/cellcentered/mpfa/elementfluxvariablescache.hh index 954afca4c2..1a8a507918 100644 --- a/dumux/discretization/cellcentered/mpfa/elementfluxvariablescache.hh +++ b/dumux/discretization/cellcentered/mpfa/elementfluxvariablescache.hh @@ -180,7 +180,7 @@ public: auto& scvfCache = (*this)[scvf]; if (!scvfCache.isUpdated()) { - auto elementJ = problem.model().globalFvGeometry().element(dataJ.globalJ); + auto elementJ = problem.model().fvGridGeometry().element(dataJ.globalJ); filler.fill(*this, scvfCache, elementJ, fvGeometry, elemVolVars, scvf); } } @@ -249,7 +249,7 @@ private: const auto scvfInsideScvIdx = scvf.insideScvIdx(); const auto insideElement = scvfInsideScvIdx == globalI ? element : - problem.model().globalFvGeometry().element(scvfInsideScvIdx); + problem.model().fvGridGeometry().element(scvfInsideScvIdx); filler.update(*this, scvfCache, insideElement, fvGeometry, elemVolVars, scvf); } diff --git a/dumux/discretization/cellcentered/mpfa/elementvolumevariables.hh b/dumux/discretization/cellcentered/mpfa/elementvolumevariables.hh index 1b86b1b7d7..03481e6a7f 100644 --- a/dumux/discretization/cellcentered/mpfa/elementvolumevariables.hh +++ b/dumux/discretization/cellcentered/mpfa/elementvolumevariables.hh @@ -118,7 +118,7 @@ public: const SolutionVector& sol) { const auto& problem = globalVolVars().problem_(); - const auto& globalFvGeometry = problem.model().globalFvGeometry(); + const auto& fvGridGeometry = problem.model().fvGridGeometry(); // stencil information const auto globalI = problem.elementMapper().index(element); @@ -143,7 +143,7 @@ public: // Update the volume variables of the neighboring elements for (auto&& dataJ : assemblyMapI) { - const auto& elementJ = globalFvGeometry.element(dataJ.globalJ); + const auto& elementJ = fvGridGeometry.element(dataJ.globalJ); auto&& scvJ = fvGeometry.scv(dataJ.globalJ); volumeVariables_[localIdx].update(problem.model().elementSolution(elementJ, sol), problem, @@ -195,11 +195,11 @@ public: for (auto&& scvf : scvfs(fvGeometry)) { // skip the rest if the scvf does not touch a domain boundary - if (!globalFvGeometry.touchesDomainBoundary(scvf)) + if (!fvGridGeometry.touchesDomainBoundary(scvf)) continue; // loop over all the scvfs in the interaction region - const auto& ivSeed = globalFvGeometry.boundaryInteractionVolumeSeed(scvf); + const auto& ivSeed = fvGridGeometry.boundaryInteractionVolumeSeed(scvf); for (auto scvfIdx : ivSeed.globalScvfIndices()) { auto&& ivScvf = fvGeometry.scvf(scvfIdx); @@ -208,7 +208,7 @@ public: continue; auto insideScvIdx = ivScvf.insideScvIdx(); - auto insideElement = globalFvGeometry.element(insideScvIdx); + auto insideElement = fvGridGeometry.element(insideScvIdx); // on dirichlet boundaries use dirichlet values if (MpfaHelper::getMpfaFaceType(problem, insideElement, ivScvf) == MpfaFaceTypes::dirichlet) @@ -243,7 +243,7 @@ public: volVarIndices_.resize(volVarIndices_.size() + additionalDofDependencies.size()); for (auto globalJ : additionalDofDependencies) { - const auto& elementJ = fvGeometry.globalFvGeometry().element(globalJ); + const auto& elementJ = fvGeometry.fvGridGeometry().element(globalJ); auto&& scvJ = fvGeometry.scv(globalJ); volumeVariables_[localIdx].update(problem.model().elementSolution(elementJ, sol), @@ -304,7 +304,7 @@ private: for (auto&& scvf : scvfs(fvGeometry)) { bool boundary = scvf.boundary(); - if (boundary || (!boundary && fvGeometry.globalFvGeometry().touchesDomainBoundary(scvf))) + if (boundary || (!boundary && fvGeometry.fvGridGeometry().touchesDomainBoundary(scvf))) bVolVarEstimate += dim-1; } diff --git a/dumux/discretization/cellcentered/mpfa/fickslaw.hh b/dumux/discretization/cellcentered/mpfa/fickslaw.hh index cbdefb8bfe..f15648d2d8 100644 --- a/dumux/discretization/cellcentered/mpfa/fickslaw.hh +++ b/dumux/discretization/cellcentered/mpfa/fickslaw.hh @@ -148,7 +148,7 @@ class FicksLawImplementation<TypeTag, DiscretizationMethods::CCMpfa> const FluxVariablesCacheFiller& fluxVarsCacheFiller) { // get interaction volume from the flux vars cache filler & upate the cache - if (problem.model().globalFvGeometry().isInBoundaryInteractionVolume(scvf)) + if (problem.model().fvGridGeometry().isInBoundaryInteractionVolume(scvf)) scvfFluxVarsCache.updateDiffusion(fluxVarsCacheFiller.boundaryInteractionVolume(), scvf, phaseIdx, compIdx); else scvfFluxVarsCache.updateDiffusion(fluxVarsCacheFiller.interactionVolume(), scvf, phaseIdx, compIdx); diff --git a/dumux/discretization/cellcentered/mpfa/fluxvariablescachefiller.hh b/dumux/discretization/cellcentered/mpfa/fluxvariablescachefiller.hh index 9b181c641c..fa7f698142 100644 --- a/dumux/discretization/cellcentered/mpfa/fluxvariablescachefiller.hh +++ b/dumux/discretization/cellcentered/mpfa/fluxvariablescachefiller.hh @@ -102,10 +102,10 @@ public: scvfPtr_ = &scvf; // prepare interaction volume and fill caches of all the scvfs connected to it - const auto& globalFvGeometry = problem().model().globalFvGeometry(); - if (globalFvGeometry.isInBoundaryInteractionVolume(scvf)) + const auto& fvGridGeometry = problem().model().fvGridGeometry(); + if (fvGridGeometry.isInBoundaryInteractionVolume(scvf)) { - bIv_ = std::make_unique<BoundaryInteractionVolume>(globalFvGeometry.boundaryInteractionVolumeSeed(scvf), + bIv_ = std::make_unique<BoundaryInteractionVolume>(fvGridGeometry.boundaryInteractionVolumeSeed(scvf), problem(), fvGeometry, elemVolVars); @@ -115,7 +115,7 @@ public: } else { - iv_ = std::make_unique<InteractionVolume>(globalFvGeometry.interactionVolumeSeed(scvf), + iv_ = std::make_unique<InteractionVolume>(fvGridGeometry.interactionVolumeSeed(scvf), problem(), fvGeometry, elemVolVars); @@ -219,7 +219,7 @@ private: const auto scvfJInsideScvIndex = scvfJ.insideScvIdx(); otherElements[otherScvfIdx] = scvfJInsideScvIndex == scvFace().insideScvIdx() ? element() : - problem().model().globalFvGeometry().element(scvfJInsideScvIndex); + problem().model().fvGridGeometry().element(scvfJInsideScvIndex); // get the corresponding flux var cache otherFluxVarCaches[otherScvfIdx] = &fluxVarsCacheContainer[scvfJ]; diff --git a/dumux/discretization/cellcentered/mpfa/fourierslaw.hh b/dumux/discretization/cellcentered/mpfa/fourierslaw.hh index 27c5d07a3d..72b3dde8c1 100644 --- a/dumux/discretization/cellcentered/mpfa/fourierslaw.hh +++ b/dumux/discretization/cellcentered/mpfa/fourierslaw.hh @@ -120,7 +120,7 @@ class FouriersLawImplementation<TypeTag, DiscretizationMethods::CCMpfa> const FluxVariablesCacheFiller& fluxVarsCacheFiller) { // get interaction volume from the flux vars cache filler & upate the cache - if (problem.model().globalFvGeometry().isInBoundaryInteractionVolume(scvf)) + if (problem.model().fvGridGeometry().isInBoundaryInteractionVolume(scvf)) scvfFluxVarsCache.updateHeatConduction(fluxVarsCacheFiller.boundaryInteractionVolume(), scvf); else scvfFluxVarsCache.updateHeatConduction(fluxVarsCacheFiller.interactionVolume(), scvf); diff --git a/dumux/discretization/cellcentered/mpfa/fvelementgeometry.hh b/dumux/discretization/cellcentered/mpfa/fvelementgeometry.hh index 3be824293e..b3707586dc 100644 --- a/dumux/discretization/cellcentered/mpfa/fvelementgeometry.hh +++ b/dumux/discretization/cellcentered/mpfa/fvelementgeometry.hh @@ -38,7 +38,7 @@ namespace Dumux * This builds up the sub control volumes and sub control volume faces * for each element. */ -template<class TypeTag, bool EnableGlobalFVGeometryCache> +template<class TypeTag, bool EnableFVGridGeometryCache> class CCMpfaFVElementGeometry {}; @@ -53,33 +53,33 @@ class CCMpfaFVElementGeometry<TypeTag, true> using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume); using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace); using Element = typename GridView::template Codim<0>::Entity; - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using ScvIterator = Dumux::ScvIterator<SubControlVolume, std::vector<IndexType>, ThisType>; using ScvfIterator = Dumux::ScvfIterator<SubControlVolumeFace, std::vector<IndexType>, ThisType>; public: //! Constructor - CCMpfaFVElementGeometry(const GlobalFVGeometry& globalFvGeometry) - : globalFvGeometryPtr_(&globalFvGeometry) {} + CCMpfaFVElementGeometry(const FVGridGeometry& fvGridGeometry) + : fvGridGeometryPtr_(&fvGridGeometry) {} //! Get an element sub control volume with a global scv index const SubControlVolume& scv(IndexType scvIdx) const { - return globalFvGeometry().scv(scvIdx); + return fvGridGeometry().scv(scvIdx); } //! Get an element sub control volume face with a global scvf index const SubControlVolumeFace& scvf(IndexType scvfIdx) const { - return globalFvGeometry().scvf(scvfIdx); + return fvGridGeometry().scvf(scvfIdx); } //! Get an element sub control volume face with a global scvf index //! We separate element and neighbor scvfs to speed up mapping const SubControlVolumeFace& flipScvf(IndexType scvfIdx, unsigned int outsideScvIdx = 0) const { - return globalFvGeometry().flipScvf(scvfIdx, outsideScvIdx); + return fvGridGeometry().flipScvf(scvfIdx, outsideScvIdx); } //! iterator range for sub control volumes. Iterates over @@ -102,7 +102,7 @@ public: friend inline Dune::IteratorRange<ScvfIterator> scvfs(const CCMpfaFVElementGeometry& fvGeometry) { - const auto& g = fvGeometry.globalFvGeometry(); + const auto& g = fvGeometry.fvGridGeometry(); const auto scvIdx = fvGeometry.scvIndices_[0]; return Dune::IteratorRange<ScvfIterator>(ScvfIterator(g.scvfIndicesOfScv(scvIdx).begin(), fvGeometry), ScvfIterator(g.scvfIndicesOfScv(scvIdx).end(), fvGeometry)); @@ -117,7 +117,7 @@ public: //! number of sub control volumes in this fv element geometry std::size_t numScvf() const { - return globalFvGeometry().scvfIndicesOfScv(scvIndices_[0]).size(); + return fvGridGeometry().scvfIndicesOfScv(scvIndices_[0]).size(); } //! Binding of an element, called by the local jacobian to prepare element assembly @@ -130,18 +130,18 @@ public: void bindElement(const Element& element) { elementPtr_ = &element; - scvIndices_ = std::vector<IndexType>({globalFvGeometry().problem_().elementMapper().index(*elementPtr_)}); + scvIndices_ = std::vector<IndexType>({fvGridGeometry().problem_().elementMapper().index(*elementPtr_)}); } //! The global finite volume geometry we are a restriction of - const GlobalFVGeometry& globalFvGeometry() const - { return *globalFvGeometryPtr_; } + const FVGridGeometry& fvGridGeometry() const + { return *fvGridGeometryPtr_; } private: const Element* elementPtr_; std::vector<IndexType> scvIndices_; - const GlobalFVGeometry* globalFvGeometryPtr_; + const FVGridGeometry* fvGridGeometryPtr_; }; //! specialization in case the FVElementGeometries are not stored @@ -157,7 +157,7 @@ class CCMpfaFVElementGeometry<TypeTag, false> using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume); using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace); using Element = typename GridView::template Codim<0>::Entity; - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using ScvIterator = Dumux::ScvIterator<SubControlVolume, std::vector<IndexType>, ThisType>; using ScvfIterator = Dumux::ScvfIterator<SubControlVolumeFace, std::vector<IndexType>, ThisType>; @@ -170,8 +170,8 @@ class CCMpfaFVElementGeometry<TypeTag, false> public: //! Constructor - CCMpfaFVElementGeometry(const GlobalFVGeometry& globalFvGeometry) - : globalFvGeometryPtr_(&globalFvGeometry) {} + CCMpfaFVElementGeometry(const FVGridGeometry& fvGridGeometry) + : fvGridGeometryPtr_(&fvGridGeometry) {} //! Get an elment sub control volume with a global scv index //! We separate element and neighbor scvs to speed up mapping @@ -255,7 +255,7 @@ public: bindElement(element); // get some references for convenience - const auto& problem = globalFvGeometry().problem_(); + const auto& problem = fvGridGeometry().problem_(); const auto globalI = problem.elementMapper().index(element); const auto& assemblyMapI = problem.model().localJacobian().assemblyMap()[globalI]; @@ -270,7 +270,7 @@ public: // make neighbor geometries // use the assembly map to determine which faces are necessary for (auto&& dataJ : assemblyMapI) - makeNeighborGeometries(globalFvGeometry().element(dataJ.globalJ), + makeNeighborGeometries(fvGridGeometry().element(dataJ.globalJ), dataJ.globalJ, dataJ.scvfsJ, dataJ.additionalScvfs); @@ -288,7 +288,7 @@ public: neighborScvIndices_.reserve(neighborScvIndices_.size() + additionalDofDependencies.size()); for (auto globalJ : additionalDofDependencies) { - neighborScvs_.emplace_back(globalFvGeometry().element(globalJ).geometry(), globalJ); + neighborScvs_.emplace_back(fvGridGeometry().element(globalJ).geometry(), globalJ); neighborScvIndices_.emplace_back(globalJ); } } @@ -303,8 +303,8 @@ public: } //! The global finite volume geometry we are a restriction of - const GlobalFVGeometry& globalFvGeometry() const - { return *globalFvGeometryPtr_; } + const FVGridGeometry& fvGridGeometry() const + { return *fvGridGeometryPtr_; } private: @@ -323,7 +323,7 @@ private: void makeElementGeometries(const Element& element) { // the problem - const auto& problem = globalFvGeometry().problem_(); + const auto& problem = fvGridGeometry().problem_(); // make the scv auto eIdx = problem.elementMapper().index(element); @@ -331,8 +331,8 @@ private: scvIndices_.emplace_back(eIdx); // get data on the scv faces - const auto& scvFaceIndices = globalFvGeometry().scvfIndicesOfScv(eIdx); - const auto& neighborVolVarIndices = globalFvGeometry().neighborVolVarIndices(eIdx); + const auto& scvFaceIndices = fvGridGeometry().scvfIndicesOfScv(eIdx); + const auto& neighborVolVarIndices = fvGridGeometry().neighborVolVarIndices(eIdx); // the quadrature point to be used on the scvf const Scalar q = GET_PARAM_FROM_GROUP(TypeTag, Scalar, Mpfa, Q); @@ -349,7 +349,7 @@ private: finishedFacets.resize(element.subEntities(1), false); int scvfCounter = 0; - for (const auto& is : intersections(globalFvGeometry().gridView(), element)) + for (const auto& is : intersections(fvGridGeometry().gridView(), element)) { // if we are dealing with a lower dimensional network // only make a new scvf if we haven't handled it yet @@ -384,7 +384,7 @@ private: auto vIdxGlobal = problem.vertexMapper().subIndex(e, vIdxLocal, dim); // do not build scvfs connected to a processor boundary - if (globalFvGeometry().isGhostVertex(vIdxGlobal)) + if (fvGridGeometry().isGhostVertex(vIdxGlobal)) continue; scvfs_.emplace_back(MpfaHelper(), @@ -417,8 +417,8 @@ private: neighborScvIndices_.push_back(eIdxGlobal); // get data on the scv faces - const auto& scvFaceIndices = globalFvGeometry().scvfIndicesOfScv(eIdxGlobal); - const auto& neighborVolVarIndices = globalFvGeometry().neighborVolVarIndices(eIdxGlobal); + const auto& scvFaceIndices = fvGridGeometry().scvfIndicesOfScv(eIdxGlobal); + const auto& neighborVolVarIndices = fvGridGeometry().neighborVolVarIndices(eIdxGlobal); // the quadrature point to be used on the scvf const Scalar q = GET_PARAM_FROM_GROUP(TypeTag, Scalar, Mpfa, Q); @@ -430,7 +430,7 @@ private: finishedFacets.resize(element.subEntities(1), false); int scvfCounter = 0; - for (const auto& is : intersections(globalFvGeometry().gridView(), element)) + for (const auto& is : intersections(fvGridGeometry().gridView(), element)) { // if we are dealing with a lower dimensional network // only make a new scvf if we haven't handled it yet @@ -462,10 +462,10 @@ private: { // get the global vertex index the scv face is connected to auto vIdxLocal = refElement.subEntity(indexInElement, 1, c, dim); - auto vIdxGlobal = globalFvGeometry().problem_().vertexMapper().subIndex(e, vIdxLocal, dim); + auto vIdxGlobal = fvGridGeometry().problem_().vertexMapper().subIndex(e, vIdxLocal, dim); // do not build scvfs connected to a processor boundary - if (globalFvGeometry().isGhostVertex(vIdxGlobal)) + if (fvGridGeometry().isGhostVertex(vIdxGlobal)) continue; // only build the scvf if it is in the list of necessary indices @@ -608,7 +608,7 @@ private: // the bound element const Element* elementPtr_; - const GlobalFVGeometry* globalFvGeometryPtr_; + const FVGridGeometry* fvGridGeometryPtr_; // local storage after binding an element std::vector<IndexType> scvIndices_; diff --git a/dumux/discretization/cellcentered/mpfa/globalfvgeometry.hh b/dumux/discretization/cellcentered/mpfa/fvgridgeometry.hh similarity index 98% rename from dumux/discretization/cellcentered/mpfa/globalfvgeometry.hh rename to dumux/discretization/cellcentered/mpfa/fvgridgeometry.hh index 97592fe79f..0626530515 100644 --- a/dumux/discretization/cellcentered/mpfa/globalfvgeometry.hh +++ b/dumux/discretization/cellcentered/mpfa/fvgridgeometry.hh @@ -22,8 +22,8 @@ * This builds up the sub control volumes and sub control volume faces * for each element. */ -#ifndef DUMUX_DISCRETIZATION_CC_MPFA_GLOBALFVGEOMETRY_BASE_HH -#define DUMUX_DISCRETIZATION_CC_MPFA_GLOBALFVGEOMETRY_BASE_HH +#ifndef DUMUX_DISCRETIZATION_CC_MPFA_FV_GRID_GEOMETRY_BASE_HH +#define DUMUX_DISCRETIZATION_CC_MPFA_FV_GRID_GEOMETRY_BASE_HH #include <dune/geometry/multilineargeometry.hh> #include <dune/geometry/referenceelements.hh> @@ -40,14 +40,14 @@ namespace Dumux * for each element. */ template<class TypeTag, bool EnableFVElementGeometryCache> -class CCMpfaGlobalFVGeometry +class CCMpfaFVGridGeometry {}; // specialization in case the FVElementGeometries are stored template<class TypeTag> -class CCMpfaGlobalFVGeometry<TypeTag, true> +class CCMpfaFVGridGeometry<TypeTag, true> { - using Implementation = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using Implementation = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); //! The actual implementation might overwrite the update() routine friend Implementation; @@ -81,7 +81,7 @@ class CCMpfaGlobalFVGeometry<TypeTag, true> public: //! Constructor - CCMpfaGlobalFVGeometry(const GridView gridView) + CCMpfaFVGridGeometry(const GridView gridView) : gridView_(gridView), elementMap_(gridView), globalInteractionVolumeSeeds_(gridView) {} //! The total number of sub control volumes @@ -442,12 +442,12 @@ private: // specialization in case the FVElementGeometries are not stored template<class TypeTag> -class CCMpfaGlobalFVGeometry<TypeTag, false> +class CCMpfaFVGridGeometry<TypeTag, false> { //! The local fvGeometry needs access to the problem friend typename GET_PROP_TYPE(TypeTag, FVElementGeometry); - using Implementation = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using Implementation = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using Problem = typename GET_PROP_TYPE(TypeTag, Problem); using GridView = typename GET_PROP_TYPE(TypeTag, GridView); using MpfaHelper = typename GET_PROP_TYPE(TypeTag, MpfaHelper); @@ -476,7 +476,7 @@ class CCMpfaGlobalFVGeometry<TypeTag, false> public: //! Constructor - CCMpfaGlobalFVGeometry(const GridView gridView) + CCMpfaFVGridGeometry(const GridView gridView) : gridView_(gridView), elementMap_(gridView), globalInteractionVolumeSeeds_(gridView_) {} //! The total number of sub control volumes diff --git a/dumux/discretization/cellcentered/mpfa/globalfluxvariablescache.hh b/dumux/discretization/cellcentered/mpfa/globalfluxvariablescache.hh index 79ace006a3..dfc65aa5ce 100644 --- a/dumux/discretization/cellcentered/mpfa/globalfluxvariablescache.hh +++ b/dumux/discretization/cellcentered/mpfa/globalfluxvariablescache.hh @@ -72,12 +72,12 @@ public: // instantiate helper class to fill the caches FluxVariablesCacheFiller filler(problem); - const auto& globalFvGeometry = problem.model().globalFvGeometry(); - fluxVarsCache_.resize(globalFvGeometry.numScvf()); + const auto& fvGridGeometry = problem.model().fvGridGeometry(); + fluxVarsCache_.resize(fvGridGeometry.numScvf()); for (const auto& element : elements(problem.gridView())) { // Prepare the geometries within the elements of the stencil - auto fvGeometry = localView(globalFvGeometry); + auto fvGeometry = localView(fvGridGeometry); fvGeometry.bind(element); auto elemVolVars = localView(problem.model().curGlobalVolVars()); diff --git a/dumux/discretization/cellcentered/mpfa/globalinteractionvolumeseedsbase.hh b/dumux/discretization/cellcentered/mpfa/globalinteractionvolumeseedsbase.hh index 06b4056d92..062997568e 100644 --- a/dumux/discretization/cellcentered/mpfa/globalinteractionvolumeseedsbase.hh +++ b/dumux/discretization/cellcentered/mpfa/globalinteractionvolumeseedsbase.hh @@ -24,7 +24,7 @@ #define DUMUX_DISCRETIZATION_MPFA_GLOBALINTERACTIONVOLUMESEEDS_BASE_HH #include <dumux/implicit/cellcentered/mpfa/properties.hh> -#include "globalfvgeometry.hh" +#include "fvgridgeometry.hh" namespace Dumux { diff --git a/dumux/discretization/cellcentered/mpfa/globalvolumevariables.hh b/dumux/discretization/cellcentered/mpfa/globalvolumevariables.hh index 617301cb09..d417f2dfc6 100644 --- a/dumux/discretization/cellcentered/mpfa/globalvolumevariables.hh +++ b/dumux/discretization/cellcentered/mpfa/globalvolumevariables.hh @@ -67,13 +67,13 @@ public: { problemPtr_ = &problem; - auto numScv = problem.model().globalFvGeometry().numScv(); - auto numDomainBoundaryScvf = problem.model().globalFvGeometry().numDomainBoundaryScvf(); + auto numScv = problem.model().fvGridGeometry().numScv(); + auto numDomainBoundaryScvf = problem.model().fvGridGeometry().numDomainBoundaryScvf(); volumeVariables_.resize(numScv + numDomainBoundaryScvf); for (const auto& element : elements(problem.gridView())) { - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) diff --git a/dumux/discretization/cellcentered/mpfa/helper.hh b/dumux/discretization/cellcentered/mpfa/helper.hh index 2c8f95c2d6..ffaea59839 100644 --- a/dumux/discretization/cellcentered/mpfa/helper.hh +++ b/dumux/discretization/cellcentered/mpfa/helper.hh @@ -545,7 +545,7 @@ public: const auto bcTypes = problem.boundaryTypes(element, scvf); // if we are on an interior boundary return interior types - if (problem.model().globalFvGeometry().isOnInteriorBoundary(scvf)) + if (problem.model().fvGridGeometry().isOnInteriorBoundary(scvf)) { if (bcTypes.hasOnlyNeumann()) return MpfaFaceTypes::interiorNeumann; diff --git a/dumux/discretization/cellcentered/mpfa/hybridfps/globalfvgeometry.hh b/dumux/discretization/cellcentered/mpfa/hybridfps/fvgridgeometry.hh similarity index 97% rename from dumux/discretization/cellcentered/mpfa/hybridfps/globalfvgeometry.hh rename to dumux/discretization/cellcentered/mpfa/hybridfps/fvgridgeometry.hh index ba4526ae8f..5658f9466f 100644 --- a/dumux/discretization/cellcentered/mpfa/hybridfps/globalfvgeometry.hh +++ b/dumux/discretization/cellcentered/mpfa/hybridfps/fvgridgeometry.hh @@ -22,8 +22,8 @@ * This builds up the sub control volumes and sub control volume faces * for each element. */ -#ifndef DUMUX_DISCRETIZATION_CC_MPFA_O_HYBRIDFPS_GLOBALFVGEOMETRY_HH -#define DUMUX_DISCRETIZATION_CC_MPFA_O_HYBRIDFPS_GLOBALFVGEOMETRY_HH +#ifndef DUMUX_DISCRETIZATION_CC_MPFA_O_HYBRIDFPS_FV_GRID_GEOMETRY_HH +#define DUMUX_DISCRETIZATION_CC_MPFA_O_HYBRIDFPS_FV_GRID_GEOMETRY_HH #include <dune/geometry/multilineargeometry.hh> #include <dune/geometry/referenceelements.hh> @@ -42,12 +42,12 @@ namespace Dumux * for each element. */ template<class TypeTag, bool EnableFVElementGeometryCache> -class CCMpfaOHybridFpsGlobalFVGeometry +class CCMpfaOHybridFpsFVGridGeometry {}; // specialization in case the FVElementGeometries are stored template<class TypeTag> -class CCMpfaOHybridFpsGlobalFVGeometry<TypeTag, true> +class CCMpfaOHybridFpsFVGridGeometry<TypeTag, true> { //! The local class needs access to the scv, scvfs and the fv element geometry //! as they are globally cached @@ -79,7 +79,7 @@ class CCMpfaOHybridFpsGlobalFVGeometry<TypeTag, true> public: //! Constructor - CCMpfaOHybridFpsGlobalFVGeometry(const GridView gridView) + CCMpfaOHybridFpsFVGridGeometry(const GridView gridView) : gridView_(gridView), elementMap_(gridView), globalInteractionVolumeSeeds_(gridView) {} //! The total number of sub control volumes @@ -223,7 +223,7 @@ public: * The local object is only functional after calling its bind/bindElement method * This is a free function that will be found by means of ADL */ - friend inline FVElementGeometry localView(const CCMpfaOHybridFpsGlobalFVGeometry& global) + friend inline FVElementGeometry localView(const CCMpfaOHybridFpsFVGridGeometry& global) { return FVElementGeometry(global); } //! Get a sub control volume with a global scv index diff --git a/dumux/discretization/cellcentered/mpfa/hybridfps/globalinteractionvolumeseeds.hh b/dumux/discretization/cellcentered/mpfa/hybridfps/globalinteractionvolumeseeds.hh index f14ac446c7..8201c4d786 100644 --- a/dumux/discretization/cellcentered/mpfa/hybridfps/globalinteractionvolumeseeds.hh +++ b/dumux/discretization/cellcentered/mpfa/hybridfps/globalinteractionvolumeseeds.hh @@ -63,7 +63,7 @@ public: oSeeds_.clear(); // -1 indicates that the scvf has not been handled yet - auto numScvf = problem_().model().globalFvGeometry().numScvf(); + auto numScvf = problem_().model().fvGridGeometry().numScvf(); scvfIndexMap_.resize(numScvf, -1); // detect and handle the boundary first @@ -85,7 +85,7 @@ private: IndexType fpsSeedIndex = 0; for (const auto& element : elements(gridView_)) { - auto fvGeometry = localView(problem_().model().globalFvGeometry()); + auto fvGeometry = localView(problem_().model().fvGridGeometry()); fvGeometry.bind(element); for (const auto& scvf : scvfs(fvGeometry)) { @@ -118,7 +118,7 @@ private: IndexType oSeedIndex = 0; for (const auto& element : elements(gridView_)) { - auto fvGeometry = localView(problem_().model().globalFvGeometry()); + auto fvGeometry = localView(problem_().model().fvGridGeometry()); fvGeometry.bind(element); for (const auto& scvf : scvfs(fvGeometry)) { diff --git a/dumux/discretization/cellcentered/mpfa/interiorboundarydata.hh b/dumux/discretization/cellcentered/mpfa/interiorboundarydata.hh index dfbe975323..9e58af0d2c 100644 --- a/dumux/discretization/cellcentered/mpfa/interiorboundarydata.hh +++ b/dumux/discretization/cellcentered/mpfa/interiorboundarydata.hh @@ -86,7 +86,7 @@ public: "not marked as interior Dirichlet face."); const auto& scvf = fvGeometry.scvf(scvfIndex()); - const auto element = problem_().model().globalFvGeometry().element(scvf.insideScvIdx()); + const auto element = problem_().model().fvGridGeometry().element(scvf.insideScvIdx()); const auto priVars = problem_().dirichlet(element, scvf); VolumeVariables volVars; diff --git a/dumux/discretization/cellcentered/mpfa/lmethod/globalinteractionvolumeseeds.hh b/dumux/discretization/cellcentered/mpfa/lmethod/globalinteractionvolumeseeds.hh index d9fe0f67c7..eef54c3ccd 100644 --- a/dumux/discretization/cellcentered/mpfa/lmethod/globalinteractionvolumeseeds.hh +++ b/dumux/discretization/cellcentered/mpfa/lmethod/globalinteractionvolumeseeds.hh @@ -62,14 +62,14 @@ public: scvfIndexMap.clear(); // reserve memory - const auto numScvf = this->problem().model().globalFvGeometry().numScvf(); - const auto numIBScvf = this->problem().model().globalFvGeometry().numInteriorBoundaryScvf(); - const auto numDBScvf = this->problem().model().globalFvGeometry().numDomainBoundaryScvf(); - const auto numBPScvf = this->problem().model().globalFvGeometry().numBranchingPointScvf(); + const auto numScvf = this->problem().model().fvGridGeometry().numScvf(); + const auto numIBScvf = this->problem().model().fvGridGeometry().numInteriorBoundaryScvf(); + const auto numDBScvf = this->problem().model().fvGridGeometry().numDomainBoundaryScvf(); + const auto numBPScvf = this->problem().model().fvGridGeometry().numBranchingPointScvf(); const int numLMethodIVs = (numScvf-numIBScvf-numDBScvf-numBPScvf)/2; - const auto numOMethodIVs = this->problem().model().globalFvGeometry().numInteriorOrDomainBoundaryVertices() - + this->problem().model().globalFvGeometry().numBranchingPointVertices(); + const auto numOMethodIVs = this->problem().model().fvGridGeometry().numInteriorOrDomainBoundaryVertices() + + this->problem().model().fvGridGeometry().numBranchingPointVertices(); if (numLMethodIVs > 0) seeds.reserve( numLMethodIVs ); @@ -83,7 +83,7 @@ public: IndexType seedIndex = 0; for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->problem().model().globalFvGeometry()); + auto fvGeometry = localView(this->problem().model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scvf : scvfs(fvGeometry)) @@ -97,7 +97,7 @@ public: // - domain boundaries // - branching points (l-method can not handle this) if (interiorOrDomainBoundaryVertices[scvf.vertexIndex()] - || this->problem().model().globalFvGeometry().touchesBranchingPoint(scvf)) + || this->problem().model().fvGridGeometry().touchesBranchingPoint(scvf)) { // make the boundary interaction volume seed boundarySeeds.emplace_back(Helper::makeBoundaryInteractionVolumeSeed(this->problem(), @@ -141,7 +141,7 @@ public: } bool isLocalMaxLevel_(const Element& element, const SubControlVolumeFace& scvf) const - { return this->problem().model().globalFvGeometry().element(scvf.outsideScvIdx()).level() <= element.level(); } + { return this->problem().model().fvGridGeometry().element(scvf.outsideScvIdx()).level() <= element.level(); } }; } // end namespace diff --git a/dumux/discretization/cellcentered/mpfa/lmethod/helper.hh b/dumux/discretization/cellcentered/mpfa/lmethod/helper.hh index 1ca199a5d2..d7e03105ce 100644 --- a/dumux/discretization/cellcentered/mpfa/lmethod/helper.hh +++ b/dumux/discretization/cellcentered/mpfa/lmethod/helper.hh @@ -139,11 +139,11 @@ private: // get the surrounding elements and "outside" data LocalIndexType otherScvfIdx = 1-localScvfIdx; - const auto e2 = problem.model().globalFvGeometry().element(scvf.outsideScvIdx()); - const auto e3 = problem.model().globalFvGeometry().element(scvfVector[otherScvfIdx]->outsideScvIdx()); + const auto e2 = problem.model().fvGridGeometry().element(scvf.outsideScvIdx()); + const auto e3 = problem.model().fvGridGeometry().element(scvfVector[otherScvfIdx]->outsideScvIdx()); - auto e2Geometry = localView(problem.model().globalFvGeometry()); - auto e3Geometry = localView(problem.model().globalFvGeometry()); + auto e2Geometry = localView(problem.model().fvGridGeometry()); + auto e3Geometry = localView(problem.model().fvGridGeometry()); e2Geometry.bindElement(e2); e3Geometry.bindElement(e3); @@ -165,8 +165,8 @@ private: e3Scvfs[localScvfIdx]->index()); // Outer seed for outside of e2, we know the local scvf index here will be localScvfIdx in 2d - const auto e4 = problem.model().globalFvGeometry().element(e2Scvfs[localScvfIdx]->outsideScvIdx()); - auto e4Geometry = localView(problem.model().globalFvGeometry()); + const auto e4 = problem.model().fvGridGeometry().element(e2Scvfs[localScvfIdx]->outsideScvIdx()); + auto e4Geometry = localView(problem.model().fvGridGeometry()); e4Geometry.bindElement(e4); const auto e4Scvfs = Implementation::getCommonAndNextScvFace(*e2Scvfs[localScvfIdx], e4Geometry, /*clockwise?*/localScvfIdx == 1); diff --git a/dumux/discretization/cellcentered/mpfa/lmethod/interactionvolume.hh b/dumux/discretization/cellcentered/mpfa/lmethod/interactionvolume.hh index c5647e7b05..0515652a85 100644 --- a/dumux/discretization/cellcentered/mpfa/lmethod/interactionvolume.hh +++ b/dumux/discretization/cellcentered/mpfa/lmethod/interactionvolume.hh @@ -276,17 +276,17 @@ private: typename std::enable_if<d == 2>::type setupInteractionRegions_(const Seed& seed, const FVElementGeometry& fvGeometry) { - const auto& globalFvGeometry = problem_().model().globalFvGeometry(); + const auto& fvGridGeometry = problem_().model().fvGridGeometry(); interactionRegions_.reserve(2); auto&& scvSeed1 = seed.scvSeed(0); auto&& scvSeed2 = seed.scvSeed(1); auto&& outerScvSeed1 = seed.outerScvSeed(0); auto&& outerScvSeed2 = seed.outerScvSeed(1); - auto e1 = globalFvGeometry.element(scvSeed1.globalIndex()); - auto e2 = globalFvGeometry.element(scvSeed2.globalIndex()); - auto e3 = globalFvGeometry.element(outerScvSeed1.globalIndex()); - auto e4 = globalFvGeometry.element(outerScvSeed2.globalIndex()); + auto e1 = fvGridGeometry.element(scvSeed1.globalIndex()); + auto e2 = fvGridGeometry.element(scvSeed2.globalIndex()); + auto e3 = fvGridGeometry.element(outerScvSeed1.globalIndex()); + auto e4 = fvGridGeometry.element(outerScvSeed2.globalIndex()); // scvSeed1 is the one the seed construction began at if (scvSeed1.contiFaceLocalIdx() == 0) diff --git a/dumux/discretization/cellcentered/mpfa/omethod/globalinteractionvolumeseeds.hh b/dumux/discretization/cellcentered/mpfa/omethod/globalinteractionvolumeseeds.hh index 8e6139968d..cdf6e22f0b 100644 --- a/dumux/discretization/cellcentered/mpfa/omethod/globalinteractionvolumeseeds.hh +++ b/dumux/discretization/cellcentered/mpfa/omethod/globalinteractionvolumeseeds.hh @@ -65,8 +65,8 @@ public: scvfIndexMap.clear(); // reserve memory - const auto numScvf = this->problem().model().globalFvGeometry().numScvf(); - const auto numInteriorOrDomainBoundaryVertices = this->problem().model().globalFvGeometry().numInteriorOrDomainBoundaryVertices(); + const auto numScvf = this->problem().model().fvGridGeometry().numScvf(); + const auto numInteriorOrDomainBoundaryVertices = this->problem().model().fvGridGeometry().numInteriorOrDomainBoundaryVertices(); const int numInteriorVertices = this->gridView().size(dim) - numInteriorOrDomainBoundaryVertices; if (numInteriorVertices > 0) @@ -81,7 +81,7 @@ public: IndexType seedIndex = 0; for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->problem().model().globalFvGeometry()); + auto fvGeometry = localView(this->problem().model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scvf : scvfs(fvGeometry)) @@ -93,7 +93,7 @@ public: // on interior or domain boundaries and on branching points we have to set // a boundary interaction volume (for compatibility with other mpfa methods) if (interiorOrDomainBoundaryVertices[scvf.vertexIndex()] - || this->problem().model().globalFvGeometry().touchesBranchingPoint(scvf)) + || this->problem().model().fvGridGeometry().touchesBranchingPoint(scvf)) { // make the boundary interaction volume seed boundarySeeds.emplace_back(Helper::makeBoundaryInteractionVolumeSeed(this->problem(), diff --git a/dumux/discretization/cellcentered/mpfa/omethod/helper.hh b/dumux/discretization/cellcentered/mpfa/omethod/helper.hh index 9c7aca1b01..b648f5c115 100644 --- a/dumux/discretization/cellcentered/mpfa/omethod/helper.hh +++ b/dumux/discretization/cellcentered/mpfa/omethod/helper.hh @@ -111,7 +111,7 @@ public: scvfSeeds.shrink_to_fit(); // check if touches domain boundary (not only interior boundary) - const bool boundary = problem.model().globalFvGeometry().touchesDomainBoundary(scvf); + const bool boundary = problem.model().fvGridGeometry().touchesDomainBoundary(scvf); return InteractionVolumeSeed(std::move(scvSeeds), std::move(scvfSeeds), boundary); } @@ -125,7 +125,7 @@ private: const SubControlVolumeFace& scvf) { // Check whether or not we are touching the boundary here - const bool onBoundary = problem.model().globalFvGeometry().touchesDomainBoundary(scvf); + const bool onBoundary = problem.model().fvGridGeometry().touchesDomainBoundary(scvf); // Get the two scv faces in the first scv const auto scvfVector = Implementation::getScvFacesAtVertex(scvf.vertexIndex(), element, fvGeometry); @@ -172,7 +172,7 @@ private: LocalIndexType localScvfIdx = scvfSeeds.size(); // fvGeometry object to bind the neighbouring element during rotation - auto outsideFvGeometry = localView(problem.model().globalFvGeometry()); + auto outsideFvGeometry = localView(problem.model().fvGridGeometry()); // Start/continue interaction region construction from the given scv face const LocalIndexType startScvfIdx = clockWise ? 1 : 0; @@ -187,7 +187,7 @@ private: const LocalIndexType insideLocalScvIdx = firstIteration ? 0 : localScvIdx; // the current element inside of the scv face - const auto insideElement = problem.model().globalFvGeometry().element(curScvf.insideScvIdx()); + const auto insideElement = problem.model().fvGridGeometry().element(curScvf.insideScvIdx()); const auto faceType = Implementation::getMpfaFaceType(problem, insideElement, curScvf); // if the face touches the boundary, create a boundary scvf entity @@ -225,7 +225,7 @@ private: } // If we get here, there are outside entities - const auto outsideElement = problem.model().globalFvGeometry().element(outsideGlobalScvIdx); + const auto outsideElement = problem.model().fvGridGeometry().element(outsideGlobalScvIdx); outsideFvGeometry.bindElement(outsideElement); // get the two scv faces in the outside element that share the vertex @@ -317,7 +317,7 @@ public: const SubControlVolumeFace& scvf) { // if the scvf does not touch a branching point, use simplified algorithm to create interaction volume seed - if (!problem.model().globalFvGeometry().touchesBranchingPoint(scvf)) + if (!problem.model().fvGridGeometry().touchesBranchingPoint(scvf)) return MpfaMethodHelper<TypeTag, MpfaMethods::oMethod, 2, 2>::makeInnerInteractionVolumeSeed(problem, element, fvGeometry, @@ -355,7 +355,7 @@ public: const SubControlVolumeFace& scvf) { // if the scvf does not touch a branching point, use simplified algorithm to create interaction volume seed - if (!problem.model().globalFvGeometry().touchesBranchingPoint(scvf)) + if (!problem.model().fvGridGeometry().touchesBranchingPoint(scvf)) return MpfaMethodHelper<TypeTag, MpfaMethods::oMethod, 2, 2>::makeBoundaryInteractionVolumeSeed(problem, element, fvGeometry, @@ -430,8 +430,8 @@ private: for (auto outsideGlobalScvIdx : actualScvf.outsideScvIndices()) { // get outside element, fvgeometry etc. - const auto outsideElement = problem.model().globalFvGeometry().element(outsideGlobalScvIdx); - auto outsideFvGeometry = localView(problem.model().globalFvGeometry()); + const auto outsideElement = problem.model().fvGridGeometry().element(outsideGlobalScvIdx); + auto outsideFvGeometry = localView(problem.model().fvGridGeometry()); outsideFvGeometry.bindElement(outsideElement); // find scvf in outside corresponding to the actual scvf @@ -739,8 +739,8 @@ private: actualScvSeed.setLocalScvfIndex(coordDir, scvfSeeds.size()); // get outside element, fvgeometry etc. - const auto outsideElement = problem.model().globalFvGeometry().element(outsideGlobalScvIdx); - auto outsideFvGeometry = localView(problem.model().globalFvGeometry()); + const auto outsideElement = problem.model().fvGridGeometry().element(outsideGlobalScvIdx); + auto outsideFvGeometry = localView(problem.model().fvGridGeometry()); outsideFvGeometry.bindElement(outsideElement); // find scvf in outside corresponding to the actual scvf @@ -801,8 +801,8 @@ private: actualScvSeed.setLocalScvfIndex(coordDir, scvfSeeds.size()); // get outside element, fvgeometry etc. - const auto outsideElement = problem.model().globalFvGeometry().element(outsideGlobalScvIdx); - auto outsideFvGeometry = localView(problem.model().globalFvGeometry()); + const auto outsideElement = problem.model().fvGridGeometry().element(outsideGlobalScvIdx); + auto outsideFvGeometry = localView(problem.model().fvGridGeometry()); outsideFvGeometry.bindElement(outsideElement); // find scvf in outside corresponding to the actual scvf diff --git a/dumux/discretization/cellcentered/mpfa/omethod/interactionvolume.hh b/dumux/discretization/cellcentered/mpfa/omethod/interactionvolume.hh index 28d37d8079..48df93750a 100644 --- a/dumux/discretization/cellcentered/mpfa/omethod/interactionvolume.hh +++ b/dumux/discretization/cellcentered/mpfa/omethod/interactionvolume.hh @@ -392,7 +392,7 @@ private: // set up quantities related to sub-control volumes for (auto&& scvSeed : seed.scvSeeds()) { - const auto element = problem_().model().globalFvGeometry().element(scvSeed.globalIndex()); + const auto element = problem_().model().fvGridGeometry().element(scvSeed.globalIndex()); localScvs_.emplace_back(problem_(), element, fvGeometry_(), scvSeed); localElements_.emplace_back(std::move(element)); volVarsPositions_.push_back(localScvs_.back().center()); diff --git a/dumux/discretization/cellcentered/tpfa/CMakeLists.txt b/dumux/discretization/cellcentered/tpfa/CMakeLists.txt index a3ecb8bb0c..b93758228f 100644 --- a/dumux/discretization/cellcentered/tpfa/CMakeLists.txt +++ b/dumux/discretization/cellcentered/tpfa/CMakeLists.txt @@ -7,6 +7,6 @@ fluxvariablescachefiller.hh fourieslaw.hh fvelementgeometry.hh globalfluxvariablescache.hh -globalfvgeometry.hh +fvgridgeometry.hh subcontrolvolumeface.hh DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/dumux/discretization/cellcentered/tpfa) diff --git a/dumux/discretization/cellcentered/tpfa/elementfluxvariablescache.hh b/dumux/discretization/cellcentered/tpfa/elementfluxvariablescache.hh index ba2198cd4f..0e4f1fe90b 100644 --- a/dumux/discretization/cellcentered/tpfa/elementfluxvariablescache.hh +++ b/dumux/discretization/cellcentered/tpfa/elementfluxvariablescache.hh @@ -169,7 +169,7 @@ public: // add required data on the scv faces in the neighboring elements for (unsigned int localIdxJ = 0; localIdxJ < numNeighbors; ++localIdxJ) { - const auto elementJ = fvGeometry.globalFvGeometry().element(assemblyMapI[localIdxJ].globalJ); + const auto elementJ = fvGeometry.fvGridGeometry().element(assemblyMapI[localIdxJ].globalJ); for (auto scvfIdx : assemblyMapI[localIdxJ].scvfsJ) { auto&& scvfJ = fvGeometry.scvf(scvfIdx); @@ -218,7 +218,7 @@ public: const auto scvfInsideScvIdx = scvf.insideScvIdx(); const auto& insideElement = scvfInsideScvIdx == globalI ? element : - problem.model().globalFvGeometry().element(scvfInsideScvIdx); + problem.model().fvGridGeometry().element(scvfInsideScvIdx); filler.fill(*this, fluxVarsCache_[localScvfIdx], insideElement, fvGeometry, elemVolVars, scvf); } diff --git a/dumux/discretization/cellcentered/tpfa/elementvolumevariables.hh b/dumux/discretization/cellcentered/tpfa/elementvolumevariables.hh index 87819ed645..372a82b7af 100644 --- a/dumux/discretization/cellcentered/tpfa/elementvolumevariables.hh +++ b/dumux/discretization/cellcentered/tpfa/elementvolumevariables.hh @@ -141,7 +141,7 @@ public: // Update the volume variables of the neighboring elements for (const auto& dataJ : assemblyMapI) { - const auto& elementJ = fvGeometry.globalFvGeometry().element(dataJ.globalJ); + const auto& elementJ = fvGeometry.fvGridGeometry().element(dataJ.globalJ); auto&& scvJ = fvGeometry.scv(dataJ.globalJ); volumeVariables_[localIdx].update(problem.model().elementSolution(elementJ, sol), problem, @@ -184,7 +184,7 @@ public: volVarIndices_.resize(volVarIndices_.size() + additionalDofDependencies.size()); for (auto globalJ : additionalDofDependencies) { - const auto& elementJ = fvGeometry.globalFvGeometry().element(globalJ); + const auto& elementJ = fvGeometry.fvGridGeometry().element(globalJ); auto&& scvJ = fvGeometry.scv(globalJ); volumeVariables_[localIdx].update(problem.model().elementSolution(elementJ, sol), diff --git a/dumux/discretization/cellcentered/tpfa/fickslaw.hh b/dumux/discretization/cellcentered/tpfa/fickslaw.hh index 4021e2a297..bbd8a63188 100644 --- a/dumux/discretization/cellcentered/tpfa/fickslaw.hh +++ b/dumux/discretization/cellcentered/tpfa/fickslaw.hh @@ -136,7 +136,7 @@ private: { const auto outsideScvIdx = scvf.outsideScvIdx(i); const auto& outsideVolVars = elemVolVars[outsideScvIdx]; - const auto outsideElement = fvGeometry.globalFvGeometry().element(outsideScvIdx); + const auto outsideElement = fvGeometry.fvGridGeometry().element(outsideScvIdx); const auto& flippedScvf = fvGeometry.flipScvf(scvf.index(), i); auto outsideTi = calculateTransmissibility_(problem, outsideElement, fvGeometry, elemVolVars, flippedScvf, phaseIdx, compIdx); diff --git a/dumux/discretization/cellcentered/tpfa/fourierslaw.hh b/dumux/discretization/cellcentered/tpfa/fourierslaw.hh index 016627964c..8bede29975 100644 --- a/dumux/discretization/cellcentered/tpfa/fourierslaw.hh +++ b/dumux/discretization/cellcentered/tpfa/fourierslaw.hh @@ -113,7 +113,7 @@ private: { const auto outsideScvIdx = scvf.outsideScvIdx(i); const auto& outsideVolVars = elemVolVars[outsideScvIdx]; - const auto outsideElement = fvGeometry.globalFvGeometry().element(outsideScvIdx); + const auto outsideElement = fvGeometry.fvGridGeometry().element(outsideScvIdx); const auto& flippedScvf = fvGeometry.flipScvf(scvf.index(), i); auto outsideTi = calculateTransmissibility_(problem, outsideElement, fvGeometry, elemVolVars, flippedScvf); @@ -149,7 +149,7 @@ private: const auto outsideScvIdx = scvf.outsideScvIdx(); const auto& outsideScv = fvGeometry.scv(outsideScvIdx); const auto& outsideVolVars = elemVolVars[outsideScvIdx]; - const auto outsideElement = fvGeometry.globalFvGeometry().element(outsideScvIdx); + const auto outsideElement = fvGeometry.fvGridGeometry().element(outsideScvIdx); auto outsideLambda = ThermalConductivityModel::effectiveThermalConductivity(outsideVolVars, problem.spatialParams(), diff --git a/dumux/discretization/cellcentered/tpfa/fvelementgeometry.hh b/dumux/discretization/cellcentered/tpfa/fvelementgeometry.hh index 26a361cabd..47bb3ddedb 100644 --- a/dumux/discretization/cellcentered/tpfa/fvelementgeometry.hh +++ b/dumux/discretization/cellcentered/tpfa/fvelementgeometry.hh @@ -34,8 +34,8 @@ namespace Dumux { //! forward declaration of the global finite volume geometry -template<class TypeTag, bool EnableGlobalFVGeometryCache> -class CCTpfaGlobalFVGeometry; +template<class TypeTag, bool EnableFVGridGeometryCache> +class CCTpfaFVGridGeometry; /*! * \ingroup ImplicitModel @@ -43,7 +43,7 @@ class CCTpfaGlobalFVGeometry; * This builds up the sub control volumes and sub control volume faces * for each element. */ -template<class TypeTag, bool EnableGlobalFVGeometryCache> +template<class TypeTag, bool EnableFVGridGeometryCache> class CCTpfaFVElementGeometry {}; @@ -58,35 +58,35 @@ class CCTpfaFVElementGeometry<TypeTag, true> using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume); using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace); using Element = typename GridView::template Codim<0>::Entity; - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using ScvIterator = Dumux::ScvIterator<SubControlVolume, std::vector<IndexType>, ThisType>; using ScvfIterator = Dumux::ScvfIterator<SubControlVolumeFace, std::vector<IndexType>, ThisType>; public: //! Constructor - CCTpfaFVElementGeometry(const GlobalFVGeometry& globalFvGeometry) - : globalFvGeometryPtr_(&globalFvGeometry) {} + CCTpfaFVElementGeometry(const FVGridGeometry& fvGridGeometry) + : fvGridGeometryPtr_(&fvGridGeometry) {} //! Get an elment sub control volume with a global scv index //! We separate element and neighbor scvs to speed up mapping const SubControlVolume& scv(IndexType scvIdx) const { - return globalFvGeometry().scv(scvIdx); + return fvGridGeometry().scv(scvIdx); } //! Get an element sub control volume face with a global scvf index //! We separate element and neighbor scvfs to speed up mapping const SubControlVolumeFace& scvf(IndexType scvfIdx) const { - return globalFvGeometry().scvf(scvfIdx); + return fvGridGeometry().scvf(scvfIdx); } //! Get the scvf on the same face but from the other side //! Note that e.g. the normals might be different in the case of surface grids const SubControlVolumeFace& flipScvf(IndexType scvfIdx, unsigned int outsideScvIdx = 0) const { - return globalFvGeometry().flipScvf(scvfIdx, outsideScvIdx); + return fvGridGeometry().flipScvf(scvfIdx, outsideScvIdx); } //! iterator range for sub control volumes. Iterates over @@ -109,7 +109,7 @@ public: friend inline Dune::IteratorRange<ScvfIterator> scvfs(const CCTpfaFVElementGeometry& fvGeometry) { - const auto& g = fvGeometry.globalFvGeometry(); + const auto& g = fvGeometry.fvGridGeometry(); const auto scvIdx = fvGeometry.scvIndices_[0]; return Dune::IteratorRange<ScvfIterator>(ScvfIterator(g.scvfIndicesOfScv(scvIdx).begin(), fvGeometry), ScvfIterator(g.scvfIndicesOfScv(scvIdx).end(), fvGeometry)); @@ -124,7 +124,7 @@ public: //! number of sub control volumes in this fv element geometry std::size_t numScvf() const { - return globalFvGeometry().scvfIndicesOfScv(scvIndices_[0]).size(); + return fvGridGeometry().scvfIndicesOfScv(scvIndices_[0]).size(); } //! Binding of an element, called by the local jacobian to prepare element assembly @@ -137,18 +137,18 @@ public: void bindElement(const Element& element) { elementPtr_ = &element; - scvIndices_ = std::vector<IndexType>({globalFvGeometry().problem_().elementMapper().index(*elementPtr_)}); + scvIndices_ = std::vector<IndexType>({fvGridGeometry().problem_().elementMapper().index(*elementPtr_)}); } //! The global finite volume geometry we are a restriction of - const GlobalFVGeometry& globalFvGeometry() const - { return *globalFvGeometryPtr_; } + const FVGridGeometry& fvGridGeometry() const + { return *fvGridGeometryPtr_; } private: const Element* elementPtr_; std::vector<IndexType> scvIndices_; - const GlobalFVGeometry* globalFvGeometryPtr_; + const FVGridGeometry* fvGridGeometryPtr_; }; //! specialization in case the FVElementGeometries are not stored @@ -162,7 +162,7 @@ class CCTpfaFVElementGeometry<TypeTag, false> using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume); using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace); using Element = typename GridView::template Codim<0>::Entity; - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); static const int dim = GridView::dimension; static const int dimWorld = GridView::dimensionworld; @@ -172,8 +172,8 @@ class CCTpfaFVElementGeometry<TypeTag, false> public: //! Constructor - CCTpfaFVElementGeometry(const GlobalFVGeometry& globalFvGeometry) - : globalFvGeometryPtr_(&globalFvGeometry) {} + CCTpfaFVElementGeometry(const FVGridGeometry& fvGridGeometry) + : fvGridGeometryPtr_(&fvGridGeometry) {} //! Get an elment sub control volume with a global scv index //! We separate element and neighbor scvs to speed up mapping @@ -254,7 +254,7 @@ public: void bind(const Element& element) { bindElement(element); - for (const auto& intersection : intersections(globalFvGeometry().gridView(), element)) + for (const auto& intersection : intersections(fvGridGeometry().gridView(), element)) { neighborScvs_.reserve(element.subEntities(1)); neighborScvfIndices_.reserve(element.subEntities(1)); @@ -301,7 +301,7 @@ public: //! Check if user added additional DOF dependencies, i.e. the residual of DOF globalI depends //! on additional DOFs not included in the discretization schemes' occupation pattern - const auto& problem = globalFvGeometry().problem_(); + const auto& problem = fvGridGeometry().problem_(); const auto globalI = problem.elementMapper().index(element); const auto& additionalDofDependencies = problem.getAdditionalDofDependencies(globalI); if (!additionalDofDependencies.empty()) @@ -310,7 +310,7 @@ public: neighborScvIndices_.reserve(neighborScvIndices_.size() + additionalDofDependencies.size()); for (auto globalJ : additionalDofDependencies) { - neighborScvs_.emplace_back(globalFvGeometry().element(globalJ).geometry(), globalJ); + neighborScvs_.emplace_back(fvGridGeometry().element(globalJ).geometry(), globalJ); neighborScvIndices_.emplace_back(globalJ); } } @@ -327,8 +327,8 @@ public: } //! The global finite volume geometry we are a restriction of - const GlobalFVGeometry& globalFvGeometry() const - { return *globalFvGeometryPtr_; } + const FVGridGeometry& fvGridGeometry() const + { return *fvGridGeometryPtr_; } private: @@ -361,12 +361,12 @@ private: //! create scvs and scvfs of the bound element void makeElementGeometries(const Element& element) { - auto eIdx = globalFvGeometry().problem_().elementMapper().index(element); + auto eIdx = fvGridGeometry().problem_().elementMapper().index(element); scvs_.emplace_back(element.geometry(), eIdx); scvIndices_.emplace_back(eIdx); - const auto& scvFaceIndices = globalFvGeometry().scvfIndicesOfScv(eIdx); - const auto& neighborVolVarIndices = globalFvGeometry().neighborVolVarIndices(eIdx); + const auto& scvFaceIndices = fvGridGeometry().scvfIndicesOfScv(eIdx); + const auto& neighborVolVarIndices = fvGridGeometry().neighborVolVarIndices(eIdx); // for network grids there might be multiple intersection with the same geometryInInside // we indentify those by the indexInInside for now (assumes conforming grids at branching facets) @@ -376,10 +376,10 @@ private: handledScvf.resize(element.subEntities(1), false); int scvfCounter = 0; - for (const auto& intersection : intersections(globalFvGeometry().gridView(), element)) + for (const auto& intersection : intersections(fvGridGeometry().gridView(), element)) { // check if intersection is on interior boundary - const auto isInteriorBoundary = globalFvGeometry().problem_().isInteriorBoundary(element, intersection); + const auto isInteriorBoundary = fvGridGeometry().problem_().isInteriorBoundary(element, intersection); if (dim < dimWorld) if (handledScvf[intersection.indexInInside()]) @@ -408,12 +408,12 @@ private: void makeNeighborGeometries(const Element& element) { // create the neighbor scv - auto eIdx = globalFvGeometry().problem_().elementMapper().index(element); + auto eIdx = fvGridGeometry().problem_().elementMapper().index(element); neighborScvs_.emplace_back(element.geometry(), eIdx); neighborScvIndices_.push_back(eIdx); - const auto& scvFaceIndices = globalFvGeometry().scvfIndicesOfScv(eIdx); - const auto& neighborVolVarIndices = globalFvGeometry().neighborVolVarIndices(eIdx); + const auto& scvFaceIndices = fvGridGeometry().scvfIndicesOfScv(eIdx); + const auto& neighborVolVarIndices = fvGridGeometry().neighborVolVarIndices(eIdx); // for network grids there might be multiple intersection with the same geometryInInside // we indentify those by the indexInInside for now (assumes conforming grids at branching facets) @@ -423,10 +423,10 @@ private: handledScvf.resize(element.subEntities(1), false); int scvfCounter = 0; - for (const auto& intersection : intersections(globalFvGeometry().gridView(), element)) + for (const auto& intersection : intersections(fvGridGeometry().gridView(), element)) { // check if intersection is on interior boundary - const auto isInteriorBoundary = globalFvGeometry().problem_().isInteriorBoundary(element, intersection); + const auto isInteriorBoundary = fvGridGeometry().problem_().isInteriorBoundary(element, intersection); if (dim < dimWorld) if (handledScvf[intersection.indexInInside()]) @@ -458,7 +458,7 @@ private: { for (unsigned outsideScvIdx = 0; outsideScvIdx < neighborVolVarIndices[scvfCounter].size(); ++outsideScvIdx) { - if (neighborVolVarIndices[scvfCounter][outsideScvIdx] == globalFvGeometry().problem_().elementMapper().index(*elementPtr_)) + if (neighborVolVarIndices[scvfCounter][outsideScvIdx] == fvGridGeometry().problem_().elementMapper().index(*elementPtr_)) { std::vector<IndexType> scvIndices({eIdx}); scvIndices.insert(scvIndices.end(), neighborVolVarIndices[scvfCounter].begin(), neighborVolVarIndices[scvfCounter].end()); @@ -518,7 +518,7 @@ private: // the bound element const Element* elementPtr_; - const GlobalFVGeometry* globalFvGeometryPtr_; + const FVGridGeometry* fvGridGeometryPtr_; // local storage after binding an element std::vector<IndexType> scvIndices_; diff --git a/dumux/discretization/cellcentered/tpfa/globalfvgeometry.hh b/dumux/discretization/cellcentered/tpfa/fvgridgeometry.hh similarity index 96% rename from dumux/discretization/cellcentered/tpfa/globalfvgeometry.hh rename to dumux/discretization/cellcentered/tpfa/fvgridgeometry.hh index 4175c9c977..d4fc52cc19 100644 --- a/dumux/discretization/cellcentered/tpfa/globalfvgeometry.hh +++ b/dumux/discretization/cellcentered/tpfa/fvgridgeometry.hh @@ -22,8 +22,8 @@ * This builds up the sub control volumes and sub control volume faces * for each element of the grid partition. */ -#ifndef DUMUX_DISCRETIZATION_CCTPFA_GLOBAL_FVGEOMETRY_HH -#define DUMUX_DISCRETIZATION_CCTPFA_GLOBAL_FVGEOMETRY_HH +#ifndef DUMUX_DISCRETIZATION_CCTPFA_FV_GRID_GEOMETRY_HH +#define DUMUX_DISCRETIZATION_CCTPFA_FV_GRID_GEOMETRY_HH #include <dumux/common/elementmap.hh> #include <dumux/implicit/cellcentered/tpfa/properties.hh> @@ -38,13 +38,13 @@ namespace Dumux * This builds up the sub control volumes and sub control volume faces * for each element. */ -template<class TypeTag, bool EnableGlobalFVGeometryCache> -class CCTpfaGlobalFVGeometry +template<class TypeTag, bool EnableFVGridGeometryCache> +class CCTpfaFVGridGeometry {}; // specialization in case the FVElementGeometries are stored globally template<class TypeTag> -class CCTpfaGlobalFVGeometry<TypeTag, true> +class CCTpfaFVGridGeometry<TypeTag, true> { using Problem = typename GET_PROP_TYPE(TypeTag, Problem); using GridView = typename GET_PROP_TYPE(TypeTag, GridView); @@ -65,7 +65,7 @@ class CCTpfaGlobalFVGeometry<TypeTag, true> public: //! Constructor - CCTpfaGlobalFVGeometry(const GridView& gridView) + CCTpfaFVGridGeometry(const GridView& gridView) : gridView_(gridView), elementMap_(gridView) {} //! The total number of sub control volumes @@ -234,8 +234,8 @@ public: * The local object is only functional after calling its bind/bindElement method * This is a free function that will be found by means of ADL */ - friend inline FVElementGeometry localView(const CCTpfaGlobalFVGeometry& global) - { return FVElementGeometry(global); } + friend inline FVElementGeometry localView(const CCTpfaFVGridGeometry& fvGridGeometry) + { return FVElementGeometry(fvGridGeometry); } //private: @@ -297,7 +297,7 @@ private: // specialization in case the FVElementGeometries are not stored template<class TypeTag> -class CCTpfaGlobalFVGeometry<TypeTag, false> +class CCTpfaFVGridGeometry<TypeTag, false> { using Problem = typename GET_PROP_TYPE(TypeTag, Problem); using GridView = typename GET_PROP_TYPE(TypeTag, GridView); @@ -315,7 +315,7 @@ class CCTpfaGlobalFVGeometry<TypeTag, false> public: //! Constructor - CCTpfaGlobalFVGeometry(const GridView& gridView) + CCTpfaFVGridGeometry(const GridView& gridView) : gridView_(gridView), elementMap_(gridView) {} //! The total number of sub control volumes @@ -455,7 +455,7 @@ public: * The local object is only functional after calling its bind/bindElement method * This is a free function that will be found by means of ADL */ - friend inline FVElementGeometry localView(const CCTpfaGlobalFVGeometry& global) + friend inline FVElementGeometry localView(const CCTpfaFVGridGeometry& global) { return FVElementGeometry(global); } private: diff --git a/dumux/discretization/cellcentered/tpfa/globalfluxvariablescache.hh b/dumux/discretization/cellcentered/tpfa/globalfluxvariablescache.hh index aba839d8eb..fd4e23fc93 100644 --- a/dumux/discretization/cellcentered/tpfa/globalfluxvariablescache.hh +++ b/dumux/discretization/cellcentered/tpfa/globalfluxvariablescache.hh @@ -65,12 +65,12 @@ public: // instantiate helper class to fill the caches FluxVariablesCacheFiller filler(problem); - const auto& globalFvGeometry = problem.model().globalFvGeometry(); - fluxVarsCache_.resize(globalFvGeometry.numScvf()); + const auto& fvGridGeometry = problem.model().fvGridGeometry(); + fluxVarsCache_.resize(fvGridGeometry.numScvf()); for (const auto& element : elements(problem.gridView())) { // Prepare the geometries within the elements of the stencil - auto fvGeometry = localView(globalFvGeometry); + auto fvGeometry = localView(fvGridGeometry); fvGeometry.bind(element); auto elemVolVars = localView(problem.model().curGlobalVolVars()); diff --git a/dumux/discretization/fluxstencil.hh b/dumux/discretization/fluxstencil.hh index 780f04e070..1a9131d75c 100644 --- a/dumux/discretization/fluxstencil.hh +++ b/dumux/discretization/fluxstencil.hh @@ -118,13 +118,13 @@ public: const FVElementGeometry& fvGeometry, const SubControlVolumeFace& scvf) { - const auto& globalFvGeometry = problem.model().globalFvGeometry(); + const auto& fvGridGeometry = problem.model().fvGridGeometry(); // return the scv (element) indices in the interaction region - if (globalFvGeometry.isInBoundaryInteractionVolume(scvf)) - return globalFvGeometry.boundaryInteractionVolumeSeed(scvf).globalScvIndices(); + if (fvGridGeometry.isInBoundaryInteractionVolume(scvf)) + return fvGridGeometry.boundaryInteractionVolumeSeed(scvf).globalScvIndices(); else - return globalFvGeometry.interactionVolumeSeed(scvf).globalScvIndices(); + return fvGridGeometry.interactionVolumeSeed(scvf).globalScvIndices(); } }; diff --git a/dumux/discretization/staggered/elementfluxvariablescache.hh b/dumux/discretization/staggered/elementfluxvariablescache.hh index df74368908..5feb420cea 100644 --- a/dumux/discretization/staggered/elementfluxvariablescache.hh +++ b/dumux/discretization/staggered/elementfluxvariablescache.hh @@ -159,7 +159,7 @@ public: for (IndexType localIdxJ = 0; localIdxJ < numNeighbors; ++localIdxJ) { const auto& fluxVarIndicesJ = globalFluxVarsCache().problem_().model().localJacobian().assemblyMap()[globalI][localIdxJ]; - const auto elementJ = fvGeometry.globalFvGeometry().element(neighborStencil[localIdxJ]); + const auto elementJ = fvGeometry.fvGridGeometry().element(neighborStencil[localIdxJ]); for (auto fluxVarIdx : fluxVarIndicesJ) { diff --git a/dumux/discretization/staggered/elementvolumevariables.hh b/dumux/discretization/staggered/elementvolumevariables.hh index 48bd0e8c9b..0ada499689 100644 --- a/dumux/discretization/staggered/elementvolumevariables.hh +++ b/dumux/discretization/staggered/elementvolumevariables.hh @@ -135,7 +135,7 @@ public: // Update the volume variables of the neighboring elements for (auto globalJ : neighborStencil) { - const auto& elementJ = fvGeometry.globalFvGeometry().element(globalJ); + const auto& elementJ = fvGeometry.fvGridGeometry().element(globalJ); auto&& scvJ = fvGeometry.scv(globalJ); volumeVariables_[localIdx].update(sol[globalJ], globalVolVars().problem_(), elementJ, scvJ); volVarIndices_[localIdx] = scvJ.index(); diff --git a/dumux/discretization/staggered/fvelementgeometry.hh b/dumux/discretization/staggered/fvelementgeometry.hh index 6cb4aa4fd2..1806d66e59 100644 --- a/dumux/discretization/staggered/fvelementgeometry.hh +++ b/dumux/discretization/staggered/fvelementgeometry.hh @@ -34,8 +34,8 @@ namespace Dumux { //! forward declaration of the global finite volume geometry -template<class TypeTag, bool EnableGlobalFVGeometryCache> -class StaggeredGlobalFVGeometry; +template<class TypeTag, bool EnableFVGridGeometryCache> +class StaggeredFVGridGeometry; /*! * \ingroup ImplicitModel @@ -43,7 +43,7 @@ class StaggeredGlobalFVGeometry; * This builds up the sub control volumes and sub control volume faces * for each element. */ -template<class TypeTag, bool EnableGlobalFVGeometryCache> +template<class TypeTag, bool EnableFVGridGeometryCache> class StaggeredFVElementGeometry {}; @@ -58,33 +58,33 @@ class StaggeredFVElementGeometry<TypeTag, true> using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume); using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace); using Element = typename GridView::template Codim<0>::Entity; - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using ScvIterator = Dumux::ScvIterator<SubControlVolume, std::vector<IndexType>, ThisType>; using ScvfIterator = Dumux::ScvfIterator<SubControlVolumeFace, std::vector<IndexType>, ThisType>; public: //! Constructor - StaggeredFVElementGeometry(const GlobalFVGeometry& globalFvGeometry) - : globalFvGeometryPtr_(&globalFvGeometry) {} + StaggeredFVElementGeometry(const FVGridGeometry& fvGridGeometry) + : fvGridGeometryPtr_(&fvGridGeometry) {} //! Get an elment sub control volume with a global scv index //! We separate element and neighbor scvs to speed up mapping const SubControlVolume& scv(IndexType scvIdx) const { - return globalFvGeometry().scv(scvIdx); + return fvGridGeometry().scv(scvIdx); } //! Get an element sub control volume face with a global scvf index //! We separate element and neighbor scvfs to speed up mapping const SubControlVolumeFace& scvf(IndexType scvfIdx) const { - return globalFvGeometry().scvf(scvfIdx); + return fvGridGeometry().scvf(scvfIdx); } const SubControlVolumeFace& scvf(IndexType eIdx ,IndexType localScvfIdx) const { - return globalFvGeometry().scvf(eIdx, localScvfIdx); + return fvGridGeometry().scvf(eIdx, localScvfIdx); } //! iterator range for sub control volumes. Iterates over @@ -107,7 +107,7 @@ public: friend inline Dune::IteratorRange<ScvfIterator> scvfs(const StaggeredFVElementGeometry& fvGeometry) { - const auto& g = fvGeometry.globalFvGeometry(); + const auto& g = fvGeometry.fvGridGeometry(); const auto scvIdx = fvGeometry.scvIndices_[0]; return Dune::IteratorRange<ScvfIterator>(ScvfIterator(g.scvfIndicesOfScv(scvIdx).begin(), fvGeometry), ScvfIterator(g.scvfIndicesOfScv(scvIdx).end(), fvGeometry)); @@ -122,7 +122,7 @@ public: //! number of sub control volumes in this fv element geometry std::size_t numScvf() const { - return globalFvGeometry().scvfIndicesOfScv(scvIndices_[0]).size(); + return fvGridGeometry().scvfIndicesOfScv(scvIndices_[0]).size(); } //! Binding of an element, called by the local jacobian to prepare element assembly @@ -135,18 +135,18 @@ public: void bindElement(const Element& element) { elementPtr_ = &element; - scvIndices_ = std::vector<IndexType>({globalFvGeometry().problem_().elementMapper().index(*elementPtr_)}); + scvIndices_ = std::vector<IndexType>({fvGridGeometry().problem_().elementMapper().index(*elementPtr_)}); } //! The global finite volume geometry we are a restriction of - const GlobalFVGeometry& globalFvGeometry() const - { return *globalFvGeometryPtr_; } + const FVGridGeometry& fvGridGeometry() const + { return *fvGridGeometryPtr_; } private: const Element* elementPtr_; std::vector<IndexType> scvIndices_; - const GlobalFVGeometry* globalFvGeometryPtr_; + const FVGridGeometry* fvGridGeometryPtr_; }; //! specialization in case the FVElementGeometries are not stored @@ -160,15 +160,15 @@ class StaggeredFVElementGeometry<TypeTag, false> using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume); using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace); using Element = typename GridView::template Codim<0>::Entity; - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using ScvIterator = Dumux::ScvIterator<SubControlVolume, std::vector<IndexType>, ThisType>; using ScvfIterator = Dumux::ScvfIterator<SubControlVolumeFace, std::vector<IndexType>, ThisType>; public: //! Constructor - StaggeredFVElementGeometry(const GlobalFVGeometry& globalFvGeometry) - : globalFvGeometryPtr_(&globalFvGeometry) {} + StaggeredFVElementGeometry(const FVGridGeometry& fvGridGeometry) + : fvGridGeometryPtr_(&fvGridGeometry) {} //! Get an elment sub control volume with a global scv index //! We separate element and neighbor scvs to speed up mapping @@ -228,7 +228,7 @@ public: void bind(const Element& element) { bindElement(element); - for (const auto& intersection : intersections(globalFvGeometry().gridView(), element)) + for (const auto& intersection : intersections(fvGridGeometry().gridView(), element)) { neighborScvs_.reserve(element.subEntities(1)); neighborScvfIndices_.reserve(element.subEntities(1)); @@ -246,23 +246,23 @@ public: } //! The global finite volume geometry we are a restriction of - const GlobalFVGeometry& globalFvGeometry() const - { return *globalFvGeometryPtr_; } + const FVGridGeometry& fvGridGeometry() const + { return *fvGridGeometryPtr_; } private: //! create scvs and scvfs of the bound element void makeElementGeometries(const Element& element) { - auto eIdx = globalFvGeometry().problem_().elementMapper().index(element); + auto eIdx = fvGridGeometry().problem_().elementMapper().index(element); scvs_.emplace_back(element.geometry(), eIdx); scvIndices_.emplace_back(eIdx); - const auto& scvFaceIndices = globalFvGeometry().scvfIndicesOfScv(eIdx); - const auto& neighborVolVarIndices = globalFvGeometry().neighborVolVarIndices(eIdx); + const auto& scvFaceIndices = fvGridGeometry().scvfIndicesOfScv(eIdx); + const auto& neighborVolVarIndices = fvGridGeometry().neighborVolVarIndices(eIdx); int scvfCounter = 0; - for (const auto& intersection : intersections(globalFvGeometry().gridView(), element)) + for (const auto& intersection : intersections(fvGridGeometry().gridView(), element)) { if (intersection.neighbor() || intersection.boundary()) { @@ -282,15 +282,15 @@ private: void makeNeighborGeometries(const Element& element) { // create the neighbor scv - auto eIdx = globalFvGeometry().problem_().elementMapper().index(element); + auto eIdx = fvGridGeometry().problem_().elementMapper().index(element); neighborScvs_.emplace_back(element.geometry(), eIdx); neighborScvIndices_.push_back(eIdx); - const auto& scvFaceIndices = globalFvGeometry().scvfIndicesOfScv(eIdx); - const auto& neighborVolVarIndices = globalFvGeometry().neighborVolVarIndices(eIdx); + const auto& scvFaceIndices = fvGridGeometry().scvfIndicesOfScv(eIdx); + const auto& neighborVolVarIndices = fvGridGeometry().neighborVolVarIndices(eIdx); int scvfCounter = 0; - for (const auto& intersection : intersections(globalFvGeometry().gridView(), element)) + for (const auto& intersection : intersections(fvGridGeometry().gridView(), element)) { if (intersection.neighbor()) { @@ -340,7 +340,7 @@ private: // the bound element const Element* elementPtr_; - const GlobalFVGeometry* globalFvGeometryPtr_; + const FVGridGeometry* fvGridGeometryPtr_; // local storage after binding an element std::vector<IndexType> scvIndices_; diff --git a/dumux/discretization/staggered/globalfvgeometry.hh b/dumux/discretization/staggered/fvgridgeometry.hh similarity index 96% rename from dumux/discretization/staggered/globalfvgeometry.hh rename to dumux/discretization/staggered/fvgridgeometry.hh index 8d2cedeb7b..8fd8b53b95 100644 --- a/dumux/discretization/staggered/globalfvgeometry.hh +++ b/dumux/discretization/staggered/fvgridgeometry.hh @@ -37,13 +37,13 @@ namespace Dumux * This builds up the sub control volumes and sub control volume faces * for each element. */ -template<class TypeTag, bool EnableGlobalFVGeometryCache> -class StaggeredGlobalFVGeometry +template<class TypeTag, bool EnableFVGridGeometryCache> +class StaggeredFVGridGeometry {}; // specialization in case the FVElementGeometries are stored globally template<class TypeTag> -class StaggeredGlobalFVGeometry<TypeTag, true> +class StaggeredFVGridGeometry<TypeTag, true> { using Problem = typename GET_PROP_TYPE(TypeTag, Problem); using GridView = typename GET_PROP_TYPE(TypeTag, GridView); @@ -67,7 +67,7 @@ class StaggeredGlobalFVGeometry<TypeTag, true> public: //! Constructor - StaggeredGlobalFVGeometry(const GridView& gridView) + StaggeredFVGridGeometry(const GridView& gridView) : gridView_(gridView), elementMap_(gridView), intersectionMapper_(gridView) {} //! The total number of sub control volumes @@ -195,7 +195,7 @@ public: * The local object is only functional after calling its bind/bindElement method * This is a free function that will be found by means of ADL */ - friend inline FVElementGeometry localView(const StaggeredGlobalFVGeometry& global) + friend inline FVElementGeometry localView(const StaggeredFVGridGeometry& global) { return FVElementGeometry(global); } //private: @@ -247,7 +247,7 @@ private: // specialization in case the FVElementGeometries are not stored template<class TypeTag> -class StaggeredGlobalFVGeometry<TypeTag, false> +class StaggeredFVGridGeometry<TypeTag, false> { using Problem = typename GET_PROP_TYPE(TypeTag, Problem); using GridView = typename GET_PROP_TYPE(TypeTag, GridView); @@ -261,7 +261,7 @@ class StaggeredGlobalFVGeometry<TypeTag, false> public: //! Constructor - StaggeredGlobalFVGeometry(const GridView& gridView) + StaggeredFVGridGeometry(const GridView& gridView) : gridView_(gridView), elementMap_(gridView) {} //! The total number of sub control volumes @@ -355,7 +355,7 @@ public: * The local object is only functional after calling its bind/bindElement method * This is a free function that will be found by means of ADL */ - friend inline FVElementGeometry localView(const StaggeredGlobalFVGeometry& global) + friend inline FVElementGeometry localView(const StaggeredFVGridGeometry& global) { return FVElementGeometry(global); } private: diff --git a/dumux/discretization/staggered/globalfluxvariablescache.hh b/dumux/discretization/staggered/globalfluxvariablescache.hh index 21ceda9649..5e4dfd38cf 100644 --- a/dumux/discretization/staggered/globalfluxvariablescache.hh +++ b/dumux/discretization/staggered/globalfluxvariablescache.hh @@ -57,12 +57,12 @@ public: void update(Problem& problem) { problemPtr_ = &problem; - const auto& globalFvGeometry = problem.model().globalFvGeometry(); - fluxVarsCache_.resize(globalFvGeometry.numScvf()); + const auto& fvGridGeometry = problem.model().fvGridGeometry(); + fluxVarsCache_.resize(fvGridGeometry.numScvf()); for (const auto& element : elements(problem.gridView())) { // Prepare the geometries within the elements of the stencil - auto fvGeometry = localView(globalFvGeometry); + auto fvGeometry = localView(fvGridGeometry); fvGeometry.bind(element); auto elemVolVars = localView(problem.model().curGlobalVolVars()); diff --git a/dumux/discretization/staggered/globalvolumevariables.hh b/dumux/discretization/staggered/globalvolumevariables.hh index 6912d7ed0a..bf6673bdaf 100644 --- a/dumux/discretization/staggered/globalvolumevariables.hh +++ b/dumux/discretization/staggered/globalvolumevariables.hh @@ -75,13 +75,13 @@ public: { problemPtr_ = &problem; - auto numScv = problem.model().globalFvGeometry().numScv(); - auto numBoundaryScvf = problem.model().globalFvGeometry().numBoundaryScvf(); + auto numScv = problem.model().fvGridGeometry().numScv(); + auto numBoundaryScvf = problem.model().fvGridGeometry().numBoundaryScvf(); volumeVariables_.resize(numScv + numBoundaryScvf); for (const auto& element : elements(problem.gridView())) { - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) diff --git a/dumux/discretization/upwindscheme.hh b/dumux/discretization/upwindscheme.hh index 94d1cdc60d..c00acef074 100644 --- a/dumux/discretization/upwindscheme.hh +++ b/dumux/discretization/upwindscheme.hh @@ -118,7 +118,7 @@ public: { // compute the outside flux const auto outsideScvIdx = fluxVars.scvFace().outsideScvIdx(i); - const auto outsideElement = fluxVars.fvGeometry().globalFvGeometry().element(outsideScvIdx); + const auto outsideElement = fluxVars.fvGeometry().fvGridGeometry().element(outsideScvIdx); const auto& flippedScvf = fluxVars.fvGeometry().flipScvf(fluxVars.scvFace().index(), i); const auto outsideFlux = AdvectionType::flux(fluxVars.problem(), @@ -240,7 +240,7 @@ public: { // compute the outside flux const auto outsideScvIdx = fluxVars.scvFace().outsideScvIdx(i); - const auto outsideElement = fluxVars.fvGeometry().globalFvGeometry().element(outsideScvIdx); + const auto outsideElement = fluxVars.fvGeometry().fvGridGeometry().element(outsideScvIdx); const auto& flippedScvf = fluxVars.fvGeometry().flipScvf(fluxVars.scvFace().index(), i); const auto outsideFlux = AdvectionType::flux(fluxVars.problem(), diff --git a/dumux/freeflow/staggered/model.hh b/dumux/freeflow/staggered/model.hh index bd88ed81f0..4e781c517d 100644 --- a/dumux/freeflow/staggered/model.hh +++ b/dumux/freeflow/staggered/model.hh @@ -62,7 +62,7 @@ class NavierStokesModel : public GET_PROP_TYPE(TypeTag, BaseModel) typedef typename GET_PROP_TYPE(TypeTag, Problem) Problem; typedef typename GET_PROP_TYPE(TypeTag, Indices) Indices; typedef typename GET_PROP_TYPE(TypeTag, Scalar) Scalar; - typedef typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry) GlobalFVGeometry; + typedef typename GET_PROP_TYPE(TypeTag, FVGridGeometry) FVGridGeometry; typedef typename GET_PROP_TYPE(TypeTag, SolutionVector) SolutionVector; typedef typename GET_PROP_TYPE(TypeTag, JacobianAssembler) JacobianAssembler; diff --git a/dumux/freeflow/staggerednc/model.hh b/dumux/freeflow/staggerednc/model.hh index 1805487164..f65194ab28 100644 --- a/dumux/freeflow/staggerednc/model.hh +++ b/dumux/freeflow/staggerednc/model.hh @@ -63,7 +63,7 @@ class NavierStokesNCModel : public NavierStokesModel<TypeTag> typedef typename GET_PROP_TYPE(TypeTag, Problem) Problem; typedef typename GET_PROP_TYPE(TypeTag, Indices) Indices; typedef typename GET_PROP_TYPE(TypeTag, Scalar) Scalar; - typedef typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry) GlobalFVGeometry; + typedef typename GET_PROP_TYPE(TypeTag, FVGridGeometry) FVGridGeometry; typedef typename GET_PROP_TYPE(TypeTag, SolutionVector) SolutionVector; typedef typename GET_PROP_TYPE(TypeTag, JacobianAssembler) JacobianAssembler; diff --git a/dumux/implicit/box/localjacobian.hh b/dumux/implicit/box/localjacobian.hh index 530fae74e1..7bc58332fd 100644 --- a/dumux/implicit/box/localjacobian.hh +++ b/dumux/implicit/box/localjacobian.hh @@ -112,7 +112,7 @@ public: SolutionVector& residual) { // prepare the volvars/fvGeometries for the case when caching is disabled - auto fvGeometry = localView(this->problem_().model().globalFvGeometry()); + auto fvGeometry = localView(this->problem_().model().fvGridGeometry()); fvGeometry.bind(element); auto curElemVolVars = localView(this->model_().curGlobalVolVars()); diff --git a/dumux/implicit/box/propertydefaults.hh b/dumux/implicit/box/propertydefaults.hh index c95a65d75b..e680c40379 100644 --- a/dumux/implicit/box/propertydefaults.hh +++ b/dumux/implicit/box/propertydefaults.hh @@ -33,7 +33,7 @@ #include <dumux/discretization/box/elementfluxvariablescache.hh> #include <dumux/discretization/box/globalvolumevariables.hh> #include <dumux/discretization/box/elementvolumevariables.hh> -#include <dumux/discretization/box/globalfvgeometry.hh> +#include <dumux/discretization/box/fvgridgeometry.hh> #include <dumux/discretization/box/fvelementgeometry.hh> #include <dumux/porousmediumflow/implicit/fluxvariablescache.hh> #include <dumux/discretization/methods.hh> @@ -61,10 +61,10 @@ SET_PROP(BoxModel, DiscretizationMethod) }; //! Set the default for the FVElementGeometry vector -SET_TYPE_PROP(BoxModel, GlobalFVGeometry, BoxGlobalFVGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalFVGeometryCache)>); +SET_TYPE_PROP(BoxModel, FVGridGeometry, BoxFVGridGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableFVGridGeometryCache)>); //! Set the default for the FVElementGeometry vector -SET_TYPE_PROP(BoxModel, FVElementGeometry, BoxFVElementGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalFVGeometryCache)>); +SET_TYPE_PROP(BoxModel, FVElementGeometry, BoxFVElementGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableFVGridGeometryCache)>); //! The sub control volume SET_PROP(BoxModel, SubControlVolume) diff --git a/dumux/implicit/cellcentered/assemblymap.hh b/dumux/implicit/cellcentered/assemblymap.hh index 606a61d8a7..a2bb34b5e8 100644 --- a/dumux/implicit/cellcentered/assemblymap.hh +++ b/dumux/implicit/cellcentered/assemblymap.hh @@ -78,7 +78,7 @@ public: // We are looking for the elements I, for which this element J is in the flux stencil auto globalJ = problem.elementMapper().index(element); - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bindElement(element); // obtain the data of J in elements I diff --git a/dumux/implicit/cellcentered/localjacobian.hh b/dumux/implicit/cellcentered/localjacobian.hh index 414fc98d67..11e3114eaf 100644 --- a/dumux/implicit/cellcentered/localjacobian.hh +++ b/dumux/implicit/cellcentered/localjacobian.hh @@ -125,7 +125,7 @@ public: const bool isGhost = (element.partitionType() == Dune::GhostEntity); // prepare the volvars/fvGeometries in case caching is disabled - auto fvGeometry = localView(this->model_().globalFvGeometry()); + auto fvGeometry = localView(this->model_().fvGridGeometry()); fvGeometry.bind(element); auto curElemVolVars = localView(this->model_().curGlobalVolVars()); @@ -217,7 +217,7 @@ protected: unsigned int j = 0; for (const auto& dataJ : assemblyMap_[globalI_]) { - auto elementJ = fvGeometry.globalFvGeometry().element(dataJ.globalJ); + auto elementJ = fvGeometry.fvGridGeometry().element(dataJ.globalJ); neighborElements.push_back(elementJ); for (auto scvfIdx : dataJ.scvfsJ) @@ -397,7 +397,7 @@ protected: { auto&& scvJ = fvGeometry.scv(globalJ); auto& curVolVarsJ = getCurVolVars(curElemVolVars, scvJ); - const auto& elementJ = fvGeometry.globalFvGeometry().element(globalJ); + const auto& elementJ = fvGeometry.fvGridGeometry().element(globalJ); auto& curSol = this->model_().curSol(); // save a copy of the original privars and volvars diff --git a/dumux/implicit/cellcentered/mpfa/generalassemblymap.hh b/dumux/implicit/cellcentered/mpfa/generalassemblymap.hh index c69911e08d..f0813505f2 100644 --- a/dumux/implicit/cellcentered/mpfa/generalassemblymap.hh +++ b/dumux/implicit/cellcentered/mpfa/generalassemblymap.hh @@ -76,7 +76,7 @@ public: // We are looking for the elements I, for which this element J is in the flux stencil auto globalJ = problem.elementMapper().index(element); - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bindElement(element); // obtain the data of J in elements I diff --git a/dumux/implicit/cellcentered/mpfa/propertydefaults.hh b/dumux/implicit/cellcentered/mpfa/propertydefaults.hh index 0f0a0dbc26..3c39f209b4 100644 --- a/dumux/implicit/cellcentered/mpfa/propertydefaults.hh +++ b/dumux/implicit/cellcentered/mpfa/propertydefaults.hh @@ -31,7 +31,7 @@ #include <dumux/porousmediumflow/implicit/fluxvariablescache.hh> #include <dumux/discretization/methods.hh> #include <dumux/discretization/cellcentered/mpfa/methods.hh> -#include <dumux/discretization/cellcentered/mpfa/globalfvgeometry.hh> +#include <dumux/discretization/cellcentered/mpfa/fvgridgeometry.hh> #include <dumux/discretization/cellcentered/mpfa/globalvolumevariables.hh> #include <dumux/discretization/cellcentered/mpfa/globalfluxvariablescache.hh> #include <dumux/discretization/cellcentered/mpfa/fvelementgeometry.hh> @@ -80,7 +80,7 @@ SET_TYPE_PROP(CCMpfaModel, BoundaryInteractionVolume, typename GET_PROP_TYPE(Typ SET_TYPE_PROP(CCMpfaModel, GlobalInteractionVolumeSeeds, CCMpfaGlobalInteractionVolumeSeeds<TypeTag>); //! Set the default for the global finite volume geometry -SET_TYPE_PROP(CCMpfaModel, GlobalFVGeometry, CCMpfaGlobalFVGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalFVGeometryCache)>); +SET_TYPE_PROP(CCMpfaModel, FVGridGeometry, CCMpfaFVGridGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableFVGridGeometryCache)>); //! The global current volume variables vector class SET_TYPE_PROP(CCMpfaModel, GlobalVolumeVariables, Dumux::CCMpfaGlobalVolumeVariables<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalVolumeVariablesCache)>); @@ -89,7 +89,7 @@ SET_TYPE_PROP(CCMpfaModel, GlobalVolumeVariables, Dumux::CCMpfaGlobalVolumeVaria SET_TYPE_PROP(CCMpfaModel, GlobalFluxVariablesCache, CCMpfaGlobalFluxVariablesCache<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalFluxVariablesCache)>); //! Set the default for the local finite volume geometry -SET_TYPE_PROP(CCMpfaModel, FVElementGeometry, CCMpfaFVElementGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalFVGeometryCache)>); +SET_TYPE_PROP(CCMpfaModel, FVElementGeometry, CCMpfaFVElementGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableFVGridGeometryCache)>); //! The global previous volume variables vector class SET_TYPE_PROP(CCMpfaModel, ElementVolumeVariables, Dumux::CCMpfaElementVolumeVariables<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalVolumeVariablesCache)>); diff --git a/dumux/implicit/cellcentered/tpfa/propertydefaults.hh b/dumux/implicit/cellcentered/tpfa/propertydefaults.hh index 1422045377..73fba7ee44 100644 --- a/dumux/implicit/cellcentered/tpfa/propertydefaults.hh +++ b/dumux/implicit/cellcentered/tpfa/propertydefaults.hh @@ -29,7 +29,7 @@ #include <dumux/implicit/propertydefaults.hh> #include <dumux/porousmediumflow/implicit/fluxvariablescache.hh> -#include <dumux/discretization/cellcentered/tpfa/globalfvgeometry.hh> +#include <dumux/discretization/cellcentered/tpfa/fvgridgeometry.hh> #include <dumux/discretization/cellcentered/tpfa/globalfluxvariablescache.hh> #include <dumux/discretization/cellcentered/tpfa/fvelementgeometry.hh> #include <dumux/discretization/cellcentered/tpfa/elementvolumevariables.hh> @@ -51,13 +51,13 @@ SET_PROP(CCTpfaModel, DiscretizationMethod) }; //! Set the default for the global finite volume geometry -SET_TYPE_PROP(CCTpfaModel, GlobalFVGeometry, CCTpfaGlobalFVGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalFVGeometryCache)>); +SET_TYPE_PROP(CCTpfaModel, FVGridGeometry, CCTpfaFVGridGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableFVGridGeometryCache)>); //! The global flux variables cache vector class SET_TYPE_PROP(CCTpfaModel, GlobalFluxVariablesCache, Dumux::CCTpfaGlobalFluxVariablesCache<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalFluxVariablesCache)>); //! Set the default for the local finite volume geometry -SET_TYPE_PROP(CCTpfaModel, FVElementGeometry, CCTpfaFVElementGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalFVGeometryCache)>); +SET_TYPE_PROP(CCTpfaModel, FVElementGeometry, CCTpfaFVElementGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableFVGridGeometryCache)>); //! The global previous volume variables vector class SET_TYPE_PROP(CCTpfaModel, ElementVolumeVariables, Dumux::CCTpfaElementVolumeVariables<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalVolumeVariablesCache)>); diff --git a/dumux/implicit/localresidual.hh b/dumux/implicit/localresidual.hh index 2d8bae3ec0..c86f3aff15 100644 --- a/dumux/implicit/localresidual.hh +++ b/dumux/implicit/localresidual.hh @@ -98,7 +98,7 @@ public: void eval(const Element &element) { // make sure FVElementGeometry and volume variables are bound to the element - auto fvGeometry = localView(problem().model().globalFvGeometry()); + auto fvGeometry = localView(problem().model().fvGridGeometry()); fvGeometry.bind(element); auto curElemVolVars = localView(problem().model().curGlobalVolVars()); @@ -128,7 +128,7 @@ public: void evalStorage(const Element &element) { // make sure FVElementGeometry and volume variables are bound to the element - auto fvGeometry = localView(problem().model().globalFvGeometry()); + auto fvGeometry = localView(problem().model().fvGridGeometry()); fvGeometry.bindElement(element); auto curElemVolVars = localView(problem().model().curGlobalVolVars()); diff --git a/dumux/implicit/model.hh b/dumux/implicit/model.hh index 06752f4ecf..0eff0e8309 100644 --- a/dumux/implicit/model.hh +++ b/dumux/implicit/model.hh @@ -77,7 +77,7 @@ class ImplicitModel dim = GridView::dimension }; - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using FVElementGeometry = typename GET_PROP_TYPE(TypeTag, FVElementGeometry); using LocalJacobian = typename GET_PROP_TYPE(TypeTag, LocalJacobian); using LocalResidual = typename GET_PROP_TYPE(TypeTag, LocalResidual); @@ -113,8 +113,8 @@ public: updateBoundaryIndices_(); - globalFvGeometryPtr_ = std::make_shared<GlobalFVGeometry>(problem.gridView()); - globalFvGeometryPtr_->update(problem); + fvGridGeometryPtr_ = std::make_shared<FVGridGeometry>(problem.gridView()); + fvGridGeometryPtr_->update(problem); int numDofs = asImp_().numDofs(); uCur_.resize(numDofs); @@ -410,7 +410,7 @@ public: updateBoundaryIndices_(); // update the fv geometry - globalFvGeometryPtr_->update(problem_()); + fvGridGeometryPtr_->update(problem_()); // resize and update the volVars with the initial solution curGlobalVolVars_.update(problem_(), curSol()); @@ -654,8 +654,8 @@ public: const GlobalVolumeVariables& prevGlobalVolVars() const { return prevGlobalVolVars_; } - const GlobalFVGeometry& globalFvGeometry() const - { return *globalFvGeometryPtr_; } + const FVGridGeometry& fvGridGeometry() const + { return *fvGridGeometryPtr_; } protected: @@ -813,7 +813,7 @@ protected: GlobalFluxVariablesCache globalfluxVarsCache_; // the finite volume element geometries - std::shared_ptr<GlobalFVGeometry> globalFvGeometryPtr_; + std::shared_ptr<FVGridGeometry> fvGridGeometryPtr_; private: /*! diff --git a/dumux/implicit/properties.hh b/dumux/implicit/properties.hh index af294c6031..87b8cf07e1 100644 --- a/dumux/implicit/properties.hh +++ b/dumux/implicit/properties.hh @@ -61,8 +61,8 @@ NEW_PROP_TAG(LocalJacobian); //!< The type of the local jacobian operator NEW_PROP_TAG(SubControlVolume);//!< The type of the sub control volume NEW_PROP_TAG(SubControlVolumeFace); //!< The type of the sub control volume face NEW_PROP_TAG(FVElementGeometry); //!< The type of the local finite volume geometry (iterators over scvs, scvfs) -NEW_PROP_TAG(GlobalFVGeometry); //!< The type of the global finite volume geometry -NEW_PROP_TAG(EnableGlobalFVGeometryCache); //! specifies if geometric data is be saved (faster, but more memory consuming) +NEW_PROP_TAG(FVGridGeometry); //!< The type of the global finite volume geometry +NEW_PROP_TAG(EnableFVGridGeometryCache); //! specifies if geometric data is be saved (faster, but more memory consuming) NEW_PROP_TAG(JacobianAssembler); //!< Assembles the global jacobian matrix NEW_PROP_TAG(JacobianMatrix); //!< Type of the global jacobian matrix diff --git a/dumux/implicit/propertydefaults.hh b/dumux/implicit/propertydefaults.hh index dfd0645fe9..0cb162d8e0 100644 --- a/dumux/implicit/propertydefaults.hh +++ b/dumux/implicit/propertydefaults.hh @@ -167,7 +167,7 @@ SET_BOOL_PROP(ImplicitBase, ImplicitEnableJacobianRecycling, false); SET_BOOL_PROP(ImplicitBase, ImplicitEnablePartialReassemble, false); //! We do not store the FVGeometry by default -SET_BOOL_PROP(ImplicitBase, EnableGlobalFVGeometryCache, false); +SET_BOOL_PROP(ImplicitBase, EnableFVGridGeometryCache, false); //! We do not store the volume variables by default SET_BOOL_PROP(ImplicitBase, EnableGlobalVolumeVariablesCache, false); diff --git a/dumux/implicit/staggered/assembler.hh b/dumux/implicit/staggered/assembler.hh index 83e3d878fc..30a84437f4 100644 --- a/dumux/implicit/staggered/assembler.hh +++ b/dumux/implicit/staggered/assembler.hh @@ -146,7 +146,7 @@ private: for (auto&& faceGlobalJ : assemblyMap(cellCenterIdx, faceIdx, ccGlobalI)) occupationPatternA12.add(ccGlobalI, faceGlobalJ); - auto fvGeometry = localView(this->problem_().model().globalFvGeometry()); + auto fvGeometry = localView(this->problem_().model().fvGridGeometry()); fvGeometry.bindElement(element); // loop over sub control faces diff --git a/dumux/implicit/staggered/assemblymap.hh b/dumux/implicit/staggered/assemblymap.hh index 1fc9fc0086..45331e432b 100644 --- a/dumux/implicit/staggered/assemblymap.hh +++ b/dumux/implicit/staggered/assemblymap.hh @@ -66,7 +66,7 @@ public: { const auto numDofsCC = problem.model().numCellCenterDofs(); const auto numDofsFace = problem.model().numFaceDofs(); - const auto numBoundaryFacets = problem.model().globalFvGeometry().numBoundaryScvf(); + const auto numBoundaryFacets = problem.model().fvGridGeometry().numBoundaryScvf(); cellCenterToCellCenterMap_.resize(numDofsCC); cellCenterToFaceMap_.resize(numDofsCC); faceToCellCenterMap_.resize(2*numDofsFace - numBoundaryFacets); @@ -81,7 +81,7 @@ public: for(auto&& element: elements(problem.gridView())) { // restrict the FvGeometry locally and bind to the element - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bindElement(element); // loop over sub control faces diff --git a/dumux/implicit/staggered/localjacobian.hh b/dumux/implicit/staggered/localjacobian.hh index 983fb36cc0..571956299e 100644 --- a/dumux/implicit/staggered/localjacobian.hh +++ b/dumux/implicit/staggered/localjacobian.hh @@ -150,7 +150,7 @@ public: DUNE_THROW(Dune::NotImplemented, "Support for ghost cells not implemented"); // prepare the volvars/fvGeometries in case caching is disabled - auto fvGeometry = localView(this->model_().globalFvGeometry()); + auto fvGeometry = localView(this->model_().fvGridGeometry()); fvGeometry.bind(element); auto curElemVolVars = localView(this->model_().curGlobalVolVars()); @@ -270,7 +270,7 @@ protected: { // get the volVars of the element with respect to which we are going to build the derivative auto&& scvJ = fvGeometry.scv(globalJ); - const auto elementJ = fvGeometry.globalFvGeometry().element(globalJ); + const auto elementJ = fvGeometry.fvGridGeometry().element(globalJ); auto& curVolVars = getCurVolVars(curElemVolVars, scvJ); VolumeVariables origVolVars(curVolVars); @@ -373,7 +373,7 @@ protected: { // get the volVars of the element with respect to which we are going to build the derivative auto&& scvJ = fvGeometry.scv(globalJ); - const auto elementJ = fvGeometry.globalFvGeometry().element(globalJ); + const auto elementJ = fvGeometry.fvGridGeometry().element(globalJ); auto& curVolVars = getCurVolVars(curElemVolVars, scvJ); VolumeVariables origVolVars(curVolVars); diff --git a/dumux/implicit/staggered/localresidual.hh b/dumux/implicit/staggered/localresidual.hh index a576541462..fe799358cf 100644 --- a/dumux/implicit/staggered/localresidual.hh +++ b/dumux/implicit/staggered/localresidual.hh @@ -114,7 +114,7 @@ public: void eval(const Element &element) { // make sure FVElementGeometry and volume variables are bound to the element - auto fvGeometry = localView(this->problem().model().globalFvGeometry()); + auto fvGeometry = localView(this->problem().model().fvGridGeometry()); fvGeometry.bind(element); auto curElemVolVars = localView(problem().model().curGlobalVolVars()); diff --git a/dumux/implicit/staggered/model.hh b/dumux/implicit/staggered/model.hh index 9d93c876b8..e59dbaab15 100644 --- a/dumux/implicit/staggered/model.hh +++ b/dumux/implicit/staggered/model.hh @@ -61,7 +61,7 @@ class StaggeredBaseModel : public ImplicitModel<TypeTag> friend typename GET_PROP_TYPE(TypeTag, LocalJacobian); using FVElementGeometry = typename GET_PROP_TYPE(TypeTag, FVElementGeometry); using Problem = typename GET_PROP_TYPE(TypeTag, Problem); - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using SolutionVector = typename GET_PROP_TYPE(TypeTag, SolutionVector); using JacobianAssembler = typename GET_PROP_TYPE(TypeTag, JacobianAssembler); @@ -106,8 +106,8 @@ public: this->updateBoundaryIndices_(); - this->globalFvGeometryPtr_ = std::make_shared<GlobalFVGeometry>(problem.gridView()); - this->globalFvGeometryPtr_->update(problem); + this->fvGridGeometryPtr_ = std::make_shared<FVGridGeometry>(problem.gridView()); + this->fvGridGeometryPtr_->update(problem); this->uCur_[cellCenterIdx].resize(asImp_().numCellCenterDofs()); this->uCur_[faceIdx].resize(asImp_().numFaceDofs()); @@ -247,7 +247,7 @@ public: for (const auto& element : elements(this->gridView_())) { // deal with the current element, bind FVGeometry to it - auto fvGeometry = localView(this->globalFvGeometry()); + auto fvGeometry = localView(this->fvGridGeometry()); fvGeometry.bindElement(element); // loop over sub control volumes @@ -377,7 +377,7 @@ public: // (*rank)[eIdx] = this->gridView_().comm().rank(); // // // get the local fv geometry -// auto fvGeometry = localView(this->globalFvGeometry()); +// auto fvGeometry = localView(this->fvGridGeometry()); // fvGeometry.bindElement(element); // // auto elemVolVars = localView(this->curGlobalVolVars()); @@ -532,7 +532,7 @@ public: */ size_t numFaceDofs() const { - return this->globalFvGeometryPtr_->numIntersections(); + return this->fvGridGeometryPtr_->numIntersections(); } const GlobalFaceVariables& curGlobalFaceVars() const diff --git a/dumux/implicit/staggered/propertydefaults.hh b/dumux/implicit/staggered/propertydefaults.hh index 6bf8447821..b1dc5044a9 100644 --- a/dumux/implicit/staggered/propertydefaults.hh +++ b/dumux/implicit/staggered/propertydefaults.hh @@ -28,7 +28,7 @@ #define DUMUX_STAGGERED_PROPERTY_DEFAULTS_HH #include <dumux/implicit/propertydefaults.hh> -#include <dumux/discretization/staggered/globalfvgeometry.hh> +#include <dumux/discretization/staggered/fvgridgeometry.hh> #include <dumux/discretization/staggered/fvelementgeometry.hh> #include <dumux/implicit/staggered/properties.hh> #include <dumux/discretization/methods.hh> @@ -78,10 +78,10 @@ SET_TYPE_PROP(StaggeredModel, BaseModel, StaggeredBaseModel<TypeTag>); //! Set the default for the global finite volume geometry -SET_TYPE_PROP(StaggeredModel, GlobalFVGeometry, StaggeredGlobalFVGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalFVGeometryCache)>); +SET_TYPE_PROP(StaggeredModel, FVGridGeometry, StaggeredFVGridGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableFVGridGeometryCache)>); //! Set the default for the local finite volume geometry -SET_TYPE_PROP(StaggeredModel, FVElementGeometry, StaggeredFVElementGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableGlobalFVGeometryCache)>); +SET_TYPE_PROP(StaggeredModel, FVElementGeometry, StaggeredFVElementGeometry<TypeTag, GET_PROP_VALUE(TypeTag, EnableFVGridGeometryCache)>); //! The sub control volume SET_PROP(StaggeredModel, SubControlVolume) diff --git a/dumux/io/staggeredvtkoutputmodule.hh b/dumux/io/staggeredvtkoutputmodule.hh index 194701d5cf..4d8fcec2d2 100644 --- a/dumux/io/staggeredvtkoutputmodule.hh +++ b/dumux/io/staggeredvtkoutputmodule.hh @@ -192,7 +192,7 @@ private: for(auto&& element : elements(this->problem().gridView())) { - auto fvGeometry = localView(this->problem().model().globalFvGeometry()); + auto fvGeometry = localView(this->problem().model().fvGridGeometry()); fvGeometry.bindElement(element); for(auto && scvf : scvfs(fvGeometry)) { diff --git a/dumux/io/vtkoutputmodulebase.hh b/dumux/io/vtkoutputmodulebase.hh index c5c605a092..2974a7b109 100644 --- a/dumux/io/vtkoutputmodulebase.hh +++ b/dumux/io/vtkoutputmodulebase.hh @@ -217,7 +217,7 @@ public: = asImp_().getPriVarData_(eIdxGlobal, priVarVectorDataInfo_[i].pvIdx[j]); } - auto fvGeometry = localView(problem_.model().globalFvGeometry()); + auto fvGeometry = localView(problem_.model().fvGridGeometry()); auto elemVolVars = localView(problem_.model().curGlobalVolVars()); // If velocity output is enabled we need to bind to the whole stencil diff --git a/dumux/mixeddimension/embedded/cellcentered/bboxtreecouplingmanager.hh b/dumux/mixeddimension/embedded/cellcentered/bboxtreecouplingmanager.hh index aabd93f3f6..a8ed791ae2 100644 --- a/dumux/mixeddimension/embedded/cellcentered/bboxtreecouplingmanager.hh +++ b/dumux/mixeddimension/embedded/cellcentered/bboxtreecouplingmanager.hh @@ -487,8 +487,8 @@ public: auto& data = pointSourceData_[id]; auto bulkPriVars = data.interpolateBulk(bulkProblem().model().curSol()); - const auto element = bulkProblem().model().globalFvGeometry().element(data.bulkElementIdx()); - auto fvGeometry = localView(bulkProblem().model().globalFvGeometry()); + const auto element = bulkProblem().model().fvGridGeometry().element(data.bulkElementIdx()); + auto fvGeometry = localView(bulkProblem().model().fvGridGeometry()); fvGeometry.bindElement(element); BulkVolumeVariables volVars; @@ -504,8 +504,8 @@ public: LowDimVolumeVariables lowDimVolVars(unsigned int id) const { const auto& data = pointSourceData_[id]; - const auto element = lowDimProblem().model().globalFvGeometry().element(data.lowDimElementIdx()); - auto fvGeometry = localView(lowDimProblem().model().globalFvGeometry()); + const auto element = lowDimProblem().model().fvGridGeometry().element(data.lowDimElementIdx()); + auto fvGeometry = localView(lowDimProblem().model().fvGridGeometry()); fvGeometry.bindElement(element); const auto& curSol = lowDimProblem().model().curSol(); diff --git a/dumux/mixeddimension/embedded/cellcentered/bboxtreecouplingmanagersimple.hh b/dumux/mixeddimension/embedded/cellcentered/bboxtreecouplingmanagersimple.hh index 6b3a52b575..030eec9cfb 100644 --- a/dumux/mixeddimension/embedded/cellcentered/bboxtreecouplingmanagersimple.hh +++ b/dumux/mixeddimension/embedded/cellcentered/bboxtreecouplingmanagersimple.hh @@ -419,8 +419,8 @@ public: auto& data = pointSourceData_[id]; auto bulkPriVars = data.interpolateBulk(bulkProblem().model().curSol()); - const auto element = bulkProblem().model().globalFvGeometry().element(data.bulkElementIdx()); - auto fvGeometry = localView(bulkProblem().model().globalFvGeometry()); + const auto element = bulkProblem().model().fvGridGeometry().element(data.bulkElementIdx()); + auto fvGeometry = localView(bulkProblem().model().fvGridGeometry()); fvGeometry.bindElement(element); BulkVolumeVariables volVars; @@ -438,8 +438,8 @@ public: auto& data = pointSourceData_[id]; auto lowDimPriVars = data.interpolateLowDim(lowDimProblem().model().curSol()); - const auto element = lowDimProblem().model().globalFvGeometry().element(data.lowDimElementIdx()); - auto fvGeometry = localView(lowDimProblem().model().globalFvGeometry()); + const auto element = lowDimProblem().model().fvGridGeometry().element(data.lowDimElementIdx()); + auto fvGeometry = localView(lowDimProblem().model().fvGridGeometry()); fvGeometry.bindElement(element); LowDimVolumeVariables volVars; diff --git a/dumux/mixeddimension/facet/mpfa/couplingmanager.hh b/dumux/mixeddimension/facet/mpfa/couplingmanager.hh index 6b6d65b0b0..f5b8a66a64 100644 --- a/dumux/mixeddimension/facet/mpfa/couplingmanager.hh +++ b/dumux/mixeddimension/facet/mpfa/couplingmanager.hh @@ -200,9 +200,9 @@ public: // of the first element, the necessary quantities for all the scvfs will be in there, // as the scvfs in the other elements are the "flipped" scvfs of the ones in the first element const auto& firstPair = couplingData.elementScvfList[0]; - const auto firstBulkElement = bulkProblem().model().globalFvGeometry().element(firstPair.first); + const auto firstBulkElement = bulkProblem().model().fvGridGeometry().element(firstPair.first); - auto bulkFvGeometry = localView(bulkProblem().model().globalFvGeometry()); + auto bulkFvGeometry = localView(bulkProblem().model().fvGridGeometry()); bulkFvGeometry.bind(firstBulkElement); auto bulkElemVolVars = localView(bulkProblem().model().curGlobalVolVars()); @@ -214,7 +214,7 @@ public: BulkPrimaryVariables flux(0.0); for (const auto& pair : couplingData.elementScvfList) { - const auto bulkElement = bulkProblem().model().globalFvGeometry().element(pair.first); + const auto bulkElement = bulkProblem().model().fvGridGeometry().element(pair.first); for (auto scvfIdx : pair.second) flux += bulkLocalResidual_.computeFlux(bulkElement, bulkFvGeometry, @@ -236,8 +236,8 @@ public: const auto& scvfCouplingData = couplingMapper_.getBulkCouplingData(element).getScvfCouplingData(scvf); assert(scvfCouplingData.first && "no coupled facet element found for given scvf!"); - const auto lowDimElement = lowDimProblem().model().globalFvGeometry().element(scvfCouplingData.second); - auto lowDimFvGeometry = localView(lowDimProblem().model().globalFvGeometry()); + const auto lowDimElement = lowDimProblem().model().fvGridGeometry().element(scvfCouplingData.second); + auto lowDimFvGeometry = localView(lowDimProblem().model().fvGridGeometry()); lowDimFvGeometry.bindElement(lowDimElement); const auto& lowDimCurSol = lowDimProblem().model().curSol(); diff --git a/dumux/mixeddimension/facet/mpfa/couplingmapper.hh b/dumux/mixeddimension/facet/mpfa/couplingmapper.hh index 83168983a7..e91b768245 100644 --- a/dumux/mixeddimension/facet/mpfa/couplingmapper.hh +++ b/dumux/mixeddimension/facet/mpfa/couplingmapper.hh @@ -153,8 +153,8 @@ public: { bulkCouplingData_[bulkElementIdx].isCoupled = true; - const auto bulkElement = bulkProblem_().model().globalFvGeometry().element(bulkElementIdx); - auto bulkFvGeometry = localView(bulkProblem_().model().globalFvGeometry()); + const auto bulkElement = bulkProblem_().model().fvGridGeometry().element(bulkElementIdx); + auto bulkFvGeometry = localView(bulkProblem_().model().fvGridGeometry()); bulkFvGeometry.bindElement(bulkElement); // find the scvfs in the bulk element that "touch" the facet element @@ -179,10 +179,10 @@ public: // also, insert scvf stencil to the coupling stencil of the low dim element const auto scvfStencil = [&] () { - if (bulkProblem_().model().globalFvGeometry().isInBoundaryInteractionVolume(scvf)) - return bulkProblem_().model().globalFvGeometry().boundaryInteractionVolumeSeed(scvf).globalScvIndices(); + if (bulkProblem_().model().fvGridGeometry().isInBoundaryInteractionVolume(scvf)) + return bulkProblem_().model().fvGridGeometry().boundaryInteractionVolumeSeed(scvf).globalScvIndices(); else - return bulkProblem_().model().globalFvGeometry().interactionVolumeSeed(scvf).globalScvIndices(); + return bulkProblem_().model().fvGridGeometry().interactionVolumeSeed(scvf).globalScvIndices(); } (); auto& lowDimCouplingStencil = lowDimCouplingData_[lowDimElementGlobalIdx].couplingStencil; diff --git a/dumux/mixeddimension/facet/mpfa/interiorboundarydata.hh b/dumux/mixeddimension/facet/mpfa/interiorboundarydata.hh index d3de8e60ab..43d75d32d1 100644 --- a/dumux/mixeddimension/facet/mpfa/interiorboundarydata.hh +++ b/dumux/mixeddimension/facet/mpfa/interiorboundarydata.hh @@ -139,7 +139,7 @@ public: //! returns the volume variables for interior dirichlet boundaries LowDimVolumeVariables facetVolVars(const FVElementGeometry& fvGeometry) const { - return problem_().couplingManager().lowDimVolVars(problem_().model().globalFvGeometry().element(elementIndex()), + return problem_().couplingManager().lowDimVolVars(problem_().model().fvGridGeometry().element(elementIndex()), fvGeometry, fvGeometry.scvf(scvfIndex())); } @@ -148,7 +148,7 @@ public: LowDimVolumeVariables facetVolVars(const FVElementGeometry& fvGeometry, const SubControlVolumeFace& scvf) const { assert(scvf.index() == scvfIndex() && "calling facet volume variables for an scvf other than the bound one"); - return problem_().couplingManager().lowDimVolVars(problem_().model().globalFvGeometry().element(elementIndex()), + return problem_().couplingManager().lowDimVolVars(problem_().model().fvGridGeometry().element(elementIndex()), fvGeometry, scvf); } @@ -161,15 +161,15 @@ public: const auto& couplingMapper = problem_().couplingManager().couplingMapper(); // get coupling data for this scvf - const auto element = problem_().model().globalFvGeometry().element(elementIndex()); + const auto element = problem_().model().fvGridGeometry().element(elementIndex()); const auto& scvfCouplingData = couplingMapper.getBulkCouplingData(element).getScvfCouplingData(fvGeometry.scvf(scvfIndex())); // obtain data necessary to fully instantiate the complete coupled facet data assert(scvfCouplingData.first && "no coupled facet element found for given scvf!"); const auto& lowDimProblem = problem_().couplingManager().lowDimProblem(); - auto lowDimElement = lowDimProblem.model().globalFvGeometry().element(scvfCouplingData.second); - auto lowDimFvGeometry = localView(lowDimProblem.model().globalFvGeometry()); + auto lowDimElement = lowDimProblem.model().fvGridGeometry().element(scvfCouplingData.second); + auto lowDimFvGeometry = localView(lowDimProblem.model().fvGridGeometry()); lowDimFvGeometry.bindElement(lowDimElement); LowDimVolumeVariables lowDimVolVars; diff --git a/dumux/mixeddimension/integrationpointsource.hh b/dumux/mixeddimension/integrationpointsource.hh index 86866d746a..74682cbef4 100644 --- a/dumux/mixeddimension/integrationpointsource.hh +++ b/dumux/mixeddimension/integrationpointsource.hh @@ -142,7 +142,7 @@ public: { // check in which subcontrolvolume(s) we are const auto element = boundingBoxTree.entity(eIdx); - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bindElement(element); const auto globalPos = source.position(); // loop over all sub control volumes and check if the point source is inside diff --git a/dumux/mixeddimension/subproblemlocaljacobian.hh b/dumux/mixeddimension/subproblemlocaljacobian.hh index a18584867e..c284c6b408 100644 --- a/dumux/mixeddimension/subproblemlocaljacobian.hh +++ b/dumux/mixeddimension/subproblemlocaljacobian.hh @@ -141,7 +141,7 @@ public: SolutionVector& residual) { // prepare the volvars/fvGeometries in case caching is disabled - auto fvGeometry = localView(this->model_().globalFvGeometry()); + auto fvGeometry = localView(this->model_().fvGridGeometry()); fvGeometry.bind(element); auto curElemVolVars = localView(this->model_().curGlobalVolVars()); @@ -333,7 +333,7 @@ protected: for (auto globalJ : couplingStencil) { - const auto otherElement = otherProblem_().model().globalFvGeometry().element(globalJ); + const auto otherElement = otherProblem_().model().fvGridGeometry().element(globalJ); const auto originalResidual = globalProblem_().couplingManager().evalCouplingResidual(element, fvGeometry, curElemVolVars, diff --git a/dumux/porousmediumflow/2p2c/implicit/model.hh b/dumux/porousmediumflow/2p2c/implicit/model.hh index a1bc9e00d7..4c43a71893 100644 --- a/dumux/porousmediumflow/2p2c/implicit/model.hh +++ b/dumux/porousmediumflow/2p2c/implicit/model.hh @@ -204,7 +204,7 @@ public: for (const auto& element : elements(this->problem_().gridView())) { // make sure FVElementGeometry & vol vars are bound to the element - auto fvGeometry = localView(this->globalFvGeometry()); + auto fvGeometry = localView(this->fvGridGeometry()); fvGeometry.bindElement(element); if (switchFlag_) diff --git a/dumux/porousmediumflow/2pnc/implicit/model.hh b/dumux/porousmediumflow/2pnc/implicit/model.hh index b92e92a9d0..5d73c5f30a 100644 --- a/dumux/porousmediumflow/2pnc/implicit/model.hh +++ b/dumux/porousmediumflow/2pnc/implicit/model.hh @@ -233,7 +233,7 @@ public: for (const auto& element : elements(this->problem_().gridView())) { // make sure FVElementGeometry & vol vars are bound to the element - auto fvGeometry = localView(this->globalFvGeometry()); + auto fvGeometry = localView(this->fvGridGeometry()); fvGeometry.bindElement(element); if (switchFlag_) diff --git a/dumux/porousmediumflow/2pncmin/implicit/model.hh b/dumux/porousmediumflow/2pncmin/implicit/model.hh index b9d7159df8..fe9dd8a047 100644 --- a/dumux/porousmediumflow/2pncmin/implicit/model.hh +++ b/dumux/porousmediumflow/2pncmin/implicit/model.hh @@ -224,7 +224,7 @@ public: for (const auto& element : elements(this->problem_().gridView())) { // make sure FVElementGeometry & vol vars are bound to the element - auto fvGeometry = localView(this->globalFvGeometry()); + auto fvGeometry = localView(this->fvGridGeometry()); fvGeometry.bindElement(element); if (switchFlag_) diff --git a/dumux/porousmediumflow/3p3c/implicit/model.hh b/dumux/porousmediumflow/3p3c/implicit/model.hh index 63bb7080d2..a6553ff5d9 100644 --- a/dumux/porousmediumflow/3p3c/implicit/model.hh +++ b/dumux/porousmediumflow/3p3c/implicit/model.hh @@ -206,7 +206,7 @@ public: for (const auto& element : elements(this->problem_().gridView())) { // make sure FVElementGeometry & vol vars are bound to the element - auto fvGeometry = localView(this->globalFvGeometry()); + auto fvGeometry = localView(this->fvGridGeometry()); fvGeometry.bindElement(element); if (switchFlag_) diff --git a/dumux/porousmediumflow/compositional/primaryvariableswitch.hh b/dumux/porousmediumflow/compositional/primaryvariableswitch.hh index 64bd67763f..32647cd96d 100644 --- a/dumux/porousmediumflow/compositional/primaryvariableswitch.hh +++ b/dumux/porousmediumflow/compositional/primaryvariableswitch.hh @@ -83,7 +83,7 @@ public: for (const auto& element : elements(problem.gridView())) { // make sure FVElementGeometry is bound to the element - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(problem.model().curGlobalVolVars()); @@ -128,7 +128,7 @@ public: for (const auto& element : elements(problem.gridView())) { // make sure FVElementGeometry is bound to the element - auto fvGeometry = localView(problem.model().globalFvGeometry()); + auto fvGeometry = localView(problem.model().fvGridGeometry()); fvGeometry.bindElement(element); const auto eIdx = problem.elementMapper().index(element); diff --git a/dumux/porousmediumflow/richards/implicit/newtoncontroller.hh b/dumux/porousmediumflow/richards/implicit/newtoncontroller.hh index 04e3a18fb7..fe27c82c90 100644 --- a/dumux/porousmediumflow/richards/implicit/newtoncontroller.hh +++ b/dumux/porousmediumflow/richards/implicit/newtoncontroller.hh @@ -91,7 +91,7 @@ public: const auto gridView = this->problem_().gridView(); for (const auto& element : elements(gridView)) { - auto fvGeometry = localView(this->model_().globalFvGeometry()); + auto fvGeometry = localView(this->model_().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) diff --git a/test/discretization/box/test_boxfvgeometry.cc b/test/discretization/box/test_boxfvgeometry.cc index 929e8e33c7..b40cc5508d 100644 --- a/test/discretization/box/test_boxfvgeometry.cc +++ b/test/discretization/box/test_boxfvgeometry.cc @@ -99,7 +99,7 @@ int main (int argc, char *argv[]) try using GlobalPosition = Dune::FieldVector<Scalar, dimworld>; using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume); using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace); - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using Problem = typename GET_PROP_TYPE(TypeTag, Problem); // make a grid @@ -111,7 +111,7 @@ int main (int argc, char *argv[]) try Problem problem(leafGridView); - GlobalFVGeometry global(leafGridView); + FVGridGeometry global(leafGridView); global.update(problem); // iterate over elements. For every element get fv geometry and loop over scvs and scvfaces diff --git a/test/discretization/cellcentered/tpfa/test_tpfafvgeometry.cc b/test/discretization/cellcentered/tpfa/test_tpfafvgeometry.cc index e6f5a1fa7b..349b045b47 100644 --- a/test/discretization/cellcentered/tpfa/test_tpfafvgeometry.cc +++ b/test/discretization/cellcentered/tpfa/test_tpfafvgeometry.cc @@ -94,7 +94,7 @@ int main (int argc, char *argv[]) try using GlobalPosition = Dune::FieldVector<Scalar, dimworld>; using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume); using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace); - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using Problem = typename GET_PROP_TYPE(TypeTag, Problem); // make a grid @@ -106,7 +106,7 @@ int main (int argc, char *argv[]) try Problem problem(leafGridView); - GlobalFVGeometry global(leafGridView); + FVGridGeometry global(leafGridView); global.update(problem); // iterate over elements. For every element get fv geometry and loop over scvs and scvfaces diff --git a/test/discretization/staggered/test_staggered.cc b/test/discretization/staggered/test_staggered.cc index 6e26dcd3cb..6c3e3e2853 100644 --- a/test/discretization/staggered/test_staggered.cc +++ b/test/discretization/staggered/test_staggered.cc @@ -33,7 +33,7 @@ #include <dune/grid/common/mcmgmapper.hh> #include <dumux/implicit/staggered/properties.hh> -#include <dumux/discretization/staggered/globalfvgeometry.hh> +#include <dumux/discretization/staggered/fvgridgeometry.hh> #include <dumux/discretization/staggered/fvelementgeometry.hh> // #include <dumux/discretization/staggered/subcontrolvolume.hh> #include <dumux/discretization/staggered/freeflow/subcontrolvolumeface.hh> @@ -65,7 +65,7 @@ SET_TYPE_PROP(TestFVGeometry, Grid, Dune::YaspGrid<2>); SET_TYPE_PROP(TestFVGeometry, Problem, Dumux::MockProblem<TypeTag>); -SET_BOOL_PROP(TestFVGeometry, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(TestFVGeometry, EnableFVGridGeometryCache, true); } } @@ -96,7 +96,7 @@ int main (int argc, char *argv[]) try using GlobalPosition = Dune::FieldVector<Scalar, dimworld>; using SubControlVolume = typename GET_PROP_TYPE(TypeTag, SubControlVolume); using SubControlVolumeFace = typename GET_PROP_TYPE(TypeTag, SubControlVolumeFace); - using GlobalFVGeometry = typename GET_PROP_TYPE(TypeTag, GlobalFVGeometry); + using FVGridGeometry = typename GET_PROP_TYPE(TypeTag, FVGridGeometry); using Problem = typename GET_PROP_TYPE(TypeTag, Problem); // make a grid @@ -108,7 +108,7 @@ int main (int argc, char *argv[]) try Problem problem(leafGridView); - GlobalFVGeometry global(leafGridView); + FVGridGeometry global(leafGridView); global.update(problem); std::cout << "Abbreviatons:\n" diff --git a/test/freeflow/staggered/channeltestproblem.hh b/test/freeflow/staggered/channeltestproblem.hh index 327f028090..bdb9399edc 100644 --- a/test/freeflow/staggered/channeltestproblem.hh +++ b/test/freeflow/staggered/channeltestproblem.hh @@ -69,7 +69,7 @@ SET_TYPE_PROP(ChannelTestProblem, Grid, Dune::YaspGrid<2>); // Set the problem property SET_TYPE_PROP(ChannelTestProblem, Problem, Dumux::ChannelTestProblem<TypeTag> ); -SET_BOOL_PROP(ChannelTestProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(ChannelTestProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(ChannelTestProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(ChannelTestProblem, EnableGlobalVolumeVariablesCache, true); diff --git a/test/freeflow/staggered/closedsystemtestproblem.hh b/test/freeflow/staggered/closedsystemtestproblem.hh index 0dd74e48bd..4c0adf6bf3 100644 --- a/test/freeflow/staggered/closedsystemtestproblem.hh +++ b/test/freeflow/staggered/closedsystemtestproblem.hh @@ -61,7 +61,7 @@ SET_TYPE_PROP(ClosedSystemTestProblem, Grid, Dune::YaspGrid<2>); // Set the problem property SET_TYPE_PROP(ClosedSystemTestProblem, Problem, Dumux::ClosedSystemTestProblem<TypeTag> ); -SET_BOOL_PROP(ClosedSystemTestProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(ClosedSystemTestProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(ClosedSystemTestProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(ClosedSystemTestProblem, EnableGlobalVolumeVariablesCache, true); diff --git a/test/freeflow/staggered/doneatestproblem.hh b/test/freeflow/staggered/doneatestproblem.hh index 49fe61b776..ba22ea2b50 100644 --- a/test/freeflow/staggered/doneatestproblem.hh +++ b/test/freeflow/staggered/doneatestproblem.hh @@ -64,7 +64,7 @@ SET_TYPE_PROP(DoneaTestProblem, Grid, Dune::YaspGrid<2>); // Set the problem property SET_TYPE_PROP(DoneaTestProblem, Problem, Dumux::DoneaTestProblem<TypeTag> ); -SET_BOOL_PROP(DoneaTestProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(DoneaTestProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(DoneaTestProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(DoneaTestProblem, EnableGlobalVolumeVariablesCache, true); @@ -299,7 +299,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) { @@ -345,7 +345,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) diff --git a/test/freeflow/staggered/kovasznaytestproblem.hh b/test/freeflow/staggered/kovasznaytestproblem.hh index 5f6deb256f..03f7b6290d 100644 --- a/test/freeflow/staggered/kovasznaytestproblem.hh +++ b/test/freeflow/staggered/kovasznaytestproblem.hh @@ -65,7 +65,7 @@ SET_TYPE_PROP(KovasznayTestProblem, Grid, Dune::YaspGrid<2, Dune::EquidistantOff // Set the problem property SET_TYPE_PROP(KovasznayTestProblem, Problem, Dumux::KovasznayTestProblem<TypeTag> ); -SET_BOOL_PROP(KovasznayTestProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(KovasznayTestProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(KovasznayTestProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(KovasznayTestProblem, EnableGlobalVolumeVariablesCache, true); @@ -308,7 +308,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) { @@ -354,7 +354,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) diff --git a/test/freeflow/staggerednc/channeltestproblem.hh b/test/freeflow/staggerednc/channeltestproblem.hh index 481692bc99..f0dfab82ab 100644 --- a/test/freeflow/staggerednc/channeltestproblem.hh +++ b/test/freeflow/staggerednc/channeltestproblem.hh @@ -74,7 +74,7 @@ SET_TYPE_PROP(ChannelNCTestProblem, Grid, Dune::YaspGrid<2>); // Set the problem property SET_TYPE_PROP(ChannelNCTestProblem, Problem, Dumux::ChannelNCTestProblem<TypeTag> ); -SET_BOOL_PROP(ChannelNCTestProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(ChannelNCTestProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(ChannelNCTestProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(ChannelNCTestProblem, EnableGlobalVolumeVariablesCache, true); @@ -311,7 +311,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) { diff --git a/test/freeflow/staggerednc/densityflowproblem.hh b/test/freeflow/staggerednc/densityflowproblem.hh index 8143c2891a..fb43203f87 100644 --- a/test/freeflow/staggerednc/densityflowproblem.hh +++ b/test/freeflow/staggerednc/densityflowproblem.hh @@ -69,7 +69,7 @@ SET_TYPE_PROP(DensityDrivenFlowProblem, Grid, Dune::YaspGrid<2>); // Set the problem property SET_TYPE_PROP(DensityDrivenFlowProblem, Problem, Dumux::DensityDrivenFlowProblem<TypeTag> ); -SET_BOOL_PROP(DensityDrivenFlowProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(DensityDrivenFlowProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(DensityDrivenFlowProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(DensityDrivenFlowProblem, EnableGlobalVolumeVariablesCache, true); @@ -277,7 +277,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) { diff --git a/test/mixeddimension/embedded/1p2c_richards2c/richardstestproblem.hh b/test/mixeddimension/embedded/1p2c_richards2c/richardstestproblem.hh index b8787e408d..4700f97326 100644 --- a/test/mixeddimension/embedded/1p2c_richards2c/richardstestproblem.hh +++ b/test/mixeddimension/embedded/1p2c_richards2c/richardstestproblem.hh @@ -53,7 +53,7 @@ NEW_TYPE_TAG(RichardsTestCCProblem, INHERITS_FROM(CCTpfaModel, RichardsTestProbl //SET_TYPE_PROP(RichardsTestProblem, Grid, Dune::YaspGrid<3, Dune::EquidistantOffsetCoordinates<double, 3> >); SET_TYPE_PROP(RichardsTestProblem, Grid, Dune::UGGrid<3>); -SET_BOOL_PROP(RichardsTestProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(RichardsTestProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(RichardsTestProblem, EnableGlobalVolumeVariablesCache, true); SET_BOOL_PROP(RichardsTestProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(RichardsTestProblem, SolutionDependentAdvection, false); @@ -266,7 +266,7 @@ public: { for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->model().curGlobalVolVars()); diff --git a/test/mixeddimension/embedded/1p2c_richards2c/rootsystemtestproblem.hh b/test/mixeddimension/embedded/1p2c_richards2c/rootsystemtestproblem.hh index 40ee2464d6..576aac0893 100644 --- a/test/mixeddimension/embedded/1p2c_richards2c/rootsystemtestproblem.hh +++ b/test/mixeddimension/embedded/1p2c_richards2c/rootsystemtestproblem.hh @@ -60,7 +60,7 @@ SET_PROP(RootsystemTestProblem, FluidSystem) // Set the grid type SET_TYPE_PROP(RootsystemTestProblem, Grid, Dune::FoamGrid<1, 3>); -SET_BOOL_PROP(RootsystemTestProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(RootsystemTestProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(RootsystemTestProblem, EnableGlobalVolumeVariablesCache, true); SET_BOOL_PROP(RootsystemTestProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(RootsystemTestProblem, SolutionDependentAdvection, false); @@ -348,7 +348,7 @@ public: { for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->model().curGlobalVolVars()); diff --git a/test/mixeddimension/embedded/1p2c_richards2c/rositestproblem.hh b/test/mixeddimension/embedded/1p2c_richards2c/rositestproblem.hh index 8859c6b927..602eed2c22 100644 --- a/test/mixeddimension/embedded/1p2c_richards2c/rositestproblem.hh +++ b/test/mixeddimension/embedded/1p2c_richards2c/rositestproblem.hh @@ -126,7 +126,7 @@ public: // low dim elements for (const auto& element : elements(this->lowDimProblem().gridView())) { - auto fvGeometry = localView(this->lowDimProblem().model().globalFvGeometry()); + auto fvGeometry = localView(this->lowDimProblem().model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->lowDimProblem().model().curGlobalVolVars()); @@ -143,7 +143,7 @@ public: // bulk elements for (const auto& element : elements(this->bulkProblem().gridView())) { - auto fvGeometry = localView(this->bulkProblem().model().globalFvGeometry()); + auto fvGeometry = localView(this->bulkProblem().model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->bulkProblem().model().curGlobalVolVars()); @@ -172,7 +172,7 @@ public: // low dim elements for (const auto& element : elements(this->lowDimProblem().gridView())) { - auto fvGeometry = localView(this->lowDimProblem().model().globalFvGeometry()); + auto fvGeometry = localView(this->lowDimProblem().model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->lowDimProblem().model().curGlobalVolVars()); @@ -197,7 +197,7 @@ public: // bulk elements for (const auto& element : elements(this->bulkProblem().gridView())) { - auto fvGeometry = localView(this->bulkProblem().model().globalFvGeometry()); + auto fvGeometry = localView(this->bulkProblem().model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->bulkProblem().model().curGlobalVolVars()); diff --git a/test/mixeddimension/embedded/1p_1p/bloodflowproblem.hh b/test/mixeddimension/embedded/1p_1p/bloodflowproblem.hh index 4dc05791b0..94008c3329 100644 --- a/test/mixeddimension/embedded/1p_1p/bloodflowproblem.hh +++ b/test/mixeddimension/embedded/1p_1p/bloodflowproblem.hh @@ -133,7 +133,7 @@ public: exactPressure_.resize(this->model().numDofs()); for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) @@ -304,7 +304,7 @@ public: { for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->model().curGlobalVolVars()); diff --git a/test/mixeddimension/embedded/1p_1p/tissueproblem.hh b/test/mixeddimension/embedded/1p_1p/tissueproblem.hh index f663847a9f..184ff676e6 100644 --- a/test/mixeddimension/embedded/1p_1p/tissueproblem.hh +++ b/test/mixeddimension/embedded/1p_1p/tissueproblem.hh @@ -53,7 +53,7 @@ NEW_TYPE_TAG(TissueCCProblem, INHERITS_FROM(CCTpfaModel, TissueProblem)); // Set the grid type SET_TYPE_PROP(TissueProblem, Grid, Dune::YaspGrid<3, Dune::EquidistantOffsetCoordinates<typename GET_PROP_TYPE(TypeTag, Scalar), 3> >); -SET_BOOL_PROP(TissueProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(TissueProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(TissueProblem, EnableGlobalVolumeVariablesCache, true); SET_BOOL_PROP(TissueProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(TissueProblem, SolutionDependentAdvection, false); @@ -142,7 +142,7 @@ public: exactPressure_.resize(this->model().numDofs()); for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) @@ -308,7 +308,7 @@ public: { for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->model().curGlobalVolVars()); diff --git a/test/mixeddimension/embedded/1p_richards/richardstestproblem.hh b/test/mixeddimension/embedded/1p_richards/richardstestproblem.hh index d8a1b4d5b7..cf87613d12 100644 --- a/test/mixeddimension/embedded/1p_richards/richardstestproblem.hh +++ b/test/mixeddimension/embedded/1p_richards/richardstestproblem.hh @@ -62,7 +62,7 @@ SET_TYPE_PROP(RichardsTestProblem, Grid, Dune::YaspGrid<3, Dune::EquidistantOffs //SET_TYPE_PROP(RichardsTestProblem, Grid, Dune::UGGrid<3>); //SET_TYPE_PROP(RichardsTestProblem, Grid, Dune::ALUGrid<3, 3, Dune::cube, Dune::conforming>); -SET_BOOL_PROP(RichardsTestProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(RichardsTestProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(RichardsTestProblem, EnableGlobalVolumeVariablesCache, true); SET_BOOL_PROP(RichardsTestProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(RichardsTestProblem, SolutionDependentAdvection, false); @@ -244,7 +244,7 @@ public: { for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->model().curGlobalVolVars()); diff --git a/test/mixeddimension/embedded/1p_richards/rootsystemtestproblem.hh b/test/mixeddimension/embedded/1p_richards/rootsystemtestproblem.hh index 5ed1fb5293..1ccde43f9b 100644 --- a/test/mixeddimension/embedded/1p_richards/rootsystemtestproblem.hh +++ b/test/mixeddimension/embedded/1p_richards/rootsystemtestproblem.hh @@ -59,7 +59,7 @@ public: // Set the grid type SET_TYPE_PROP(RootsystemTestProblem, Grid, Dune::FoamGrid<1, 3>); -SET_BOOL_PROP(RootsystemTestProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(RootsystemTestProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(RootsystemTestProblem, EnableGlobalVolumeVariablesCache, true); SET_BOOL_PROP(RootsystemTestProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(RootsystemTestProblem, SolutionDependentAdvection, false); @@ -317,7 +317,7 @@ public: { for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->model().curGlobalVolVars()); diff --git a/test/porousmediumflow/1p/implicit/1pniconductionproblem.hh b/test/porousmediumflow/1p/implicit/1pniconductionproblem.hh index 70959c2c83..3198893b99 100644 --- a/test/porousmediumflow/1p/implicit/1pniconductionproblem.hh +++ b/test/porousmediumflow/1p/implicit/1pniconductionproblem.hh @@ -160,7 +160,7 @@ public: const auto someElemSol = this->model().elementSolution(someElement, this->model().curSol()); const auto someInitSol = initial_(someElement.geometry().center()); - auto someFvGeometry = localView(this->model().globalFvGeometry()); + auto someFvGeometry = localView(this->model().fvGridGeometry()); someFvGeometry.bindElement(someElement); const auto someScv = *(scvs(someFvGeometry).begin()); @@ -180,7 +180,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) diff --git a/test/porousmediumflow/1p/implicit/1pniconvectionproblem.hh b/test/porousmediumflow/1p/implicit/1pniconvectionproblem.hh index f05548162f..ffdefa6481 100644 --- a/test/porousmediumflow/1p/implicit/1pniconvectionproblem.hh +++ b/test/porousmediumflow/1p/implicit/1pniconvectionproblem.hh @@ -172,7 +172,7 @@ public: const auto someElement = *(elements(this->gridView()).begin()); const auto someElemSol = this->model().elementSolution(someElement, this->model().curSol()); - auto someFvGeometry = localView(this->model().globalFvGeometry()); + auto someFvGeometry = localView(this->model().fvGridGeometry()); someFvGeometry.bindElement(someElement); const auto someScv = *(scvs(someFvGeometry).begin()); @@ -195,7 +195,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) { diff --git a/test/porousmediumflow/1p/implicit/fractureproblem.hh b/test/porousmediumflow/1p/implicit/fractureproblem.hh index e28acf4c48..62b0db658b 100644 --- a/test/porousmediumflow/1p/implicit/fractureproblem.hh +++ b/test/porousmediumflow/1p/implicit/fractureproblem.hh @@ -49,7 +49,7 @@ NEW_TYPE_TAG(FractureBoxProblem, INHERITS_FROM(BoxModel, FractureProblem)); NEW_TYPE_TAG(FractureCCProblem, INHERITS_FROM(CCTpfaModel, FractureProblem)); NEW_TYPE_TAG(FractureCCMpfaProblem, INHERITS_FROM(CCMpfaModel, FractureProblem)); -SET_BOOL_PROP(FractureCCProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(FractureCCProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(FractureCCProblem, EnableGlobalVolumeVariablesCache, true); SET_BOOL_PROP(FractureCCProblem, EnableGlobalFluxVariablesCache, true); diff --git a/test/porousmediumflow/1p2c/implicit/1p2cniconductionproblem.hh b/test/porousmediumflow/1p2c/implicit/1p2cniconductionproblem.hh index eff5938a79..75b8f67a3a 100644 --- a/test/porousmediumflow/1p2c/implicit/1p2cniconductionproblem.hh +++ b/test/porousmediumflow/1p2c/implicit/1p2cniconductionproblem.hh @@ -176,7 +176,7 @@ public: const auto someElemSol = this->model().elementSolution(someElement, this->model().curSol()); const auto someInitSol = initial_(someElement.geometry().center()); - auto someFvGeometry = localView(this->model().globalFvGeometry()); + auto someFvGeometry = localView(this->model().fvGridGeometry()); someFvGeometry.bindElement(someElement); const auto someScv = *(scvs(someFvGeometry).begin()); @@ -196,7 +196,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) diff --git a/test/porousmediumflow/1p2c/implicit/1p2cniconvectionproblem.hh b/test/porousmediumflow/1p2c/implicit/1p2cniconvectionproblem.hh index bbd4777fe1..929e80f89d 100644 --- a/test/porousmediumflow/1p2c/implicit/1p2cniconvectionproblem.hh +++ b/test/porousmediumflow/1p2c/implicit/1p2cniconvectionproblem.hh @@ -184,7 +184,7 @@ public: const auto someElement = *(elements(this->gridView()).begin()); const auto someElemSol = this->model().elementSolution(someElement, this->model().curSol()); - auto someFvGeometry = localView(this->model().globalFvGeometry()); + auto someFvGeometry = localView(this->model().fvGridGeometry()); someFvGeometry.bindElement(someElement); const auto someScv = *(scvs(someFvGeometry).begin()); @@ -207,7 +207,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) { diff --git a/test/porousmediumflow/2p/implicit/cc2pcornerpointproblem.hh b/test/porousmediumflow/2p/implicit/cc2pcornerpointproblem.hh index ebe07fc92f..87315d80a3 100644 --- a/test/porousmediumflow/2p/implicit/cc2pcornerpointproblem.hh +++ b/test/porousmediumflow/2p/implicit/cc2pcornerpointproblem.hh @@ -305,7 +305,7 @@ public: for (const auto& element : elements(this->gridView())) { int eIdx = this->elementMapper().index(element); - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) diff --git a/test/porousmediumflow/2p/implicit/fractureproblem.hh b/test/porousmediumflow/2p/implicit/fractureproblem.hh index f60b6bea32..d3de2f357a 100644 --- a/test/porousmediumflow/2p/implicit/fractureproblem.hh +++ b/test/porousmediumflow/2p/implicit/fractureproblem.hh @@ -48,7 +48,7 @@ NEW_TYPE_TAG(FractureBoxProblem, INHERITS_FROM(BoxModel, FractureProblem)); NEW_TYPE_TAG(FractureCCProblem, INHERITS_FROM(CCTpfaModel, FractureProblem)); NEW_TYPE_TAG(FractureCCMpfaProblem, INHERITS_FROM(CCMpfaModel, FractureProblem)); -SET_BOOL_PROP(FractureProblem, EnableGlobalFVGeometryCache, true); +SET_BOOL_PROP(FractureProblem, EnableFVGridGeometryCache, true); SET_BOOL_PROP(FractureProblem, EnableGlobalVolumeVariablesCache, true); SET_BOOL_PROP(FractureProblem, EnableGlobalFluxVariablesCache, true); SET_BOOL_PROP(FractureProblem, SolutionDependentAdvection, false); diff --git a/test/porousmediumflow/2p/implicit/lensproblem.hh b/test/porousmediumflow/2p/implicit/lensproblem.hh index babb81109d..4897635d0d 100644 --- a/test/porousmediumflow/2p/implicit/lensproblem.hh +++ b/test/porousmediumflow/2p/implicit/lensproblem.hh @@ -427,7 +427,7 @@ private: for (const auto& element : elements(this->gridView(), Dune::Partitions::interior)) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->model().curGlobalVolVars()); diff --git a/test/porousmediumflow/2pnc/implicit/fuelcellproblem.hh b/test/porousmediumflow/2pnc/implicit/fuelcellproblem.hh index cc4fad9e8b..18d6aaacee 100644 --- a/test/porousmediumflow/2pnc/implicit/fuelcellproblem.hh +++ b/test/porousmediumflow/2pnc/implicit/fuelcellproblem.hh @@ -268,7 +268,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->model().curGlobalVolVars()); diff --git a/test/porousmediumflow/3p/implicit/3pniconductionproblem.hh b/test/porousmediumflow/3p/implicit/3pniconductionproblem.hh index 77c9eb68ea..2ebb373e23 100644 --- a/test/porousmediumflow/3p/implicit/3pniconductionproblem.hh +++ b/test/porousmediumflow/3p/implicit/3pniconductionproblem.hh @@ -175,7 +175,7 @@ public: const auto someElemSol = this->model().elementSolution(someElement, this->model().curSol()); const auto someInitSol = initialAtPos(someElement.geometry().center()); - auto someFvGeometry = localView(this->model().globalFvGeometry()); + auto someFvGeometry = localView(this->model().fvGridGeometry()); someFvGeometry.bindElement(someElement); const auto someScv = *(scvs(someFvGeometry).begin()); @@ -195,7 +195,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) diff --git a/test/porousmediumflow/3p/implicit/3pniconvectionproblem.hh b/test/porousmediumflow/3p/implicit/3pniconvectionproblem.hh index 8ad9231143..a88a062336 100644 --- a/test/porousmediumflow/3p/implicit/3pniconvectionproblem.hh +++ b/test/porousmediumflow/3p/implicit/3pniconvectionproblem.hh @@ -185,7 +185,7 @@ public: const auto someElemSol = this->model().elementSolution(someElement, this->model().curSol()); const auto someInitSol = initialAtPos(someElement.geometry().center()); - auto someFvGeometry = localView(this->model().globalFvGeometry()); + auto someFvGeometry = localView(this->model().fvGridGeometry()); someFvGeometry.bindElement(someElement); const auto someScv = *(scvs(someFvGeometry).begin()); @@ -208,7 +208,7 @@ public: for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); for (auto&& scv : scvs(fvGeometry)) { diff --git a/test/porousmediumflow/richardsnc/implicit/richardswelltracerproblem.hh b/test/porousmediumflow/richardsnc/implicit/richardswelltracerproblem.hh index 38f3cc2bcb..5252fc5fe2 100644 --- a/test/porousmediumflow/richardsnc/implicit/richardswelltracerproblem.hh +++ b/test/porousmediumflow/richardsnc/implicit/richardswelltracerproblem.hh @@ -147,7 +147,7 @@ public: // bulk elements for (const auto& element : elements(this->gridView())) { - auto fvGeometry = localView(this->model().globalFvGeometry()); + auto fvGeometry = localView(this->model().fvGridGeometry()); fvGeometry.bindElement(element); auto elemVolVars = localView(this->model().curGlobalVolVars()); -- GitLab