From acfc83d90a289711682853795aa16db02301bf03 Mon Sep 17 00:00:00 2001
From: Kilian Weishaupt <kilian.weishaupt@iws.uni-stuttgart.de>
Date: Mon, 4 Dec 2017 15:52:14 +0100
Subject: [PATCH] [properties][freeflow] Fix properties for all free-flow
 models

* include dumux/common/properties.hh
* do not inherit from NumericModel and LinearSolverTypeTag anymore
---
 dumux/freeflow/properties.hh                   | 1 +
 dumux/freeflow/staggered/boundarytypes.hh      | 1 +
 dumux/freeflow/staggered/fluxvariables.hh      | 2 +-
 dumux/freeflow/staggered/fluxvariablescache.hh | 2 +-
 dumux/freeflow/staggered/indices.hh            | 2 ++
 dumux/freeflow/staggered/localresidual.hh      | 1 +
 dumux/freeflow/staggered/problem.hh            | 4 ++--
 dumux/freeflow/staggered/properties.hh         | 5 ++---
 dumux/freeflow/staggered/velocityoutput.hh     | 2 +-
 dumux/freeflow/staggered/volumevariables.hh    | 2 ++
 dumux/freeflow/staggerednc/localresidual.hh    | 2 +-
 dumux/freeflow/staggerednc/properties.hh       | 5 +----
 dumux/freeflow/staggerednc/volumevariables.hh  | 1 +
 dumux/freeflow/staggeredni/fluxvariables.hh    | 2 +-
 dumux/freeflow/staggeredni/localresidual.hh    | 2 +-
 dumux/freeflow/staggeredni/properties.hh       | 1 +
 16 files changed, 20 insertions(+), 15 deletions(-)

diff --git a/dumux/freeflow/properties.hh b/dumux/freeflow/properties.hh
index 4dac51a72d..e73a4e28d8 100644
--- a/dumux/freeflow/properties.hh
+++ b/dumux/freeflow/properties.hh
@@ -26,6 +26,7 @@
 #ifndef DUMUX_FREE_FLOW_PROPERTIES_HH
 #define DUMUX_FREE_FLOW_PROPERTIES_HH
 
+#include <dumux/common/properties.hh>
 #include <dumux/common/properties/basic.hh>
 #include <dumux/discretization/staggered/freeflow/facevariables.hh>
 #include <dumux/implicit/staggered/primaryvariables.hh>
diff --git a/dumux/freeflow/staggered/boundarytypes.hh b/dumux/freeflow/staggered/boundarytypes.hh
index 88b0de7d10..b2336f2bbb 100644
--- a/dumux/freeflow/staggered/boundarytypes.hh
+++ b/dumux/freeflow/staggered/boundarytypes.hh
@@ -23,6 +23,7 @@
 #ifndef STAGGERED_FREEFLOW_BOUNDARY_TYPES_HH
 #define STAGGERED_FREEFLOW_BOUNDARY_TYPES_HH
 
+#include <dumux/common/properties.hh>
 #include <dumux/common/boundarytypes.hh>
 
 namespace Dumux
diff --git a/dumux/freeflow/staggered/fluxvariables.hh b/dumux/freeflow/staggered/fluxvariables.hh
index a85555cdc4..3f239c5e07 100644
--- a/dumux/freeflow/staggered/fluxvariables.hh
+++ b/dumux/freeflow/staggered/fluxvariables.hh
@@ -23,7 +23,7 @@
 #ifndef DUMUX_FREELOW_IMPLICIT_FLUXVARIABLES_HH
 #define DUMUX_FREELOW_IMPLICIT_FLUXVARIABLES_HH
 
-#include <dumux/common/basicproperties.hh>
+#include <dumux/common/properties.hh>
 #include <dumux/discretization/fluxvariablesbase.hh>
 
 namespace Dumux
diff --git a/dumux/freeflow/staggered/fluxvariablescache.hh b/dumux/freeflow/staggered/fluxvariablescache.hh
index 10a568425b..f57119f4ab 100644
--- a/dumux/freeflow/staggered/fluxvariablescache.hh
+++ b/dumux/freeflow/staggered/fluxvariablescache.hh
@@ -23,8 +23,8 @@
 #ifndef DUMUX_FREEFLOW_IMPLICIT_FLUXVARIABLESCACHE_HH
 #define DUMUX_FREEFLOW_IMPLICIT_FLUXVARIABLESCACHE_HH
 
-#include <dumux/common/basicproperties.hh>
 #include <dune/localfunctions/lagrange/pqkfactory.hh>
+#include <dumux/common/properties.hh>
 #include <dumux/discretization/methods.hh>
 
 namespace Dumux
diff --git a/dumux/freeflow/staggered/indices.hh b/dumux/freeflow/staggered/indices.hh
index 704590dac4..39fec61a10 100644
--- a/dumux/freeflow/staggered/indices.hh
+++ b/dumux/freeflow/staggered/indices.hh
@@ -23,6 +23,8 @@
 #ifndef DUMUX_NAVIERSTOKES_COMMON_INDICES_HH
 #define DUMUX_NAVIERSTOKES_COMMON_INDICES_HH
 
+#include <dumux/common/properties.hh>
+
 namespace Dumux
 {
 // \{
diff --git a/dumux/freeflow/staggered/localresidual.hh b/dumux/freeflow/staggered/localresidual.hh
index 62933ed306..a586b85ba8 100644
--- a/dumux/freeflow/staggered/localresidual.hh
+++ b/dumux/freeflow/staggered/localresidual.hh
@@ -23,6 +23,7 @@
 #ifndef DUMUX_STAGGERED_NAVIERSTOKES_LOCAL_RESIDUAL_HH
 #define DUMUX_STAGGERED_NAVIERSTOKES_LOCAL_RESIDUAL_HH
 
+#include <dumux/common/properties.hh>
 
 namespace Dumux
 {
diff --git a/dumux/freeflow/staggered/problem.hh b/dumux/freeflow/staggered/problem.hh
index 8f57dbdd36..910f052f69 100644
--- a/dumux/freeflow/staggered/problem.hh
+++ b/dumux/freeflow/staggered/problem.hh
@@ -23,9 +23,9 @@
 #ifndef DUMUX_NAVIERSTOKES_PROBLEM_HH
 #define DUMUX_NAVIERSTOKES_PROBLEM_HH
 
-#include <dumux/common/basicproperties.hh>
-#include "properties.hh"
+#include <dumux/common/properties.hh>
 #include <dumux/common/staggeredfvproblem.hh>
+#include "properties.hh"
 
 namespace Dumux
 {
diff --git a/dumux/freeflow/staggered/properties.hh b/dumux/freeflow/staggered/properties.hh
index 992345c10d..336ddcac10 100644
--- a/dumux/freeflow/staggered/properties.hh
+++ b/dumux/freeflow/staggered/properties.hh
@@ -27,8 +27,6 @@
 #ifndef DUMUX_NAVIERSTOKES_PROPERTIES_HH
 #define DUMUX_NAVIERSTOKES_PROPERTIES_HH
 
-#include <dumux/common/basicproperties.hh>
-#include <dumux/linear/linearsolverproperties.hh>
 #include <dumux/freeflow/properties.hh>
 
 #include <dumux/implicit/staggered/localresidual.hh>
@@ -48,6 +46,7 @@
 #include <dumux/material/components/nullcomponent.hh>
 #include <dumux/material/fluidsystems/1p.hh>
 
+#include <dumux/common/properties.hh>
 
 namespace Dumux
 {
@@ -62,7 +61,7 @@ namespace Properties {
 //////////////////////////////////////////////////////////////////
 
 //! The type tags for the implicit single-phase problems
-NEW_TYPE_TAG(NavierStokes, INHERITS_FROM(LinearSolverTypeTag, NumericModel, FreeFlow));
+NEW_TYPE_TAG(NavierStokes, INHERITS_FROM(FreeFlow));
 
 //! The type tags for the corresponding non-isothermal problems
 NEW_TYPE_TAG(NavierStokesNI, INHERITS_FROM(NavierStokes, NavierStokesNonIsothermal));
diff --git a/dumux/freeflow/staggered/velocityoutput.hh b/dumux/freeflow/staggered/velocityoutput.hh
index 5270d2753b..1394934d21 100644
--- a/dumux/freeflow/staggered/velocityoutput.hh
+++ b/dumux/freeflow/staggered/velocityoutput.hh
@@ -28,7 +28,7 @@
 #include <dune/istl/bvector.hh>
 #include <dune/geometry/referenceelements.hh>
 
-#include <dumux/common/basicproperties.hh>
+#include <dumux/common/properties.hh>
 #include <dumux/discretization/methods.hh>
 
 namespace Dumux
diff --git a/dumux/freeflow/staggered/volumevariables.hh b/dumux/freeflow/staggered/volumevariables.hh
index 244e7a918f..34457a97e2 100644
--- a/dumux/freeflow/staggered/volumevariables.hh
+++ b/dumux/freeflow/staggered/volumevariables.hh
@@ -24,6 +24,8 @@
 #ifndef DUMUX_NAVIERSTOKES_VOLUME_VARIABLES_HH
 #define DUMUX_NAVIERSTOKES_VOLUME_VARIABLES_HH
 
+#include <dumux/common/properties.hh>
+
 #include "properties.hh"
 #include <dumux/discretization/volumevariables.hh>
 
diff --git a/dumux/freeflow/staggerednc/localresidual.hh b/dumux/freeflow/staggerednc/localresidual.hh
index 6edb9805f3..c426ed8aee 100644
--- a/dumux/freeflow/staggerednc/localresidual.hh
+++ b/dumux/freeflow/staggerednc/localresidual.hh
@@ -23,7 +23,7 @@
 #ifndef DUMUX_STAGGERED_NAVIERSTOKES_NC_LOCAL_RESIDUAL_HH
 #define DUMUX_STAGGERED_NAVIERSTOKES_NC_LOCAL_RESIDUAL_HH
 
-
+#include <dumux/common/properties.hh>
 #include <dumux/common/valgrind.hh>
 #include <dumux/implicit/staggered/localresidual.hh>
 
diff --git a/dumux/freeflow/staggerednc/properties.hh b/dumux/freeflow/staggerednc/properties.hh
index ef483a6cb6..e3cf94efcb 100644
--- a/dumux/freeflow/staggerednc/properties.hh
+++ b/dumux/freeflow/staggerednc/properties.hh
@@ -27,9 +27,6 @@
 #ifndef DUMUX_NAVIERSTOKES_NC_PROPERTIES_HH
 #define DUMUX_NAVIERSTOKES_NC_PROPERTIES_HH
 
-#include <dumux/common/basicproperties.hh>
-#include <dumux/linear/linearsolverproperties.hh>
-
 #include <dumux/freeflow/staggered/properties.hh>
 #include <dumux/freeflow/staggeredni/properties.hh>
 #include <dumux/discretization/fickslaw.hh>
@@ -59,7 +56,7 @@ namespace Properties {
 //////////////////////////////////////////////////////////////////
 
 //! The type tags for the implicit single-phase problems
-NEW_TYPE_TAG(NavierStokesNC, INHERITS_FROM(NavierStokes, NumericModel, LinearSolverTypeTag));
+NEW_TYPE_TAG(NavierStokesNC, INHERITS_FROM(NavierStokes));
 NEW_TYPE_TAG(NavierStokesNCNI, INHERITS_FROM(NavierStokesNC, NavierStokesNonIsothermal));
 
 ///////////////////////////////////////////////////////////////////////////
diff --git a/dumux/freeflow/staggerednc/volumevariables.hh b/dumux/freeflow/staggerednc/volumevariables.hh
index 02bcf0567a..463bad3ab2 100644
--- a/dumux/freeflow/staggerednc/volumevariables.hh
+++ b/dumux/freeflow/staggerednc/volumevariables.hh
@@ -24,6 +24,7 @@
 #ifndef DUMUX_NAVIER_STOKES_NC_VOLUMEVARIABLES_HH
 #define DUMUX_NAVIER_STOKES_NC_VOLUMEVARIABLES_HH
 
+#include <dumux/common/properties.hh>
 #include "properties.hh"
 
 #include "../staggered/volumevariables.hh"
diff --git a/dumux/freeflow/staggeredni/fluxvariables.hh b/dumux/freeflow/staggeredni/fluxvariables.hh
index 028f371296..6e5f77a33b 100644
--- a/dumux/freeflow/staggeredni/fluxvariables.hh
+++ b/dumux/freeflow/staggeredni/fluxvariables.hh
@@ -23,7 +23,7 @@
 #ifndef DUMUX_FREELOW_IMPLICIT_NI_FLUXVARIABLES_HH
 #define DUMUX_FREELOW_IMPLICIT_NI_FLUXVARIABLES_HH
 
-#include <dumux/common/basicproperties.hh>
+#include <dumux/common/properties.hh>
 
 namespace Dumux
 {
diff --git a/dumux/freeflow/staggeredni/localresidual.hh b/dumux/freeflow/staggeredni/localresidual.hh
index b6517c21ac..a067af3921 100644
--- a/dumux/freeflow/staggeredni/localresidual.hh
+++ b/dumux/freeflow/staggeredni/localresidual.hh
@@ -25,7 +25,7 @@
 #ifndef DUMUX_FREE_FLOW_ENERGY_LOCAL_RESIDUAL_HH
 #define DUMUX_FREE_FLOW_ENERGY_LOCAL_RESIDUAL_HH
 
-// #include <dumux/implicit/properties.hh>
+#include <dumux/common/properties.hh>
 
 namespace Dumux
 {
diff --git a/dumux/freeflow/staggeredni/properties.hh b/dumux/freeflow/staggeredni/properties.hh
index 8aab152173..f7752d75e7 100644
--- a/dumux/freeflow/staggeredni/properties.hh
+++ b/dumux/freeflow/staggeredni/properties.hh
@@ -27,6 +27,7 @@
 #ifndef DUMUX_NAVIER_STOKES_NI_PROPERTIES_HH
 #define DUMUX_NAVIER_STOKES_NI_PROPERTIES_HH
 
+#include <dumux/common/properties.hh>
 #include "fluxvariables.hh"
 #include "indices.hh"
 #include "localresidual.hh"
-- 
GitLab