From afedd010d517785a7e0e401d48e532560e891112 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dennis=20Gl=C3=A4ser?= <dennis.glaeser@iws.uni-stuttgart.de> Date: Tue, 31 May 2022 11:21:31 +0000 Subject: [PATCH] [gitlab][mr_template] do not use markdown links in comment --- .gitlab/merge_request_templates/default.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/merge_request_templates/default.md b/.gitlab/merge_request_templates/default.md index b05469b639..9957552066 100644 --- a/.gitlab/merge_request_templates/default.md +++ b/.gitlab/merge_request_templates/default.md @@ -35,6 +35,6 @@ The following aspects might also come up during review: * Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits * Does the change improve the performance? (if yes, add this aspect to the MR description) -* Is the code is a gross violation of programming best practices such as [DRY (don't repeat yourself / code duplication)](https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself), [the SOLID principles](https://en.wikipedia.org/wiki/SOLID), or the [C++ Core Guidelines](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)? +* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)? * Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions) --> -- GitLab