diff --git a/dumux/freeflow/navierstokes/staggered/fluxvariables.hh b/dumux/freeflow/navierstokes/staggered/fluxvariables.hh index 180170856fcffeb49c8e3ffcca55ff7f9052c9f1..8500c684ea15f90a082fcc1fa260bdf485be61b9 100644 --- a/dumux/freeflow/navierstokes/staggered/fluxvariables.hh +++ b/dumux/freeflow/navierstokes/staggered/fluxvariables.hh @@ -331,7 +331,7 @@ public: // It is not clear how to evaluate the BJ condition here. // For symmetry reasons, our own scvf should then have the same Neumann flux as the lateral face. // TODO: We should clarify if this is the correct approach. - if (currentScvfBoundaryTypes->isBJS(Indices::velocity(lateralScvf.directionIndex())) && lateralFaceBoundaryTypes && + if (currentScvfBoundaryTypes->isBeaversJoseph(Indices::velocity(lateralScvf.directionIndex())) && lateralFaceBoundaryTypes && lateralFaceBoundaryTypes->isNeumann(Indices::velocity(scvf.directionIndex()))) { const auto& lateralStaggeredFaceCenter = lateralStaggeredFaceCenter_(scvf, localSubFaceIdx); @@ -375,7 +375,7 @@ public: std::bitset<3> admittableBcTypes; admittableBcTypes.set(0, lateralFaceBoundaryTypes->isDirichlet(Indices::pressureIdx)); admittableBcTypes.set(1, lateralFaceBoundaryTypes->isDirichlet(Indices::velocity(scvf.directionIndex()))); - admittableBcTypes.set(2, lateralFaceBoundaryTypes->isBJS(Indices::velocity(scvf.directionIndex()))); + admittableBcTypes.set(2, lateralFaceBoundaryTypes->isBeaversJoseph(Indices::velocity(scvf.directionIndex()))); if (admittableBcTypes.count() != 1) { DUNE_THROW(Dune::InvalidStateException, "Invalid boundary conditions for lateral scvf " @@ -502,7 +502,7 @@ private: const auto& lateralBoundaryFacePos = lateralStaggeredFaceCenter_(scvf, localSubFaceIdx); return problem.dirichlet(element, scvf.makeBoundaryFace(lateralBoundaryFacePos))[Indices::velocity(lateralFace.directionIndex())]; } - else if (bcTypes.isBJS(Indices::velocity(lateralFace.directionIndex()))) + else if (bcTypes.isBeaversJoseph(Indices::velocity(lateralFace.directionIndex()))) { return VelocityGradients::beaversJosephVelocityAtCurrentScvf(problem, element, fvGeometry, scvf, faceVars, currentScvfBoundaryTypes, lateralFaceBoundaryTypes, localSubFaceIdx); @@ -573,7 +573,7 @@ private: { if (!scvf.boundary() || currentScvfBoundaryTypes->isDirichlet(Indices::velocity(lateralFace.directionIndex())) || - currentScvfBoundaryTypes->isBJS(Indices::velocity(lateralFace.directionIndex()))) + currentScvfBoundaryTypes->isBeaversJoseph(Indices::velocity(lateralFace.directionIndex()))) { const Scalar velocityGrad_ji = VelocityGradients::velocityGradJI(problem, element, fvGeometry, scvf, faceVars, currentScvfBoundaryTypes, lateralFaceBoundaryTypes, localSubFaceIdx); // Account for the orientation of the staggered normal face's outer normal vector. diff --git a/dumux/freeflow/navierstokes/staggered/staggeredupwindfluxvariables.hh b/dumux/freeflow/navierstokes/staggered/staggeredupwindfluxvariables.hh index 0566c7e6e567ba15418fa25836e862a05c5c44f8..fbdb57c2daf7cf0ee77055bdfcc505ca090acdca 100644 --- a/dumux/freeflow/navierstokes/staggered/staggeredupwindfluxvariables.hh +++ b/dumux/freeflow/navierstokes/staggered/staggeredupwindfluxvariables.hh @@ -582,7 +582,7 @@ private: // Find out what boundary type is set on the lateral face const bool useZeroGradient = lateralFaceBoundaryTypes && (lateralFaceBoundaryTypes->isSymmetry() || lateralFaceBoundaryTypes->isDirichlet(Indices::pressureIdx)); - const bool lateralFaceHasBJS = lateralFaceBoundaryTypes && lateralFaceBoundaryTypes->isBJS(Indices::velocity(scvf.directionIndex())); + const bool lateralFaceHasBJS = lateralFaceBoundaryTypes && lateralFaceBoundaryTypes->isBeaversJoseph(Indices::velocity(scvf.directionIndex())); const bool lateralFaceHasDirichletVelocity = lateralFaceBoundaryTypes && lateralFaceBoundaryTypes->isDirichlet(Indices::velocity(scvf.directionIndex())); const Scalar velocitySelf = faceVars.velocitySelf(); diff --git a/dumux/freeflow/navierstokes/staggered/velocitygradients.hh b/dumux/freeflow/navierstokes/staggered/velocitygradients.hh index 6dd2bce86249df1b6fe13fae49dc807c9ae143b7..014a98b7e7b84b2608a87a818877813503991363 100644 --- a/dumux/freeflow/navierstokes/staggered/velocitygradients.hh +++ b/dumux/freeflow/navierstokes/staggered/velocitygradients.hh @@ -121,7 +121,7 @@ public: const auto& lateralBoundaryFacePos = lateralStaggeredFaceCenter_(scvf, localSubFaceIdx); return problem.dirichlet(element, lateralScvf.makeBoundaryFace(lateralBoundaryFacePos))[Indices::velocity(scvf.directionIndex())]; } - else if (lateralFaceBoundaryTypes->isBJS(Indices::velocity(scvf.directionIndex()))) + else if (lateralFaceBoundaryTypes->isBeaversJoseph(Indices::velocity(scvf.directionIndex()))) { return beaversJosephVelocityAtLateralScvf(problem, element, fvGeometry, scvf, faceVars, currentScvfBoundaryTypes, lateralFaceBoundaryTypes, localSubFaceIdx); @@ -200,7 +200,7 @@ public: const auto& lateralBoundaryFacePos = lateralStaggeredFaceCenter_(scvf, localSubFaceIdx); return problem.dirichlet(element, scvf.makeBoundaryFace(lateralBoundaryFacePos))[Indices::velocity(lateralScvf.directionIndex())]; } - else if (currentScvfBoundaryTypes->isBJS(Indices::velocity(lateralScvf.directionIndex()))) + else if (currentScvfBoundaryTypes->isBeaversJoseph(Indices::velocity(lateralScvf.directionIndex()))) { return beaversJosephVelocityAtCurrentScvf(problem, element, fvGeometry, scvf, faceVars, currentScvfBoundaryTypes, lateralFaceBoundaryTypes, localSubFaceIdx); @@ -265,7 +265,7 @@ public: if (lateralScvf.boundary()) { if (lateralFaceBoundaryTypes->isDirichlet(Indices::pressureIdx) || - lateralFaceBoundaryTypes->isBJS(Indices::velocity(scvf.directionIndex()))) + lateralFaceBoundaryTypes->isBeaversJoseph(Indices::velocity(scvf.directionIndex()))) return 0.0; } @@ -325,7 +325,7 @@ public: if (scvf.boundary()) { if (currentScvfBoundaryTypes->isDirichlet(Indices::pressureIdx) || - currentScvfBoundaryTypes->isBJS(Indices::velocity(lateralScvf.directionIndex()))) + currentScvfBoundaryTypes->isBeaversJoseph(Indices::velocity(lateralScvf.directionIndex()))) return 0.0; } diff --git a/dumux/freeflow/rans/problem.hh b/dumux/freeflow/rans/problem.hh index 5218848fc4ad9b0cefdffcd9796dd8c0a316837e..1b5721d002b88025d55ba53f71f97a1be25684d4 100644 --- a/dumux/freeflow/rans/problem.hh +++ b/dumux/freeflow/rans/problem.hh @@ -337,14 +337,14 @@ public: // adapt calculations for Beavers-Joseph-Saffman condition unsigned int normalNormDim = lateralFace.directionIndex(); - if (lateralFace.boundary() && (asImp_().boundaryTypes(element, lateralFace).isBJS(Indices::velocity(velIdx)))) + if (lateralFace.boundary() && (asImp_().boundaryTypes(element, lateralFace).isBeaversJoseph(Indices::velocity(velIdx)))) { unsigned int neighborIdx = neighborIdx_[elementIdx][normalNormDim][0]; if (lateralFace.center()[normalNormDim] < cellCenter_[elementIdx][normalNormDim]) neighborIdx = neighborIdx_[elementIdx][normalNormDim][1]; const SubControlVolume& scv = fvGeometry.scv(scvf.insideScvIdx()); - bjsVelocityAverage[normalNormDim] += ParentType::beaversJosephVelocity(element, scv, lateralFace, velocity_[elementIdx][velIdx], 0.0); + bjsVelocityAverage[normalNormDim] += ParentType::beaversJosephVelocity(element, scv, scvf, lateralFace, velocity_[elementIdx][velIdx], 0.0); if (bjsNumFaces[normalNormDim] > 0 && neighborIdx != bjsNeighbor[normalNormDim]) DUNE_THROW(Dune::InvalidStateException, "Two different neighborIdx should not occur"); bjsNeighbor[normalNormDim] = neighborIdx;