From d0a16247bfaeea624b3040094fd30a7deb295ca6 Mon Sep 17 00:00:00 2001
From: Ned Coltman <edward.coltman@iws.uni-stuttgart.de>
Date: Wed, 2 Mar 2022 23:14:14 +0100
Subject: [PATCH] [dispersion] rename tensortype to model
---
CHANGELOG.md | 9 ++----
dumux/common/deprecated.hh | 4 +--
dumux/common/properties.hh | 4 +--
dumux/flux/box/dispersionflux.hh | 11 +++----
dumux/flux/cctpfa/dispersionflux.hh | 12 ++++----
dumux/porenetwork/1pnc/model.hh | 16 +++++-----
dumux/porousmediumflow/1pnc/model.hh | 30 +++++++++----------
.../porousmediumflow/1pnc/volumevariables.hh | 2 +-
dumux/porousmediumflow/1pncmin/model.hh | 20 ++++++-------
dumux/porousmediumflow/fluxvariables.hh | 4 +--
dumux/porousmediumflow/nonisothermal/model.hh | 4 +--
dumux/porousmediumflow/properties.hh | 6 ++--
dumux/porousmediumflow/tracer/model.hh | 8 ++---
.../tracer/volumevariables.hh | 2 +-
.../1pnc/dispersion/properties.hh | 2 +-
15 files changed, 66 insertions(+), 68 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 995fdd707b..8b727bebfb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -69,15 +69,12 @@ template<class TypeTag>
struct EnableThermalDispersion<TypeTag, TTag::MyTest> { static constexpr bool value = true; };
```
-To determine the type of dispersion tensor, please define the property `DispersionTensorType` within your `properties.hh` header. For example:
+To determine the type of dispersion tensor, please define the property `CompositionalDispersionModel` within your `properties.hh` header. Per default, the `ThermalDispersionModel` is set to the same model as the `CompositionalDispersionModel`, but this can be set specifically as well. For example:
```cpp
template<class TypeTag>
-struct DispersionTensorType<TypeTag, TTag::MyTest> { using type = ScheideggersDispersionTensor<TypeTag>; };
-```
-or
-```cpp
+struct CompositionalDispersionModel<TypeTag, TTag::MyTest> { using type = ScheideggersDispersionTensor<TypeTag>; };
template<class TypeTag>
-struct DispersionTensorType<TypeTag, TTag::MyTest> { using type = FullDispersionTensor<TypeTag>; };
+struct ThermalDispersionModel<TypeTag, TTag::MyTest> { using type = FullDispersionTensor<TypeTag>; };
```
The parameters describing your dispersion tensor can then be included in your `spatialparameters.hh` file, and passed via input parameters. An example of this can be seen in the `test/porousmediumflow/1pnc/dispersion/` folder, and in the `test/porousmediumflow/tracer/constvel/` folders.
diff --git a/dumux/common/deprecated.hh b/dumux/common/deprecated.hh
index 6fa7e99347..dd896bb57c 100644
--- a/dumux/common/deprecated.hh
+++ b/dumux/common/deprecated.hh
@@ -73,8 +73,8 @@ static constexpr bool hasEnableThermalDispersion()
{ return Dune::Std::is_detected<HasEnableThermalDispersionDetector, ModelTraits>::value; }
template<class ModelTraits>
-static constexpr bool hasThermalDispersionTensorType()
-{ return !std::is_same<typename ModelTraits::ThermalDispersionTensorType, int>::value; }
+static constexpr bool hasThermalDispersionModel()
+{ return !std::is_same<typename ModelTraits::ThermalDispersionModel, int>::value; }
template<class SpatialParams, class Element, class Scv, class ElemSol>
using HasNewTemperatureDetector = decltype(std::declval<SpatialParams>().temperature(
diff --git a/dumux/common/properties.hh b/dumux/common/properties.hh
index 40c76a98e9..2a7d1fdbb0 100644
--- a/dumux/common/properties.hh
+++ b/dumux/common/properties.hh
@@ -150,9 +150,9 @@ struct SolutionDependentMolecularDiffusion { using type = UndefinedProperty; };
template<class TypeTag, class MyTypeTag>
struct HeatConductionType { using type = UndefinedProperty; }; //!< The type for the calculation of the heat conduction fluxes
template<class TypeTag, class MyTypeTag>
-struct CompositionalDispersionTensorType { using type = UndefinedProperty; }; //!< The type for the calculation of the compositional dispersion tensor
+struct CompositionalDispersionModel { using type = UndefinedProperty; }; //!< The type for the calculation of the compositional dispersion tensor
template<class TypeTag, class MyTypeTag>
-struct ThermalDispersionTensorType { using type = UndefinedProperty; }; //!< The type for the calculation of the thermal dispersion tensor
+struct ThermalDispersionModel { using type = UndefinedProperty; }; //!< The type for the calculation of the thermal dispersion tensor
template<class TypeTag, class MyTypeTag>
struct SolutionDependentHeatConduction { using type = UndefinedProperty; }; //!< specifies if the parameters for the heat conduction fluxes depend on the solution
diff --git a/dumux/flux/box/dispersionflux.hh b/dumux/flux/box/dispersionflux.hh
index cd9a185888..37cfa1ee68 100644
--- a/dumux/flux/box/dispersionflux.hh
+++ b/dumux/flux/box/dispersionflux.hh
@@ -118,8 +118,9 @@ public:
{
// collect the dispersion tensor, the fluxVarsCache and the shape values
const auto& dispersionTensor =
- VolumeVariables::CompositionalDispersionTensorType::compositionalDispersionTensor(problem, scvf, fvGeometry,
- elemVolVars, elemFluxVarsCache, phaseIdx, compIdx);
+ VolumeVariables::CompositionalDispersionModel::compositionalDispersionTensor(problem, scvf, fvGeometry,
+ elemVolVars, elemFluxVarsCache,
+ phaseIdx, compIdx);
// the mole/mass fraction gradient
Dune::FieldVector<Scalar, dimWorld> gradX(0.0);
@@ -151,9 +152,9 @@ public:
{
// collect the dispersion tensor
const auto& dispersionTensor =
- ModelTraits::ThermalDispersionTensorType::thermalDispersionTensor(problem, scvf, fvGeometry,
- elemVolVars, elemFluxVarsCache,
- phaseIdx);
+ ModelTraits::ThermalDispersionModel::thermalDispersionTensor(problem, scvf, fvGeometry,
+ elemVolVars, elemFluxVarsCache,
+ phaseIdx);
// compute the temperature gradient with the shape functions
const auto& fluxVarsCache = elemFluxVarsCache[scvf];
Dune::FieldVector<Scalar, GridView::dimensionworld> gradTemp(0.0);
diff --git a/dumux/flux/cctpfa/dispersionflux.hh b/dumux/flux/cctpfa/dispersionflux.hh
index 446394728b..dde3eb414f 100644
--- a/dumux/flux/cctpfa/dispersionflux.hh
+++ b/dumux/flux/cctpfa/dispersionflux.hh
@@ -118,9 +118,9 @@ public:
for (int compIdx = 0; compIdx < numComponents; compIdx++)
{
const auto& dispersionTensor =
- VolumeVariables::CompositionalDispersionTensorType::compositionalDispersionTensor(problem, scvf, fvGeometry,
- elemVolVars, elemFluxVarsCache,
- phaseIdx, compIdx);
+ VolumeVariables::CompositionalDispersionModel::compositionalDispersionTensor(problem, scvf, fvGeometry,
+ elemVolVars, elemFluxVarsCache,
+ phaseIdx, compIdx);
const auto dij = computeTpfaTransmissibility(scvf, fvGeometry.scv(scvf.insideScvIdx()), dispersionTensor, insideVolVars.extrusionFactor());
const auto xInside = massOrMoleFraction(insideVolVars, referenceSystem, phaseIdx, compIdx);
@@ -152,9 +152,9 @@ public:
const auto& outsideVolVars = elemVolVars[scvf.outsideScvIdx()];
const auto& dispersionTensor =
- ModelTraits::ThermalDispersionTensorType::thermalDispersionTensor(problem, scvf, fvGeometry,
- elemVolVars, elemFluxVarsCache,
- phaseIdx);
+ ModelTraits::ThermalDispersionModel::thermalDispersionTensor(problem, scvf, fvGeometry,
+ elemVolVars, elemFluxVarsCache,
+ phaseIdx);
const auto dij = computeTpfaTransmissibility(scvf, fvGeometry.scv(scvf.insideScvIdx()), dispersionTensor, insideVolVars.extrusionFactor());
// get the inside/outside temperatures
diff --git a/dumux/porenetwork/1pnc/model.hh b/dumux/porenetwork/1pnc/model.hh
index ea5b2db2af..c42fb3bdb7 100644
--- a/dumux/porenetwork/1pnc/model.hh
+++ b/dumux/porenetwork/1pnc/model.hh
@@ -158,19 +158,19 @@ private:
static_assert(FST::numPhases == MT::numFluidPhases(), "Number of phases mismatch between model and fluid state");
using BaseTraits = OnePVolumeVariablesTraits<PV, FSY, FST, SSY, SST, PT, MT>;
- using CDTT = GetPropType<TypeTag, Properties::CompositionalDispersionTensorType>;
+ using CDM = GetPropType<TypeTag, Properties::CompositionalDispersionModel>;
using DT = GetPropType<TypeTag, Properties::MolecularDiffusionType>;
using EDM = GetPropType<TypeTag, Properties::EffectiveDiffusivityModel>;
- template<class BaseTraits, class CDTT, class DT, class EDM>
+ template<class BaseTraits, class CDM, class DT, class EDM>
struct NCTraits : public BaseTraits
{
- using CompositionalDispersionTensorType = CDTT;
+ using CompositionalDispersionModel = CDM;
using DiffusionType = DT;
using EffectiveDiffusivityModel = EDM;
};
public:
- using type = PoreNetwork::OnePNCVolumeVariables<NCTraits<BaseTraits, CDTT, DT, EDM>>;
+ using type = PoreNetwork::OnePNCVolumeVariables<NCTraits<BaseTraits, CDM, DT, EDM>>;
};
//!< Set the vtk output fields specific to this model
@@ -216,21 +216,21 @@ private:
static_assert(FST::numPhases == MT::numFluidPhases(), "Number of phases mismatch between model and fluid state");
using BaseTraits = OnePVolumeVariablesTraits<PV, FSY, FST, SSY, SST, PT, MT>;
- using CDTT = GetPropType<TypeTag, Properties::CompositionalDispersionTensorType>;
+ using CDM = GetPropType<TypeTag, Properties::CompositionalDispersionModel>;
using DT = GetPropType<TypeTag, Properties::MolecularDiffusionType>;
using EDM = GetPropType<TypeTag, Properties::EffectiveDiffusivityModel>;
using ETCM = GetPropType< TypeTag, Properties:: ThermalConductivityModel>;
- template<class BaseTraits, class CDTT, class TDTT, class DT, class EDM, class ETCM>
+ template<class BaseTraits, class CDM, class DT, class EDM, class ETCM>
struct NCNITraits : public BaseTraits
{
- using CompositionalDispersionTensorType = CDTT;
+ using CompositionalDispersionModel = CDM;
using DiffusionType = DT;
using EffectiveDiffusivityModel = EDM;
using EffectiveThermalConductivityModel = ETCM;
};
public:
- using type = PoreNetwork::OnePNCVolumeVariables<NCNITraits<BaseTraits, CDTT, TDTT, DT, EDM, ETCM>>;
+ using type = PoreNetwork::OnePNCVolumeVariables<NCNITraits<BaseTraits, CDM, DT, EDM, ETCM>>;
};
template<class TypeTag>
diff --git a/dumux/porousmediumflow/1pnc/model.hh b/dumux/porousmediumflow/1pnc/model.hh
index 003b8814a1..56620d4e3b 100644
--- a/dumux/porousmediumflow/1pnc/model.hh
+++ b/dumux/porousmediumflow/1pnc/model.hh
@@ -190,19 +190,19 @@ private:
static_assert(FST::numPhases == MT::numFluidPhases(), "Number of phases mismatch between model and fluid state");
using BaseTraits = OnePVolumeVariablesTraits<PV, FSY, FST, SSY, SST, PT, MT>;
- using CDTT = GetPropType<TypeTag, Properties::CompositionalDispersionTensorType>;
+ using CDM = GetPropType<TypeTag, Properties::CompositionalDispersionModel>;
using DT = GetPropType<TypeTag, Properties::MolecularDiffusionType>;
using EDM = GetPropType<TypeTag, Properties::EffectiveDiffusivityModel>;
- template<class BaseTraits, class CDTT, class DT, class EDM>
+ template<class BaseTraits, class CDM, class DT, class EDM>
struct NCTraits : public BaseTraits
{
- using CompositionalDispersionTensorType = CDTT;
+ using CompositionalDispersionModel = CDM;
using DiffusionType = DT;
using EffectiveDiffusivityModel = EDM;
};
public:
- using type = OnePNCVolumeVariables<NCTraits<BaseTraits, CDTT, DT, EDM>>;
+ using type = OnePNCVolumeVariables<NCTraits<BaseTraits, CDM, DT, EDM>>;
};
//! Set the vtk output fields specific to this model
@@ -228,9 +228,9 @@ struct ModelTraits<TypeTag, TTag::OnePNCNI>
{
private:
using IsothermalTraits = GetPropType<TypeTag, Properties::BaseModelTraits>;
- using TDTT = GetPropType<TypeTag, Properties::ThermalDispersionTensorType>;
+ using TDM = GetPropType<TypeTag, Properties::ThermalDispersionModel>;
public:
- using type = PorousMediumFlowNIModelTraits<IsothermalTraits, TDTT>;
+ using type = PorousMediumFlowNIModelTraits<IsothermalTraits, TDM>;
};
template<class TypeTag>
@@ -250,21 +250,21 @@ private:
static_assert(FST::numPhases == MT::numFluidPhases(), "Number of phases mismatch between model and fluid state");
using BaseTraits = OnePVolumeVariablesTraits<PV, FSY, FST, SSY, SST, PT, MT>;
- using CDTT = GetPropType<TypeTag, Properties::CompositionalDispersionTensorType>;
+ using CDM = GetPropType<TypeTag, Properties::CompositionalDispersionModel>;
using DT = GetPropType<TypeTag, Properties::MolecularDiffusionType>;
using EDM = GetPropType<TypeTag, Properties::EffectiveDiffusivityModel>;
using ETCM = GetPropType< TypeTag, Properties:: ThermalConductivityModel>;
- template<class BaseTraits, class CDTT, class DT, class EDM, class ETCM>
+ template<class BaseTraits, class CDM, class DT, class EDM, class ETCM>
struct NCNITraits : public BaseTraits
{
- using CompositionalDispersionTensorType = CDTT;
+ using CompositionalDispersionModel = CDM;
using DiffusionType = DT;
using EffectiveDiffusivityModel = EDM;
using EffectiveThermalConductivityModel = ETCM;
};
public:
- using type = OnePNCVolumeVariables<NCNITraits<BaseTraits, CDTT, DT, EDM, ETCM>>;
+ using type = OnePNCVolumeVariables<NCNITraits<BaseTraits, CDM, DT, EDM, ETCM>>;
};
} // end namespace Properties
@@ -355,22 +355,22 @@ private:
using PT = typename GetPropType<TypeTag, Properties::SpatialParams>::PermeabilityType;
using BaseTraits = OnePVolumeVariablesTraits<PV, FSY, FST, SSY, SST, PT, MT>;
- using CDTT = GetPropType<TypeTag, Properties::CompositionalDispersionTensorType>;
+ using CDM = GetPropType<TypeTag, Properties::CompositionalDispersionModel>;
using DT = GetPropType<TypeTag, Properties::MolecularDiffusionType>;
using EDM = GetPropType<TypeTag, Properties::EffectiveDiffusivityModel>;
using ETCM = GetPropType< TypeTag, Properties:: ThermalConductivityModel>;
- template<class BaseTraits, class CDTT, class DT, class EDM, class ETCM>
+ template<class BaseTraits, class CDM, class DT, class EDM, class ETCM>
struct NCNITraits : public BaseTraits
{
- using CompositionalDispersionTensorType = CDTT;
+ using CompositionalDispersionModel = CDM;
using DiffusionType = DT;
using EffectiveDiffusivityModel = EDM;
using EffectiveThermalConductivityModel = ETCM;
};
- using EquilibriumVolVars = OnePNCVolumeVariables<NCNITraits<BaseTraits, CDTT, DT, EDM, ETCM>>;
+ using EquilibriumVolVars = OnePNCVolumeVariables<NCNITraits<BaseTraits, CDM, DT, EDM, ETCM>>;
public:
- using type = NonEquilibriumVolumeVariables<NCNITraits<BaseTraits, CDTT, DT, EDM, ETCM>, EquilibriumVolVars>;
+ using type = NonEquilibriumVolumeVariables<NCNITraits<BaseTraits, CDM, DT, EDM, ETCM>, EquilibriumVolVars>;
};
} // end namespace Properties
diff --git a/dumux/porousmediumflow/1pnc/volumevariables.hh b/dumux/porousmediumflow/1pnc/volumevariables.hh
index 61c6ccf863..380fcccebf 100644
--- a/dumux/porousmediumflow/1pnc/volumevariables.hh
+++ b/dumux/porousmediumflow/1pnc/volumevariables.hh
@@ -65,7 +65,7 @@ class OnePNCVolumeVariables
public:
//! Export the compositional dispersion tensor law
- using CompositionalDispersionTensorType = typename Traits::CompositionalDispersionTensorType;
+ using CompositionalDispersionModel = typename Traits::CompositionalDispersionModel;
//! Export fluid state type
using FluidState = typename Traits::FluidState;
//! Export fluid system type
diff --git a/dumux/porousmediumflow/1pncmin/model.hh b/dumux/porousmediumflow/1pncmin/model.hh
index 9560a531b6..0db57078fc 100644
--- a/dumux/porousmediumflow/1pncmin/model.hh
+++ b/dumux/porousmediumflow/1pncmin/model.hh
@@ -115,20 +115,20 @@ private:
static_assert(FST::numPhases == MT::numFluidPhases(), "Number of phases mismatch between model and fluid state");
using BaseTraits = OnePVolumeVariablesTraits<PV, FSY, FST, SSY, SST, PT, MT>;
- using CDTT = GetPropType<TypeTag, Properties::CompositionalDispersionTensorType>;
+ using CDM = GetPropType<TypeTag, Properties::CompositionalDispersionModel>;
using DT = GetPropType<TypeTag, Properties::MolecularDiffusionType>;
using EDM = GetPropType<TypeTag, Properties::EffectiveDiffusivityModel>;
- template<class BaseTraits, class CDTT, class DT, class EDM>
+ template<class BaseTraits, class CDM, class DT, class EDM>
struct NCTraits : public BaseTraits
{
- using CompositionalDispersionTensorType = CDTT;
+ using CompositionalDispersionModel = CDM;
using DiffusionType = DT;
using EffectiveDiffusivityModel = EDM;
};
- using NonMinVolVars = OnePNCVolumeVariables<NCTraits<BaseTraits, CDTT, DT, EDM>>;
+ using NonMinVolVars = OnePNCVolumeVariables<NCTraits<BaseTraits, CDM, DT, EDM>>;
public:
- using type = MineralizationVolumeVariables<NCTraits<BaseTraits, CDTT, DT, EDM>, NonMinVolVars>;
+ using type = MineralizationVolumeVariables<NCTraits<BaseTraits, CDM, DT, EDM>, NonMinVolVars>;
};
// Use the mineralization local residual
@@ -203,21 +203,21 @@ private:
static_assert(FST::numPhases == MT::numFluidPhases(), "Number of phases mismatch between model and fluid state");
using BaseTraits = OnePVolumeVariablesTraits<PV, FSY, FST, SSY, SST, PT, MT>;
- using CDTT = GetPropType<TypeTag, Properties::CompositionalDispersionTensorType>;
+ using CDM = GetPropType<TypeTag, Properties::CompositionalDispersionModel>;
using DT = GetPropType<TypeTag, Properties::MolecularDiffusionType>;
using EDM = GetPropType<TypeTag, Properties::EffectiveDiffusivityModel>;
using ETCM = GetPropType< TypeTag, Properties:: ThermalConductivityModel>;
- template<class BaseTraits, class CDTT, class TDTT, class DT, class EDM, class ETCM>
+ template<class BaseTraits, class CDM, class DT, class EDM, class ETCM>
struct NCNITraits : public BaseTraits
{
- using CompositionalDispersionTensorType = CDTT;
+ using CompositionalDispersionModel = CDM;
using DiffusionType = DT;
using EffectiveDiffusivityModel = EDM;
using EffectiveThermalConductivityModel = ETCM;
};
- using NonMinVolVars = OnePNCVolumeVariables<NCNITraits<BaseTraits, CDTT, TDTT, DT, EDM, ETCM>>;
+ using NonMinVolVars = OnePNCVolumeVariables<NCNITraits<BaseTraits, CDM, DT, EDM, ETCM>>;
public:
- using type = MineralizationVolumeVariables<NCNITraits<BaseTraits, CDTT, TDTT, DT, EDM, ETCM>, NonMinVolVars>;
+ using type = MineralizationVolumeVariables<NCNITraits<BaseTraits, CDM, DT, EDM, ETCM>, NonMinVolVars>;
};
//! Use the average for effective conductivities
template<class TypeTag>
diff --git a/dumux/porousmediumflow/fluxvariables.hh b/dumux/porousmediumflow/fluxvariables.hh
index 7145211aa6..9760a25fe7 100644
--- a/dumux/porousmediumflow/fluxvariables.hh
+++ b/dumux/porousmediumflow/fluxvariables.hh
@@ -152,7 +152,7 @@ public:
if constexpr (enableThermalDispersion)
{
// TODO: Here?
- if constexpr (Deprecated::hasThermalDispersionTensorType<ModelTraits>())
+ if constexpr (Deprecated::hasThermalDispersionModel<ModelTraits>())
{
return DispersionFluxType::thermalDispersionFlux(this->problem(),
this->element(),
@@ -163,7 +163,7 @@ public:
this->elemFluxVarsCache());
}
else
- DUNE_THROW(Dune::InvalidStateException, "Please pass the ThermalDispersionTensorType to the model traits");
+ DUNE_THROW(Dune::InvalidStateException, "Please pass the ThermalDispersionModel to the model traits");
}
else
return Dune::FieldVector<Scalar, 1>(0.0);
diff --git a/dumux/porousmediumflow/nonisothermal/model.hh b/dumux/porousmediumflow/nonisothermal/model.hh
index 0f7ec5f301..177b5b40a3 100644
--- a/dumux/porousmediumflow/nonisothermal/model.hh
+++ b/dumux/porousmediumflow/nonisothermal/model.hh
@@ -65,14 +65,14 @@ namespace Dumux {
*
* \tparam IsothermalTraits Model traits of the isothermal model
*/
-template<class IsothermalT, class TDTT = int>
+template<class IsothermalT, class TDM = int>
struct PorousMediumFlowNIModelTraits : public IsothermalT
{
//! Export the isothermal model traits
using IsothermalTraits = IsothermalT;
//! Export the thermal dispersion tensor type
- using ThermalDispersionTensorType = TDTT;
+ using ThermalDispersionModel = TDM;
//! We solve for one more equation, i.e. the energy balance
static constexpr int numEq() { return IsothermalTraits::numEq()+1; }
diff --git a/dumux/porousmediumflow/properties.hh b/dumux/porousmediumflow/properties.hh
index ae6cbe75b8..c362bc318f 100644
--- a/dumux/porousmediumflow/properties.hh
+++ b/dumux/porousmediumflow/properties.hh
@@ -89,12 +89,12 @@ struct DispersionFluxType<TypeTag, TTag::PorousMediumFlow> { using type = Diffus
//! By default, we use Scheideggers's law for the dispersive tensor calculation
template<class TypeTag>
-struct CompositionalDispersionTensorType<TypeTag, TTag::PorousMediumFlow> { using type = ScheideggersDispersionTensor<TypeTag>; };
+struct CompositionalDispersionModel<TypeTag, TTag::PorousMediumFlow> { using type = ScheideggersDispersionTensor<TypeTag>; };
//! By default, we use the same dispersion tensor type as the componsitonal dispersion for the thermal disperion tensor
template<class TypeTag>
-struct ThermalDispersionTensorType<TypeTag, TTag::PorousMediumFlow>
-{ using type = GetPropType<TypeTag, Properties::CompositionalDispersionTensorType>; };
+struct ThermalDispersionModel<TypeTag, TTag::PorousMediumFlow>
+{ using type = GetPropType<TypeTag, Properties::CompositionalDispersionModel>; };
//! By default, we use fourier's law as the default for heat conduction fluxes
template<class TypeTag>
diff --git a/dumux/porousmediumflow/tracer/model.hh b/dumux/porousmediumflow/tracer/model.hh
index 4498b0a00f..871e121aba 100644
--- a/dumux/porousmediumflow/tracer/model.hh
+++ b/dumux/porousmediumflow/tracer/model.hh
@@ -94,7 +94,7 @@ struct TracerModelTraits
* \tparam FSY The fluid system type
* \tparam MT The model traits
*/
-template<class PV, class FSY, class SSY, class SST, class MT, class CDTT, class DT, class EDM>
+template<class PV, class FSY, class SSY, class SST, class MT, class CDM, class DT, class EDM>
struct TracerVolumeVariablesTraits
{
using PrimaryVariables = PV;
@@ -102,7 +102,7 @@ struct TracerVolumeVariablesTraits
using SolidSystem = SSY;
using SolidState = SST;
using ModelTraits = MT;
- using CompositionalDispersionTensorType = CDTT;
+ using CompositionalDispersionModel = CDM;
using DiffusionType = DT;
using EffectiveDiffusivityModel = EDM;
};
@@ -158,11 +158,11 @@ private:
using SSY = GetPropType<TypeTag, Properties::SolidSystem>;
using SST = GetPropType<TypeTag, Properties::SolidState>;
using MT = GetPropType<TypeTag, Properties::ModelTraits>;
- using CDTT = GetPropType<TypeTag, Properties::CompositionalDispersionTensorType>;
+ using CDM = GetPropType<TypeTag, Properties::CompositionalDispersionModel>;
using DT = GetPropType<TypeTag, Properties::MolecularDiffusionType>;
using EDM = GetPropType<TypeTag, Properties::EffectiveDiffusivityModel>;
- using Traits = TracerVolumeVariablesTraits<PV, FSY, SSY, SST, MT, CDTT, DT, EDM>;
+ using Traits = TracerVolumeVariablesTraits<PV, FSY, SSY, SST, MT, CDM, DT, EDM>;
public:
using type = TracerVolumeVariables<Traits>;
};
diff --git a/dumux/porousmediumflow/tracer/volumevariables.hh b/dumux/porousmediumflow/tracer/volumevariables.hh
index ab42fc92ec..4b8baf143b 100644
--- a/dumux/porousmediumflow/tracer/volumevariables.hh
+++ b/dumux/porousmediumflow/tracer/volumevariables.hh
@@ -64,7 +64,7 @@ class TracerVolumeVariables
public:
//! Export the dispersion tensor law
- using CompositionalDispersionTensorType = typename Traits::CompositionalDispersionTensorType;
+ using CompositionalDispersionModel = typename Traits::CompositionalDispersionModel;
//! Export the fluid system type
using FluidSystem = typename Traits::FluidSystem;
//! Export the solid state type
diff --git a/test/porousmediumflow/1pnc/dispersion/properties.hh b/test/porousmediumflow/1pnc/dispersion/properties.hh
index 837a96a8ca..bf8c75367a 100644
--- a/test/porousmediumflow/1pnc/dispersion/properties.hh
+++ b/test/porousmediumflow/1pnc/dispersion/properties.hh
@@ -103,7 +103,7 @@ template<class TypeTag>
struct EnableThermalDispersion<TypeTag, TTag::DispersionTest> { static constexpr bool value = NONISOTHERMAL; };
template<class TypeTag>
-struct CompositionalDispersionTensorType<TypeTag, TTag::DispersionTest>
+struct CompositionalDispersionModel<TypeTag, TTag::DispersionTest>
{
#if SCHEIDEGGER
using type = ScheideggersDispersionTensor<TypeTag>;
--
GitLab