From d153effab598275e35d1b7ee70f66f466ac503ee Mon Sep 17 00:00:00 2001
From: Timo Koch <timokoch@math.uio.no>
Date: Sun, 23 Jun 2024 18:53:12 +0000
Subject: [PATCH] [facet][box] Simplify code removing uninitialized variable
---
.../facet/box/fvelementgeometry.hh | 32 +++++++++----------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/dumux/multidomain/facet/box/fvelementgeometry.hh b/dumux/multidomain/facet/box/fvelementgeometry.hh
index 17d8bf724e..7a26d8029d 100644
--- a/dumux/multidomain/facet/box/fvelementgeometry.hh
+++ b/dumux/multidomain/facet/box/fvelementgeometry.hh
@@ -174,18 +174,19 @@ public:
assert(isBound());
using ScvfGeometry = typename SubControlVolumeFace::Traits::Geometry;
const GeometryHelper geometryHelper(element().geometry());
- typename SubControlVolumeFace::Traits::CornerStorage corners;
if (scvf.boundary() || scvf.interiorBoundary())
- {
- corners = geometryHelper.getBoundaryScvfCorners(scvf.facetIndexInElement(),
- scvf.indexInElementFacet());
- return { Dune::GeometryTypes::cube(ScvfGeometry::mydimension), corners };
- }
- else
- {
- corners = geometryHelper.getScvfCorners(scvf.index());
- return { Dune::GeometryTypes::cube(ScvfGeometry::mydimension), corners };
- }
+ return {
+ Dune::GeometryTypes::cube(ScvfGeometry::mydimension),
+ geometryHelper.getBoundaryScvfCorners(
+ scvf.facetIndexInElement(),
+ scvf.indexInElementFacet()
+ )
+ };
+
+ return {
+ Dune::GeometryTypes::cube(ScvfGeometry::mydimension),
+ geometryHelper.getScvfCorners(scvf.index())
+ };
}
private:
@@ -345,11 +346,10 @@ public:
)
};
- else
- return {
- Dune::GeometryTypes::cube(ScvfGeometry::mydimension),
- geometryHelper.getScvfCorners(scvf.index())
- };
+ return {
+ Dune::GeometryTypes::cube(ScvfGeometry::mydimension),
+ geometryHelper.getScvfCorners(scvf.index())
+ };
}
private:
--
GitLab