From d7a133f7f69c5ea7c556385e5bbba70573315c83 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20Gr=C3=BCninger?= <foss@grueninger.de>
Date: Fri, 22 Jun 2018 06:46:21 +0200
Subject: [PATCH] Exceptions should be caught by reference.

---
 dumux/material/constraintsolvers/compositionfromfugacities.hh   | 2 +-
 dumux/material/constraintsolvers/ncpflash.hh                    | 2 +-
 test/discretization/box/test_boxfvgeometry.cc                   | 2 +-
 test/discretization/cellcentered/tpfa/test_tpfafvgeometry.cc    | 2 +-
 .../staggered/test_staggered_free_flow_geometry.cc              | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/dumux/material/constraintsolvers/compositionfromfugacities.hh b/dumux/material/constraintsolvers/compositionfromfugacities.hh
index 8c0119eb39..ec59caddda 100644
--- a/dumux/material/constraintsolvers/compositionfromfugacities.hh
+++ b/dumux/material/constraintsolvers/compositionfromfugacities.hh
@@ -140,7 +140,7 @@ public:
             // Solve J*x = b
             x = 0;
             try { J.solve(x, b); }
-            catch (Dune::FMatrixError e)
+            catch (Dune::FMatrixError &e)
             { throw NumericalProblem(e.what()); }
 
             //std::cout << "original delta: " << x << "\n";
diff --git a/dumux/material/constraintsolvers/ncpflash.hh b/dumux/material/constraintsolvers/ncpflash.hh
index 17a19b8bd4..567d2380c1 100644
--- a/dumux/material/constraintsolvers/ncpflash.hh
+++ b/dumux/material/constraintsolvers/ncpflash.hh
@@ -196,7 +196,7 @@ public:
             deltaX = 0;
 
             try { J.solve(deltaX, b); }
-            catch (Dune::FMatrixError e)
+            catch (Dune::FMatrixError &e)
             {
                 /*
                 printFluidState_(fluidState);
diff --git a/test/discretization/box/test_boxfvgeometry.cc b/test/discretization/box/test_boxfvgeometry.cc
index 3f04b22cf1..227191bc55 100644
--- a/test/discretization/box/test_boxfvgeometry.cc
+++ b/test/discretization/box/test_boxfvgeometry.cc
@@ -109,7 +109,7 @@ int main (int argc, char *argv[]) try
 // //////////////////////////////////
 //   Error handler
 // /////////////////////////////////
-catch (Dune::Exception e) {
+catch (Dune::Exception &e) {
 
     std::cout << e << std::endl;
     return 1;
diff --git a/test/discretization/cellcentered/tpfa/test_tpfafvgeometry.cc b/test/discretization/cellcentered/tpfa/test_tpfafvgeometry.cc
index 32679980bf..e7223e64bb 100644
--- a/test/discretization/cellcentered/tpfa/test_tpfafvgeometry.cc
+++ b/test/discretization/cellcentered/tpfa/test_tpfafvgeometry.cc
@@ -110,7 +110,7 @@ int main (int argc, char *argv[]) try
 // //////////////////////////////////
 //   Error handler
 // /////////////////////////////////
-catch (Dune::Exception e) {
+catch (Dune::Exception &e) {
 
     std::cout << e << std::endl;
     return 1;
diff --git a/test/discretization/staggered/test_staggered_free_flow_geometry.cc b/test/discretization/staggered/test_staggered_free_flow_geometry.cc
index a315111787..2634a94720 100644
--- a/test/discretization/staggered/test_staggered_free_flow_geometry.cc
+++ b/test/discretization/staggered/test_staggered_free_flow_geometry.cc
@@ -163,7 +163,7 @@ int main (int argc, char *argv[]) try
 // //////////////////////////////////
 //   Error handler
 // /////////////////////////////////
-catch (Dune::Exception e) {
+catch (Dune::Exception &e) {
 
     std::cout << e << std::endl;
     return 1;
-- 
GitLab