[test][ff][channel] Rename doNothing to unconstrained outflow

The condition leads to a velocity profile that spreads in all directions
at the outlet of a channel.

test/freeflow/navierstokes/channel/2d/CMakeLists.txt

@@ -36,16 +36,16 @@ dumux_add_test(NAME test_ff_stokes_channel_neumann_x_neumann_y
                          -Problem.Name test_ff_stokes_channel_nxny -Problem.OutletCondition NeumannX_NeumannY
                          -Problem.UseVelocityProfile true -Problem.OutletPressure 0 -Problem.IsStationary true")
 
-dumux_add_test(NAME test_ff_stokes_channel_do_nothing
+dumux_add_test(NAME test_ff_stokes_channel_unconstrained_outflow
               TARGET test_ff_channel
               LABELS freeflow navierstokes
               CMAKE_GUARD HAVE_UMFPACK
               COMMAND ${CMAKE_SOURCE_DIR}/bin/testing/runtest.py
               CMD_ARGS       --script fuzzy
-                             --files ${CMAKE_SOURCE_DIR}/test/references/test_ff_stokes_channel_do_nothing-reference.vtu
-                                     ${CMAKE_CURRENT_BINARY_DIR}/test_ff_stokes_channel_do_nothing-00002.vtu
-                             --command "${CMAKE_CURRENT_BINARY_DIR}/test_ff_channel params.input -Problem.OutletCondition DoNothing -Grid.UpperRight \"2 1\" -Grid.Cells \"50 25\"
-                         -Problem.Name test_ff_stokes_channel_do_nothing -Problem.OutletCondition DoNothing -Problem.UseVelocityProfile true -Problem.OutletPressure 0")
+                             --files ${CMAKE_SOURCE_DIR}/test/references/test_ff_stokes_channel_unconstrained_outflow-reference.vtu
+                                     ${CMAKE_CURRENT_BINARY_DIR}/test_ff_stokes_channel_unconstrained_outflow-00002.vtu
+                             --command "${CMAKE_CURRENT_BINARY_DIR}/test_ff_channel params.input -Problem.OutletCondition UnconstrainedOutflow -Grid.UpperRight \"2 1\" -Grid.Cells \"50 25\"
+                         -Problem.Name test_ff_stokes_channel_unconstrained_outflow -Problem.OutletCondition UnconstrainedOutflow -Problem.UseVelocityProfile true -Problem.OutletPressure 0")
 
 dumux_add_test(NAME test_ff_navierstokes_channel
               TARGET test_ff_channel

test/freeflow/navierstokes/channel/2d/problem.hh

@@ -73,7 +73,7 @@ class ChannelTestProblem : public NavierStokesProblem<TypeTag>
     // the types of outlet boundary conditions
     enum class OutletCondition
     {
-        outflow, doNothing, neumannXdirichletY, neumannXneumannY
+        outflow, unconstrainedOutflow, neumannXdirichletY, neumannXneumannY
     };
 
 public:
@@ -89,8 +89,8 @@ public:
         const auto outletBC = getParam<std::string>("Problem.OutletCondition", "Outflow");
         if (outletBC == "Outflow")
             outletCondition_ = OutletCondition::outflow;
-        else if (outletBC == "DoNothing")
-            outletCondition_ = OutletCondition::doNothing;
+        else if (outletBC == "UnconstrainedOutflow")
+            outletCondition_ = OutletCondition::unconstrainedOutflow;
         else if (outletBC == "NeumannX_DirichletY")
             outletCondition_ = OutletCondition::neumannXdirichletY;
         else if (outletBC == "NeumannX_NeumannY")
@@ -211,7 +211,7 @@ public:
         {
             using FluxHelper = NavierStokesMomentumBoundaryFluxHelper;
 
-            if (outletCondition_ == OutletCondition::doNothing)
+            if (outletCondition_ == OutletCondition::unconstrainedOutflow)
                 values = FluxHelper::fixedPressureMomentumFlux(*this, fvGeometry, scvf, elemVolVars, elemFluxVarsCache, outletPressure_, false /*zeroNormalVelocityGradient*/);
             else if (outletCondition_ == OutletCondition::outflow)
                 values = FluxHelper::fixedPressureMomentumFlux(*this, fvGeometry, scvf, elemVolVars, elemFluxVarsCache, outletPressure_, true /*zeroNormalVelocityGradient*/);