From e7f370caa93dbeeef67088d63b160265f77ee397 Mon Sep 17 00:00:00 2001
From: Ned Coltman <edward.coltman@iws.uni-stuttgart.de>
Date: Mon, 22 Nov 2021 10:12:19 +0100
Subject: [PATCH] [flux][dispersion][tpfa] Add dispersive fluxes for tpfa with
constant velocity fields
---
dumux/flux/cctpfa/dispersionflux.hh | 168 ++++++++++++++++++
dumux/flux/dispersionflux.hh | 1 +
.../dispersiontensors/scheidegger.hh | 2 +-
.../nonisothermal/localresidual.hh | 7 +-
.../porousmediumflow/tracer/localresidual.hh | 11 +-
5 files changed, 175 insertions(+), 14 deletions(-)
create mode 100644 dumux/flux/cctpfa/dispersionflux.hh
diff --git a/dumux/flux/cctpfa/dispersionflux.hh b/dumux/flux/cctpfa/dispersionflux.hh
new file mode 100644
index 0000000000..af2dad28aa
--- /dev/null
+++ b/dumux/flux/cctpfa/dispersionflux.hh
@@ -0,0 +1,168 @@
+// -*- mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*-
+// vi: set et ts=4 sw=4 sts=4:
+/*****************************************************************************
+ * See the file COPYING for full copying permissions. *
+ * *
+ * This program is free software: you can redistribute it and/or modify *
+ * it under the terms of the GNU General Public License as published by *
+ * the Free Software Foundation, either version 3 of the License, or *
+ * (at your option) any later version. *
+ * *
+ * This program is distributed in the hope that it will be useful, *
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
+ * GNU General Public License for more details. *
+ * *
+ * You should have received a copy of the GNU General Public License *
+ * along with this program. If not, see <http://www.gnu.org/licenses/>. *
+ *****************************************************************************/
+/*!
+ * \file
+ * \ingroup CCTpfaFlux
+ * \brief This file contains the data which is required to calculate
+ * dispersive fluxes.
+ */
+#ifndef DUMUX_DISCRETIZATION_CC_TPFA_DISPERSION_FLUX_HH
+#define DUMUX_DISCRETIZATION_CC_TPFA_DISPERSION_FLUX_HH
+
+#include <dune/common/fvector.hh>
+#include <dune/common/fmatrix.hh>
+
+#include <dumux/common/math.hh>
+#include <dumux/common/properties.hh>
+#include <dumux/discretization/method.hh>
+#include <dumux/discretization/extrusion.hh>
+#include <dumux/discretization/cellcentered/tpfa/computetransmissibility.hh>
+#include <dumux/flux/traits.hh>
+
+namespace Dumux {
+
+// forward declaration
+template<class TypeTag, class DiscretizationMethod, ReferenceSystemFormulation referenceSystem>
+class OnePDispersionFluxImplementation;
+
+/*!
+ * \ingroup CCTpfaFlux
+ * \brief Specialization of a Dispersion flux for the cctpfa method
+ */
+template <class TypeTag, ReferenceSystemFormulation referenceSystem>
+class OnePDispersionFluxImplementation<TypeTag, DiscretizationMethods::CCTpfa, referenceSystem>
+{
+ using Scalar = GetPropType<TypeTag, Properties::Scalar>;
+ using Problem = GetPropType<TypeTag, Properties::Problem>;
+ using FluidSystem = GetPropType<TypeTag, Properties::FluidSystem>;
+ using VolumeVariables = GetPropType<TypeTag, Properties::VolumeVariables>;
+ using GridGeometry = GetPropType<TypeTag, Properties::GridGeometry>;
+ using FVElementGeometry = typename GridGeometry::LocalView;
+ using SubControlVolume = typename GridGeometry::SubControlVolume;
+ using SubControlVolumeFace = typename GridGeometry::SubControlVolumeFace;
+ using Extrusion = Extrusion_t<GridGeometry>;
+ using ElementVolumeVariables = typename GetPropType<TypeTag, Properties::GridVolumeVariables>::LocalView;
+ using ElementFluxVariablesCache = typename GetPropType<TypeTag, Properties::GridFluxVariablesCache>::LocalView;
+ using FluxVarCache = GetPropType<TypeTag, Properties::FluxVariablesCache>;
+ using FluxVariables = GetPropType<TypeTag, Properties::FluxVariables>;
+ using FluxTraits = typename Dumux::FluxTraits<FluxVariables>;
+ using BalanceEqOpts = GetPropType<TypeTag, Properties::BalanceEqOpts>;
+ using GridView = typename GetPropType<TypeTag, Properties::GridGeometry>::GridView;
+ using Element = typename GridView::template Codim<0>::Entity;
+ using ModelTraits = GetPropType<TypeTag, Properties::ModelTraits>;
+
+ enum { dim = GridView::dimension} ;
+ enum { dimWorld = GridView::dimensionworld} ;
+ enum
+ {
+ numPhases = ModelTraits::numFluidPhases(),
+ numComponents = ModelTraits::numFluidComponents()
+ };
+
+ using DimWorldMatrix = Dune::FieldMatrix<Scalar, dimWorld, dimWorld>;
+ using ComponentFluxVector = Dune::FieldVector<Scalar, numComponents>;
+ using HeatFluxScalar = Scalar;
+
+ static constexpr bool stationaryVelocityField = FluxTraits::hasStationaryVelocityField();
+
+public:
+
+ //return the reference system
+ static constexpr ReferenceSystemFormulation referenceSystemFormulation()
+ { return referenceSystem; }
+
+ /*!
+ * \brief Returns the dispersive fluxes of all components within
+ * a fluid phase across the given sub-control volume face.
+ * The computed fluxes are given in mole/s or kg/s, depending
+ * on the template parameter ReferenceSystemFormulation.
+ */
+ static ComponentFluxVector compositionalDispersionFlux(const Problem& problem,
+ const Element& element,
+ const FVElementGeometry& fvGeometry,
+ const ElementVolumeVariables& elemVolVars,
+ const SubControlVolumeFace& scvf,
+ const int phaseIdx,
+ const ElementFluxVariablesCache& elemFluxVarsCache)
+ {
+ if (scvf.numOutsideScvs() > 1 )
+ DUNE_THROW(Dune::NotImplemented, "\n Dispersion using ccTPFA is only implemented for conforming grids.");
+ if (!stationaryVelocityField)
+ DUNE_THROW(Dune::NotImplemented, "\n Dispersion using ccTPFA is only implemented for problems with stationary velocity fields");
+
+ ComponentFluxVector componentFlux(0.0);
+ const auto& insideVolVars = elemVolVars[scvf.insideScvIdx()];
+ const auto& outsideVolVars = elemVolVars[scvf.outsideScvIdx()];
+
+ const DimWorldMatrix dispersionTensor = VolumeVariables::DispersionTensorType::dispersionTensor(problem, scvf, fvGeometry,
+ elemVolVars, elemFluxVarsCache);
+ const auto dij = computeTpfaTransmissibility(scvf, fvGeometry.scv(scvf.insideScvIdx()), dispersionTensor, insideVolVars.extrusionFactor());
+
+ const auto rhoInside = massOrMolarDensity(insideVolVars, referenceSystem, phaseIdx);
+ const auto rhoOutside = massOrMolarDensity(outsideVolVars, referenceSystem, phaseIdx);
+ const Scalar rho = 0.5*(rhoInside + rhoOutside);
+
+ for (int compIdx = 0; compIdx < numComponents; compIdx++)
+ {
+ const auto xInside = massOrMoleFraction(insideVolVars, referenceSystem, phaseIdx, compIdx);
+ const auto xOutide = massOrMoleFraction(outsideVolVars, referenceSystem, phaseIdx, compIdx);
+
+ componentFlux[compIdx] = (rho * (xInside-xOutide) * dij) * scvf.area();
+ }
+ return componentFlux;
+ }
+
+
+ /*!
+ * \brief Returns the thermal dispersive flux
+ * across the given sub-control volume face.
+ */
+ static HeatFluxScalar thermalDispersionFlux(const Problem& problem,
+ const Element& element,
+ const FVElementGeometry& fvGeometry,
+ const ElementVolumeVariables& elemVolVars,
+ const SubControlVolumeFace& scvf,
+ const int phaseIdx,
+ const ElementFluxVariablesCache& elemFluxVarsCache)
+ {
+ if (scvf.numOutsideScvs() > 1 )
+ DUNE_THROW(Dune::NotImplemented, "\n Dispersion using ccTPFA is only implemented for conforming grids.");
+ if (!stationaryVelocityField)
+ DUNE_THROW(Dune::NotImplemented, "\n Dispersion using ccTPFA is only implemented for problems with stationary velocity fields");
+
+ const auto& insideVolVars = elemVolVars[scvf.insideScvIdx()];
+ const auto& outsideVolVars = elemVolVars[scvf.outsideScvIdx()];
+
+ const DimWorldMatrix dispersionTensor = VolumeVariables::DispersionTensorType::dispersionTensor(problem, scvf, fvGeometry,
+ elemVolVars, elemFluxVarsCache);
+ const auto dij = computeTpfaTransmissibility(scvf, fvGeometry.scv(scvf.insideScvIdx()), dispersionTensor, insideVolVars.extrusionFactor());
+
+ // get the inside/outside temperatures
+ const auto tInside = insideVolVars.temperature();
+ const auto tOutside = outsideVolVars.temperature();
+
+ // compute the heat conduction flux
+ return (tInside-tOutside) * dij * scvf.area();
+ }
+
+};
+
+} // end namespace Dumux
+
+#endif
diff --git a/dumux/flux/dispersionflux.hh b/dumux/flux/dispersionflux.hh
index f1d09969ee..3e53451593 100644
--- a/dumux/flux/dispersionflux.hh
+++ b/dumux/flux/dispersionflux.hh
@@ -26,5 +26,6 @@
#include <dumux/flux/dispersionflux_fwd.hh>
#include <dumux/flux/box/dispersionflux.hh>
+#include <dumux/flux/cctpfa/dispersionflux.hh>
#endif
diff --git a/dumux/material/fluidmatrixinteractions/dispersiontensors/scheidegger.hh b/dumux/material/fluidmatrixinteractions/dispersiontensors/scheidegger.hh
index 18a2b00f6f..20773b2ca8 100644
--- a/dumux/material/fluidmatrixinteractions/dispersiontensors/scheidegger.hh
+++ b/dumux/material/fluidmatrixinteractions/dispersiontensors/scheidegger.hh
@@ -113,7 +113,7 @@ public:
velocity /= -0.5 * (insideVolVars.viscosity() + outsideVolVars.viscosity());
}
else
- DUNE_THROW(Dune::NotImplemented, "\n Scheidegger Dispersion for compositional models is only implemented using the Box method.");
+ DUNE_THROW(Dune::NotImplemented, "\n Scheidegger Dispersion for compositional models without given constant velocity field is only implemented using the Box method.");
}
//calculate dispersion tensor
diff --git a/dumux/porousmediumflow/nonisothermal/localresidual.hh b/dumux/porousmediumflow/nonisothermal/localresidual.hh
index b52e5d8684..309212a805 100644
--- a/dumux/porousmediumflow/nonisothermal/localresidual.hh
+++ b/dumux/porousmediumflow/nonisothermal/localresidual.hh
@@ -213,12 +213,9 @@ public:
{
if constexpr (Deprecated::hasEnableThermalDispersion<ModelTraits>())
{
- if constexpr (ModelTraits::enableCompositionalDispersion())
+ if constexpr (ModelTraits::enableThermalDispersion())
{
- if constexpr (FVElementGeometry::GridGeometry::discMethod == DiscretizationMethods::box && numPhases == 1)
- flux[energyEqIdx] += fluxVars.thermalDispersionFlux();
- else
- DUNE_THROW(Dune::NotImplemented, "Dispersion Fluxes are only implemented for single phase flows using the Box method.");
+ flux[energyEqIdx] += fluxVars.thermalDispersionFlux();
}
}
else
diff --git a/dumux/porousmediumflow/tracer/localresidual.hh b/dumux/porousmediumflow/tracer/localresidual.hh
index 7f0b51a085..289c3a6b48 100644
--- a/dumux/porousmediumflow/tracer/localresidual.hh
+++ b/dumux/porousmediumflow/tracer/localresidual.hh
@@ -185,16 +185,11 @@ public:
{
if constexpr (ModelTraits::enableCompositionalDispersion())
{
- if constexpr (FVElementGeometry::GridGeometry::discMethod == DiscretizationMethods::box)
+ const auto dispersionFluxes = fluxVars.compositionalDispersionFlux(phaseIdx);
+ for (int compIdx = 0; compIdx < numComponents; ++compIdx)
{
- const auto dispersionFluxes = fluxVars.compositionalDispersionFlux(phaseIdx);
- for (int compIdx = 0; compIdx < numComponents; ++compIdx)
- {
- flux[compIdx] += dispersionFluxes[compIdx];
- }
+ flux[compIdx] += dispersionFluxes[compIdx];
}
- else
- DUNE_THROW(Dune::NotImplemented, "Dispersion Fluxes are only implemented for the Box method.");
}
}
else
--
GitLab