diff --git a/dumux/implicit/common/implicitlocaljacobian.hh b/dumux/implicit/common/implicitlocaljacobian.hh index c5cb7d5492ad3f06a64dc0722e661e788fe53a2a..a8220f7ad9069fd0af83d79df8f3bac32bc2400b 100644 --- a/dumux/implicit/common/implicitlocaljacobian.hh +++ b/dumux/implicit/common/implicitlocaljacobian.hh @@ -150,13 +150,6 @@ public: bcTypes_.update(problem_(), element_(), fvElemGeom_); - // this is pretty much a HACK because the internal state of - // the problem is not supposed to be changed during the - // evaluation of the residual. (Reasons: It is a violation of - // abstraction, makes everything more prone to errors and is - // not thread save.) The real solution are context objects! - problem_().updateCouplingParams(element_()); - // set the hints for the volume variables model_().setHints(element, prevVolVars_, curVolVars_); diff --git a/dumux/implicit/common/implicitlocalresidual.hh b/dumux/implicit/common/implicitlocalresidual.hh index e0b2a9478477e7998802abe8ce9529513e66f0e3..5da7de436fc35be72219aa5c75d6f69a20d5db0a 100644 --- a/dumux/implicit/common/implicitlocalresidual.hh +++ b/dumux/implicit/common/implicitlocalresidual.hh @@ -110,13 +110,6 @@ public: ElementBoundaryTypes bcTypes; bcTypes.update(problem_(), element, fvGeometry_()); - // this is pretty much a HACK because the internal state of - // the problem is not supposed to be changed during the - // evaluation of the residual. (Reasons: It is a violation of - // abstraction, makes everything more prone to errors and is - // not thread save.) The real solution are context objects! - problem_().updateCouplingParams(element); - asImp_().eval(element, fvGeometry_(), volVarsPrev, volVarsCur, bcTypes); } diff --git a/dumux/implicit/common/implicitproblem.hh b/dumux/implicit/common/implicitproblem.hh index 5214146c70bcc1fffdbe024950f135e34a297dea..708b4746b5201463dd5e54beca885ea035197e23 100644 --- a/dumux/implicit/common/implicitproblem.hh +++ b/dumux/implicit/common/implicitproblem.hh @@ -510,6 +510,7 @@ public: * \param element The DUNE Codim<0> entity for which the coupling * parameters should be computed. */ + DUNE_DEPRECATED void updateCouplingParams(const Element &element) const {}