From eaa93f12e2f1ec9831dce53b3653ba0b5aa41fc8 Mon Sep 17 00:00:00 2001
From: Bernd Flemisch <bernd@iws.uni-stuttgart.de>
Date: Tue, 27 Aug 2013 10:48:10 +0000
Subject: [PATCH] Deprecate the empty function updateCouplingParams from
ImplicitProblem and remove corresponding calls in ImplicitLocalResidual and
ImplicitLocalJacobian. The function is nowhere reimplemented in both stable
and devel.
git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@11273 2fb0f335-1f38-0410-981e-8018bf24f1b0
---
dumux/implicit/common/implicitlocaljacobian.hh | 7 -------
dumux/implicit/common/implicitlocalresidual.hh | 7 -------
dumux/implicit/common/implicitproblem.hh | 1 +
3 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/dumux/implicit/common/implicitlocaljacobian.hh b/dumux/implicit/common/implicitlocaljacobian.hh
index c5cb7d5492..a8220f7ad9 100644
--- a/dumux/implicit/common/implicitlocaljacobian.hh
+++ b/dumux/implicit/common/implicitlocaljacobian.hh
@@ -150,13 +150,6 @@ public:
bcTypes_.update(problem_(), element_(), fvElemGeom_);
- // this is pretty much a HACK because the internal state of
- // the problem is not supposed to be changed during the
- // evaluation of the residual. (Reasons: It is a violation of
- // abstraction, makes everything more prone to errors and is
- // not thread save.) The real solution are context objects!
- problem_().updateCouplingParams(element_());
-
// set the hints for the volume variables
model_().setHints(element, prevVolVars_, curVolVars_);
diff --git a/dumux/implicit/common/implicitlocalresidual.hh b/dumux/implicit/common/implicitlocalresidual.hh
index e0b2a94784..5da7de436f 100644
--- a/dumux/implicit/common/implicitlocalresidual.hh
+++ b/dumux/implicit/common/implicitlocalresidual.hh
@@ -110,13 +110,6 @@ public:
ElementBoundaryTypes bcTypes;
bcTypes.update(problem_(), element, fvGeometry_());
- // this is pretty much a HACK because the internal state of
- // the problem is not supposed to be changed during the
- // evaluation of the residual. (Reasons: It is a violation of
- // abstraction, makes everything more prone to errors and is
- // not thread save.) The real solution are context objects!
- problem_().updateCouplingParams(element);
-
asImp_().eval(element, fvGeometry_(), volVarsPrev, volVarsCur, bcTypes);
}
diff --git a/dumux/implicit/common/implicitproblem.hh b/dumux/implicit/common/implicitproblem.hh
index 5214146c70..708b4746b5 100644
--- a/dumux/implicit/common/implicitproblem.hh
+++ b/dumux/implicit/common/implicitproblem.hh
@@ -510,6 +510,7 @@ public:
* \param element The DUNE Codim<0> entity for which the coupling
* parameters should be computed.
*/
+ DUNE_DEPRECATED
void updateCouplingParams(const Element &element) const
{}
--
GitLab