diff --git a/CHANGELOG.md b/CHANGELOG.md index 0ca546f6e971d45ec3c0b0fe9ca96466d12e200e..2b5af751e98887e27e9b5f2eaa8cbb2155d2d518 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -50,7 +50,7 @@ for (const auto& element : elements(gridGeometry.gridView())) - __Embedded coupling__: Add a coupling manager for the 1D-3D projection based scheme with resolved interface introduced in Koch 2021 (https://arxiv.org/abs/2106.06358) -- __Dispersion__: Dispersion fluxes have been added as an option for the compositional and thermal porous medium flow models. These models use either a scheidegger dispersion tensor, which is dependent on the velocity field and two length parameters, or a full open tensor that can be user defined. For compositional models coupled with flow models (e.g. 1pnc), using the scheidegger dispersion tensor is only allowed when using the box discretization method. Otherwise all dispersion fluxes should be availble for the tpfa and the box discretization methods. +- __Dispersion__: Dispersion fluxes have been added as an option for the compositional and thermal one-phase porous medium flow models. These models use either a Scheidegger-type dispersion tensor, which is dependent on the velocity field and two length parameters, or a full and constant (_not_ solution-dependent, but possibly spatially varying) tensor that can be user defined in the spatial parameters. For compositional models coupled with flow models (e.g. 1pnc), using the Scheidegger-type dispersion tensor is only implemented for the box discretization method. To enable either thermal or compositional dispersion, please define these properties within your `properties.hh` header. For example: ```cpp @@ -60,7 +60,7 @@ template<class TypeTag> struct EnableThermalDispersion<TypeTag, TTag::MyTest> { static constexpr bool value = true; }; ``` -To determine which type of dispersion tensor you would prefer to use, please define this property within your `properties.hh` header. For example: +To determine the type of dispersion tensor, please define the property `DispersionTensorType` within your `properties.hh` header. For example: ```cpp template<class TypeTag> struct DispersionTensorType<TypeTag, TTag::MyTest> { using type = ScheideggersDispersionTensor<TypeTag>; }; diff --git a/test/porousmediumflow/tracer/constvel/spatialparams.hh b/test/porousmediumflow/tracer/constvel/spatialparams.hh index 583bad5d65dce3305ffe7ee9bab32ebe3324768c..b19cbec90f1056e1aaa5e83056ead250c4444f32 100644 --- a/test/porousmediumflow/tracer/constvel/spatialparams.hh +++ b/test/porousmediumflow/tracer/constvel/spatialparams.hh @@ -55,10 +55,8 @@ public: TracerTestSpatialParams(std::shared_ptr<const GridGeometry> gridGeometry) : ParentType(gridGeometry) { -#if ENABLEDISPERSION - alphaL_ = getParam<Scalar>("Problem.AlphaL"); - alphaT_ = getParam<Scalar>("Problem.AlphaT"); -#endif + alphaL_ = getParam<Scalar>("Problem.AlphaL", 0.0); + alphaT_ = getParam<Scalar>("Problem.AlphaT", 0.0); } /*!