Skip to content
GitLab
Switch branch/tag
  1. 23 Mar, 2015 1 commit
  3. 12 Mar, 2015 2 commits
  5. 20 Feb, 2015 1 commit
    • Bernd Flemisch's avatar
      [implicit] store Geometry if it is re-used · ec5a8c79
      Bernd Flemisch authored 
      Since grid implementations like Yasp calculate the Geometries on the
fly, every call to entity.geometry() may involve computation. This patch
stores a Geometry when it can be used later on in the same block. Only
for the implicit models, decoupled contains a lot more.

For simple models this actually pays off: for 1p in 3d on a larger grid,
the running time could be reduced from 15.5 to 14 s.

Reviewed by Timo.



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@14284 2fb0f335-1f38-0410-981e-8018bf24f1b0
      ec5a8c79
  7. 11 Feb, 2015 1 commit
    • Timo Koch's avatar
      [cellcentered] cleanup ccfvelementgeometry · 76973d94
      Timo Koch authored 
      Remove unused include and enums. Corrected enums to match cellcentered geometry.
The enums were still matched to the box method causing a memory overhead for the cellcentered.
Cellcentered methods should now need less allocated memory. Question remains if vector sizes 
in element geometry have to be variable (hanging nodes and low dimensional grids)

Reviewed by bernd
  


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@14233 2fb0f335-1f38-0410-981e-8018bf24f1b0
      76973d94
  9. 10 Feb, 2015 1 commit
    • Bernd Flemisch's avatar
      [mpnc] retrieve run-time parameter values instead of compile-time · 9b27f263
      Bernd Flemisch authored 
      property values

Several values steering the output as well as the Newton have been
handled inconsistently. While they have been obtained as run-time values
from the parameter tree in other models or parts of the mpnc model, the
compile-time property values have been taken at certain locations. Thus,
despite "advertised" as being run-time, it was not possible to actually
set them run-time. This was also due to the fact that those values have
been set as (private) enums. In order to reach consistency, these values
are member variables now and retrieved run-time.

Reviewed by gruenich.



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@14228 2fb0f335-1f38-0410-981e-8018bf24f1b0
      9b27f263
  11. 05 Feb, 2015 1 commit
  13. 04 Feb, 2015 1 commit
  15. 02 Feb, 2015 2 commits
  17. 28 Jan, 2015 2 commits
  19. 27 Jan, 2015 1 commit
    • Bernd Flemisch's avatar
      [newton] improve terminology · b5604a68
      Bernd Flemisch authored 
      The terminology for the Newton method is improved according to FS#238.
In particular, what has been referred to as "relative error" is now
termed "maximum relative shift", while "absolute error" has been renamed
to "residual reduction". This is particularly important, if
corresponding parameters or properties are set. See the CHANGELOG for
details.

Reviewed by gruenich.



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@14132 2fb0f335-1f38-0410-981e-8018bf24f1b0
      b5604a68
  21. 23 Jan, 2015 3 commits
  23. 21 Jan, 2015 1 commit
  25. 20 Jan, 2015 3 commits
  27. 16 Jan, 2015 2 commits
    • Bernd Flemisch's avatar
      [reverse] reverse unintended part of r14070 · da25ffc8
      Bernd Flemisch authored 
      

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@14071 2fb0f335-1f38-0410-981e-8018bf24f1b0
      da25ffc8
    • Bernd Flemisch's avatar
      [nonisothermal] improve naming and meaning of solid thermal parameters · 8465d28a
      Bernd Flemisch authored 
      This implements FS#216.

The "heatCapacity" function of the spatial parameters and the volume
variables for the implicit nonisothermal models was a misnomer, since it
returned an effective quantity, namely, 
heatCapacity*density*(1 - porosity) in [J/(K m^3)].
Except for mpnc, which resulted in an additional inconsistency.

Corresponding to the decision documented in FS#216, this patch renames
the function to "solidHeatCapacity" and returns always the "true"
(non-effective) heat capacity in [J/(kg K)]. This requires an additional
function "solidDensity" which returns the mass density of the porous
matrix. Moreover, the functions "thermalConductivitySolid/Fluid" are
renamed to "solid/fluidThermalConductivity". The decision to prepend
with "solid/fluid" rather than to append is motivated by consistency
with components and fluid systems, where "gas" and "liquid" are always
prepended to the corresponding function names.

_Beware_: this change breaks compatibility. You have to adapt your
spatial parameters such that they offer functions "solidHeatCapacity",
"solidDensity" and "solidThermalConductivity".

Reviewed by Alex.



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@14070 2fb0f335-1f38-0410-981e-8018bf24f1b0
      8465d28a
  29. 15 Jan, 2015 1 commit
  31. 14 Jan, 2015 1 commit
  33. 13 Jan, 2015 2 commits
  35. 12 Dec, 2014 1 commit
  37. 10 Dec, 2014 1 commit
  39. 09 Dec, 2014 1 commit
  41. 04 Dec, 2014 1 commit
  43. 03 Dec, 2014 1 commit
  45. 02 Dec, 2014 1 commit
  47. 28 Nov, 2014 3 commits
    • Thomas Fetzer's avatar
      [non-isothermal] · 509c42ba
      Thomas Fetzer authored 
      update to the generic non-isothermal model

adjusted:
 - 1p model
 - 3p model
 - 1p test (including 1pni tests)
 - 1p2c test (including 1p2cni tests)
 - 2p2c test (including 2p2cni tests)
 - 3p test (including 3pni tests)
 - 3p3c test (including 3p3cpni tests)
 - new ctest for kuevette problem

updated:
 - SET_TYPE_PROP instead of SET_PROP
 - documentation of non-isothermal problems
 - solution for 2pinjectionproblem (now with simplex grid)
 - version number in one start message

deleted:
 - old non-isothermal test folders
 - whitespace at end of configure.ac lines

created and reviewed by kissinger and fetzer




git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@13825 2fb0f335-1f38-0410-981e-8018bf24f1b0
      509c42ba
    • Bernd Flemisch's avatar
      [cell-centered implicit] fix bug introduced by r13823 · 87334751
      Bernd Flemisch authored 
      It was not such a good idea to change the name of the protected
evalDirichletSegment_ function of the CCLocalResidual, since it can be
overwritten in derived LocalResiduals, and in fact is already
overwritten in MPNCLocalResidual. The name is changed back to its
original.



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@13824 2fb0f335-1f38-0410-981e-8018bf24f1b0
      87334751
    • Bernd Flemisch's avatar
      [cell-centered implicit] fix a bug in the handling of mixed boundary · a78975bb
      Bernd Flemisch authored 
      conditions

Mixed boundary conditions here means that a part of the
equations/primary variables gets Dirichlet conditions, while the rest
gets Neumann conditions.

While in the cell-centered method pure Dirichlet conditions for all
equations are handled by calculating the resulting fluxes and adding
them to the cell residual, such a flux cannot be (easily?) calculated
for an equation that gets a Dirichlet condition as part of mixed
conditions. Therefore, such a Dirichlet condition is implemented in a
strong way by _replacing_ the corresponding cell residual.

It is important that this replacement is done at the very end of the
residual calculation. However, for corner cells this has not been
guaranteed so far. Therefore, fluxed resulting from the other boundary
parts of a corner cell could have been added to the replaced residual,
obviously leading to a wrong boundary condition treatment.

This patch resolves the issue by guaranteeing that the residual
replacement is done at the end of the residual calculation.

Brought to attention and reviewed by Thomas. Thanks.



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@13823 2fb0f335-1f38-0410-981e-8018bf24f1b0
      a78975bb
  49. 27 Nov, 2014 1 commit
  51. 25 Nov, 2014 4 commits