GitLab

updated changelog
corrected "adaptation" in the docu

reviewed by nicolas



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15505 2fb0f335-1f38-0410-981e-8018bf24f1b0

updated the parameterlist.txt
then renamed the gridadaptation for implicit to gridadaption, to be
consistent with the decoupled stuff and the docu.

reviewed by nicolas


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15504 2fb0f335-1f38-0410-981e-8018bf24f1b0

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15503 2fb0f335-1f38-0410-981e-8018bf24f1b0

The box method is not yet mass conservative. Therefore, an error is thrown by calling grid adaptation for the box method. 


Reviewed by Bernd

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15489 2fb0f335-1f38-0410-981e-8018bf24f1b0

mistakenly commented in commit r15453.  Reviewed by kissinger


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15465 2fb0f335-1f38-0410-981e-8018bf24f1b0

The material folder is now complete: 
-All units have been "TeXed"  and added where missing
-All relevant function arguments are described in doxygen
-All doxygen warnings but one have been removed, also from the recently added fluidsystems

Work done by Simon, reviewed by Alex


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15453 2fb0f335-1f38-0410-981e-8018bf24f1b0

added timeStepIndex to output in zeroeqmodels
updated documentation of boundarylayer model

reviewed by natalies



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15437 2fb0f335-1f38-0410-981e-8018bf24f1b0

- changed naming of mole fractions x^alpha_kappa to x^kappa_alpha
- added zeroThreshold for the kuevette problem, because the non-wetting
  phase already disappaered at the end of the simulation

reviewed by timok



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15436 2fb0f335-1f38-0410-981e-8018bf24f1b0

introduced setMassFraction() in the compositionalfluidstate.hh so that
in case of mass fraction formulation, they can be set directly, the
converting to mole fractions is now handled by the
compositionalfluidstate class

some test failed (kuevette with 5% difference), new references are
committed, however maybe some thresholds have to be adapted

reviewed by kissinger


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15433 2fb0f335-1f38-0410-981e-8018bf24f1b0

- added FluidState group, which appears now on the module page
- fixed ingroups


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15432 2fb0f335-1f38-0410-981e-8018bf24f1b0

- added doxygen comments and cleanup of defaultcomponents.hh
- improved documentation of constant.hh

[test]
- added units in test_navierstokes.input

reviewed by natalies



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15420 2fb0f335-1f38-0410-981e-8018bf24f1b0

Add required properties and their defaults.
[fix] Parameter in the ni electrochemistry
[cleanup] Adjust class names to naming conventions

Reviewed by bernd



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15403 2fb0f335-1f38-0410-981e-8018bf24f1b0

added the kinematicEddyViscosity to the vtu output, for using it in the
transport models

reviewed by kilian


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15401 2fb0f335-1f38-0410-981e-8018bf24f1b0

- added "constant" component which reads its properties from the input file
- updated documention for the "unit" component
- updated test_navierstokes which now uses the "constant" component

reviewed by bernd


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15395 2fb0f335-1f38-0410-981e-8018bf24f1b0

- added DUNE_THROW in case some wants to use stokes in 3D
- removed unnecessary and unused code accidentily committed in r12468

reviewed by timok


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15389 2fb0f335-1f38-0410-981e-8018bf24f1b0

Reviewed by Thomas


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15384 2fb0f335-1f38-0410-981e-8018bf24f1b0

[bugfix,2pnc] Fix the 2pnc model/test. A volVars update got deleted by accident causing wrong vtu output.

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15382 2fb0f335-1f38-0410-981e-8018bf24f1b0

[adapt] Implement a boundaryFaceIndex method for cellcentered fv geometry for compatibility with the box fvgeometry.

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15378 2fb0f335-1f38-0410-981e-8018bf24f1b0

boundary/source function available for implicit problems.

The init indicator used to assume to have an *AtPos method available.
However, these methods are not always available. The new inidicator uses
the respective highest method in hierarchy.

Reviewed by martins 


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15375 2fb0f335-1f38-0410-981e-8018bf24f1b0

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15350 2fb0f335-1f38-0410-981e-8018bf24f1b0

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15349 2fb0f335-1f38-0410-981e-8018bf24f1b0

functionality.

Add a test for the gmsh interface of the gridcreator. The example uses
parametrized boundary segments read from the gmsh file and
boundaryMarkers defined in the gmsh file. The output files are fuzzy
comopared.

Reviewed by bernd


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15348 2fb0f335-1f38-0410-981e-8018bf24f1b0

- All headers and source files are moved to the specfied include directory during installation.

- Existing CMakeLists.txt files were appended.
- CMakeLists.txt were added in folders that did not contain any CMakeLists.txt files but contain headers
- The installed version of dumux has been tested by Bernd with the dumux-lecture module

Reviewed, modified and tested by Bernd.



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15347 2fb0f335-1f38-0410-981e-8018bf24f1b0

  - added functionality and properties to refine grid in all directions
  - naming (comp -> dimIdx)

[multidomain]
  - adapted to changes in the interfacegridcreator
  - removed unused properties from input file
  - in coupled zeroeq problem added output at beginning of simulations

[freeflow]
  - removed one unused property from test_zeroeq2c.input

reviewed by timok



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15341 2fb0f335-1f38-0410-981e-8018bf24f1b0

This solves FS#237, see further details there.

The solution is to be aware of a restart already in the GridCreator.
Then, it is possible to construct the grid there that will be used for
the restarted simulation. This requires that the parameter Problem.Name
is set in the input file in order to deduct the correct restart file
names.

Reviewed and improved by Timo.


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15336 2fb0f335-1f38-0410-981e-8018bf24f1b0

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15328 2fb0f335-1f38-0410-981e-8018bf24f1b0

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15318 2fb0f335-1f38-0410-981e-8018bf24f1b0

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15316 2fb0f335-1f38-0410-981e-8018bf24f1b0

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15309 2fb0f335-1f38-0410-981e-8018bf24f1b0

Everything can be controlled by the input file: Changing

[Grid]
File = ./grid.dgf

into

[Grid]
File = ./grid.gmsh

or into

[Grid]
LowerLeft = 0 0 0
UpperRight = 1 1 1
Cells = 20 30 10

will construct a gmsh grid or a structured grid instead of the dgf grid.
The grid creator is the new standard grid creator.
To use all features dune 2.4 is required (e.g. structured grid factory)
but it dgf/gmsh works with dune 2.3. The structured grid factories can
be deprecated as soon as dune 2.4 is released.

additional feature:
- set inital refinement in Grid.Refinement  (oder options can be easily
  added, write me)
- grid specific parameter in input file, e.g.  UGGrid: Grid.ClosureType
  = None
turns off green refinement (triangles closure).
- new property GridParameterGroup sets the input file group the grid
  creator is looking in. Particularly useful for two grid simulations:

[DarcyGrid]
File = bla.dgf

[StokesGrid]
File = blub.dgf



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15307 2fb0f335-1f38-0410-981e-8018bf24f1b0

* Remove trailing whitespace and tabs
* Move electrochemistry output to the test problem (not related to 2pnc in general)
* Make electrochemistry have static members
* Use naming conventions for indices in the model
* Try to make the model work with cellcentered too (No cell-centered test available so far)
* Make electrochemistry input parameters part of a group "ElectroChemistry"
* Make the electrochemistry model a named enum (ElectroChemistryModel)for readability

Reviewed by martins 



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15298 2fb0f335-1f38-0410-981e-8018bf24f1b0

- BuildBot failed for commit -r 15292. The possible reason was the usage of static const int as template parameter for electrochemistry. (checked with M.Schneider)
- Unused variable removed from h2on2o2fluidsystem.hh 
- Unnecessary headers removed from test_box2pnc.cc 

Reviewed by (M.Schneider)

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15296 2fb0f335-1f38-0410-981e-8018bf24f1b0

- The required binary coefficients are added.
- Electrochemistry equations added for both isothermal and non-isothermal cases (Non-isothermal are not used till now).
- pc-s relation for hydrophobic material  added
- h2ON2o2 fluid system added
- fuelcell test case is the new test problem for 2pnc model.

Moreover, some updated related to 2pncmin model are included

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15292 2fb0f335-1f38-0410-981e-8018bf24f1b0

fixed wrong guardian macros

reviewed by martins


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15240 2fb0f335-1f38-0410-981e-8018bf24f1b0

exception is caught. 

The parameter list was printed every time a parameter exception was
thrown in the parameter class. This made it impossible to catch
parameter exceptions without having a paramter list output every time.
Now it is printed only if the start function exits with a parameter
error.



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15229 2fb0f335-1f38-0410-981e-8018bf24f1b0

conventions, review by vishal


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15209 2fb0f335-1f38-0410-981e-8018bf24f1b0

- adaption to style of other models (replaced use of \nabla by use of div or grad)
- replaced use of mass fraction with mole fraction in diffusion term and added
  comment about use of binary diffusion
- fixed typos

[doxygen,material]
- fixed typos and line break



git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15207 2fb0f335-1f38-0410-981e-8018bf24f1b0

(e.g., replaced mass with mole fractions)

Reviewed by Thomas


git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15206 2fb0f335-1f38-0410-981e-8018bf24f1b0

- Units in the fluidsystem/brinevariablesalinity and components/nacl checked. Additional commented units removed.
- Commented cout statements removed from computefromfugacities2pncmin, computefromreferencephase2pnc and miscible2pnccomposition
- The ccommented out removed from problem file and input file corrected.
- The test case is checked for both debug and optim model with clang compiler.

   

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15203 2fb0f335-1f38-0410-981e-8018bf24f1b0

git-svn-id: svn://svn.iws.uni-stuttgart.de/DUMUX/dumux/trunk@15202 2fb0f335-1f38-0410-981e-8018bf24f1b0