dumux issueshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues2018-07-25T13:55:54Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/532[RANS] Make calculation of velocity gradients more general and robust2018-07-25T13:55:54ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.de[RANS] Make calculation of velocity gradients more general and robustWhen considering a domain that features a pointy tip like illustrated below, it might be the case that the cell at the tip does not
have any vertical or horizontal neighbors. Right now, the calculation of the velocity gradient for RANS s...When considering a domain that features a pointy tip like illustrated below, it might be the case that the cell at the tip does not
have any vertical or horizontal neighbors. Right now, the calculation of the velocity gradient for RANS seems to produce nan values for this situation.
```cpp
+++++++++++++
+++++++++++
++++++++
++++++
+++
+
```
One could furthermore think of a more general gradient calculation tool that might by helpful in other cases.
Robustness issue addressed by !1130,
the generalization could be done on a dumux day.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/487Boundary conditions for FreeFlow2019-08-26T10:51:45ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deBoundary conditions for FreeFlowWe should rethink the way boundary conditions for the Navier-Stokes models are handled.
Versteeg and Malalasekera suggest the following boundary conditions:
* inlet
* outlet
* wall
* prescribed pressure
* symmetry
* periodicity (or cyc...We should rethink the way boundary conditions for the Navier-Stokes models are handled.
Versteeg and Malalasekera suggest the following boundary conditions:
* inlet
* outlet
* wall
* prescribed pressure
* symmetry
* periodicity (or cyclic boundary condition)
Until now, "outlet" and "prescribed pressure" are somehow combined into the "outflow" BC, which does not always make sense.
Should we adapt to these kind of fixed conditions or provide at least some convenience methods?
What do we need to consider for coupling to other domains?3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/427Improve staggered free flow model2018-11-12T16:01:12ZTimo Kochtimokoch@math.uio.noImprove staggered free flow model- [x] Account for extrusion factor (see !914)
- [x] fluxes
- [x] storage terms
- [x] Add 2D friction term to mimic 3D flow (see !925)
- [ ] Implement better tests (e.g. 3D, transient, backward-facing step, etc.) (see #415)
- [ ] Imp...- [x] Account for extrusion factor (see !914)
- [x] fluxes
- [x] storage terms
- [x] Add 2D friction term to mimic 3D flow (see !925)
- [ ] Implement better tests (e.g. 3D, transient, backward-facing step, etc.) (see #415)
- [ ] Improve the documentation (help message) and appearance of the test provlems
- [x] Improve inheritance structure (especially for RANS models) (see !915)
- [x] Improve boundary conditions (#487)
- [x] Check caching on/off3.0Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/424Staggered: Decoupled stencil from flux variables2017-12-21T15:35:10ZTimo Kochtimokoch@math.uio.noStaggered: Decoupled stencil from flux variables3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/611Cleanup/Freeflow2018-11-27T13:04:16ZNed ColtmanCleanup/Freeflow@AndreaVescovini has identified a few errors in the navierstokes environment.
* [x] Add check for a dirichlet pressure conditions when developing the lateral advective fluxes. !1327
* [x] Correct the cell size in the Channel test give...@AndreaVescovini has identified a few errors in the navierstokes environment.
* [x] Add check for a dirichlet pressure conditions when developing the lateral advective fluxes. !1327
* [x] Correct the cell size in the Channel test given a grid refinement !1329
* [x] Remove the isWall(globalpos) function from the channel test !1328
* [x] In the convergence script, label the velocity components and change x-axis title !1326
* [x] In the convergence script, label adapt the reference order lines to show the proper slope, regardless of the number of decades shown in the plot. !13263.0Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/609Bugfixes for staggered free flow2018-11-22T15:52:38ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deBugfixes for staggered free flowThanks to @AndreaVescovini , several bugs in the free flow model were found.
We should create merge requests in order to get these fixes into the master before the release.Thanks to @AndreaVescovini , several bugs in the free flow model were found.
We should create merge requests in order to get these fixes into the master before the release.3.0Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/493Unify PorousMediumVolVars and FreeFlowVolVars2018-07-20T15:19:50ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deUnify PorousMediumVolVars and FreeFlowVolVarsAfter having introduced the solid system, both PM flow and free flow should be able to use the same base volVarsAfter having introduced the solid system, both PM flow and free flow should be able to use the same base volVars3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/482Fix replaceCompEqIdx for free flow2018-04-30T14:31:48ZTimo Kochtimokoch@math.uio.noFix replaceCompEqIdx for free flow3.0Sina AckermannSina Ackermannhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/574Generalize free flow problem2019-02-20T17:39:08ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deGeneralize free flow problemSo far, each RANS model features its own problem. We have to check if this can be somehow generalized or if we could at least use one common class name with template specialization.
We could introduce a scoped enum `TurbulenceModel` (li...So far, each RANS model features its own problem. We have to check if this can be somehow generalized or if we could at least use one common class name with template specialization.
We could introduce a scoped enum `TurbulenceModel` (like `DiscMethod`) based on which to correct spezialization is chosen.3.1Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/490Convergence rates for staggered free flow implementation2019-06-27T09:29:35ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deConvergence rates for staggered free flow implementationWe should have a discussion about the expected convergence rates for v and p and double check the currently implemented tests.We should have a discussion about the expected convergence rates for v and p and double check the currently implemented tests.3.1https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/662Wrong use of extrusion factors (freeflow)2019-02-27T09:56:07ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deWrong use of extrusion factors (freeflow)At certain points, the use of the extrusion factor is implemented wrong:
* fluxoversurface.hh lacks the factor for the calculation of the volume fluxes
* stokesdarcy/couplingdata.hh includes the factor in the calculation of diffusive fl...At certain points, the use of the extrusion factor is implemented wrong:
* fluxoversurface.hh lacks the factor for the calculation of the volume fluxes
* stokesdarcy/couplingdata.hh includes the factor in the calculation of diffusive fluxes, however, those values
are then applied as Neuman-BCs where the factor is again applied
__TODO__ @heck What about the Maxwell-Stefan fluxes in the coupling data?3.1Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/713Generalize implementation of Beavers-Joseph(-Saffmann) slip condition2019-07-19T12:30:12ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deGeneralize implementation of Beavers-Joseph(-Saffmann) slip conditionSo far ths BJS condition only considers $`du/dy`$. We should extend this to $`(du/dy`$ + $`dv/dx)`$So far ths BJS condition only considers $`du/dy`$. We should extend this to $`(du/dy`$ + $`dv/dx)`$3.1Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/691Staggered Lingo Unification2019-04-26T07:09:20ZNed ColtmanStaggered Lingo UnificationWe waste a lot of time getting confused with terms like "lateral", "normal", "parallel", "staggered", "sub-", "frontal", "tangential", and there are of course a few remaining.
Many of these terms actually refer to the same thing. It wou...We waste a lot of time getting confused with terms like "lateral", "normal", "parallel", "staggered", "sub-", "frontal", "tangential", and there are of course a few remaining.
Many of these terms actually refer to the same thing. It would be nice to have rules for when each of these words is used, and to unify their use within the staggered discretization and the freeflow models.
Is this possible?3.1Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/537[staggered] Connectivity map stores own dofIdx2020-07-29T09:01:59ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.de[staggered] Connectivity map stores own dofIdxThis is not needed, as the own dof is always known.
Concerns the staggered local assembler, probably the matrix pattern helper and the elementvolvars.This is not needed, as the own dof is always known.
Concerns the staggered local assembler, probably the matrix pattern helper and the elementvolvars.3.1Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/804[staggered] Matrix block arrangement does not comply with literature standard2020-03-31T11:18:09ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.de[staggered] Matrix block arrangement does not comply with literature standardPapers dealing with solvers for saddlepoint problems (like the incompressible Navier-Stokes equations, [example](https://epubs.siam.org/doi/abs/10.1137/16M1076770)) usually define the block matrix as
```math
M = \begin{pmatrix}
A & B...Papers dealing with solvers for saddlepoint problems (like the incompressible Navier-Stokes equations, [example](https://epubs.siam.org/doi/abs/10.1137/16M1076770)) usually define the block matrix as
```math
M = \begin{pmatrix}
A & B^T\\
B & C
\end{pmatrix}
```
where $`A`$ is the block for the derivatives of the momentum balance equation residuals w.r.t velocity ("velocity block")
and $`C`$ is is the block for the derivatives of the mass balance equation residuals w.r.t pressure ("pressure block").
For incompressible fluids, $`C`$ is zero.
However, the multitype blockmatrix in Dumux for staggered problems looks like this:
```math
M = \begin{pmatrix}
C & B^T\\
B & A
\end{pmatrix}
```
which causes confusion and requires special care, e.g, for the implementation of the Uzawa solver !1827
I suggest we adapt the matrix structure such that the velocity block is on the upper left. Are there any concerns / objections?3.2Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/415Implement better tests for freeflow2020-03-25T14:54:40ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deImplement better tests for freeflow__This isssue has been split into #839 #838 #837 and will be closed.__
There is a myriad of benchmarks, numerical and analytical solutions for free-flow problems. We should incorporate more of them in our free-flow tests. Thomas and ...__This isssue has been split into #839 #838 #837 and will be closed.__
There is a myriad of benchmarks, numerical and analytical solutions for free-flow problems. We should incorporate more of them in our free-flow tests. Thomas and Christoph had some of them for their staggered grid implementation.
Currently, there are two test which come with an analytical solution:
`test_donea` and `test_kovasznay`
Here a some ideas what could be added:
- [ ] Analytical solution for simple stationary 2d channel test (test already exists)
- [ ] [Ghia 1982](https://ac.els-cdn.com/0021999182900584/1-s2.0-0021999182900584-main.pdf?_tid=e9f7486c-d67c-11e7-96b6-00000aab0f26&acdnat=1512121945_6871c2de3e7d5699f53ef718416dc341)
- [x] Transient flow field test with analytical solution
- [ ] Transient flow field test: lid driven cavity
- [ ] Analytical solution for diffusion (mass/energy) tests
- [x] Ensure same results for mass and mole formulation (see !950)
More suggestions welcome!
- [ ] Improve the description of the tests and the help-message
Could be a job for a HiWi.3.2Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/838[freeflow][test] Add analytical solution to channel test2020-08-28T05:02:47ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.de[freeflow][test] Add analytical solution to channel testAdd parabolic flow profile to low Re channel test.Add parabolic flow profile to low Re channel test.3.3Melanie LippMelanie Lipphttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/837[freeflow][test] Transfer lid-driven cavity test to an example2020-11-05T15:36:53ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.de[freeflow][test] Transfer lid-driven cavity test to an example[Ghia 1982](https://ac.els-cdn.com/0021999182900584/1-s2.0-0021999182900584-main.pdf?_tid=e9f7486c-d67c-11e7-96b6-00000aab0f26&acdnat=1512121945_6871c2de3e7d5699f53ef718416dc341) provide reference solutions (plot over line data) for the
...[Ghia 1982](https://ac.els-cdn.com/0021999182900584/1-s2.0-0021999182900584-main.pdf?_tid=e9f7486c-d67c-11e7-96b6-00000aab0f26&acdnat=1512121945_6871c2de3e7d5699f53ef718416dc341) provide reference solutions (plot over line data) for the
lid-driven cavity test.
I have used the data in my thesis and we could maybe also add them to the test.
* [ ] Turn the test into an example
* [ ] Add literature reference data
* [ ] Use `plotoverline` script from `bin` to extract line data
* [ ] Use scipy/gnuplot to plot and compare with the reference data3.3Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/686Improve usage of container types in staggered2020-05-27T06:57:12ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deImprove usage of container types in staggered* Replace `std::vector` by `Dune::ReservedVector` or even `std::array`, where possible
* most sizes are known at compile time* Replace `std::vector` by `Dune::ReservedVector` or even `std::array`, where possible
* most sizes are known at compile time3.3Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/675[freeflow] Remove property NormalizePressure2020-08-26T08:00:48ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.de[freeflow] Remove property NormalizePressureWhen enabled, all pressure related calculations for the momentum equations are done with `p - p_const`. The idea was to lower the numerical values of the pressure in the hope of decreasing numerical errors when further processing the val...When enabled, all pressure related calculations for the momentum equations are done with `p - p_const`. The idea was to lower the numerical values of the pressure in the hope of decreasing numerical errors when further processing the values in for the Jacobian. However, `p - p_const` probably already introduces the same error we wanted to avoid in the first place.
The property and the pressure normalization should therefore be removed after a check of the Matrix' condition number.3.3Kilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.de