dumux issueshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues2023-10-27T20:40:04Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1307Update doxygen to 3.82023-10-27T20:40:04ZTimo Kochtimokoch@math.uio.noUpdate doxygen to 3.8For example, the installation instructions are now in doxygen and need updating:
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/doc/doxygen/pages/installation.md?ref_type=headsFor example, the installation instructions are now in doxygen and need updating:
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/doc/doxygen/pages/installation.md?ref_type=heads3.8Ivan BunticIvan Buntichttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1211CppCheck [internalAstError]2023-01-25T23:38:42ZHamza OukiliCppCheck [internalAstError]<!--
This form is for bug reports ONLY!
If you're looking for help check out the [readme](/README.md).
-->
**Bug report**
**What happened / Problem description**:
When running the Cppcheck (static code analyzer) on dumux. It reports ...<!--
This form is for bug reports ONLY!
If you're looking for help check out the [readme](/README.md).
-->
**Bug report**
**What happened / Problem description**:
When running the Cppcheck (static code analyzer) on dumux. It reports 2 errors related to the fmt format library. One error is a syntax error in the dumux/dumux/io/format/fmt/format-inl.h file :
Checking dumux/dumux/io/format/fmt/format.cc: _HAS_EXCEPTIONS=0;__EXCEPTIONS;__GNUC__...
dumux/dumux/io/format/fmt/format-inl.h:208:61: error: Syntax Error: AST broken, binary operator '=' doesn't have two operands. [internalAstError]
FMT_API FMT_FUNC format_error::~format_error() FMT_NOEXCEPT = default;
![image](/uploads/dd96b890a795e6735ddc3202a554deb7/image.png)
**What you expected to happen**:
No errors from Cppcheck
**How to reproduce it (as minimally and precisely as possible)**:
run Cppcheck 2.10 on DuMux 3.6
**Anything else we need to know?**:
We maybe able to correct both errors by upgrading to the latest version of the fmt library instead of our version 7.1.0 from 2 years ago we can go to the latest version 9.1.0. But this upgrade might create other problems.
**Environment**:
- Dune version: 2.9
- DuMux version: 3.6
- Others: Cppcheck 2.103.7Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1210CppCheck [internalAstError]2023-01-25T23:38:04ZHamza OukiliCppCheck [internalAstError]<!--
This form is for bug reports ONLY!
If you're looking for help check out the [readme](/README.md).
-->
**Bug report**
**What happened / Problem description**:
When running the Cppcheck (static code analyzer) on dumux. I receive a...<!--
This form is for bug reports ONLY!
If you're looking for help check out the [readme](/README.md).
-->
**Bug report**
**What happened / Problem description**:
When running the Cppcheck (static code analyzer) on dumux. I receive a possible Syntax Error on the dumux/test/common/typetraits/test_isvalid.cc file, but it could also be another false positive :
Checking dumux/test/common/typetraits/test_isvalid.cc ...
dumux/test/common/typetraits/test_isvalid.cc:22:57: error: Syntax Error: AST broken, 'a' doesn't have a parent. [internalAstError]
const auto hasResize = isValid([](auto&& a) -> decltype(a.resize(std::size_t(1))) { });
please see the screenshot below :
![image](/uploads/d4e75a786a6f2dd25ecf920617ea8ce2/image.png)
**What you expected to happen**:
No errors from Cppcheck
**How to reproduce it (as minimally and precisely as possible)**:
run Cppcheck 2.10 on DuMux 3.6
**Anything else we need to know?**:
**Environment**:
- Dune version: 2.9
- DuMux version: 3.6
- Others: CppCheck 2.103.7Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1209[cleanup] Use new ignore field feature of the test driver2023-03-14T18:01:36ZTimo Kochtimokoch@math.uio.no[cleanup] Use new ignore field feature of the test driverThe dumux test script https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/bin/testing/runtest.py gets with !3353 an option to ignore fields (`--ignore "fielda" "fieldb"`). This can be used instead of setting a very hi...The dumux test script https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/bin/testing/runtest.py gets with !3353 an option to ignore fields (`--ignore "fielda" "fieldb"`). This can be used instead of setting a very high zero threshold to make the intent clear.
Example: `rank` should be ignored when comparison parallel and sequential files.
Example implementation: `test/freeflow/shallowwater/dambreak/CMakeLists.txt`3.7Harsha Pallamharsha.pallam@iws.uni-stuttgart.deHarsha Pallamharsha.pallam@iws.uni-stuttgart.dehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1208Cppcheck [missingReturn] error2023-01-23T14:05:11ZHamza OukiliCppcheck [missingReturn] error<!--
This form is for bug reports ONLY!
If you're looking for help check out the [readme](/README.md).
-->
**Bug report**
**What happened / Problem description**:
When running the Cppcheck (static code analyzer) on dumux, some possib...<!--
This form is for bug reports ONLY!
If you're looking for help check out the [readme](/README.md).
-->
**Bug report**
**What happened / Problem description**:
When running the Cppcheck (static code analyzer) on dumux, some possible errors are reported by Cppcheck. One of them is a [missingReturn] error on the dumux/test/material/components/plotproperties.cc file :
Checking dumux/test/material/components/plotproperties.cc ...
dumux/test/material/components/plotproperties.cc:294:130: error: Found an exit path from function with non-void return type that has missing return statement [missingReturn]
-> typename std::enable_if_t<decltype(isValid(hasNoChargeOverload{})(declval<C>()))::value || !ComponentTraits<C>::isIon, void> {}
please see the screenshot below for similar errors in the same file plotproperties.cc :
![IssueBugplotproperties](/uploads/c4efd2e35cb048d9690ae8fad54b358c/IssueBugplotproperties.png)
**What you expected to happen**:
No errors from Cppcheck
**How to reproduce it (as minimally and precisely as possible)**:
run Cppcheck 2.10 on DuMux 3.6
**Anything else we need to know?**:
**Environment**:
- Dune version: 2.9
- DuMux version: 3.6
- Others: Cppcheck 2.103.7Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1202Make extract module add default license2023-02-08T01:36:16ZTimo Kochtimokoch@math.uio.noMake extract module add default licenseMost dumux-pub modules do not have a FLOSS license (see #396) preventing reuse/modification.
To improve the situation, we could automatically add GPLv3 or later in the [extract module script](https://git.iws.uni-stuttgart.de/dumux-repos...Most dumux-pub modules do not have a FLOSS license (see #396) preventing reuse/modification.
To improve the situation, we could automatically add GPLv3 or later in the [extract module script](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/bin/extract_as_new_module.py) (or interactively).https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1163Cleanup code after release 3.5 (removal of deprecated features)2022-07-28T14:08:45ZTimo Kochtimokoch@math.uio.noCleanup code after release 3.5 (removal of deprecated features)Features/code/headers/functions/classes deprecated before release 3.5 and marked for removal after release 3.5 can now be removed from the code base.Features/code/headers/functions/classes deprecated before release 3.5 and marked for removal after release 3.5 can now be removed from the code base.3.6Ivan BunticIvan Buntichttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1145[python] Use new spatial params interfaces extrusionfactor/temperature2022-05-02T19:07:04ZTimo Kochtimokoch@math.uio.no[python] Use new spatial params interfaces extrusionfactor/temperatureThe Python bindings have been forgotten in the interface changeThe Python bindings have been forgotten in the interface change3.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1143[examples][biomin] Regenerate CO2 tables with new Python script2022-04-25T13:49:06ZTimo Kochtimokoch@math.uio.no[examples][biomin] Regenerate CO2 tables with new Python scriptThe biomin example uses custom tables that should be recreated with the new Python script since the internal format has been updatedThe biomin example uses custom tables that should be recreated with the new Python script since the internal format has been updated3.5Johannes HommelJohannes Hommel2022-04-26https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1124Cleanup outdated comment about gcc 5.32022-02-15T15:24:24ZTimo Kochtimokoch@math.uio.noCleanup outdated comment about gcc 5.3We have some occurrences of this sentence for some introspection helpers that have been copied around: `for g++ > 5.3, this can be replaced by a lambda`
These comments are outdated. We don't support 5.3 anymore but also I think we check...We have some occurrences of this sentence for some introspection helpers that have been copied around: `for g++ > 5.3, this can be replaced by a lambda`
These comments are outdated. We don't support 5.3 anymore but also I think we checked and using lambda is not that easy in this context. If there are more comments of this sort (in other places), we can also make a cleanup commit afterward.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1004Cleanup classes/functions/headers deprecated before release 3.32021-04-04T21:06:53ZTimo Kochtimokoch@math.uio.noCleanup classes/functions/headers deprecated before release 3.33.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/969[python] Small finite volume example based on grid geometry abstraction2021-02-17T17:04:42ZTimo Kochtimokoch@math.uio.no[python] Small finite volume example based on grid geometry abstractionWe have our finite volume grid abstraction in Python already. I think it would be nice (maybe interesting for teaching also) to have a small Python finite volume solver based on that.
The easiest thing is probably an explicit Euler adve...We have our finite volume grid abstraction in Python already. I think it would be nice (maybe interesting for teaching also) to have a small Python finite volume solver based on that.
The easiest thing is probably an explicit Euler advection code.3.4https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/953Fix deprecation warnings for embedded tests2020-10-30T14:04:28ZTimo Kochtimokoch@math.uio.noFix deprecation warnings for embedded testsSome embedded test still emit deprecation warnings because of the coupling manager changes.Some embedded test still emit deprecation warnings because of the coupling manager changes.3.3https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/886Use convenience functions referenceElement(entity) / referenceElement(geo)2020-05-28T21:20:48ZTimo Kochtimokoch@math.uio.noUse convenience functions referenceElement(entity) / referenceElement(geo)Since Dune 2.6 there is convenience functions `referenceElement` (free functions) to construct reference elements from entitites ([`dune/grid/common/entity.hh`](https://gitlab.dune-project.org/core/dune-grid/-/blob/master/dune/grid/commo...Since Dune 2.6 there is convenience functions `referenceElement` (free functions) to construct reference elements from entitites ([`dune/grid/common/entity.hh`](https://gitlab.dune-project.org/core/dune-grid/-/blob/master/dune/grid/common/entity.hh)) or geometries ([`dune/grid/common/geometry.hh`](https://gitlab.dune-project.org/core/dune-grid/-/blob/master/dune/grid/common/geometry.hh)).
This can replace the more verbose and less readable calls to `ReferenceElements::general()` we currently use.3.3Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/883Translate shell scripts to Python2021-10-28T08:45:56ZTimo Kochtimokoch@math.uio.noTranslate shell scripts to PythonAs I recently work quite a lot on macOS I found the following problem:
Due to the many different shells it's quite hard to write portable shell scripts. Most of the command just don't work exactly the same.
__Suggestion__
using Python ...As I recently work quite a lot on macOS I found the following problem:
Due to the many different shells it's quite hard to write portable shell scripts. Most of the command just don't work exactly the same.
__Suggestion__
using Python (version 3) instead it should be much easier to get things portable and maybe more people also understand Python scripts.3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/852Run and fix make headercheck2020-04-21T15:51:45ZTimo Kochtimokoch@math.uio.noRun and fix make headercheck* [x] Review the dumux repo (!1940, !1945, !1970)
* [x] Review the dumux-course (dumux-course!99)
* [x] Review the dumux-lecture (dumux-lecture!106)* [x] Review the dumux repo (!1940, !1945, !1970)
* [x] Review the dumux-course (dumux-course!99)
* [x] Review the dumux-lecture (dumux-lecture!106)3.2Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/700Test virtual interface for Problem2019-10-30T10:02:28ZTimo Kochtimokoch@math.uio.noTest virtual interface for ProblemGetting rid of the problem template would be a huge improvement in the code.
We should do performance measurement and check what run-time penalty a virtual problem interface would bring.
For that we have to first check which functions ac...Getting rid of the problem template would be a huge improvement in the code.
We should do performance measurement and check what run-time penalty a virtual problem interface would bring.
For that we have to first check which functions actually need to be virtual, add the virtual keyword, we could then exchange templates for a base class pointer one-by-one, and check for performance penalties.
The highest penalty is probably expected for a grid with a high boundary to internal cell ratio, and simple boundary and initial conditions so that the possible virtual function call would actually matter.Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/613Fix deprecation warning related to `gridvariables.init`2018-11-25T11:29:53ZTimo Kochtimokoch@math.uio.noFix deprecation warning related to `gridvariables.init`3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/555Free all spatial params of property system2018-11-22T20:58:17ZTimo Kochtimokoch@math.uio.noFree all spatial params of property systemUsually FVGridGeometry and Scalar (like in the base class) should be enough. Add more only if absolutely necessary.Usually FVGridGeometry and Scalar (like in the base class) should be enough. Add more only if absolutely necessary.3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/544Need for unit test for CheckPointTimeLoop2018-08-03T06:01:19ZTimo Kochtimokoch@math.uio.noNeed for unit test for CheckPointTimeLoopThe check pointing can be tricky with floating point operations. We should have a unit test testing corner cases, very small and very big time step size and so on.The check pointing can be tricky with floating point operations. We should have a unit test testing corner cases, very small and very big time step size and so on.3.0