Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Issues
  • #1054
Closed
Open
Issue created Jul 22, 2021 by Timo Koch@timokOwner

Discretization method as tag instead of enum

Tags (see https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/dumux/common/tag.hh) have some advantages over enums and, as far as I know, no disadvantages (edit: one disadvantage is that interfaces receiving a method as an argument need to be templated while this is not necessary for the enum implementation). The most prominent advantage being that a new tag can be added in user code without modifying the discretization/method.hh header which is currently required. This makes is difficult/impossible to add a new discretization in a separate module.

Tags have been introduced for the CouplingMode in couplingmanager1d3d.hh which previously was an enum and enabled implemented new modes in downstream modules. There was also a deprecation period possible which should be possible for the discretization method as well.

!2795 (closed) !2844 (merged)

Edited Sep 29, 2021 by Ivan Buntic
Assignee
Assign to
Time tracking