Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 86
    • Merge requests 86
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Issues
  • #1056
Closed
Open
Issue created Jul 22, 2021 by Timo Koch@timokOwner

Add gridGeometry.update(gridView)

In a recent update in dune the mappers got a new update(gridView) interface reflecting the value semantics of grid views introduced some time ago. In the same way we should also add gridView then to the gridgeometry.update function.

In our current usage it's slightly strange to write

GridGeometry gridGeometry(gridView);
gridGeometry.update(gridView);

So I suggest to change the behaviour of the grid geometry so that it already calls update in the constructor. We could add a special policy to be able to choose not initialize the grid geometry in the constructor if this is really needed.

As update gets a new signature, deprecation would be fairly easy I think if we accept that using the old interface update() means that you initialize the grid geometry twice (and you get a deprecation warning)

Edited Jul 22, 2021 by Timo Koch
Assignee
Assign to
Time tracking