Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 107
    • Issues 107
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 100
    • Merge requests 100
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Issues
  • #1173

Remove scv/scvf.geometry()/corner()

Scv and Scvf do not need to store any corners and/or geometries. The geometry can be computed on-the-fly given an element geometry. We could provide such a feature in the element geometries.

Since I assume that this is a hardly used feature, and all occurrences in Dumux (can be counted on one hand) can use a replacement, I suggest to remove these interfaces without deprecation.

The benefit is much less memory usage when caching the scv/scvfs.

The proposed interface is two free functions

auto geometry(fvElementGeometry, scv) auto geometry(fvElementGeometry, scvf)

Alternatively, we can think about

auto geometry(element_geometry, scv) auto geometry(element_geometry, scvf)

then all local Dune index information has to be available from the scv/scvf object, while the first version allows to do some additional mapping only known to the fvElementGeometry implementation.

Edited Nov 30, 2022 by Timo Koch
Assignee
Assign to
Time tracking