FS#313 test_adaptive2p2c2d.cc triggers has duplicate condition
Metadata
Property | Value |
---|---|
Project | dumux |
Category | Decoupled models |
Reported by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
Reported at | Feb 23, 2016 12:19 |
Type | Bug Report |
Version | Git |
Last edited by | Johannes Hommel (johannes.hommel@iws.uni-stuttgart.de) |
Last edited at | Jul 14, 2016 13:53 |
Description
GCC 6 with -Wduplicated-cond emits the following warning. Having a look into the code, it seems like a real bug to me.
In file included from /temp/gruenich/dune/test241/dumux/dumux/porousmediumflow/2p2c/sequential/fv3dpressureadaptive.hh:36:0, from /temp/gruenich/dune/test241/dumux/dumux/porousmediumflow/2p2c/sequential/adaptiveproperties.hh:68, from /temp/gruenich/dune/test241/dumux/test/porousmediumflow/2p2c/sequential/test_adaptive2p2c2dproblem.hh:36, from /temp/gruenich/dune/test241/dumux/test/porousmediumflow/2p2c/sequential/test_adaptive2p2c2d.cc:26: /temp/gruenich/dune/test241/dumux/dumux/porousmediumflow/2p2c/sequential/fvmpfal3dinteractionvolumecontaineradaptive.hh: In member function int Dumux::FvMpfaL3d2P2CInteractionVolumeContainerAdaptive::getMpfaCase2or4cells(const IntersectionIterator&, Dumux::FvMpfaL3d2P2CInteractionVolumeContainerAdaptive::InteractionVolume&, bool&): /temp/gruenich/dune/test241/dumux/dumux/porousmediumflow/2p2c/sequential/fvmpfal3dinteractionvolumecontaineradaptive.hh:496:18: warning: duplicated if condition [-Wduplicated-cond] else if(mapJ== 3) ^~ /temp/gruenich/dune/test241/dumux/dumux/porousmediumflow/2p2c/sequential/fvmpfal3dinteractionvolumecontaineradaptive.hh:492:13: note: previously used here if (mapJ== 3){ ^~