Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 91
    • Issues 91
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 82
    • Merge requests 82
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Issues
  • #339
Closed
Open
Created Oct 03, 2016 by Timo Koch@timokOwner

Thorough check that ALL tests use epsilons for floating point comparison in boundary conditions and spatial params

This is the main reason for failing test. All tests should use a proper epsilon.

  • This epsilon usually is made of a base epsilon static constexpr eps_ = 1.5e-7; times a magnitude. In the case of grids this should be a characteristic cell size.
  • If the grid is in the scale of 1m there is no adjustment necessary. However a runtime check would make it flexible for using any grid
  • We could also introduce a preprocessor constant or global variable in a namespace for the epsilon
  • We can also use more of Dune::Float_Cmp
Assignee
Assign to
Time tracking