Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 107
    • Issues 107
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 100
    • Merge requests 100
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Issues
  • #426

BrineCO2 Fluidsystems uses wrong/misleading gasDensity_ calculation

The brineco2.hh fluidystems uses an incorrect gasDensity calculation in the private gasDensity_ function. It returns the unchanged CO2 gas density, while the density function implies a lot more complex density calculation similar to the liquidDensity_. This seems to be like this from the very first commit on git, but e.g. in a biofluidsystem.hh that was derived from the brineco2.hh a long time ago by @hommel on dumux-devel there is a more complex gasDensity calculation using Dalton's law available. (see below) I suggest we change/fix this once most tests pass, because this might change some results for the next branch. I am not sure, what we should do about the master (or 2.12).

Additionally the normalization of some moleFractions etc. seems a little sketchy to me, but that might be necessary. Additionally the second the brineco2.hh still uses the deprecated xl and xg naming. This should be changed, while fixing this.

static Scalar gasDensity_(Scalar T, Scalar pg, Scalar xgH2O) { Scalar pH2O = xgH2O*pg; //Dalton' Law Scalar pCO2 = pg - pH2O; Scalar gasDensityCO2 = CO2::gasDensity(T, pCO2); Scalar gasDensityH2O = H2O::gasDensity(T, pH2O); Scalar gasDensity = gasDensityCO2 + gasDensityH2O; return gasDensity; }

Assignee
Assign to
Time tracking