Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 109
    • Issues 109
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Issues
  • #463

Rethink isothermal/mineralization type tags

In order to realize non-isothermal models, type tags inherit from the non-isothermal type tag and one has to set the properties IsothermalIndices, IsothermalNumEq etc. The actual types/values are then determined by the non-isothermal type tag.

Alternatively, one could also directly set the non-isothermal types (e.g. EnergyIndices), because the current way neither saves code nor does it improve readability. Since mineralization models use a similar pattern, in non-isothermal mineralization models it is particularly difficult to see which type is set/used.

Also, we would get rid of all properties like IsothermalIndices, IsothermalVolumeVariables, ..., NonMineralizationVtkOutputFields, NonMineralizationVolumeVariables ...

Assignee
Assign to
Time tracking