Streamline names in vtk output (again)
I know the names have been streamlined a while ago, and are also being adjusted for stokes (#506 (closed), !1036 (merged)). But with the change introducing mixed-wettability for the two-phase models we should think again.
In particular pw, sn
are not correct anymore. More general would be p_phaseName
or p_0
. p_phaseName
is nicer IMO since you don't have to check the code again to know which pressure that is. Potentially there are name clashes, e.g. when using two times water in a 2p test. The names returned by fluid systems and components can be quite lengthy and often start with capital letter. For this purpose it would be nice if the they would supply short names / abbreviations with a maximum of 3 or 4 characters. The output module could also do a sanity check if the names are unique, and make them if they are not.
There is also the question in the light of !1039 (merged) how to use the same names for primary variables for input and output. Until now !1039 (merged) specifies the privar names for input but doesn't influence the ones for output. Option 1 is that this is wanted -> I want to be able to read any file and just supply the field names myself. Option 2 is that we somehow force the same names for the output (which might be complicated because output doesn't care about which variables are privars right now).