Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Issues
  • #648
Closed
Open
Issue created Jan 08, 2019 by Timo Koch@timokOwner2 of 4 checklist items completed2/4 checklist items

Put property definitions in tests (examples/applications) in separate header

To make another step away from the problem-does-everything-mentality that was common (and a necessary evil) in dumux 2, I suggest to put the property definitions into a separate header. There are not connected in any way to the Problem class, so IMO they shouldn't be defined in the problem header. For the purpose of re-usability they also shouldn't be directly coded in the main file.

Edit: Result from the vote: We want to advertise putting properties in a separate header.

  • Separate properties into properties.hh for the examples (milestone 3.2) !1933 (merged)
  • Separate properties into properties.hh for the dumux-course (milestone 3.2) course#24
  • Separate properties into properties.hh for the dumux-lecture (milestone 3.3) lecture#15
  • Separate properties into properties.hh for the tests (milestone 3.3)

This doesn't have to be in one go. If someone edits a test anyway feel free to do this change as well.

Edited Apr 09, 2020 by Ned Coltman
Assignee
Assign to
Time tracking