Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 91
    • Issues 91
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 80
    • Merge requests 80
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Issues
  • #801
Closed
Open
Created Jan 20, 2020 by Martin Schneider@martinsMaintainer

[Box] variable switch at boundary

It seems that there is a bug in the variable switch for box at the boundary. In the initPriVarSwitch_ method, the states of Dirichlet nodes are corrected. This method is called in newtonBegin, which however is called after the initialization of uLastIter.

Therefore, when calling the newtonUpdate method, the corrected states of uCurrentIter are overwritten.

We could fix this by either calling initPriVarSwitch_ before uLastIter is initialized or by setting this vector after newtonBeginStep. So we could simply change

if (numSteps_ > 0)
    uLastIter = uCurrentIter;

to

if (numSteps_ >= 0)
    uLastIter = uCurrentIter;
Edited Jan 20, 2020 by Martin Schneider
Assignee
Assign to
Time tracking