Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Issues
  • #830
Closed
Open
Issue created Mar 23, 2020 by Timo Koch@timokOwner

Deprecate property GridView

Given that we have the properties GridGeometry and Grid it seems unnecessary to have GridView as well.

Suggestion:

  • replace all GetPropType<TypeTag, Properties::GridView> by typename GetPropType<TypeTag, Properties::GridGeometry>::GridView
  • replace GetPropType<TypeTag, Properties::GridView> by typename GetPropType<TypeTag, Properties::Grid>::LeafGridView where the above is not possible

Only disadvantage I can see: We cannot change from LeafGridView to LevelGridView by changing the GridView property but you need to change the GridGeometry property. Given that this feature is hardly ever used, it seems acceptable.

Edited Mar 23, 2020 by Timo Koch
Assignee
Assign to
Time tracking