Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 91
    • Issues 91
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 80
    • Merge requests 80
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Issues
  • #830
Closed
Open
Created Mar 23, 2020 by Timo Koch@timokOwner

Deprecate property GridView

Given that we have the properties GridGeometry and Grid it seems unnecessary to have GridView as well.

Suggestion:

  • replace all GetPropType<TypeTag, Properties::GridView> by typename GetPropType<TypeTag, Properties::GridGeometry>::GridView
  • replace GetPropType<TypeTag, Properties::GridView> by typename GetPropType<TypeTag, Properties::Grid>::LeafGridView where the above is not possible

Only disadvantage I can see: We cannot change from LeafGridView to LevelGridView by changing the GridView property but you need to change the GridGeometry property. Given that this feature is hardly ever used, it seems acceptable.

Edited Mar 23, 2020 by Timo Koch
Assignee
Assign to
Time tracking