Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Issues
  • #845
Closed
Open
Issue created Mar 30, 2020 by Bernd Flemisch@berndOwner

Inconsistency in parallelhelpers?

The function prepareLinearAlgebraParallel in dumux/linear/parallelhelpers.hh has, among others, two template parameters LinearSolverTraits and ParallelTraits. It receives three parameters

std::shared_ptr<typename ParallelTraits::...>& comm, fop, sp.

ParallelTraits is then used for branching between an overlapping and a nonoverlapping treatment.

Later on, actual values are assigned to these parameters not employing the types shown above, but rather in terms of, for example,

using Traits = typename LinearSolverTraits::template ParallelNonoverlapping<Matrix, Vector>;
comm = std::make_shared<typename Traits::Comm>(pHelper.gridView().comm(), category);

The local alias Traits should always coincide with the template parameter ParallelTraits, otherwise the assigments won't work.

To me, using the local alias is confusing. Can it be deleted or was it done on purpose? Maybe it's a leftover from the time before if constexpr?

Edited Mar 30, 2020 by Bernd Flemisch
Assignee
Assign to
Time tracking