Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 85
    • Issues 85
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 80
    • Merge requests 80
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Issues
  • #933

Closed
Open
Created Sep 22, 2020 by Kilian Weishaupt@kweisOwner

Discussion: Unify LocalAssemblers and SubDomainCouplingAssemblers

From a brief glance at BoxLocalAssembler and SubDomainBoxLocalAssembler it seems that there is a large degree of code duplication. I think it should be possible to make SubDomainBoxLocalAssembler inherit from BoxLocalAssembler.

The only critical parts are some calls to couplingManager. This could be replaced by some lambda calls which do nothing for the non-coupling assembler. The coupled assembler could then call the base class' function with a specialized lambda which . , e.g., update the coupled variables.

We could evaluate the possibility of streamlining our code on the next Dumux day.

Edited Sep 22, 2020 by Kilian Weishaupt
Assignee
Assign to
Time tracking