dumux merge requests
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests
2020-06-02T07:58:17Z
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2136
[cmake] Require CMake 3.13
2020-06-02T07:58:17Z
Christoph Grüninger
[cmake] Require CMake 3.13
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2323
[io][cmake] Add format header to installed headers
2020-10-30T00:35:06Z
Timo Koch
timokoch@math.uio.no
[io][cmake] Add format header to installed headers
3.3
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2549
Feature/cmakelists
2021-04-04T21:10:01Z
Timo Koch
timokoch@math.uio.no
Feature/cmakelists
Fixes #1006.
Fixes #1006.
3.4
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2589
[test] Remove symlink to removed folder
2021-05-06T08:57:41Z
Timo Koch
timokoch@math.uio.no
[test] Remove symlink to removed folder
The `grid` folder doesn't exist so the symlink is broken.
The `grid` folder doesn't exist so the symlink is broken.
3.4
Hanchuan Wu
Hanchuan Wu
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2633
Use dumux_add_test instead of dune_add_test
2021-05-21T08:37:04Z
Timo Koch
timokoch@math.uio.no
Use dumux_add_test instead of dune_add_test
Should be added to release/3.4
Should be added to release/3.4
3.4
Dennis Gläser
Dennis Gläser
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2903
[cmake] Several smaller cleanups
2021-10-26T16:20:45Z
Timo Koch
timokoch@math.uio.no
[cmake] Several smaller cleanups
Make CMake slightly less verbose and fix some warnings
Make CMake slightly less verbose and fix some warnings
3.5
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3048
[cmake] Add DUMUX_ENABLE_PYTHONBINDINGS with default DUNE_ENABLE_PYTHONBINDINGS
2022-04-19T16:13:54Z
Timo Koch
timokoch@math.uio.no
[cmake] Add DUMUX_ENABLE_PYTHONBINDINGS with default DUNE_ENABLE_PYTHONBINDINGS
This allows to disable the Dumux Python bindings independent of the Dune
Python bindings.
This allows to disable the Dumux Python bindings independent of the Dune
Python bindings.
3.5
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3066
Cleanup/cmakelists
2022-04-26T12:26:57Z
Timo Koch
timokoch@math.uio.no
Cleanup/cmakelists
3.5
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3416
Doxygen/remove shell script
2023-03-02T14:29:47Z
Timo Koch
timokoch@math.uio.no
Doxygen/remove shell script
Wait for !3367 to be merged.
Wait for !3367 to be merged.
Dennis Gläser
Dennis Gläser
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3441
[python][cmake] Use dune_python_configure_bindings
2023-03-14T10:47:35Z
Timo Koch
timokoch@math.uio.no
[python][cmake] Use dune_python_configure_bindings
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3466
[cmake] Make sure we build shared libs when Python is enabled and enforce C++17
2023-03-20T19:51:07Z
Timo Koch
timokoch@math.uio.no
[cmake] Make sure we build shared libs when Python is enabled and enforce C++17
!3436 accidentally removed DUMUX_CMAKE_FLAGS which was used in some downstream tests to set BUILD_SHARED_LIBS for Python. The fact that is was removed shows that it wasn't clear what it's good for. We need a better mechanism that actuall...
!3436 accidentally removed DUMUX_CMAKE_FLAGS which was used in some downstream tests to set BUILD_SHARED_LIBS for Python. The fact that is was removed shows that it wasn't clear what it's good for. We need a better mechanism that actually enforced our requirement of BUILD_SHARED_LIBS=ON when using Python bindings. This attempts to do this through CMake.
We also enforce C++17 by setting it as a PUBLIC interface of the dumux library.
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3467
[cmake] Bump version to 3.14 for install(SCRIPT/CODE)
2023-03-21T09:27:03Z
Timo Koch
timokoch@math.uio.no
[cmake] Bump version to 3.14 for install(SCRIPT/CODE)
This fixes a deprecation/policy warning with CMake
This fixes a deprecation/policy warning with CMake
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3499
[cmake] Add missing include
2023-07-18T11:11:20Z
Christoph Grüninger
[cmake] Add missing include
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Configure broke with latest du...
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Configure broke with latest dune-common. Probably due to a change in C++ feature detection.
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
TODO: insert text here
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3500
Merge branch 'feature/cmake-missing-include' into 'master'
2023-03-27T13:25:09Z
Christoph Grüninger
Merge branch 'feature/cmake-missing-include' into 'master'
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
TODO: insert text here
<!--
I...
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
TODO: insert text here
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
TODO: insert text here
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [ ] does the new code follow the [style guide](doc/styleguide.md)?
- [ ] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [ ] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [ ] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [ ] is the list of the header includes complete? ("include what you use")
- [ ] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
- [ ] (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
- [ ] (if not applicable remove) if the examples are modified, is the documentation regenerated (using [`generate_example_docs.py`](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/examples/generate_example_docs.py))
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->
3.7
Hamza Oukili
Hamza Oukili
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3678
[cleanup] Add missing content in CMakeLists.txt
2023-10-27T18:22:42Z
Ivan Buntic
[cleanup] Add missing content in CMakeLists.txt
3.8
Ivan Buntic
Ivan Buntic
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3702
[cmake] Raise requirement to CMake 3.16
2023-11-02T07:52:40Z
Timo Koch
timokoch@math.uio.no
[cmake] Raise requirement to CMake 3.16
Raise the requirement to CMake 3.16 in preparation for https://gitlab.dune-project.org/core/dune-common/-/merge_requests/1302.
Ubuntu 20.04 has it. We now test with 22.04 (which has CMake 3.22).
Raise the requirement to CMake 3.16 in preparation for https://gitlab.dune-project.org/core/dune-common/-/merge_requests/1302.
Ubuntu 20.04 has it. We now test with 22.04 (which has CMake 3.22).
3.8
Ivan Buntic
Ivan Buntic
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3710
[cmake][python] Disable DuMux Python bindings by default, enable in cmake.opts
2024-03-14T15:05:21Z
Mathis Kelm
[cmake][python] Disable DuMux Python bindings by default, enable in cmake.opts
<!--
SPDX-FileCopyrightInfo: Copyright © DuMux Project contributors, see AUTHORS.md in root folder
SPDX-License-Identifier: CC0-1.0
-->
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please...
<!--
SPDX-FileCopyrightInfo: Copyright © DuMux Project contributors, see AUTHORS.md in root folder
SPDX-License-Identifier: CC0-1.0
-->
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
When building shared libraries in DuMux the libraries of upstream DUNE modules should be built as shared libraries too. Instead of automatically enabling Python bindings and setting `BUILD_SHARED_LIBS` in the root `CMakeLists.txt` the options should be set in `cmake.opts` and used for building both DuMux and the upstream DUNE modules with dunecontrol.
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
3.8
Mathis Kelm
Mathis Kelm