dumux merge requests
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests
2023-06-28T23:07:27Z
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3581
[handbook][cleanup] Remove rest of handbook
2023-06-28T23:07:27Z
Timo Koch
timokoch@math.uio.no
[handbook][cleanup] Remove rest of handbook
Fixes #991 Fixes #1238
Fixes #991 Fixes #1238
3.8
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3557
[cleanup] Simplify and remove some code deprecated in the previous release
2023-05-31T13:51:49Z
Martin Utz
[cleanup] Simplify and remove some code deprecated in the previous release
Remove some deprecated interfaces and
* Simplify newton norm calculation
* No longer store geometry in cell-centered scv and tpfa scvf
Remove some deprecated interfaces and
* Simplify newton norm calculation
* No longer store geometry in cell-centered scv and tpfa scvf
3.8
Martin Utz
Martin Utz
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3554
Resolve "installexternal.py fails to download METIS"
2023-07-18T11:11:24Z
Hamza Oukili
Resolve "installexternal.py fails to download METIS"
<!--
SPDX-FileCopyrightInfo: Copyright © DuMux Project contributors, see AUTHORS.md in root folder
SPDX-License-Identifier: CC0-1.0
-->
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please...
<!--
SPDX-FileCopyrightInfo: Copyright © DuMux Project contributors, see AUTHORS.md in root folder
SPDX-License-Identifier: CC0-1.0
-->
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Removing Metis, it is not used in the dumux repository
Fixes #1240
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->
Closes #1240
3.7
Hamza Oukili
Hamza Oukili
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3490
[examples] unify formatting of overview
2023-07-18T11:11:19Z
Martin Schneider
[examples] unify formatting of overview
3.7
Martin Schneider
Martin Schneider
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3473
Remove unnecessary define UGGRID 0
2023-03-23T09:49:36Z
Hamza Oukili
Remove unnecessary define UGGRID 0
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Since dune 2.6 and OPM 2018.04...
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Since dune 2.6 and OPM 2018.04 are not compatible and give a compiler error, `#define HAVE_DUNE_UGGRID 0` has been added. But it produces a warning of "HAVE_DUNE_UGGRID" redefined
But now dune 2.9 and OPM 2022.10 seems to be compatible. This MR removes `#define HAVE_DUNE_UGGRID 0`
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [ ] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->
3.7
Hamza Oukili
Hamza Oukili
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3472
Cleanup/gridmanager only include what we use
2023-03-22T23:14:22Z
Timo Koch
timokoch@math.uio.no
Cleanup/gridmanager only include what we use
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3471
[cleanup] Remove deprecated type tag for momentum model
2023-03-22T14:16:05Z
Stefanie Kiemle
[cleanup] Remove deprecated type tag for momentum model
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
fix #1231 Clean up for release...
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
fix #1231 Clean up for release/3.7
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
- [x] (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
- [x] (if not applicable remove) if the examples are modified, is the documentation regenerated (using [`generate_example_docs.py`](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/examples/generate_example_docs.py))
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->
3.7
Stefanie Kiemle
Stefanie Kiemle
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3470
[staggered][disc] Deprecate scv/scvf.geometry/corner
2023-03-22T10:51:29Z
Timo Koch
timokoch@math.uio.no
[staggered][disc] Deprecate scv/scvf.geometry/corner
Update for the staggered geometry that was forgotten to be updated in !3463
Update for the staggered geometry that was forgotten to be updated in !3463
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3469
[test][angeli] Use fvGeometry.geometry(scvf)
2023-03-22T10:51:22Z
Timo Koch
timokoch@math.uio.no
[test][angeli] Use fvGeometry.geometry(scvf)
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3465
[linear][istlsolvers] Improve parameter handling and allow setting a matrix o...
2023-03-20T21:05:52Z
Timo Koch
timokoch@math.uio.no
[linear][istlsolvers] Improve parameter handling and allow setting a matrix operator for reuse
* [parallelhelpers] Introduce possibility to split treatment of vector and matrix
* [linear][istlsolvers] Improve parameter handling and allow setting a matrix operator for reuse
* The solver accepts now either a parameter group or a Dun...
* [parallelhelpers] Introduce possibility to split treatment of vector and matrix
* [linear][istlsolvers] Improve parameter handling and allow setting a matrix operator for reuse
* The solver accepts now either a parameter group or a Dune::ParameterTree. In the case of the latter,
the parameter tree is forwarded without modificaiton to the dune-istl solvers.
* Introduce a new function to set the maximum number of itertions
* Introduce two new interfaces "setMatrix(A)" and "solve(x, b)". The first one constructs a solver
based on the matrix A. If the new solve interface without matrix is called, this pre-constructed
solver is used in the solver. solve(A, x, b) still exists and construct a solver based on A and
ignores any stored solver. This allows to contruct a solver and then reuse it for many right hand sides.
This can be practical, for example, in parallel for linear problems
where constructing the solver involves the modificaiton
of the matrix and communication and is therefore an expensive step.
* [projection] Use istl solvers replacing old solver backends
* Use new istl solvers everywhere
* Deprecated the old solvers
* Return solver result that is convertible to bool but contains Dune::InverseOperatorResults
* Simplify parallel code branches
* Make solver copyable by using shared_ptr for parallel helper
Fixes #1220
Fixes #1230
Fixes #1223
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3464
Feature/improve cvfe localassembler
2023-03-19T22:21:45Z
Timo Koch
timokoch@math.uio.no
Feature/improve cvfe localassembler
Small fixes in the subdomain cvfe localassembler
Small fixes in the subdomain cvfe localassembler
3.7
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3463
[disc] Deprecate scv/scvf.geometry/corner
2023-03-21T22:26:02Z
Timo Koch
timokoch@math.uio.no
[disc] Deprecate scv/scvf.geometry/corner
Addresses #1173 (makes sure we can finish this task after release 3.7 and all interfaces are properly deprecated for release 3.7).
Addresses #1173 (makes sure we can finish this task after release 3.7 and all interfaces are properly deprecated for release 3.7).
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3462
[assembly][cvfe] Unify CVFE assembly
2023-03-21T13:09:01Z
Timo Koch
timokoch@math.uio.no
[assembly][cvfe] Unify CVFE assembly
* [x] Unify the local and subdomain assemblers for CVFE
* [x] Unify treatment for fcdiamond on the boundary, treat like other CVFE schemes (non-compatible change)
* [x] Add changelog entry for fcdiamond
* [x] Remove obsolete local assemb...
* [x] Unify the local and subdomain assemblers for CVFE
* [x] Unify treatment for fcdiamond on the boundary, treat like other CVFE schemes (non-compatible change)
* [x] Add changelog entry for fcdiamond
* [x] Remove obsolete local assemblers
depends on !3460 because it adopts that bugfix to all CVFE schemes.
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3451
[examples][1d3d] Fix math typo
2023-03-15T20:45:07Z
Timo Koch
timokoch@math.uio.no
[examples][1d3d] Fix math typo
3.7
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3448
Remove deprecated file and satisfy headercheck
2023-03-17T16:15:36Z
Mathis Kelm
Remove deprecated file and satisfy headercheck
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Adds some missing headers so h...
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Adds some missing headers so headercheck passes.
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
- [x] (if not applicable remove) if the examples are modified, is the documentation regenerated (using [`generate_example_docs.py`](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/examples/generate_example_docs.py))
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->
3.7
Hamza Oukili
Hamza Oukili
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3447
[assembly] Use unified Jacbian sparsity pattern computation for CVFE methods
2023-03-15T15:39:03Z
Timo Koch
timokoch@math.uio.no
[assembly] Use unified Jacbian sparsity pattern computation for CVFE methods
**What this MR does / why does DuMux need it**:
Unifies Jacobian pattern computation for CVFE schemes (similar to !3445 for multidomain)
Fixes fcdiamond Jacobian for explicit time integration
**What this MR does / why does DuMux need it**:
Unifies Jacobian pattern computation for CVFE schemes (similar to !3445 for multidomain)
Fixes fcdiamond Jacobian for explicit time integration
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3445
[md][assembly] Unify coupling Jacobian pattern for cvfe schmes
2023-03-15T14:45:35Z
Timo Koch
timokoch@math.uio.no
[md][assembly] Unify coupling Jacobian pattern for cvfe schmes
**What this MR does / why does DuMux need it**:
Use the same implementation for the coupling jacobian for all cvfe schemes
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the exis...
**What this MR does / why does DuMux need it**:
Use the same implementation for the coupling jacobian for all cvfe schemes
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
3.7
Timo Koch
timokoch@math.uio.no
Timo Koch
timokoch@math.uio.no
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3438
Feature/update and clean examples
2023-03-16T18:26:56Z
Hanchuan Wu
Feature/update and clean examples
Clean up deprecation warnings in examples.
Clean up deprecation warnings in examples.
3.7
Hanchuan Wu
Hanchuan Wu
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3436
[cmake.opts] remove undefined flags variable
2023-03-20T15:35:07Z
Dennis Gläser
[cmake.opts] remove undefined flags variable
There seems to be an undefined (empty) variable passed to the cmake opts.
There seems to be an undefined (empty) variable passed to the cmake opts.
3.7
Dennis Gläser
Dennis Gläser
https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3425
Cleanup python setup for dune 2.9 and newer
2023-03-09T13:26:49Z
Mathis Kelm
Cleanup python setup for dune 2.9 and newer
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Simplifies installation, CI an...
<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Simplifies installation, CI and CMake code by assuming a dune version of 2.9 or newer. Fixes #1225
Checking for the existence of the virtual environment is still necessary as dune 2.10 introduces the ability to deactivate it, which is used in our minimal installation pipelines.
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->
3.7
Mathis Kelm
Mathis Kelm