dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2022-07-24T19:52:30Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3219[pmflow][velocity][cleanup] Remove unused aliases2022-07-24T19:52:30ZTimo Kochtimokoch@math.uio.no[pmflow][velocity][cleanup] Remove unused aliases3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3218Feature/outsource assembly helper2022-07-24T18:28:50ZTimo Kochtimokoch@math.uio.noFeature/outsource assembly helper3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3217[box][cleanup] Remove unused variable2022-07-24T16:17:23ZTimo Kochtimokoch@math.uio.no[box][cleanup] Remove unused variable3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3216[cleanup][vtkoutputmodule] Do not require elementIndex interface unnecessarily2022-07-23T01:07:35ZTimo Kochtimokoch@math.uio.no[cleanup][vtkoutputmodule] Do not require elementIndex interface unnecessarily3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3205[python] Update gridgeometry update interface2022-07-15T19:17:46ZTimo Kochtimokoch@math.uio.no[python] Update gridgeometry update interfaceCleanup required after #1056 is fixed now. No longer use the deprecated `gg.update()` method.Cleanup required after #1056 is fixed now. No longer use the deprecated `gg.update()` method.3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3188[cleanup][2pnc] Remove duplicate calculation of density/mole-denstiy in VolVars2022-07-12T19:25:44ZHanchuan Wu[cleanup][2pnc] Remove duplicate calculation of density/mole-denstiy in VolVars<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Remove duplicate calculation o...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Remove duplicate calculation of density/mole-denstiy in 2pncVolVars
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
Fixes #1172
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.3.6Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3185[simpleh2o] Small cleanup2022-07-06T12:02:33ZTimo Kochtimokoch@math.uio.no[simpleh2o] Small cleanupFix comment, remove unused R, write .0 for floating point numbers
Fixes #1170 (I didn't see any usage of R and it's a private variable, so I removed it)Fix comment, remove unused R, write .0 for floating point numbers
Fixes #1170 (I didn't see any usage of R and it's a private variable, so I removed it)3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3184[geometry][cleanup] Use free reference element function2022-07-04T08:13:43ZTimo Kochtimokoch@math.uio.no[geometry][cleanup] Use free reference element function3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3173WIP: encapsulate operations in the volvars update method2023-09-27T16:15:46ZNed ColtmanWIP: encapsulate operations in the volvars update method<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This merge request should remo...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This merge request should remove duplicated code often seen in the volvars' update functions. This issue is outlined in #814.
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
@tufan, @nedc, @hanchuan, @yue
**Question: **
does it make sense to add new headers to the dumux/material/constraintsolvers/ directory, or would another location make more sense?
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [ ] does the new code follow the [style guide](doc/styleguide.md)?
- [ ] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [ ] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [ ] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->3.9https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3171Separate extended 1.5phase Richards model into a separate model2022-10-05T12:41:25ZSina AckermannSeparate extended 1.5phase Richards model into a separate model<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
See Issue #1165
- [x] keep or...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
See Issue #1165
- [x] keep original richards folder with deprecation warnings
- [x] adapt richardsextended folder, inherit from richards1p
- [x] adapt tests: `richards/nonisothermal/evaporation` uses the extended model
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
TODO: insert text here
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.
<!--
The following aspects might also come up during review:
* Does the change reduce the performance of the code (more CPU time or more memory) and is this justified by the benefits
* Does the change improve the performance? (if yes, add this aspect to the MR description)
* Is the code is a gross violation of programming best practices such as DRY (don't repeat yourself / code duplication, see https://de.wikipedia.org/wiki/Don%E2%80%99t_repeat_yourself, the SOLID principles (https://en.wikipedia.org/wiki/SOLID), or the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)?
* Is the code well-documented, concise, easily readable? (e.g. variables are well-named, the logic is split into small & well-named functions)
-->3.6Sina AckermannSina Ackermannhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3170Cleanup/deprecated2022-07-23T11:31:50ZStefanie KiemleCleanup/deprecated<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This merge request is supposed...<!--
Thanks for considering to open a merge request!
Before asking for a review of your MR, please read the [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
This merge request is supposed to remove the deprecated lines of code, headers and files trailing after release/3.5.
The corresponding issue is described in #1163.
<!--
Is there a corresponding issue? Add "Fixes hashtag issuenumber" which will automatically close the issue when this MR is merged. Add "Related to hashtag issuenumber" if it's related but doesn't fix the issue completely.
-->
**Notes for the reviewer**
Fixes #1163
<!--
Keep the following TODO list in the merge request description for documentation.
Bullet points marked with _(if not applicable remove)_ may be removed.
-->
Before you request a review from someone, make sure to revise the following points:
- [x] does the new code follow the [style guide](doc/styleguide.md)?
- [x] do the test pipelines pass? (see guide on [how to run pipelines for a merge request](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/wikis/Running-test-pipelines-for-merge-requests))
- [x] is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
- [x] does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in `CHANGELOG.md`.
- [x] is the list of the header includes complete? ("include what you use")
- [x] all files have to end with a `\n` character. Make sure there is no `\ No newline at end of file` comment in "Changes" of this MR.3.6Stefanie KiemleStefanie Kiemlehttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3163[test][donea][mom][cleanup] Identity mapping is simpler with iota2022-06-04T18:38:01ZTimo Kochtimokoch@math.uio.no[test][donea][mom][cleanup] Identity mapping is simpler with iota3.6Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3162[cleanup][test][porenetwork] removing setPreviousSolution call2022-06-03T09:32:33ZKai Wendel[cleanup][test][porenetwork] removing setPreviousSolution callThere are only three tests that use a function call in the form of assembler->setPreviousSolution(xOld).
If this line is deleted and the tests compiled again, they perform exactly in the same way as before, therefore I would suggest, to ...There are only three tests that use a function call in the form of assembler->setPreviousSolution(xOld).
If this line is deleted and the tests compiled again, they perform exactly in the same way as before, therefore I would suggest, to remove this call as access to the old solution is already given when the constructor of the assembler is called.
This raises the question, whether this setPreviousSolution() method shall be deleted completely, as it is not called anywhere else except those three tests, or if it is maybe left as it could be used under other circumstances3.6Kai WendelKai Wendelhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3157reorder changelog2022-06-02T11:50:52ZBernd Flemischreorder changelogReorder the changes from 3.4 to 3.5 in the changelog.Reorder the changes from 3.4 to 3.5 in the changelog.3.5Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3149Merge branch 'cleanup/1pnc-remove-delp-from-default-output' into 'master'2022-06-01T18:33:23ZTimo Kochtimokoch@math.uio.noMerge branch 'cleanup/1pnc-remove-delp-from-default-output' into 'master'[1pnc] Remove delp from default output
See merge request dumux-repositories/dumux!3144
(cherry picked from commit 8e3e6ea6679693538e0c3b418c89de726a8f3843)
840cd078 [1pnc] Remove delp from default output[1pnc] Remove delp from default output
See merge request dumux-repositories/dumux!3144
(cherry picked from commit 8e3e6ea6679693538e0c3b418c89de726a8f3843)
840cd078 [1pnc] Remove delp from default output3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3147[python][linter] Fix pylint warning appearing with newer version2022-06-01T16:57:36ZTimo Kochtimokoch@math.uio.no[python][linter] Fix pylint warning appearing with newer version3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3144[1pnc] Remove delp from default output2022-06-01T18:00:18ZTimo Kochtimokoch@math.uio.no[1pnc] Remove delp from default outputdelp is not generally a useful output in particular since -1e5 is hard-coded as offset.
In case of small pressure changes this output also suffers from possible large rounding errors
since p is the primary variables and -1e5 might result...delp is not generally a useful output in particular since -1e5 is hard-coded as offset.
In case of small pressure changes this output also suffers from possible large rounding errors
since p is the primary variables and -1e5 might result in 5 insifgnificant digits.
No other model has this default output field. Hence, this makes
output more consistent across models.3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3121[test][1p][conv_disc] do not multiply period by pi2022-05-25T14:52:38ZDennis Gläser[test][1p][conv_disc] do not multiply period by piTimo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3069Spatial parameters for Python bindings2022-05-02T19:07:03ZNed ColtmanSpatial parameters for Python bindingsFixes #1145Fixes #11453.5Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/3066Cleanup/cmakelists2022-04-26T12:26:57ZTimo Kochtimokoch@math.uio.noCleanup/cmakelists3.5Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no