dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2019-07-25T06:30:44Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1650[Navier-Stokes] Revise definition of transporting velocity on boundary for mo...2019-07-25T06:30:44ZMelanie Lipp[Navier-Stokes] Revise definition of transporting velocity on boundary for momentum upwinding.Closes #721Closes #7213.1Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1807[vangenuchten] Introduce pore-connectivity parameter L2020-02-01T13:41:56ZTimo Kochtimokoch@math.uio.no[vangenuchten] Introduce pore-connectivity parameter L<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Introduces the pore-connectivity parameter `l`. The para...<!--
Thanks for sending a merge request!
If this is your first time, read our [contributing guidelines](/CONTRIBUTING.md)
-->
**What this MR does / why does DuMux need it**:
Introduces the pore-connectivity parameter `l`. The parameter is used in the relative permeability curve in the Mualem model.
Mualem (1976) suggested that 0.5 is a good value for many soils. Sometimes a
value different from 0.5 is provided, which is why this patch implements it as additional variable.
**Special notes for your reviewer**:
* There was something weird in `krn`. The function uses the factor $`(1-S_{we})^{1/3}`$ but according to the van Genuchten Mualem model this should be $`(1-S_{we})^{1/2}`$ or $`(1-S_{we})^l`$. See Mualem 1976 (https://doi.org/10.1029/WR012i003p00513) and e.g. Dury et all (1999) (https://doi.org/10.1029/1999WR900019). @holle The `1/3` appears e.g. in your habilitation but no other sources than Mualem and van Genuchten are given. Can you comment on where it might come from?
* I believe the derivative $`\frac{\partial k_{rn}}{\partial S_{we}}`$ was wrong. Please recheck the new result before merging.
These two points change the van genuchten material law (not backwards compatible) and could also result in differences in the reference solutions. If the changes get accepted we should
* [x] Add note in changelog about the changes in vangenuchten
* [x] Check tests and possibly update references3.2Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2252Rewrite Install external with Python2021-05-19T11:06:19ZFelix WeinhardtRewrite Install external with Python
Fixes #866
Fixes #8663.4Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2757Add code of conduct2021-08-24T20:57:52ZTimo Kochtimokoch@math.uio.noAdd code of conduct@all I think it would be good to adapt and official code of conduct in the DuMux community and the development of DuMux. This would be a formalization of what we already (hopefully) practiced and tried to communicate to developers.
I sug...@all I think it would be good to adapt and official code of conduct in the DuMux community and the development of DuMux. This would be a formalization of what we already (hopefully) practiced and tried to communicate to developers.
I suggest to add en established form (e.g. the [Contributor Covenant](https://www.contributor-covenant.org/ as suggested in this MR). Small modifications are of course possible (personally I don't think this is necessary).
TODOs
* [x] Contact methodBernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2905Deprecate the shell scripts2021-10-28T08:45:56ZFarid MohammadiDeprecate the shell scriptsCloses #883
TODO:
- [x] Deprecation warning in python for `bin/util/test_dumux.sh`
- [x] Deprecate the following scripts:
1. [compareparameters.sh](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/bin/doc/comp...Closes #883
TODO:
- [x] Deprecation warning in python for `bin/util/test_dumux.sh`
- [x] Deprecate the following scripts:
1. [compareparameters.sh](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/bin/doc/compareparameters.sh)
2. [replace_property_macros.sh](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/master/bin/util/replace_property_macros.sh)
- [x] Add changes in the `CHANGELOG.md`3.5Farid MohammadiFarid Mohammadi