dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2021-04-05T13:56:39Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2452Feature/water vapor viscosity2021-04-05T13:56:39ZGabi SeitzFeature/water vapor viscosityCloses issue #573
- [x] check tests of dumux-lecture (see MR [143](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux-lecture/-/merge_requests/143) in dumux-lecture)
- [x] check tests of dumux-course (all tests passed)Closes issue #573
- [x] check tests of dumux-lecture (see MR [143](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux-lecture/-/merge_requests/143) in dumux-lecture)
- [x] check tests of dumux-course (all tests passed)3.4Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2450Python script translation for extractmodule2021-05-19T11:20:14ZHanchuan WuPython script translation for extractmoduleFixes #973Fixes #9733.4Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2434[test][1p] Add root benchmark analytical solution Schnepf et al 20202021-01-08T12:04:14ZTimo Kochtimokoch@math.uio.no[test][1p] Add root benchmark analytical solution Schnepf et al 20203.4Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2432[test][richards] Add two benchmark cases Vanderborght 20052021-01-11T14:42:35ZTimo Kochtimokoch@math.uio.no[test][richards] Add two benchmark cases Vanderborght 2005Adds two benchmark cases from Schnepf et al doi: 10.3389/fpls.2020.00316. Based on the scenarios from Vanderborght et al 2005 https://doi.org/10.2113/4.1.206.
* [x] Create reference solution for testingAdds two benchmark cases from Schnepf et al doi: 10.3389/fpls.2020.00316. Based on the scenarios from Vanderborght et al 2005 https://doi.org/10.2113/4.1.206.
* [x] Create reference solution for testing3.4Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2422[flux][tpfa][fickslaw] Add flux overload taking inside/outside volVars explic...2021-04-29T07:00:09ZTimo Kochtimokoch@math.uio.no[flux][tpfa][fickslaw] Add flux overload taking inside/outside volVars explicitly3.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2419[python] Make DuMux installable via pip2021-04-29T07:00:09ZSamuel Burbullasamuel.burbulla@mathematik.uni-stuttgart.de[python] Make DuMux installable via pipThis adds the files necessary for publishing DuMux as python package.
I have uploaded a first development release to PyPI: https://pypi.org/project/dumux/
Feel free to try `pip install dumux`.This adds the files necessary for publishing DuMux as python package.
I have uploaded a first development release to PyPI: https://pypi.org/project/dumux/
Feel free to try `pip install dumux`.3.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2417Feature/tokenize2021-04-29T07:00:09ZTimo Kochtimokoch@math.uio.noFeature/tokenize3.4Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2410Improve yasp- and subgridmanager2020-12-03T19:26:34ZKilian WeishauptImprove yasp- and subgridmanager3.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2285Feature/new gridvars concept2021-04-29T07:00:08ZDennis GläserFeature/new gridvars concept**What this MR does / why does DuMux need it**:
Introduces a new grid variables concept, where the grid variables represent the entire state of a current solution. That is, they define both primary & secondary variables and, once implem...**What this MR does / why does DuMux need it**:
Introduces a new grid variables concept, where the grid variables represent the entire state of a current solution. That is, they define both primary & secondary variables and, once implemented in the future, the time level on which the solution is defined.
Mentions #9403.4Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2252Rewrite Install external with Python2021-05-19T11:06:19ZFelix WeinhardtRewrite Install external with Python
Fixes #866
Fixes #8663.4Hanchuan WuHanchuan Wuhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2243[shallowwater][diffusion] add turbulent diffusion to shallow water2021-06-07T12:47:16ZFrank Platzek[shallowwater][diffusion] add turbulent diffusion to shallow water**Adding (turbulent) diffusion to the shallow water model (part of freeflow)**:
The implementation basically contains three parts:
1. computation of a horzontal diffusion flux (shear stress)
2. computation of possible wall-shear stress
...**Adding (turbulent) diffusion to the shallow water model (part of freeflow)**:
The implementation basically contains three parts:
1. computation of a horzontal diffusion flux (shear stress)
2. computation of possible wall-shear stress
3. computation of a turbulent viscosity from a very basic turbulence model (mixing-length based, kept as local as possible)
For now using either a constant eddy-viscosity (turbulence model 0) or a horizontal mixing-length based appraoch (turbulence model 1). Other turbulence models might be added in later. The implementation contains 2 wall shear stress implementations:
1. no-slip implementation
2. law-of-the-wall implementation
One test has been added: Poiseuille flow test: for flow in a channel with rough side walls. This test has an analytical solution.
**Which issue this MR fixes**
Fixes #706
**Special notes for your reviewer**: The Poiseuille flow test only tests two of the three added functionalities:
the horizontal diffusion and the wall shear stress implementations, with constant eddy viscosity. The turbulence model 1 implementation where the eddy viscosity is computed algebraically based on the local bottom shear stress and velocity gradients is not tested in this test case. A number of test cases was, however, performed to test this. Among others, a test case for the flow around a thin wall. Should this test also be added?
Moreover, the present Poiseuille test uses a structured rectangular grid. The same test was also set up and performed on an unstructured triangular grid. Is this test also required? Thank you very much!3.4Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2231Feature/python createdockerimage script2021-05-11T15:18:16ZDennis GläserFeature/python createdockerimage scriptThis MR is based on !2222 using the implementation made be @utz, but it modifies the `createdockerimage.py` script such that it expects an install script in the form as introduced in !2230, i.e., it expects everything to be installed by ...This MR is based on !2222 using the implementation made be @utz, but it modifies the `createdockerimage.py` script such that it expects an install script in the form as introduced in !2230, i.e., it expects everything to be installed by it. If we like this, we can close !2222.
This has the advantage that the script does not have to be called from within the module, but can be called from anywhere.
This is WIP because it depends on !2230, especially on the question if we want to restrict ourselves to this type of install scripts.
Relates #912, #921
part of #8833.4Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2208Feature/pore network model2021-02-25T15:34:18ZKilian WeishauptFeature/pore network modelThis MR implements pore-network models in Dumux.
__TODO__
- [x] remove deprecated warnings
- [x] discuss folder structure
- [x] discuss caching and transmissibility laws
- [x] discuss grid data
- [x] discuss tests
- [x] check docu
- [x...This MR implements pore-network models in Dumux.
__TODO__
- [x] remove deprecated warnings
- [x] discuss folder structure
- [x] discuss caching and transmissibility laws
- [x] discuss grid data
- [x] discuss tests
- [x] check docu
- [x] clean up
- [x] use script in `bin/util/create_cmakelists.py` to create CMakeLists.txt files
- [x] change license headers to GPL v3
- [x] put flux-related header into `dumux/flux`
- [x] revise and check ps-Sw curve
- [x] discuss and find a solution for the 2p and 2pni tests, which are very sensitive to the chosen regularization method and the parameter Swmax.
- [x] Add description in changelog (+ backwards-compatibility policy)3.4Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2319Feature/io format output2020-11-02T11:15:25ZTimo Kochtimokoch@math.uio.noFeature/io format outputDepends on !2317 to be merged.
Fixes #916.Depends on !2317 to be merged.
Fixes #916.3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2318[examples] add python3 catch for examples doc script2020-10-29T14:37:38ZSimon Emmert[examples] add python3 catch for examples doc scriptThis adds an additional catch to use the script for the documentation of examples with python3.
I am not entirely sure if we really need this as the shebang is already there. So if users/developers use the script correctly, the catch i...This adds an additional catch to use the script for the documentation of examples with python3.
I am not entirely sure if we really need this as the shebang is already there. So if users/developers use the script correctly, the catch is not needed. However, if as in #952 the script is used with python directly, the python generated error-message is not really helpful.
Let's discuss this, before we merge!
So this MR is here in case we think this is catch is of any help.
fixes #9523.3Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2317Feature/fmt2020-10-29T19:58:58ZTimo Kochtimokoch@math.uio.noFeature/fmtAdds the core part of the [fmt library](https://github.com/fmtlib/fmt/) version 7.1.0.
This enables Python style string formatting.
`fmt::format` implements `std::format` which will be available in the C++20 standard library.
https://fm...Adds the core part of the [fmt library](https://github.com/fmtlib/fmt/) version 7.1.0.
This enables Python style string formatting.
`fmt::format` implements `std::format` which will be available in the C++20 standard library.
https://fmt.dev/latest/index.html
https://en.cppreference.com/w/cpp/utility/format3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2311[newtonsolver] Use linearSolver.norm() if available2023-02-19T15:51:05ZTimo Kochtimokoch@math.uio.no[newtonsolver] Use linearSolver.norm() if availableIf a linear solver provides the ability to compute a norm use that interface, otherwise fallback to the assembler interface.If a linear solver provides the ability to compute a norm use that interface, otherwise fallback to the assembler interface.3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2310Feature/solver cleanup2023-02-19T15:51:05ZTimo Kochtimokoch@math.uio.noFeature/solver cleanupVarious improvements to solver/parallel backend extracted from !2113Various improvements to solver/parallel backend extracted from !21133.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2300Feature/constantspatialparams1p2020-10-26T13:48:21ZTimo Kochtimokoch@math.uio.noFeature/constantspatialparams1pI have found myself implementing this class quite often, or at least copying it from somewhere, so I thought we could actually add it as a default spatial params for 1p models.
The same could be actually done for 2p models with the new ...I have found myself implementing this class quite often, or at least copying it from somewhere, so I thought we could actually add it as a default spatial params for 1p models.
The same could be actually done for 2p models with the new interface of !1607 where all parameters are read from the input file.3.3Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/2288Feature/1d3d coupling manager improvements2020-10-27T11:57:54ZTimo Kochtimokoch@math.uio.noFeature/1d3d coupling manager improvementsImprovements to 1d3d coupling managers. Implements the changes of !2190 in sensible smaller steps. These changes are improvements that resulted from the 1d3d embedded scheme comparisons included in https://doi.org/10.1016/j.jcp.2020.1093...Improvements to 1d3d coupling managers. Implements the changes of !2190 in sensible smaller steps. These changes are improvements that resulted from the 1d3d embedded scheme comparisons included in https://doi.org/10.1016/j.jcp.2020.109370.
The kernel coupling manager (which was not very good) has been replaced with the coupling manager from the paper.
Depends on !2287 to be merged. Will be easier to review once this other MR is merged.
Depends on !2307 to be merged.3.3Kilian WeishauptKilian Weishaupt