dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2018-11-12T14:49:57Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1250WIP: Cleanup/rename all tests2018-11-12T14:49:57ZNed ColtmanWIP: Cleanup/rename all testsGeneral Plan:
1. Rename targets.
2. Reorganize such that only one `.cc` file exists per folder, rename to `main.cc`, `problem.hh`, `spatialparams.hh` and `params.input`. Differentiate by adding `_xxx` if necessary, e.g. `problem_darcy.h...General Plan:
1. Rename targets.
2. Reorganize such that only one `.cc` file exists per folder, rename to `main.cc`, `problem.hh`, `spatialparams.hh` and `params.input`. Differentiate by adding `_xxx` if necessary, e.g. `problem_darcy.hh` and `problem_stokes.hh` in a multidomain test.
3. Rename `Problem.Name` to target name and reference solutions to `Problem.Name-reference.vt*`.
Felix:
* [ ] 1p
* [x] 1pnc
* [x] 1pncmin
* [ ] richards
* [ ] richardsnc
Simon:
* [x] 2p
* [x] 2p1c
* [x] 2p2c
* [x] 2pnc
* [x] 2pncmin
* [x] 3p
* [x] 3p3c
* [x] 3pwateroil
Johannes:
* [x] mpnc
* [x] co2
* [x] tracer
* [x] geomechanics
* [x] discretization (Reverted)
Ned:
* [x] freeflow
* [x] md_boundary
* [x] md_embedded
* [x] md_poromechanics
* [x] md_facet3.0Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1249Resolve "Remove TypeTag from Problem-specific TypeTag definitions"2018-11-02T17:53:47ZMelanie LippResolve "Remove TypeTag from Problem-specific TypeTag definitions"Closes #584Closes #5843.0Simon EmmertSimon Emmerthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1246[test][mpnc] Add grids folder to CMakeLists2018-10-23T16:56:09ZMartin Schneider[test][mpnc] Add grids folder to CMakeLists3.0Simon EmmertSimon Emmerthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1240link to LICENSE.md from README.md2018-10-18T12:51:11ZBernd Flemischlink to LICENSE.md from README.md3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1239Cleanup MultiDomainNewtonSolver2018-10-24T08:35:33ZDennis GläserCleanup MultiDomainNewtonSolverThe way I see it the newton solver class does not receive the time loop anymore but uses the isStationary query from the assembler. This fixes the comment above the constructor and removes the non-compiling constructor from the multidoma...The way I see it the newton solver class does not receive the time loop anymore but uses the isStationary query from the assembler. This fixes the comment above the constructor and removes the non-compiling constructor from the multidomain newton solver.
TODO:
- [ ] run tests3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1238[2p2c][sequential] remove `template` from call to nontemplate functions2018-10-18T11:41:07ZBernd Flemisch[2p2c][sequential] remove `template` from call to nontemplate functions3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1237[test][python] Do not open in binary mode2018-10-17T18:04:12ZTimo Kochtimokoch@math.uio.no[test][python] Do not open in binary mode3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1236[test][python] Fix equality test2018-10-17T17:59:40ZTimo Kochtimokoch@math.uio.no[test][python] Fix equality testWe want to test for equality not identity.We want to test for equality not identity.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1235[cmake] Use labels to mark unit tests2018-11-13T15:34:24ZTimo Kochtimokoch@math.uio.no[cmake] Use labels to mark unit testsThis adds labels to unit tests. This automatically creates a target
`build_unit_tests` or if any other label is used `build_<label>_tests`.
Unfortunately this feature is not included in the Dune 2.6 release branch.
Depends on http...This adds labels to unit tests. This automatically creates a target
`build_unit_tests` or if any other label is used `build_<label>_tests`.
Unfortunately this feature is not included in the Dune 2.6 release branch.
Depends on https://gitlab.dune-project.org/core/dune-common/merge_requests/575 to be merged (backport to dune 2.6)3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1234Add changelog for version update 2.12 >> 3.02018-12-17T10:05:44ZTimo Kochtimokoch@math.uio.noAdd changelog for version update 2.12 >> 3.0Fixes #462.
* [x] Complete changelog
* [x] Add small guide what to change to port a 2.12 problem/spatialparams/main-file
For the guide, I added a wiki entry (not finished). Click "Wiki" on the right, find guide entry on the lef...Fixes #462.
* [x] Complete changelog
* [x] Add small guide what to change to port a 2.12 problem/spatialparams/main-file
For the guide, I added a wiki entry (not finished). Click "Wiki" on the right, find guide entry on the left, or click [here](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/wikis/Updating-programs-from-version-2.12-to-version-3.0)3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1231Feature/user specified solid params in spatial params2018-11-20T10:34:44ZJohannes HommelFeature/user specified solid params in spatial paramsUsing fancy C++ magic, user-specified solid parameters such as heat capacity, thermal conductivity, and solid density can now also be set in the spatial parameter file as was possible in 2.12, overriding the default solid state function ...Using fancy C++ magic, user-specified solid parameters such as heat capacity, thermal conductivity, and solid density can now also be set in the spatial parameter file as was possible in 2.12, overriding the default solid state function calls.
This implements a feature request of Holger, see issue #578.
An example for the solid heat capacity is implemented in /test/porousmediumflow/3p3c/implicit/columnxylolspatialparams.hh, restoring the release 2.12 version.
```cpp
template <class ElementSolution, class SolidState>
Scalar solidHeatCapacity(const Element& element,
const SubControlVolume& scv,
const ElementSolution& elemSol,
const SolidState& solidState) const
{
const auto& globalPos = scv.dofPosition();
if (isFineMaterial_(globalPos))
return fineHeatCap_;
else
return coarseHeatCap_;
}
```
Thus, the test now also only uses an inert solid system and state again as the previous detour of defining two solid components for the sake of having two distinct heat capacities is no longer necessary.
* [x] Document fancy C++ magic in the ni volume variables
Fixes #578.3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1230[porousmediumflow] Port Forchheimer2018-10-11T14:38:05ZKilian Weishaupt[porousmediumflow] Port Forchheimer3.0Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1227[test][navierstokes] Fix test name for CMake dependency2018-09-30T18:17:01ZKilian Weishaupt[test][navierstokes] Fix test name for CMake dependency* was forgotten in recent renaming of tests
* restart test failed because it was not forced to be run after the "regular" test* was forgotten in recent renaming of tests
* restart test failed because it was not forced to be run after the "regular" test3.0Melanie LippMelanie Lipphttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1225[cc][parallel] fix handling of ghosts in local assembler2018-10-22T08:43:20ZBernd Flemisch[cc][parallel] fix handling of ghosts in local assemblerSet the partial derivatives explicitly for ghosts _after_ the
standard values have been calculated.
Fixes #576.Set the partial derivatives explicitly for ghosts _after_ the
standard values have been calculated.
Fixes #576.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1224[elastic][mpfa] fix broken SFINAE constructs2018-10-22T09:34:58ZBernd Flemisch[elastic][mpfa] fix broken SFINAE constructsStore return values explicitly as constexpr. Fixes compilation errors
triggered on specific gcc's.
Fixes #577.Store return values explicitly as constexpr. Fixes compilation errors
triggered on specific gcc's.
Fixes #577.3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1222[params] Make it possible to initialize parameters when not called from main2018-10-18T10:02:51ZTimo Kochtimokoch@math.uio.no[params] Make it possible to initialize parameters when not called from mainWe cannot expect that we always have `argv`,`argc` to initialize the parameters. Also we might wanna run a simulation without input file. Unfortunately, the new interface makes it possible to easily overwrite parameters in every class / ...We cannot expect that we always have `argv`,`argc` to initialize the parameters. Also we might wanna run a simulation without input file. Unfortunately, the new interface makes it possible to easily overwrite parameters in every class / function. The name `init` still suggests that it should be only used to initialize parameters. Do we want such an option for the singleton? AFAIK Fenics also has a global parameter object that can be changed everywhere. This makes it possible to easily change parameters in the main file. However, the feature should never be used in any class as setting the parameter will have hidden side effects on the whole program. Maybe just having a function `init` instead of a function `setParam` documents our intent on how to use it well. By the way, overwriting the params in some class is also possible with the current `init`, it's just inefficient as you overwrite all parameters and have to read the input file again.3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1221[linear][doc] Fix name of linear solver2018-09-10T14:40:40ZTimo Kochtimokoch@math.uio.no[linear][doc] Fix name of linear solver3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1220Fix Staggered IO Fields2018-09-10T09:13:58ZKilian WeishauptFix Staggered IO FieldsThis MR should fix all staggered models. After being merged into feature/iofields, a rebase might be useful.
We still need to decide whether to keep the unit test in the current form or simplify it.This MR should fix all staggered models. After being merged into feature/iofields, a rebase might be useful.
We still need to decide whether to keep the unit test in the current form or simplify it.3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1217[freeflow] Remove wallFunctions from common problem2018-10-11T09:03:30ZKilian Weishaupt[freeflow] Remove wallFunctions from common problem* move to RANS problem* move to RANS problem3.0Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1212Feature/iofields2018-11-12T16:26:11ZTimo Kochtimokoch@math.uio.noFeature/iofieldsfixes #562fixes #5623.0Bernd FlemischBernd Flemisch