dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2018-11-12T21:32:21Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1273[properties] Implement getPropValue as free constexpr function2018-11-12T21:32:21ZTimo Kochtimokoch@math.uio.no[properties] Implement getPropValue as free constexpr function3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1235[cmake] Use labels to mark unit tests2018-11-13T15:34:24ZTimo Kochtimokoch@math.uio.no[cmake] Use labels to mark unit testsThis adds labels to unit tests. This automatically creates a target
`build_unit_tests` or if any other label is used `build_<label>_tests`.
Unfortunately this feature is not included in the Dune 2.6 release branch.
Depends on http...This adds labels to unit tests. This automatically creates a target
`build_unit_tests` or if any other label is used `build_<label>_tests`.
Unfortunately this feature is not included in the Dune 2.6 release branch.
Depends on https://gitlab.dune-project.org/core/dune-common/merge_requests/575 to be merged (backport to dune 2.6)3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1234Add changelog for version update 2.12 >> 3.02018-12-17T10:05:44ZTimo Kochtimokoch@math.uio.noAdd changelog for version update 2.12 >> 3.0Fixes #462.
* [x] Complete changelog
* [x] Add small guide what to change to port a 2.12 problem/spatialparams/main-file
For the guide, I added a wiki entry (not finished). Click "Wiki" on the right, find guide entry on the lef...Fixes #462.
* [x] Complete changelog
* [x] Add small guide what to change to port a 2.12 problem/spatialparams/main-file
For the guide, I added a wiki entry (not finished). Click "Wiki" on the right, find guide entry on the left, or click [here](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/wikis/Updating-programs-from-version-2.12-to-version-3.0)3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1231Feature/user specified solid params in spatial params2018-11-20T10:34:44ZJohannes HommelFeature/user specified solid params in spatial paramsUsing fancy C++ magic, user-specified solid parameters such as heat capacity, thermal conductivity, and solid density can now also be set in the spatial parameter file as was possible in 2.12, overriding the default solid state function ...Using fancy C++ magic, user-specified solid parameters such as heat capacity, thermal conductivity, and solid density can now also be set in the spatial parameter file as was possible in 2.12, overriding the default solid state function calls.
This implements a feature request of Holger, see issue #578.
An example for the solid heat capacity is implemented in /test/porousmediumflow/3p3c/implicit/columnxylolspatialparams.hh, restoring the release 2.12 version.
```cpp
template <class ElementSolution, class SolidState>
Scalar solidHeatCapacity(const Element& element,
const SubControlVolume& scv,
const ElementSolution& elemSol,
const SolidState& solidState) const
{
const auto& globalPos = scv.dofPosition();
if (isFineMaterial_(globalPos))
return fineHeatCap_;
else
return coarseHeatCap_;
}
```
Thus, the test now also only uses an inert solid system and state again as the previous detour of defining two solid components for the sake of having two distinct heat capacities is no longer necessary.
* [x] Document fancy C++ magic in the ni volume variables
Fixes #578.3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1230[porousmediumflow] Port Forchheimer2018-10-11T14:38:05ZKilian Weishaupt[porousmediumflow] Port Forchheimer3.0Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1222[params] Make it possible to initialize parameters when not called from main2018-10-18T10:02:51ZTimo Kochtimokoch@math.uio.no[params] Make it possible to initialize parameters when not called from mainWe cannot expect that we always have `argv`,`argc` to initialize the parameters. Also we might wanna run a simulation without input file. Unfortunately, the new interface makes it possible to easily overwrite parameters in every class / ...We cannot expect that we always have `argv`,`argc` to initialize the parameters. Also we might wanna run a simulation without input file. Unfortunately, the new interface makes it possible to easily overwrite parameters in every class / function. The name `init` still suggests that it should be only used to initialize parameters. Do we want such an option for the singleton? AFAIK Fenics also has a global parameter object that can be changed everywhere. This makes it possible to easily change parameters in the main file. However, the feature should never be used in any class as setting the parameter will have hidden side effects on the whole program. Maybe just having a function `init` instead of a function `setParam` documents our intent on how to use it well. By the way, overwriting the params in some class is also possible with the current `init`, it's just inefficient as you overwrite all parameters and have to read the input file again.3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1212Feature/iofields2018-11-12T16:26:11ZTimo Kochtimokoch@math.uio.noFeature/iofieldsfixes #562fixes #5623.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1211[properties] Add property system implementation without macros and variadic t...2018-10-18T12:35:33ZTimo Kochtimokoch@math.uio.no[properties] Add property system implementation without macros and variadic templatesAn new implementation of the property system with variadic templates and without macros
* variadic (unlimited hierarchy instead of 5 levels)
* uses no class inheritance
* uses no macrosAn new implementation of the property system with variadic templates and without macros
* variadic (unlimited hierarchy instead of 5 levels)
* uses no class inheritance
* uses no macros3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1205[brineco2] reintroduced a gas denstity calculation taking into account compos...2018-09-02T08:55:45ZJohannes Hommel[brineco2] reintroduced a gas denstity calculation taking into account compositional effectsFixes #426. Reintroduced the old compositional calculation as the default, with the option to use the plain CO2::gasDensity.
* [x] Use old reference solution
* [x] Add documentation of new function gasDensity_
* [x] Rename gasDensity_ t...Fixes #426. Reintroduced the old compositional calculation as the default, with the option to use the plain CO2::gasDensity.
* [x] Use old reference solution
* [x] Add documentation of new function gasDensity_
* [x] Rename gasDensity_ to gasDensityMixture_3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1195Cleanup/interfacial areas2018-11-23T07:16:39ZKatharina HeckCleanup/interfacial areas* [x] create test for cctpfa nonequilibrium
* [x] cleanup thermal non-equilibrium localresidual: qBoil is a special case which should not be calculated for all models with 1 liquid energy equation
* [x] for 1 energyequation for the flu...* [x] create test for cctpfa nonequilibrium
* [x] cleanup thermal non-equilibrium localresidual: qBoil is a special case which should not be calculated for all models with 1 liquid energy equation
* [x] for 1 energyequation for the fluid: remove interfacial area calculation from localresidual but instead transfer that to spatialparams/volumevariables
Fixes #555, closes #5663.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1171[test][1pni] Add a test in 1d and remove the one in 2d2018-08-09T09:08:35ZTimo Kochtimokoch@math.uio.no[test][1pni] Add a test in 1d and remove the one in 2dThere are enough other ni convection tests in
1d and there's the 1pni conduction test in 2d.
mpfa test was removed because it doesn't work in 1d but there is also still another one there.There are enough other ni convection tests in
1d and there's the 1pni conduction test in 2d.
mpfa test was removed because it doesn't work in 1d but there is also still another one there.3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1166[common] Add function for generic interpolation2018-08-07T12:08:26ZTimo Kochtimokoch@math.uio.no[common] Add function for generic interpolation3.0Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1153Feature/reuse brine in brine co22018-08-09T12:43:07ZDennis GläserFeature/reuse brine in brine co2Todo:
* [x] after the rebase the tests fail now
Fixes #527.Todo:
* [x] after the rebase the tests fail now
Fixes #527.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1140Feature/2p1c wettability2018-08-16T08:54:18ZSimon EmmertFeature/2p1c wettabilityIntroduced switch depending on formulation for privarswitch in volVars and spatialParams.
* [x] adapt/create tests for changed wettability
Fixes #522
~~**Additionally:** fix bug in 2p volVars with bf82b1e7~~ (already merged to...Introduced switch depending on formulation for privarswitch in volVars and spatialParams.
* [x] adapt/create tests for changed wettability
Fixes #522
~~**Additionally:** fix bug in 2p volVars with bf82b1e7~~ (already merged to master !1173)3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1122Feature/enable ff velocity output per default2018-07-20T14:24:15ZTimo Kochtimokoch@math.uio.noFeature/enable ff velocity output per defaultdepends on !1113.depends on !1113.3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1114Free velocity output of TypeTag2018-07-18T19:55:43ZTimo Kochtimokoch@math.uio.noFree velocity output of TypeTag* [ ] Adapt all test as done for 1pnc / test_angeli* [ ] Adapt all test as done for 1pnc / test_angeli3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1113Free vtkoutputmodule from TypeTag2018-07-20T15:34:29ZKilian WeishauptFree vtkoutputmodule from TypeTagdepends on !1112
see #448.depends on !1112
see #448.3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1106Rename output field temperature -> T for consistency with p and S2018-07-17T05:44:13ZTimo Kochtimokoch@math.uio.noRename output field temperature -> T for consistency with p and S3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1100[test][md][facet] Remove numpy dependency2018-07-13T09:11:26ZTimo Kochtimokoch@math.uio.no[test][md][facet] Remove numpy dependencynumpy is a large dependency which is currently not installed in the testing docker. We might add it in the future but for this test removing the dependency was ok.numpy is a large dependency which is currently not installed in the testing docker. We might add it in the future but for this test removing the dependency was ok.3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1099Feature/haveparam hasparam2018-07-13T09:48:45ZTimo Kochtimokoch@math.uio.noFeature/haveparam hasparam3.0Bernd FlemischBernd Flemisch