dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2018-12-01T11:56:26Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1371[material][co2tables] Add namespace Dumux for typedef2018-12-01T11:56:26ZKilian Weishaupt[material][co2tables] Add namespace Dumux for typedef* fixes compiler error introduced in 55701b332a946c2a52930c1e836a4d07a643d433
@scholz Does doxygen still work with this?* fixes compiler error introduced in 55701b332a946c2a52930c1e836a4d07a643d433
@scholz Does doxygen still work with this?3.0Simon EmmertSimon Emmerthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1370Streamline folder/include structure in discretization2018-12-03T11:03:19ZTimo Kochtimokoch@math.uio.noStreamline folder/include structure in discretization3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1368Feature/improve md traits2018-11-30T09:17:23ZTimo Kochtimokoch@math.uio.noFeature/improve md traitsFix #625 -> necessary preparation for !1350 Fix #625 -> necessary preparation for !1350 3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1367[handbook] update section on propertysystem to new syntax2018-12-04T20:24:51ZGabi Seitz[handbook] update section on propertysystem to new syntax3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1365[fvproblem] Resize the solution vector before applying initial solution2018-11-29T10:23:20ZTimo Kochtimokoch@math.uio.no[fvproblem] Resize the solution vector before applying initial solution* The solution was assumed to be resized before applying the initial solution. I don't think this is safe.
* Resizing has no effect if the size is already the same* The solution was assumed to be resized before applying the initial solution. I don't think this is safe.
* Resizing has no effect if the size is already the same3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1364Fix box pv state at boundary2020-05-27T17:55:28ZKilian WeishauptFix box pv state at boundaryfixes #551
fixes #551
3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1363[tests][references] Update velocity output in reference files2018-11-28T17:42:02ZMartin Schneider[tests][references] Update velocity output in reference files3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1361[discretization] specialize evalSolution for primary variables with state2018-11-30T16:03:12ZBernd Flemisch[discretization] specialize evalSolution for primary variables with stateInterpolating the entries of primary variable vectors by means of shape
functions can be wrong: If the vectors have different states, the entries
can be associated with different physical fields. Since the function
`evalSolution` is p...Interpolating the entries of primary variable vectors by means of shape
functions can be wrong: If the vectors have different states, the entries
can be associated with different physical fields. Since the function
`evalSolution` is physics-agnostic, this presents a simple solution
without adding knowledge about the physics. If the states are different
over all corners of the associated geometry, `evalSolution` returns
the primary variables associated with the vertex that is closest to
the evaluation point.3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1359[params] Improve handling of parameter files2018-11-28T16:43:15ZTimo Kochtimokoch@math.uio.no[params] Improve handling of parameter filesFix #623.
If no parameter file is given look for
* executbale.input
* params.intput
If none are found, try it without parameter file.
If a parameter file is given, let Dune do the error handling,
and check if the file exists....Fix #623.
If no parameter file is given look for
* executbale.input
* params.intput
If none are found, try it without parameter file.
If a parameter file is given, let Dune do the error handling,
and check if the file exists.
Messages are now:
* no parameter file found:
```
No parameter file found. Continuing without parameter file.
ParameterException [init:../dumux/io/grid/gridmanager.hh:407]: Please supply one of the parameters Grid.UpperRight, or a grid file in Grid.File ---> Abort!
```
* parameter file doesn't exist:
```
Reading parameters from file bla.inpuit.
Dune reported error: Dune::IOError [readINITree:../dune/common/parametertreeparser.cc:49]: Could not open configuration file bla.inpuit ---> Abort!
```
which I find better than before. In particular if a program doesn't need a parameter file, there is no error now.3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1358[md][stokesDarcy] Make couplingContext bind itself2018-11-28T17:42:02ZKilian Weishaupt[md][stokesDarcy] Make couplingContext bind itself* if a couplingContext is not yet correctly bound, it now can just
do that itself
* change the signature of some methods to have the element at hand
* update Darcy ref sol velocity
* if a couplingContext is not yet correctly bound, it now can just
do that itself
* change the signature of some methods to have the element at hand
* update Darcy ref sol velocity
3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1357[handbook] updated 'getting started' chapter2018-12-04T19:29:17ZJohannes Hommel[handbook] updated 'getting started' chapter[handbook] updated 'getting started' chapter, split in 'quick start' and 'detailed installation, documentation and externals'
* [x] As discussed, I propose to split the installation instructions into two chapters:
* Quick Start
* De...[handbook] updated 'getting started' chapter, split in 'quick start' and 'detailed installation, documentation and externals'
* [x] As discussed, I propose to split the installation instructions into two chapters:
* Quick Start
* Detailed Installation, Documentation, and Externals
Any objections?3.0Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1354Revert "[veloutput] Remove numDofs function"2018-11-27T23:51:38ZTimo Kochtimokoch@math.uio.noRevert "[veloutput] Remove numDofs function"This reverts commit 17e2a139adcd46fa007c10a8cf026d2410c3504a.
Hopefully fixes #618This reverts commit 17e2a139adcd46fa007c10a8cf026d2410c3504a.
Hopefully fixes #6183.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1353[common] Implement partial function for referencing parts of a tuple2018-11-28T09:35:14ZTimo Kochtimokoch@math.uio.no[common] Implement partial function for referencing parts of a tuple3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1351Cleanup/doxygen for 3.02019-10-07T16:11:27ZSimon EmmertCleanup/doxygen for 3.0When checking doxygen, the doxygen should be built and the doxyerr.log should have as little lines/errors as possible. We currently have around 1800 lines of errors and want to reduce this to 1 to 7 lines.
The Doxygen for a **file** sh...When checking doxygen, the doxygen should be built and the doxyerr.log should have as little lines/errors as possible. We currently have around 1800 lines of errors and want to reduce this to 1 to 7 lines.
The Doxygen for a **file** should look like this:
```
/*!
* \file
* \ingroup Common
* \brief Manages the handling of time dependent problems
*/
```
It should always contain the `\file` first.
The `\ingroup` gives a Group that is as **precise** as possible and is part of the `modules.txt`
The `\brief` is a **short comment** on what happens in the file. Alternatively a `\copybrief` could be used. **Make sure the copybrief links to the correct section and is not ambigous!**
Additional text could be added similar to the function description.
A class could look like this:
```
/*!
* \ingroup Common
* \brief Manages the handling of time dependent problems.
*
* This class facilitates the time management of the simulation.
* It doesn't manage [...]
* [...]
* [...] index starting at 0.
*
* \note Time and time step sizes are in units of seconds
*/
```
The class should always have the proper `\ingroup` just like the file.
The `\brief` should always contain a **short description**, and only in very very rare occasions a class can have a `\copybrief`. In the end this is also documentation for users that do not build doxygen and `\copybriefs` from another file are most likely not very useful.
The main part should be an in depth explanation of what is done. This should contain math-expressions where applicable. They can look like the following:
```
* This class implements a spline \f$s(x)\f$ for which, given \f$n\f$ sampling
* points \f$x_1, \dots, x_n\f$, the following conditions hold
*\f{align*}{
s(x_i) & = y_i \quad \forall i \in \{1, \dots, n \}\\
s'(x_1) & = m_1 \\
s'(x_n) & = m_n
\f}
*
```
For a **function** in a file the Doxygen can look like this:
```
/*!
* \brief Set the current simulated time and the time step index.
*
* \param t The time \f$\mathrm{[s]}\f$ which should be jumped to
* \param stepIdx The new time step index
*/
void setTime(Scalar t, int stepIdx)
{ time_ = t; timeStepIdx_ = stepIdx; }
```
The function has a **short comment** with the `\brief`.
If there are **function-arguments** that are not self-explanatory, they should be described using `\param`.** Always explain all params or no params at all!** Otherwise Doxygen will throw an error.
Additional Doxygen-commands that might be useful are `\note` for giving an important note/hint on what the function does as well as `\return` which specifies the return value (if applicable).
We will go through the errors according to folders:
* [x] freeflow (262) @nedc
* [x] material (209) @ackerm
* [x] multidomain (168)
* [x] porousmediumflow (558) @scholz
* [x] common, discretization, geomechanics @hommel
* [ ] nonlinear,io,linear, material, nonlinear, parallel
Fix/Document everything according to the guideline. If there is a problem with a copybrief try to fix it or contact @scholz for help.
Closes #5963.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1350Multidomain wrappers to easier write main files2018-11-30T11:07:46ZTimo Kochtimokoch@math.uio.noMultidomain wrappers to easier write main files* wrapper for grid variables for multidomain (when it's more than two it already gets nasty in the main file)
* wrapper for vtk output module
The same could be done for problems, grid geometry. I think, there is more such classes it ...* wrapper for grid variables for multidomain (when it's more than two it already gets nasty in the main file)
* wrapper for vtk output module
The same could be done for problems, grid geometry. I think, there is more such classes it would get even shorter as all the type aliases are hidden too.
It gives nasty compiler errors though, if e.g. you put in the wrong type the message is crazy long because of those Hybrid::forEaches.
!1365 should be merged first.
!1368 should be merged first.3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1349[bugfix] Fix typo2018-11-27T17:48:42ZTimo Kochtimokoch@math.uio.no[bugfix] Fix typoFix #617 Fix #616 Corrects the typo introduced in aca9cfd55faee5e8cd4d14e5c678978de79a4c0b that caused a compiler errorFix #617 Fix #616 Corrects the typo introduced in aca9cfd55faee5e8cd4d14e5c678978de79a4c0b that caused a compiler error3.0Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1346[gitignore] Add synctex.gz latex files2018-11-27T14:05:10ZTimo Kochtimokoch@math.uio.no[gitignore] Add synctex.gz latex files3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1345[vtk] Only assume parallel vtk if the file extension starts with p2018-11-27T18:27:44ZTimo Kochtimokoch@math.uio.no[vtk] Only assume parallel vtk if the file extension starts with p3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1342[bin] Make property script executbale2018-11-27T09:35:03ZTimo Kochtimokoch@math.uio.no[bin] Make property script executbale3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1341[md][newtonsolver] Fix compiler error with c++142018-11-27T10:24:01ZKilian Weishaupt[md][newtonsolver] Fix compiler error with c++14* id is not constexpr* id is not constexpr3.0Ned ColtmanNed Coltman