dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2018-11-26T15:34:56Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1331[upwind] Rename parameter from Implicit.UpwindWeight to Flux.UpwindWeight2018-11-26T15:34:56ZTimo Kochtimokoch@math.uio.no[upwind] Rename parameter from Implicit.UpwindWeight to Flux.UpwindWeightFix #605Fix #6053.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1330Feature/improve privar switch2018-11-26T16:13:43ZTimo Kochtimokoch@math.uio.noFeature/improve privar switchFix #580.
todo:
- [x] Check all models/tests
- [x] Check/adapt dumux-lecture main files (see dumux-lecture!50)Fix #580.
todo:
- [x] Check all models/tests
- [x] Check/adapt dumux-lecture main files (see dumux-lecture!50)3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1328Remove unused function isWall.2018-11-24T17:37:17ZMelanie LippRemove unused function isWall.3.0Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1327Freeflow/lateraladvectiveflux pressurecheck2018-11-26T16:15:33ZNed ColtmanFreeflow/lateraladvectiveflux pressurecheck* [x] Add check for a dirichlet pressure conditions when developing the lateral advective fluxes.* [x] Add check for a dirichlet pressure conditions when developing the lateral advective fluxes.3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1326Freeflow/convergencescript cleanup2018-11-27T13:04:15ZNed ColtmanFreeflow/convergencescript cleanup* [x] In the convergence script, label the velocity components and change x-axis title
* [x] In the convergence script, label adapt the reference order lines to show the proper slope, regardless of the number of decades shown in the p...* [x] In the convergence script, label the velocity components and change x-axis title
* [x] In the convergence script, label adapt the reference order lines to show the proper slope, regardless of the number of decades shown in the plot.
Closes #611 3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1325Feature/mpfa-scv-gradient-reconstruction2018-12-04T16:24:44ZDennis GläserFeature/mpfa-scv-gradient-reconstructionIntroduces functionality to reconstruct gradients and velocities on the mpfa dual grid sub-control volumes.
Has to wait for !1286 Introduces functionality to reconstruct gradients and velocities on the mpfa dual grid sub-control volumes.
Has to wait for !1286 3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1321Fix/co2nitests2018-11-23T01:10:13ZTimo Kochtimokoch@math.uio.noFix/co2nitests3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1320Feature/velocity output with mpfa2018-11-23T15:56:03ZDennis GläserFeature/velocity output with mpfaTODO:
- [x] There seems to be an issue at corners where Dirichlet and Neumann Bcs meet
TODO:
- [x] There seems to be an issue at corners where Dirichlet and Neumann Bcs meet
3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1319Fix/velocity output2018-11-27T23:56:52ZMartin SchneiderFix/velocity outputFix #594 Fix #594 3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1318[brine] Remove default for constant salinty2018-11-27T23:56:15ZTimo Kochtimokoch@math.uio.no[brine] Remove default for constant salintyFixes #607Fixes #6073.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1317[Rans][OneEq] Missing outflow condition for one eq model, updated reference2018-11-22T18:57:53ZNed Coltman[Rans][OneEq] Missing outflow condition for one eq model, updated referenceThe boundary condition for the RANS one-eq model's variable (ViscosityTilde) is incorrectly set. No condition was set for this variable at the outflow, so a Dirichlet boundary is incorrectly assigned. All other tests including the one-eq...The boundary condition for the RANS one-eq model's variable (ViscosityTilde) is incorrectly set. No condition was set for this variable at the outflow, so a Dirichlet boundary is incorrectly assigned. All other tests including the one-eq RANS model set an outflow condition for this variable.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1316[fix] headercheck2018-11-21T21:19:34ZTimo Kochtimokoch@math.uio.no[fix] headercheck3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1315[component] Remove defaults from constant component2018-11-26T14:12:37ZTimo Kochtimokoch@math.uio.no[component] Remove defaults from constant componentFix #579 where is was noted that 1.0 as default is more a disadvantage
than an advantage. Just specify 1.0 in the input file explicitly
instead. For examples typos in the input files could be unnoticed.
* Remove the default for cons...Fix #579 where is was noted that 1.0 as default is more a disadvantage
than an advantage. Just specify 1.0 in the input file explicitly
instead. For examples typos in the input files could be unnoticed.
* Remove the default for constant component
* Do not set molar density if it's not used and not returned in any interface (fixes #608)
* Do not output molar density in navierstokes non-compositional models (fixes #608), adjust references (remove rhoMolar)
* Fuelcellni test had the wrong solid phase properties -> fixed parameters and adjusted reference solution
* Sagd test had a typo in the input file -> fixed typo and adjusted reference solution3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1314[cmake] Remove nonexistent files2018-11-21T18:39:09ZTimo Kochtimokoch@math.uio.no[cmake] Remove nonexistent files3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1313Cleanup multidomain boundary tests2018-11-30T11:18:21ZKilian WeishauptCleanup multidomain boundary tests* Use the new `partial()` function in the main files
* Remove unnecessary folder structure and reduce number of executables
* General clean-up* Use the new `partial()` function in the main files
* Remove unnecessary folder structure and reduce number of executables
* General clean-up3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1312[staggered] Depreate GridVariables::init with two arguments2018-11-21T18:55:40ZTimo Kochtimokoch@math.uio.no[staggered] Depreate GridVariables::init with two arguments3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1311[flux] Create new flux folder move headers2018-12-01T11:15:43ZTimo Kochtimokoch@math.uio.no[flux] Create new flux folder move headersFixes #606 Fixes #606 3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1310[cmake] Fix install functions2018-11-21T15:52:26ZTimo Kochtimokoch@math.uio.no[cmake] Fix install functions3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1309Use Dune::is_detected2018-11-21T14:09:46ZKilian WeishauptUse Dune::is_detectedfixes #602
Dune2.6 already provides a fallback implementation of `std::is_detected` (C++17).
We can use this to replace the rather lengthy and complicated `isValid()` method.
It is substantially less typing and easier to read. Ho...fixes #602
Dune2.6 already provides a fallback implementation of `std::is_detected` (C++17).
We can use this to replace the rather lengthy and complicated `isValid()` method.
It is substantially less typing and easier to read. However, you need two helper structs instead of one (but each one being a one-liner).
Also seems to work with gcc5.53.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1308[fix/cakegridcreator] Last element is only connected with the first one for 360°2018-11-22T21:08:43ZTimo Kochtimokoch@math.uio.no[fix/cakegridcreator] Last element is only connected with the first one for 360°* [x] Add test for 2D with vtk comparison (compile time)
* [x] Make sure test runs for 360 and less than 360 with vtk comparison (run time) for both 2D and 3D
fixes #601* [x] Add test for 2D with vtk comparison (compile time)
* [x] Make sure test runs for 360 and less than 360 with vtk comparison (run time) for both 2D and 3D
fixes #6013.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no