dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2018-11-21T15:52:26Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1310[cmake] Fix install functions2018-11-21T15:52:26ZTimo Kochtimokoch@math.uio.no[cmake] Fix install functions3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1309Use Dune::is_detected2018-11-21T14:09:46ZKilian WeishauptUse Dune::is_detectedfixes #602
Dune2.6 already provides a fallback implementation of `std::is_detected` (C++17).
We can use this to replace the rather lengthy and complicated `isValid()` method.
It is substantially less typing and easier to read. Ho...fixes #602
Dune2.6 already provides a fallback implementation of `std::is_detected` (C++17).
We can use this to replace the rather lengthy and complicated `isValid()` method.
It is substantially less typing and easier to read. However, you need two helper structs instead of one (but each one being a one-liner).
Also seems to work with gcc5.53.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1308[fix/cakegridcreator] Last element is only connected with the first one for 360°2018-11-22T21:08:43ZTimo Kochtimokoch@math.uio.no[fix/cakegridcreator] Last element is only connected with the first one for 360°* [x] Add test for 2D with vtk comparison (compile time)
* [x] Make sure test runs for 360 and less than 360 with vtk comparison (run time) for both 2D and 3D
fixes #601* [x] Add test for 2D with vtk comparison (compile time)
* [x] Make sure test runs for 360 and less than 360 with vtk comparison (run time) for both 2D and 3D
fixes #6013.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1306[gridvars] Unify for stationary and instationary problems2018-11-21T14:20:17ZTimo Kochtimokoch@math.uio.no[gridvars] Unify for stationary and instationary problems* Always initialize prevGridVolVars
* Means memory overhead for stationary problems with caching (but caching means I have enough memory anyway)
* Greatly simplifies usage
* Deprecate for now and can be implemented on dumux day
* Fix...* Always initialize prevGridVolVars
* Means memory overhead for stationary problems with caching (but caching means I have enough memory anyway)
* Greatly simplifies usage
* Deprecate for now and can be implemented on dumux day
* Fixes md facet explicit transport test3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1305[ni] Remove unused alias2018-11-20T08:59:11ZTimo Kochtimokoch@math.uio.no[ni] Remove unused aliasSpatialParams is not exported by all traitsSpatialParams is not exported by all traits3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1304[cleanup] Improve index types2018-12-09T17:40:09ZTimo Kochtimokoch@math.uio.no[cleanup] Improve index typesFixes #358.Fixes #358.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1303[test][navierstokesnc] Use different executables for caching on/off2018-11-19T18:12:22ZKilian Weishaupt[test][navierstokesnc] Use different executables for caching on/off3.0Sina AckermannSina Ackermannhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1300Provide a script that replaces property macro usages2018-11-19T18:10:43ZBernd FlemischProvide a script that replaces property macro usagesFixes #593.Fixes #593.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1298Restructure mpfa flux caches2018-11-22T17:01:29ZDennis GläserRestructure mpfa flux cachesThe main improvement is that the process-dependent flux variable caches are much smaller now, only storing a pointer to the respective interaction volume data handle class. From there, all necessary information can be obtained. Also, thi...The main improvement is that the process-dependent flux variable caches are much smaller now, only storing a pointer to the respective interaction volume data handle class. From there, all necessary information can be obtained. Also, this data now also comprises everything necessary for face unknown reconstruction and gradient evaluations on scvs.
Todo:
- [x] use correct sol-dependence flag in heat conduction filler
- [x] store omegas in data handle as well (required for gradient reconstruction)
- [x] use static interaction volume in some test
Possibility of including Neumann boundary conditions into the local system of equations as well as face unknown & gradients reconstruction will be done in the near future on a separate branch.3.0Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1297[test][el1p] Replace deprecated IOFields::init with initOutputModule2018-11-15T23:07:13ZTimo Kochtimokoch@math.uio.no[test][el1p] Replace deprecated IOFields::init with initOutputModule3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1296Replace propertysystem macros2018-11-18T20:27:36ZBernd FlemischReplace propertysystem macrosExecutes the measures described in #593.Executes the measures described in #593.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1291[CMake] Added labels for freeflow and rans tests2018-11-14T11:00:54ZNed Coltman[CMake] Added labels for freeflow and rans tests3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1290Feature/fvgeometry boundary2018-11-18T21:15:54ZKilian WeishauptFeature/fvgeometry boundary3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1289[test][md][label] Add multidomain label to multidomain tests2018-11-13T17:52:29ZTimo Kochtimokoch@math.uio.no[test][md][label] Add multidomain label to multidomain tests3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1288Feature/md explicit assembler2018-11-15T23:02:44ZDennis GläserFeature/md explicit assemblerSteps to do:
- [x] cleanup of md-cc-localassembler
- [x] add documentation
- [x] introduce explicit local assembler
- [x] implement tpfa test
- [x] try to reuse cc-explicit-local assembler (assembly routine is essentially the same) -> __...Steps to do:
- [x] cleanup of md-cc-localassembler
- [x] add documentation
- [x] introduce explicit local assembler
- [x] implement tpfa test
- [x] try to reuse cc-explicit-local assembler (assembly routine is essentially the same) -> __discarded__
- [x] implement box-explicit multidomain local assembler
- [x] implement test for box
- [x] use new namings/folders according to !1284
- [x] add reference files to tests
Fixes #521 3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1287[discretization] Rename header methods.hh to method.hh2018-11-13T17:29:14ZKilian Weishaupt[discretization] Rename header methods.hh to method.hhfixes #572fixes #5723.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1286[cc/staggered] Do not cache Dirichlet volVars2018-12-03T09:10:58ZKilian Weishaupt[cc/staggered] Do not cache Dirichlet volVarsfixes #545 fixes #545 3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1285Cleanup/md remove setcouplingmgr2018-11-13T16:12:53ZKilian WeishauptCleanup/md remove setcouplingmgrfixes #564fixes #5643.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1284Cleanup/apply naming scheme to tests2018-11-14T13:09:07ZNed ColtmanCleanup/apply naming scheme to testsGeneral Plan:
1. Rename targets.
2. Reorganize such that only one `.cc` file exists per folder, rename to `main.cc`, `problem.hh`, `spatialparams.hh` and `params.input`. Differentiate by adding `_xxx` if necessary, e.g. `problem_darcy.h...General Plan:
1. Rename targets.
2. Reorganize such that only one `.cc` file exists per folder, rename to `main.cc`, `problem.hh`, `spatialparams.hh` and `params.input`. Differentiate by adding `_xxx` if necessary, e.g. `problem_darcy.hh` and `problem_stokes.hh` in a multidomain test.
3. Rename `Problem.Name` to target name and reference solutions to `Problem.Name-reference.vt*`.
Felix:
* [x] 1p
* [x] 1pnc
* [x] 1pncmin
* [x] richards
* [x] richardsnc
Simon:
* [x] 2p
* [x] 2p1c
* [x] 2p2c
* [x] 2pnc
* [x] 2pncmin
* [x] 3p
* [x] 3p3c
* [x] 3pwateroil
Johannes:
* [x] mpnc
* [x] co2
* [x] tracer
* [x] geomechanics
* [x] discretization (Reverted)
Ned:
* [x] freeflow
* [x] md_boundary
* [x] md_embedded
* [x] md_poromechanics
* [x] md_facet3.0Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1283Feature/test facetcoupling xi2018-12-04T15:30:32ZDennis GläserFeature/test facetcoupling xiHas to wait for !1284 and !1285 and adapt the test names/implementations accordingly.
TODO:
- [x] Implement gravity handling for xi != 1.0
- [x] add tests for gravity and various xis
Implementation of gravity handling on surface ...Has to wait for !1284 and !1285 and adapt the test names/implementations accordingly.
TODO:
- [x] Implement gravity handling for xi != 1.0
- [x] add tests for gravity and various xis
Implementation of gravity handling on surface grids will be done separately at one point towards Milestone 3.1 (see #591).3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.no