dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2018-11-26T15:34:56Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1331[upwind] Rename parameter from Implicit.UpwindWeight to Flux.UpwindWeight2018-11-26T15:34:56ZTimo Kochtimokoch@math.uio.no[upwind] Rename parameter from Implicit.UpwindWeight to Flux.UpwindWeightFix #605Fix #6053.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1315[component] Remove defaults from constant component2018-11-26T14:12:37ZTimo Kochtimokoch@math.uio.no[component] Remove defaults from constant componentFix #579 where is was noted that 1.0 as default is more a disadvantage
than an advantage. Just specify 1.0 in the input file explicitly
instead. For examples typos in the input files could be unnoticed.
* Remove the default for cons...Fix #579 where is was noted that 1.0 as default is more a disadvantage
than an advantage. Just specify 1.0 in the input file explicitly
instead. For examples typos in the input files could be unnoticed.
* Remove the default for constant component
* Do not set molar density if it's not used and not returned in any interface (fixes #608)
* Do not output molar density in navierstokes non-compositional models (fixes #608), adjust references (remove rhoMolar)
* Fuelcellni test had the wrong solid phase properties -> fixed parameters and adjusted reference solution
* Sagd test had a typo in the input file -> fixed typo and adjusted reference solution3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1335Cleanup freeflow tests2018-11-26T11:49:54ZKilian WeishauptCleanup freeflow tests3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1334Remove primaryVariableName() from model traits2018-11-26T08:25:51ZKilian WeishauptRemove primaryVariableName() from model traits3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1333[cleanup] Fix #613 deprecation warnings from gridvars->init2018-11-25T11:07:37ZTimo Kochtimokoch@math.uio.no[cleanup] Fix #613 deprecation warnings from gridvars->init3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1328Remove unused function isWall.2018-11-24T17:37:17ZMelanie LippRemove unused function isWall.3.0Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1020Stokes-darcy coupling with maxwell stefan difusion2018-11-23T16:15:19ZKatharina HeckStokes-darcy coupling with maxwell stefan difusion* [x] test if solution is the same as ficks when using 2 components
* [x] specialize if Ficks Law or Maxwell Stefan should be used. This might be done when choosing the Diffusion Law.
* [x] include check making sure that diffusion Law...* [x] test if solution is the same as ficks when using 2 components
* [x] specialize if Ficks Law or Maxwell Stefan should be used. This might be done when choosing the Diffusion Law.
* [x] include check making sure that diffusion Law is the same in pm and ff
* [x] set up test with maxwell stefan and 3 components3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1320Feature/velocity output with mpfa2018-11-23T15:56:03ZDennis GläserFeature/velocity output with mpfaTODO:
- [x] There seems to be an issue at corners where Dirichlet and Neumann Bcs meet
TODO:
- [x] There seems to be an issue at corners where Dirichlet and Neumann Bcs meet
3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1195Cleanup/interfacial areas2018-11-23T07:16:39ZKatharina HeckCleanup/interfacial areas* [x] create test for cctpfa nonequilibrium
* [x] cleanup thermal non-equilibrium localresidual: qBoil is a special case which should not be calculated for all models with 1 liquid energy equation
* [x] for 1 energyequation for the flu...* [x] create test for cctpfa nonequilibrium
* [x] cleanup thermal non-equilibrium localresidual: qBoil is a special case which should not be calculated for all models with 1 liquid energy equation
* [x] for 1 energyequation for the fluid: remove interfacial area calculation from localresidual but instead transfer that to spatialparams/volumevariables
Fixes #555, closes #5663.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1321Fix/co2nitests2018-11-23T01:10:13ZTimo Kochtimokoch@math.uio.noFix/co2nitests3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1308[fix/cakegridcreator] Last element is only connected with the first one for 360°2018-11-22T21:08:43ZTimo Kochtimokoch@math.uio.no[fix/cakegridcreator] Last element is only connected with the first one for 360°* [x] Add test for 2D with vtk comparison (compile time)
* [x] Make sure test runs for 360 and less than 360 with vtk comparison (run time) for both 2D and 3D
fixes #601* [x] Add test for 2D with vtk comparison (compile time)
* [x] Make sure test runs for 360 and less than 360 with vtk comparison (run time) for both 2D and 3D
fixes #6013.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1317[Rans][OneEq] Missing outflow condition for one eq model, updated reference2018-11-22T18:57:53ZNed Coltman[Rans][OneEq] Missing outflow condition for one eq model, updated referenceThe boundary condition for the RANS one-eq model's variable (ViscosityTilde) is incorrectly set. No condition was set for this variable at the outflow, so a Dirichlet boundary is incorrectly assigned. All other tests including the one-eq...The boundary condition for the RANS one-eq model's variable (ViscosityTilde) is incorrectly set. No condition was set for this variable at the outflow, so a Dirichlet boundary is incorrectly assigned. All other tests including the one-eq RANS model set an outflow condition for this variable.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1298Restructure mpfa flux caches2018-11-22T17:01:29ZDennis GläserRestructure mpfa flux cachesThe main improvement is that the process-dependent flux variable caches are much smaller now, only storing a pointer to the respective interaction volume data handle class. From there, all necessary information can be obtained. Also, thi...The main improvement is that the process-dependent flux variable caches are much smaller now, only storing a pointer to the respective interaction volume data handle class. From there, all necessary information can be obtained. Also, this data now also comprises everything necessary for face unknown reconstruction and gradient evaluations on scvs.
Todo:
- [x] use correct sol-dependence flag in heat conduction filler
- [x] store omegas in data handle as well (required for gradient reconstruction)
- [x] use static interaction volume in some test
Possibility of including Neumann boundary conditions into the local system of equations as well as face unknown & gradients reconstruction will be done in the near future on a separate branch.3.0Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1316[fix] headercheck2018-11-21T21:19:34ZTimo Kochtimokoch@math.uio.no[fix] headercheck3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1312[staggered] Depreate GridVariables::init with two arguments2018-11-21T18:55:40ZTimo Kochtimokoch@math.uio.no[staggered] Depreate GridVariables::init with two arguments3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1314[cmake] Remove nonexistent files2018-11-21T18:39:09ZTimo Kochtimokoch@math.uio.no[cmake] Remove nonexistent files3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1310[cmake] Fix install functions2018-11-21T15:52:26ZTimo Kochtimokoch@math.uio.no[cmake] Fix install functions3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1306[gridvars] Unify for stationary and instationary problems2018-11-21T14:20:17ZTimo Kochtimokoch@math.uio.no[gridvars] Unify for stationary and instationary problems* Always initialize prevGridVolVars
* Means memory overhead for stationary problems with caching (but caching means I have enough memory anyway)
* Greatly simplifies usage
* Deprecate for now and can be implemented on dumux day
* Fix...* Always initialize prevGridVolVars
* Means memory overhead for stationary problems with caching (but caching means I have enough memory anyway)
* Greatly simplifies usage
* Deprecate for now and can be implemented on dumux day
* Fixes md facet explicit transport test3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1309Use Dune::is_detected2018-11-21T14:09:46ZKilian WeishauptUse Dune::is_detectedfixes #602
Dune2.6 already provides a fallback implementation of `std::is_detected` (C++17).
We can use this to replace the rather lengthy and complicated `isValid()` method.
It is substantially less typing and easier to read. Ho...fixes #602
Dune2.6 already provides a fallback implementation of `std::is_detected` (C++17).
We can use this to replace the rather lengthy and complicated `isValid()` method.
It is substantially less typing and easier to read. However, you need two helper structs instead of one (but each one being a one-liner).
Also seems to work with gcc5.53.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1302[test] Make grid variables instationary2018-11-20T13:58:30ZTimo Kochtimokoch@math.uio.no[test] Make grid variables instationary* The test fails on buildbot due to an assert (the grid vars are not instationary)
However simply removing the assert still makes the test pass.
This raises the question if this should be an error __or__ if we can find a better solut...* The test fails on buildbot due to an assert (the grid vars are not instationary)
However simply removing the assert still makes the test pass.
This raises the question if this should be an error __or__ if we can find a better solution. I think we could also always set the previous volvars in `init` to the current volvars and just not use them for stationary runs (memory overhead).
@DennisGlaeser any ideas for a better solution?3.0Dennis GläserDennis Gläser