dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2018-12-01T11:56:26Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1371[material][co2tables] Add namespace Dumux for typedef2018-12-01T11:56:26ZKilian Weishaupt[material][co2tables] Add namespace Dumux for typedef* fixes compiler error introduced in 55701b332a946c2a52930c1e836a4d07a643d433
@scholz Does doxygen still work with this?* fixes compiler error introduced in 55701b332a946c2a52930c1e836a4d07a643d433
@scholz Does doxygen still work with this?3.0Simon EmmertSimon Emmerthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1364Fix box pv state at boundary2020-05-27T17:55:28ZKilian WeishauptFix box pv state at boundaryfixes #551
fixes #551
3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1361[discretization] specialize evalSolution for primary variables with state2018-11-30T16:03:12ZBernd Flemisch[discretization] specialize evalSolution for primary variables with stateInterpolating the entries of primary variable vectors by means of shape
functions can be wrong: If the vectors have different states, the entries
can be associated with different physical fields. Since the function
`evalSolution` is p...Interpolating the entries of primary variable vectors by means of shape
functions can be wrong: If the vectors have different states, the entries
can be associated with different physical fields. Since the function
`evalSolution` is physics-agnostic, this presents a simple solution
without adding knowledge about the physics. If the states are different
over all corners of the associated geometry, `evalSolution` returns
the primary variables associated with the vertex that is closest to
the evaluation point.3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1358[md][stokesDarcy] Make couplingContext bind itself2018-11-28T17:42:02ZKilian Weishaupt[md][stokesDarcy] Make couplingContext bind itself* if a couplingContext is not yet correctly bound, it now can just
do that itself
* change the signature of some methods to have the element at hand
* update Darcy ref sol velocity
* if a couplingContext is not yet correctly bound, it now can just
do that itself
* change the signature of some methods to have the element at hand
* update Darcy ref sol velocity
3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1354Revert "[veloutput] Remove numDofs function"2018-11-27T23:51:38ZTimo Kochtimokoch@math.uio.noRevert "[veloutput] Remove numDofs function"This reverts commit 17e2a139adcd46fa007c10a8cf026d2410c3504a.
Hopefully fixes #618This reverts commit 17e2a139adcd46fa007c10a8cf026d2410c3504a.
Hopefully fixes #6183.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1349[bugfix] Fix typo2018-11-27T17:48:42ZTimo Kochtimokoch@math.uio.no[bugfix] Fix typoFix #617 Fix #616 Corrects the typo introduced in aca9cfd55faee5e8cd4d14e5c678978de79a4c0b that caused a compiler errorFix #617 Fix #616 Corrects the typo introduced in aca9cfd55faee5e8cd4d14e5c678978de79a4c0b that caused a compiler error3.0Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1345[vtk] Only assume parallel vtk if the file extension starts with p2018-11-27T18:27:44ZTimo Kochtimokoch@math.uio.no[vtk] Only assume parallel vtk if the file extension starts with p3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1341[md][newtonsolver] Fix compiler error with c++142018-11-27T10:24:01ZKilian Weishaupt[md][newtonsolver] Fix compiler error with c++14* id is not constexpr* id is not constexpr3.0Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1340[test][md][stokesdarcy1p2c2p2cni] Use realistic non-isothermal soil properties2018-11-27T12:06:16ZKilian Weishaupt[test][md][stokesdarcy1p2c2p2cni] Use realistic non-isothermal soil properties* update ref sol
fixes #614* update ref sol
fixes #6143.0Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1332Fix/1pnc usemoles2018-11-26T16:55:01ZTimo Kochtimokoch@math.uio.noFix/1pnc usemolesFix #582Fix #5823.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1321Fix/co2nitests2018-11-23T01:10:13ZTimo Kochtimokoch@math.uio.noFix/co2nitests3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1319Fix/velocity output2018-11-27T23:56:52ZMartin SchneiderFix/velocity outputFix #594 Fix #594 3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1317[Rans][OneEq] Missing outflow condition for one eq model, updated reference2018-11-22T18:57:53ZNed Coltman[Rans][OneEq] Missing outflow condition for one eq model, updated referenceThe boundary condition for the RANS one-eq model's variable (ViscosityTilde) is incorrectly set. No condition was set for this variable at the outflow, so a Dirichlet boundary is incorrectly assigned. All other tests including the one-eq...The boundary condition for the RANS one-eq model's variable (ViscosityTilde) is incorrectly set. No condition was set for this variable at the outflow, so a Dirichlet boundary is incorrectly assigned. All other tests including the one-eq RANS model set an outflow condition for this variable.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1316[fix] headercheck2018-11-21T21:19:34ZTimo Kochtimokoch@math.uio.no[fix] headercheck3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1310[cmake] Fix install functions2018-11-21T15:52:26ZTimo Kochtimokoch@math.uio.no[cmake] Fix install functions3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1309Use Dune::is_detected2018-11-21T14:09:46ZKilian WeishauptUse Dune::is_detectedfixes #602
Dune2.6 already provides a fallback implementation of `std::is_detected` (C++17).
We can use this to replace the rather lengthy and complicated `isValid()` method.
It is substantially less typing and easier to read. Ho...fixes #602
Dune2.6 already provides a fallback implementation of `std::is_detected` (C++17).
We can use this to replace the rather lengthy and complicated `isValid()` method.
It is substantially less typing and easier to read. However, you need two helper structs instead of one (but each one being a one-liner).
Also seems to work with gcc5.53.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1308[fix/cakegridcreator] Last element is only connected with the first one for 360°2018-11-22T21:08:43ZTimo Kochtimokoch@math.uio.no[fix/cakegridcreator] Last element is only connected with the first one for 360°* [x] Add test for 2D with vtk comparison (compile time)
* [x] Make sure test runs for 360 and less than 360 with vtk comparison (run time) for both 2D and 3D
fixes #601* [x] Add test for 2D with vtk comparison (compile time)
* [x] Make sure test runs for 360 and less than 360 with vtk comparison (run time) for both 2D and 3D
fixes #6013.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1305[ni] Remove unused alias2018-11-20T08:59:11ZTimo Kochtimokoch@math.uio.no[ni] Remove unused aliasSpatialParams is not exported by all traitsSpatialParams is not exported by all traits3.0https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1303[test][navierstokesnc] Use different executables for caching on/off2018-11-19T18:12:22ZKilian Weishaupt[test][navierstokesnc] Use different executables for caching on/off3.0Sina AckermannSina Ackermannhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1302[test] Make grid variables instationary2018-11-20T13:58:30ZTimo Kochtimokoch@math.uio.no[test] Make grid variables instationary* The test fails on buildbot due to an assert (the grid vars are not instationary)
However simply removing the assert still makes the test pass.
This raises the question if this should be an error __or__ if we can find a better solut...* The test fails on buildbot due to an assert (the grid vars are not instationary)
However simply removing the assert still makes the test pass.
This raises the question if this should be an error __or__ if we can find a better solution. I think we could also always set the previous volvars in `init` to the current volvars and just not use them for stationary runs (memory overhead).
@DennisGlaeser any ideas for a better solution?3.0Dennis GläserDennis Gläser