dumux merge requestshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests2018-10-17T18:04:12Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1237[test][python] Do not open in binary mode2018-10-17T18:04:12ZTimo Kochtimokoch@math.uio.no[test][python] Do not open in binary mode3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1236[test][python] Fix equality test2018-10-17T17:59:40ZTimo Kochtimokoch@math.uio.no[test][python] Fix equality testWe want to test for equality not identity.We want to test for equality not identity.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1235[cmake] Use labels to mark unit tests2018-11-13T15:34:24ZTimo Kochtimokoch@math.uio.no[cmake] Use labels to mark unit testsThis adds labels to unit tests. This automatically creates a target
`build_unit_tests` or if any other label is used `build_<label>_tests`.
Unfortunately this feature is not included in the Dune 2.6 release branch.
Depends on http...This adds labels to unit tests. This automatically creates a target
`build_unit_tests` or if any other label is used `build_<label>_tests`.
Unfortunately this feature is not included in the Dune 2.6 release branch.
Depends on https://gitlab.dune-project.org/core/dune-common/merge_requests/575 to be merged (backport to dune 2.6)3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1234Add changelog for version update 2.12 >> 3.02018-12-17T10:05:44ZTimo Kochtimokoch@math.uio.noAdd changelog for version update 2.12 >> 3.0Fixes #462.
* [x] Complete changelog
* [x] Add small guide what to change to port a 2.12 problem/spatialparams/main-file
For the guide, I added a wiki entry (not finished). Click "Wiki" on the right, find guide entry on the lef...Fixes #462.
* [x] Complete changelog
* [x] Add small guide what to change to port a 2.12 problem/spatialparams/main-file
For the guide, I added a wiki entry (not finished). Click "Wiki" on the right, find guide entry on the left, or click [here](https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/wikis/Updating-programs-from-version-2.12-to-version-3.0)3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1233Fix/periodic boundaries2018-10-17T15:21:40ZDennis GläserFix/periodic boundariesThe BoxFVGridGeometry in case of caching was not equipped with the return function for the index map.The BoxFVGridGeometry in case of caching was not equipped with the return function for the index map.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1231Feature/user specified solid params in spatial params2018-11-20T10:34:44ZJohannes HommelFeature/user specified solid params in spatial paramsUsing fancy C++ magic, user-specified solid parameters such as heat capacity, thermal conductivity, and solid density can now also be set in the spatial parameter file as was possible in 2.12, overriding the default solid state function ...Using fancy C++ magic, user-specified solid parameters such as heat capacity, thermal conductivity, and solid density can now also be set in the spatial parameter file as was possible in 2.12, overriding the default solid state function calls.
This implements a feature request of Holger, see issue #578.
An example for the solid heat capacity is implemented in /test/porousmediumflow/3p3c/implicit/columnxylolspatialparams.hh, restoring the release 2.12 version.
```cpp
template <class ElementSolution, class SolidState>
Scalar solidHeatCapacity(const Element& element,
const SubControlVolume& scv,
const ElementSolution& elemSol,
const SolidState& solidState) const
{
const auto& globalPos = scv.dofPosition();
if (isFineMaterial_(globalPos))
return fineHeatCap_;
else
return coarseHeatCap_;
}
```
Thus, the test now also only uses an inert solid system and state again as the previous detour of defining two solid components for the sake of having two distinct heat capacities is no longer necessary.
* [x] Document fancy C++ magic in the ni volume variables
Fixes #578.3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1230[porousmediumflow] Port Forchheimer2018-10-11T14:38:05ZKilian Weishaupt[porousmediumflow] Port Forchheimer3.0Martin SchneiderMartin Schneiderhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1227[test][navierstokes] Fix test name for CMake dependency2018-09-30T18:17:01ZKilian Weishaupt[test][navierstokes] Fix test name for CMake dependency* was forgotten in recent renaming of tests
* restart test failed because it was not forced to be run after the "regular" test* was forgotten in recent renaming of tests
* restart test failed because it was not forced to be run after the "regular" test3.0Melanie LippMelanie Lipphttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1225[cc][parallel] fix handling of ghosts in local assembler2018-10-22T08:43:20ZBernd Flemisch[cc][parallel] fix handling of ghosts in local assemblerSet the partial derivatives explicitly for ghosts _after_ the
standard values have been calculated.
Fixes #576.Set the partial derivatives explicitly for ghosts _after_ the
standard values have been calculated.
Fixes #576.3.0Timo Kochtimokoch@math.uio.noTimo Kochtimokoch@math.uio.nohttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1224[elastic][mpfa] fix broken SFINAE constructs2018-10-22T09:34:58ZBernd Flemisch[elastic][mpfa] fix broken SFINAE constructsStore return values explicitly as constexpr. Fixes compilation errors
triggered on specific gcc's.
Fixes #577.Store return values explicitly as constexpr. Fixes compilation errors
triggered on specific gcc's.
Fixes #577.3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1222[params] Make it possible to initialize parameters when not called from main2018-10-18T10:02:51ZTimo Kochtimokoch@math.uio.no[params] Make it possible to initialize parameters when not called from mainWe cannot expect that we always have `argv`,`argc` to initialize the parameters. Also we might wanna run a simulation without input file. Unfortunately, the new interface makes it possible to easily overwrite parameters in every class / ...We cannot expect that we always have `argv`,`argc` to initialize the parameters. Also we might wanna run a simulation without input file. Unfortunately, the new interface makes it possible to easily overwrite parameters in every class / function. The name `init` still suggests that it should be only used to initialize parameters. Do we want such an option for the singleton? AFAIK Fenics also has a global parameter object that can be changed everywhere. This makes it possible to easily change parameters in the main file. However, the feature should never be used in any class as setting the parameter will have hidden side effects on the whole program. Maybe just having a function `init` instead of a function `setParam` documents our intent on how to use it well. By the way, overwriting the params in some class is also possible with the current `init`, it's just inefficient as you overwrite all parameters and have to read the input file again.3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1221[linear][doc] Fix name of linear solver2018-09-10T14:40:40ZTimo Kochtimokoch@math.uio.no[linear][doc] Fix name of linear solver3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1220Fix Staggered IO Fields2018-09-10T09:13:58ZKilian WeishauptFix Staggered IO FieldsThis MR should fix all staggered models. After being merged into feature/iofields, a rebase might be useful.
We still need to decide whether to keep the unit test in the current form or simplify it.This MR should fix all staggered models. After being merged into feature/iofields, a rebase might be useful.
We still need to decide whether to keep the unit test in the current form or simplify it.3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1217[freeflow] Remove wallFunctions from common problem2018-10-11T09:03:30ZKilian Weishaupt[freeflow] Remove wallFunctions from common problem* move to RANS problem* move to RANS problem3.0Ned ColtmanNed Coltmanhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1214Feature/runtime inertia2018-09-28T15:41:06ZKilian WeishauptFeature/runtime inertia- [x] Remove all occurences of SET_BOOL_PROP(TypeTag, EnableInertiaTerms)
- [x] Check all tests
- [x] Adapt input files if necesary
- [x] Check if some tests can use the same executable
- [x] Remove all occurences of SET_BOOL_PROP(TypeTag, EnableInertiaTerms)
- [x] Check all tests
- [x] Adapt input files if necesary
- [x] Check if some tests can use the same executable
3.0Kilian WeishauptKilian Weishaupthttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1212Feature/iofields2018-11-12T16:26:11ZTimo Kochtimokoch@math.uio.noFeature/iofieldsfixes #562fixes #5623.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1211[properties] Add property system implementation without macros and variadic t...2018-10-18T12:35:33ZTimo Kochtimokoch@math.uio.no[properties] Add property system implementation without macros and variadic templatesAn new implementation of the property system with variadic templates and without macros
* variadic (unlimited hierarchy instead of 5 levels)
* uses no class inheritance
* uses no macrosAn new implementation of the property system with variadic templates and without macros
* variadic (unlimited hierarchy instead of 5 levels)
* uses no class inheritance
* uses no macros3.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1205[brineco2] reintroduced a gas denstity calculation taking into account compos...2018-09-02T08:55:45ZJohannes Hommel[brineco2] reintroduced a gas denstity calculation taking into account compositional effectsFixes #426. Reintroduced the old compositional calculation as the default, with the option to use the plain CO2::gasDensity.
* [x] Use old reference solution
* [x] Add documentation of new function gasDensity_
* [x] Rename gasDensity_ t...Fixes #426. Reintroduced the old compositional calculation as the default, with the option to use the plain CO2::gasDensity.
* [x] Use old reference solution
* [x] Add documentation of new function gasDensity_
* [x] Rename gasDensity_ to gasDensityMixture_3.0Dennis GläserDennis Gläserhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1204[brineco2][tests] disable brineco2-test phase restriction and make brineco2 n...2018-08-30T07:15:32ZSimon Emmert[brineco2][tests] disable brineco2-test phase restriction and make brineco2 non-ideal mixtureThe BrineCO2 fluidsystem is not compatible with the `restrictToPhase` we use for all other tests because the fugacity coefficients are calculated using the other phases' composition.
We also realized that BrineCO2 is not an ideal mixtu...The BrineCO2 fluidsystem is not compatible with the `restrictToPhase` we use for all other tests because the fugacity coefficients are calculated using the other phases' composition.
We also realized that BrineCO2 is not an ideal mixture in the wetting-phase case.
Fixes #5613.0Bernd FlemischBernd Flemischhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/merge_requests/1203[test] Use FoamGrid for 2d in 3d grid as alu doesn't support networks just su...2018-08-29T09:16:40ZTimo Kochtimokoch@math.uio.no[test] Use FoamGrid for 2d in 3d grid as alu doesn't support networks just surfacesFixes #567.
dune-alugrid only supports surface not network grids. The resulting vtk file was still correct as it doesn't care about face connectivity. But the assert signified that something is wrong.
Now we use dune-foamgrid, the grid ...Fixes #567.
dune-alugrid only supports surface not network grids. The resulting vtk file was still correct as it doesn't care about face connectivity. But the assert signified that something is wrong.
Now we use dune-foamgrid, the grid was also made with dune-foamgrid.3.0Dennis GläserDennis Gläser